kot 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d51222d3929d9c0712fe696713d63329b18950e6fdde1975e1c97b7076b4959d
-  data.tar.gz: 802eecd963724fd4398292b645a2f1a681eddadcc177b3d63b66785e4a7a8479
+  metadata.gz: b3d7be21381f93bf3481b87a3167afeb00bc85101113fb55031d25d169434d56
+  data.tar.gz: 57e6c62c8bf39ff09f63db2c9c70a4f3c3727ade7e216ea1cc26d7a8a42dd67f
 SHA512:
-  metadata.gz: b024eda53798ada11f65efbc172843da5a6d7836cc0140178da8ab0381618e10094cb7fe51d6f5636218d75edeb1425d55b05ddcd9c82287bedbd62728ee6dcf
-  data.tar.gz: 772bc25d250dc89b2ce11e148cca0a5638b93575de92d979f911d49e39e7fca1abd978338b24a70582a3dafbe096b0b878338a4236f4b68624994ca4fa83d33b
+  metadata.gz: dfade4c0dda38f2ad2d8182abacecb4686088c6323a6a0c044507ba921aebe8fb552b3b92eb8c7a0f24a0d62d21762ce623de852d30a38b069c0cd0b42a9354e
+  data.tar.gz: a59fbf2efccc4843e456c8a5093e263030411250d100f42163425f4b22a6b3ce778acf94a69c1d67e066f95c8dd5b0e5ec75a2db4eadd7d3eae0e32c65d2cfa8

data/lib/kot/hill_climbing_estimator.rb

@@ -12,46 +12,60 @@ module Kot
       last_response ? est_theta + ((max_b - est_theta) / 2.0) : est_theta - ((est_theta - min_b) / 2.0)
     end
 
-    def estimate(responses:[], items:[], all_items:[], est_theta:0.0)
-
-
-      if responses.uniq.count == 1
-        raise ArgumentError.new("Responses are all #{responses.first} but missing all_items argument") if all_items.empty?
-        return dodd(est_theta:est_theta, items:all_items, last_response:responses.last)
-      end
-
-      lower_bound = items.map(&:b).min
-      upper_bound = items.map(&:b).max
-
-      return lower_bound if upper_bound == lower_bound
-
-      best_theta = - Float::INFINITY
-      max_ll = - Float::INFINITY
-
-      10.times do
 
+    def estimate_iteration(best_theta, max_ll, lower_bound, upper_bound, responses, items)
         step_size = (upper_bound - lower_bound) /  10
-        intervals = (lower_bound...upper_bound).step(step_size)
+
+        case step_size <=> 0
+        when 1
+          intervals = (lower_bound..upper_bound).step(step_size).each
+        when -1
+          intervals = (upper_bound..lower_bound).step(step_size.abs).reverse_each
+        when 0
+          intervals = []
+        end
 
         intervals.each do |ii|
 
           ll = ItemResponseTheory.log_likelihood(ii, responses, items)
 
-
           if ll > max_ll
             max_ll = ll
 
             #TODO - precision-based early exit
             best_theta = ii
           else
-            lower_bound = best_theta - step_size
-            upper_bound = [ii, best_theta+step_size].max #HACK
+            lower_bound = best_theta - step_size.abs
+            upper_bound = ii
             break
           end
 
         end
 
-      # End of hillclimb
+        return best_theta, max_ll, lower_bound, upper_bound
+    end
+
+    def estimate(responses:[], items:[], all_items:[], est_theta:0.0)
+      if responses.uniq.count == 1
+        raise ArgumentError.new("Responses are all #{responses.first} but missing all_items argument") if all_items.empty?
+        return dodd(est_theta:est_theta, items:all_items, last_response:responses.last)
+      end
+
+      lower_bound = items.map(&:b).min
+      upper_bound = items.map(&:b).max
+
+      return lower_bound if upper_bound == lower_bound
+
+      best_theta = - Float::INFINITY
+      max_ll = - Float::INFINITY
+
+      old_best_theta = best_theta
+
+      10.times do
+        best_theta, max_ll, lower_bound, upper_bound = 
+          estimate_iteration(best_theta, max_ll, lower_bound, upper_bound, responses, items)
+
+        break if lower_bound == upper_bound
       end
 
       return best_theta

data/lib/kot/item_response_theory.rb

@@ -1,6 +1,5 @@
 module Kot
 
-
   # Requires a, b, c, d
   module ItemResponseTheory
 
@@ -37,7 +36,7 @@ module Kot
 
     # Item characteristic curve
     def icc(theta)
-      c + ((d - c) / (1 + icc_component(theta)))
+      c + ((d - c) / (1.0 + icc_component(theta)))
     end
 
     # Information value of an item

data/lib/kot/version.rb

@@ -1,3 +1,3 @@
 module Kot
-  VERSION = '0.0.1'.freeze
+  VERSION = '0.0.2'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: kot
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Adam Watkins