kosher 0.6.2 → 0.7.0

data/kosher.gemspec

@@ -9,20 +9,17 @@ Gem::Specification.new do |s|
   s.authors     = ['Paper Cavalier']
   s.email       = 'code@papercavalier.com'
   s.homepage    = 'https://rubygems.org/gems/kosher'
-  s.summary     = %q{An overengineered attempt to abstract bookselling into a set of models}
-  s.description = %q{Kosher is an overengineered attempt to abstract bookselling into a set of models.}
-
-  s.rubyforge_project = 'kosher'
+  s.summary     = %q{An overengineered abstraction of book trading}
+  s.description = %q{Kosher abstracts online book trading into a set of models.}
 
  {
     'rspec'         => '~> 2.6',
-    'ruby-debug19'  => '~> 0.11.6'
   }.each do |lib, version|
     s.add_development_dependency lib, version
   end
 
  {
-    'money'         => '~> 3.6',
+    'money'         => '~> 3.7.1',
     'structure'     => '~> 0.7.1'
   }.each do |lib, version|
     s.add_runtime_dependency lib, version

data/lib/kosher/item.rb

@@ -4,19 +4,13 @@ module Kosher
   #
   # An item has a price, quantity, condition, and description.
   class Item < Structure
-    key     :cents, :type => Integer
-    key     :currency
     key     :quantity, :type => Integer
+    has_one :price
     has_one :condition
     has_one :description
 
     def kosher?
       condition.kosher? && description.kosher?
     end
-
-    def price
-      raise TypeError, "Can't render money" unless cents
-      Money.new(cents, currency)
-    end
   end
 end

data/lib/kosher/offer.rb

@@ -1,8 +1,6 @@
 module Kosher
 
   # An offer.
-  #
-  # This is an actual item offered on a particular venue by a seller.
   class Offer < Structure
     include Comparable
 
@@ -33,7 +31,7 @@ module Kosher
 
     # The total price of an offer.
     def price
-      item.price + shipping.cost
+      item.price.to_money + shipping.cost.to_money
     end
   end
 end

data/lib/kosher/price.rb

@@ -0,0 +1,13 @@
+module Kosher
+
+  # A price.
+  class Price < Structure
+    key :cents, :type => Integer
+    key :currency
+
+    def to_money
+      raise TypeError, "Cannot render money" unless cents
+      Money.new(cents, currency)
+    end
+  end
+end

data/lib/kosher/shipping.rb

@@ -3,24 +3,17 @@ module Kosher
   #
   # Shipping costs something (or nothing) and is subject to availability.
   class Shipping < Structure
-    key     :cents, :type => Integer
-    key     :currency
+    has_one :cost
     has_one :availability
 
     # Returns whether the item ships for free.
     def free?
-      cents == 0
+      cost.cents == 0
     end
 
     # Returns true if the item is available to ship.
     def kosher?
       availability.kosher?
     end
-
-    # The shipping cost.
-    def cost
-      raise TypeError, "Can't render money" unless cents
-      Money.new(cents, currency)
-    end
   end
 end

data/lib/kosher/version.rb

@@ -1,3 +1,3 @@
 module Kosher
-  VERSION = '0.6.2'
+  VERSION = '0.7.0'
 end

data/lib/kosher.rb

@@ -9,25 +9,21 @@ require 'structure/json'
 require 'kosher/threshold'
 
 # Require the models.
-require 'kosher/author'
 require 'kosher/availability'
-require 'kosher/book'
 require 'kosher/condition'
 require 'kosher/description'
-require 'kosher/image'
 require 'kosher/item'
 require 'kosher/location'
 require 'kosher/offer'
+require 'kosher/price'
 require 'kosher/seller'
 require 'kosher/shipping'
 require 'kosher/venue'
 
 module Kosher
   class << self
-    attr_writer :seller_blacklist
-
     def seller_blacklist
-      @seller_blacklist ||= []
+      @seller_blacklist ||= Array.new
     end
   end
 

data/spec/kosher/item_spec.rb

@@ -41,15 +41,5 @@ module Kosher
         end
       end
     end
-
-    describe "#price" do
-      context "when no cents are specified" do
-        it "raises an error" do
-          expect do
-            @item.price
-          end.to raise_error TypeError
-        end
-      end
-    end
   end
 end

data/spec/kosher/offer_spec.rb

@@ -65,11 +65,8 @@ module Kosher
 
     describe "#price" do
       it "sum of item price and shipping cost" do
-        @offer.item.cents = 1000
-        @offer.item.currency = 'EUR'
-
-        @offer.shipping.cents = 399
-        @offer.shipping.currency = 'EUR'
+        @offer.item.price    = Price.new(cents: 1000, currency: 'EUR')
+        @offer.shipping.cost = Price.new(cents: 399, currency: 'EUR')
 
         @offer.price.cents.should eql 1399
         @offer.price.currency.iso_code.should eql 'EUR'

data/spec/kosher/price_spec.rb

@@ -0,0 +1,16 @@
+require 'spec_helper'
+
+module Kosher
+  describe Price do
+    describe "#to_money" do
+      it "returns a Money object" do
+        price = Price.new(:cents => 100, :currency => 'USD')
+        price.to_money.should be_a Money
+      end
+
+      it "raises a type error if cents is nil" do
+        expect { Price.new.to_money }.to raise_error TypeError
+      end
+    end
+  end
+end

data/spec/kosher/seller_spec.rb

@@ -8,7 +8,7 @@ module Kosher
 
     describe "#blacklisted?" do
       before do
-        Kosher.seller_blacklist = ['foo']
+        Kosher.seller_blacklist << 'foo'
       end
 
       it "returns true if the seller is blacklisted" do
@@ -48,7 +48,7 @@ module Kosher
 
       it "returns false if seller is blacklisted" do
         @seller.id = ['foo']
-        Kosher.seller_blacklist = [@seller.id]
+        Kosher.seller_blacklist << @seller.id
         @seller.should_not be_kosher
       end
     end

data/spec/kosher/shipping_spec.rb

@@ -9,14 +9,14 @@ module Kosher
     describe "#free?" do
       context "when shipping costs 0" do
         it "returns true" do
-          @shipping.cents = 0
+          @shipping.cost = Price.new(cents: 0)
           @shipping.should be_free
         end
       end
 
       context "when shipping is not free" do
         it "returns false" do
-          @shipping.cents = 1
+          @shipping.cost = Price.new(cents: 1)
           @shipping.should_not be_free
         end
       end
@@ -37,15 +37,5 @@ module Kosher
         end
       end
     end
-
-    describe "#cost" do
-      context "when no cents are specified" do
-        it "raises an error" do
-          expect do
-            @shipping.cost
-          end.to raise_error TypeError
-        end
-      end
-    end
   end
 end

data/spec/spec_helper.rb

@@ -1,8 +1,5 @@
 require 'rubygems'
 require 'bundler/setup'
 require 'rspec'
-require 'ruby-debug'
 
-require File.expand_path('../../lib/kosher', __FILE__)
-
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
+trequire File.expand_path('../../lib/kosher', __FILE__)

metadata

@@ -4,9 +4,9 @@ version: !ruby/object:Gem::Version
   prerelease: false
   segments: 
   - 0
-  - 6
-  - 2
-  version: 0.6.2
+  - 7
+  - 0
+  version: 0.7.0
 platform: ruby
 authors: 
 - Paper Cavalier
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-06-14 00:00:00 +01:00
+date: 2011-06-20 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -31,39 +31,25 @@ dependencies:
         version: "2.6"
   type: :development
   version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: ruby-debug19
-  prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ~>
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 0
-        - 11
-        - 6
-        version: 0.11.6
-  type: :development
-  version_requirements: *id002
 - !ruby/object:Gem::Dependency 
   name: money
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
         segments: 
         - 3
-        - 6
-        version: "3.6"
+        - 7
+        - 1
+        version: 3.7.1
   type: :runtime
-  version_requirements: *id003
+  version_requirements: *id002
 - !ruby/object:Gem::Dependency 
   name: structure
   prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
+  requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
@@ -74,8 +60,8 @@ dependencies:
         - 1
         version: 0.7.1
   type: :runtime
-  version_requirements: *id004
-description: Kosher is an overengineered attempt to abstract bookselling into a set of models.
+  version_requirements: *id003
+description: Kosher abstracts online book trading into a set of models.
 email: code@papercavalier.com
 executables: []
 
@@ -91,27 +77,25 @@ files:
 - Rakefile
 - kosher.gemspec
 - lib/kosher.rb
-- lib/kosher/author.rb
 - lib/kosher/availability.rb
-- lib/kosher/book.rb
 - lib/kosher/condition.rb
 - lib/kosher/description.rb
-- lib/kosher/image.rb
 - lib/kosher/item.rb
 - lib/kosher/location.rb
 - lib/kosher/offer.rb
+- lib/kosher/price.rb
 - lib/kosher/seller.rb
 - lib/kosher/shipping.rb
 - lib/kosher/threshold.rb
 - lib/kosher/venue.rb
 - lib/kosher/version.rb
 - spec/kosher/availability_spec.rb
-- spec/kosher/book_spec.rb
 - spec/kosher/condition_spec.rb
 - spec/kosher/description_spec.rb
 - spec/kosher/item_spec.rb
 - spec/kosher/location_spec.rb
 - spec/kosher/offer_spec.rb
+- spec/kosher/price_spec.rb
 - spec/kosher/seller_spec.rb
 - spec/kosher/shipping_spec.rb
 - spec/kosher/venue_spec.rb
@@ -144,19 +128,19 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: "0"
 requirements: []
 
-rubyforge_project: kosher
+rubyforge_project: 
 rubygems_version: 1.3.7
 signing_key: 
 specification_version: 3
-summary: An overengineered attempt to abstract bookselling into a set of models
+summary: An overengineered abstraction of book trading
 test_files: 
 - spec/kosher/availability_spec.rb
-- spec/kosher/book_spec.rb
 - spec/kosher/condition_spec.rb
 - spec/kosher/description_spec.rb
 - spec/kosher/item_spec.rb
 - spec/kosher/location_spec.rb
 - spec/kosher/offer_spec.rb
+- spec/kosher/price_spec.rb
 - spec/kosher/seller_spec.rb
 - spec/kosher/shipping_spec.rb
 - spec/kosher/venue_spec.rb

data/lib/kosher/author.rb

@@ -1,8 +0,0 @@
-module Kosher
-
-  # A book author.
-  class Author < Structure
-    key :name
-    key :role
-  end
-end

data/lib/kosher/book.rb

@@ -1,39 +0,0 @@
-module Kosher
-
-  # A book.
-  #
-  # A book is sold on many venues and has many offers through those venues.
-  class Book < Structure
-    key      :asin
-    key      :edition
-    key      :format
-    key      :images,       :type => Hash
-    key      :isbn
-    key      :pages,        :type => Integer
-    key      :published_in, :type => Integer
-    key      :publisher
-    key      :title
-    key      :volumes,      :type => Integer
-    has_many :other_editions
-    has_many :authors
-    has_many :offers
-    has_many :similar_books
-
-    # The best kosher offer.
-    #
-    # Returns nil if there are no (kosher) offers.
-    def best_kosher_offer
-      offer = offers.sort.first
-      offer && offer.kosher? ? offer : nil
-    end
-
-    # A full bibliographic description of the book, as in:
-    #
-    #   Chronicle Books, 1991. Hardcover. 1st edition. 2 volumes. 1200 pages.
-    #
-    # Missing attributes are omitted.
-    def description
-      # TODO
-    end
-  end
-end

data/lib/kosher/image.rb

@@ -1,9 +0,0 @@
-module Kosher
-
-  # An image of a book cover.
-  class Image < Structure
-    key :height, :type => Integer
-    key :url,    :type => URI
-    key :width,  :type => Integer
-  end
-end

data/spec/kosher/book_spec.rb

@@ -1,76 +0,0 @@
-require 'spec_helper'
-
-module Kosher
-  describe Book do
-    describe "#best_kosher_offer" do
-      before do
-        @book = Book.new
-
-        @offer1 = Offer.new
-        @offer2 = Offer.new
-      end
-
-      context "when there are more than one kosher offers" do
-        before do
-          @offer1.stub!(:kosher?).and_return(true)
-          @offer1.stub!(:price).and_return(Money.new(200, 'EUR'))
-          @book.offers << @offer1
-
-          @offer2.stub!(:kosher?).and_return(true)
-          @offer2.stub!(:price).and_return(Money.new(100, 'EUR'))
-          @book.offers << @offer2
-        end
-
-        it "returns the kosher offer with the lowest price" do
-          @book.best_kosher_offer.should eql @offer2
-        end
-      end
-
-      context "when there is one kosher and one unkosher offer" do
-        before do
-          @offer1.stub!(:kosher?).and_return(true)
-          @offer1.stub!(:price).and_return(Money.new(200, 'EUR'))
-          @book.offers << @offer1
-
-          @offer2.stub!(:kosher?).and_return(false)
-          @offer2.stub!(:price).and_return(Money.new(100, 'EUR'))
-          @book.offers << @offer2
-        end
-
-        it "returns the kosher offer" do
-          @book.best_kosher_offer.should eql @offer1
-        end
-      end
-
-      context "when there is one kosher offer" do
-        before do
-          @offer1.stub!(:kosher?).and_return(true)
-          @offer1.stub!(:price).and_return(Money.new(100, 'EUR'))
-          @book.offers << @offer1
-        end
-
-        it "returns the kosher offer" do
-          @book.best_kosher_offer.should eql @offer1
-        end
-      end
-
-      context "when there is one unkosher offer" do
-        before do
-          @offer1.stub!(:kosher?).and_return(false)
-          @offer1.stub!(:price).and_return(Money.new(100, 'EUR'))
-          @book.offers << @offer1
-        end
-
-        it "returns nil" do
-          @book.best_kosher_offer.should be_nil
-        end
-      end
-
-      context "when there are no offers" do
-        it "returns nil" do
-          @book.best_kosher_offer.should be_nil
-        end
-      end
-    end
-  end
-end