kosher 0.2.19 → 0.2.20

data/Gemfile

@@ -1,3 +1,6 @@
 source 'http://rubygems.org'
 
+gem 'rspec', '~> 2.5.0'
+gem 'ruby-debug19', '~> 0.11.6'
+
 gemspec

data/kosher.gemspec

@@ -9,14 +9,12 @@ Gem::Specification.new do |s|
   s.authors     = ['Paper Cavalier']
   s.email       = 'code@papercavalier.com'
   s.homepage    = 'https://rubygems.org/gems/kosher'
-  s.summary     = %q{A somewhat overengineered attempt to abstract bookdealing into a set of models}
-  s.description = %q{Kosher is a somewhat overengineered attempt to abstract bookdealing into a set of models.}
+  s.summary     = %q{A somewhat overengineered attempt to abstract bookselling into a set of models}
+  s.description = %q{Kosher is a somewhat overengineered attempt to abstract bookselling into a set of models.}
 
   s.rubyforge_project = 'kosher'
 
   s.add_dependency('money', '~> 3.6.1')
-  s.add_development_dependency('rspec', '~> 2.5.0')
-  s.add_development_dependency('ruby-debug19', '~> 0.11.6')
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")

data/lib/kosher/human_readable.rb

@@ -0,0 +1,4 @@
+module Kosher
+  class HumanReadable < Struct.new(:price, :description)
+  end
+end

data/lib/kosher/offer.rb

@@ -1,31 +1,48 @@
 module Kosher
-  class Offer < Struct.new(:id, :item, :seller, :shipping)
+
+  # A used or new offer of a book by a dealer or store.
+  class Offer < Struct.new(:id, :item, :seller, :shipping, :human_readable)
     include Comparable
 
     class << self
+
+      # The base currency.
       attr_accessor :base_currency
     end
 
     self.base_currency = 'EUR'
 
+    # Compares offer with another offer.
+    #
+    # A kosher offer is better than an unkosher offer. If both offers are
+    # kosher or unkosher, a lower-priced offer is better.
     def <=>(other)
-      if self.kosher? != other.kosher?
-        self.kosher? ? -1 : 1
+      if kosher? != other.kosher?
+        kosher? ? -1 : 1
       else
-        self.price.exchange_to(base_currency) <=> other.price.exchange_to(base_currency)
+        exchanged_price <=> other.exchanged_price
       end
     end
 
-    def base_currency
-      self.class.base_currency
+    # The price exchanged to the base currency.
+    def exchanged_price
+      price.exchange_to(base_currency)
     end
 
+    # Returns whether the offer is kosher.
     def kosher?
       item.kosher? && seller.kosher? && shipping.kosher?
     end
 
+    # The total price, including the shipping cost.
     def price
       item.price + shipping.cost
     end
+
+    private
+
+    def base_currency
+      self.class.base_currency
+    end
   end
 end

data/lib/kosher/version.rb

@@ -1,3 +1,3 @@
 module Kosher
-  VERSION = '0.2.19'
+  VERSION = '0.2.20'
 end

data/lib/kosher.rb

@@ -8,6 +8,7 @@ require 'kosher/condition'
 require 'kosher/description'
 require 'kosher/item'
 require 'kosher/location'
+require 'kosher/human_readable'
 require 'kosher/offer'
 require 'kosher/seller'
 require 'kosher/shipping'

data/spec/kosher/human_readable_spec.rb

@@ -0,0 +1,5 @@
+require 'spec_helper'
+
+module Kosher
+  describe HumanReadable
+end

data/spec/kosher/offer_spec.rb

@@ -11,7 +11,7 @@ module Kosher
 
     describe "#base_currency" do
       it "defaults to EUR" do
-        @offer.base_currency.should eql 'EUR'
+        @offer.send(:base_currency).should eql 'EUR'
       end
     end
 

metadata

@@ -2,7 +2,7 @@
 name: kosher
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.2.19
+  version: 0.2.20
 platform: ruby
 authors: 
 - Paper Cavalier
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-19 00:00:00 +00:00
+date: 2011-04-01 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -24,29 +24,7 @@ dependencies:
         version: 3.6.1
   type: :runtime
   version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: rspec
-  prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ~>
-      - !ruby/object:Gem::Version 
-        version: 2.5.0
-  type: :development
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
-  name: ruby-debug19
-  prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ~>
-      - !ruby/object:Gem::Version 
-        version: 0.11.6
-  type: :development
-  version_requirements: *id003
-description: Kosher is a somewhat overengineered attempt to abstract bookdealing into a set of models.
+description: Kosher is a somewhat overengineered attempt to abstract bookselling into a set of models.
 email: code@papercavalier.com
 executables: []
 
@@ -66,6 +44,7 @@ files:
 - lib/kosher/book.rb
 - lib/kosher/condition.rb
 - lib/kosher/description.rb
+- lib/kosher/human_readable.rb
 - lib/kosher/item.rb
 - lib/kosher/location.rb
 - lib/kosher/offer.rb
@@ -77,6 +56,7 @@ files:
 - spec/kosher/book_spec.rb
 - spec/kosher/condition_spec.rb
 - spec/kosher/description_spec.rb
+- spec/kosher/human_readable_spec.rb
 - spec/kosher/item_spec.rb
 - spec/kosher/location_spec.rb
 - spec/kosher/offer_spec.rb
@@ -110,12 +90,13 @@ rubyforge_project: kosher
 rubygems_version: 1.5.2
 signing_key: 
 specification_version: 3
-summary: A somewhat overengineered attempt to abstract bookdealing into a set of models
+summary: A somewhat overengineered attempt to abstract bookselling into a set of models
 test_files: 
 - spec/kosher/availability_spec.rb
 - spec/kosher/book_spec.rb
 - spec/kosher/condition_spec.rb
 - spec/kosher/description_spec.rb
+- spec/kosher/human_readable_spec.rb
 - spec/kosher/item_spec.rb
 - spec/kosher/location_spec.rb
 - spec/kosher/offer_spec.rb