kosher 0.1.2 → 0.1.3

data/lib/kosher/condition.rb

@@ -2,18 +2,12 @@ module Kosher
   class Condition < Struct.new(:in_words)
     def to_i
       case in_words
-      when 'new'
-        1
-      when 'mint'
-        2
-      when 'verygood'
-        3
-      when 'good'
-        4
-      when 'acceptable'
-        5
-      else
-        6
+      when 'new' then 1
+      when 'mint' then 2
+      when 'verygood' then 3
+      when 'good' then 4
+      when 'acceptable' then 5
+      else 6
       end
     end
 

data/lib/kosher/item.rb

@@ -1,25 +1,28 @@
 module Kosher
-  class Item < Struct.new(:asin, :offers)
+  class Item < Struct.new(:asin, :offers, :sales_rank)
 
-    def self.build(doc)
-      asin   = doc['ASIN']
-      offers = build_offers(doc['Offers']['Offer'])
+    class << self
+      def build(doc)
+        asin       = doc['ASIN']
+        sales_rank = doc['SalesRank'].to_i
+        offers     = build_offers(doc['Offers']['Offer'])
 
-      new(asin, offers)
-    end
+        new(asin, offers, sales_rank)
+      end
 
-    private
+      private
 
-    def self.build_offers(offers)
-      [offers].flatten.compact.map do |offer|
+      def build_offers(offers)
+        [offers].flatten.compact.map do |offer|
 
-        # Senify Yen because Ruby Money says so
-        price = offer['OfferListing']['Price']
-        if price['CurrencyCode'] == 'JPY'
-          price['Amount'] = price['Amount'].to_i * 100
-        end
+          # Senify Yen because Ruby Money says so
+          price = offer['OfferListing']['Price']
+          if price['CurrencyCode'] == 'JPY'
+            price['Amount'] = price['Amount'].to_i * 100
+          end
 
-        Offer.build(offer)
+          Offer.build(offer)
+        end
       end
     end
   end

data/lib/kosher/version.rb

@@ -1,3 +1,3 @@
 module Kosher
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'
 end

data/spec/kosher/algorithm_spec.rb

@@ -1,4 +1,4 @@
-require "spec_helper"
+require 'spec_helper'
 
 module Kosher
   describe Algorithm do

data/spec/kosher/condition_spec.rb

@@ -1,4 +1,4 @@
-require "spec_helper"
+require 'spec_helper'
 
 module Kosher
   describe Condition do
@@ -8,23 +8,23 @@ module Kosher
       end
 
       it "casts as integer" do
-        this("new").should eql 1
-        this("mint").should eql 2
-        this("verygood").should eql 3
-        this("good").should eql 4
-        this("acceptable").should eql 5
+        this('new').should eql 1
+        this('mint').should eql 2
+        this('verygood').should eql 3
+        this('good').should eql 4
+        this('acceptable').should eql 5
       end
 
       it "casts unrecognized conditions as 6" do
-        this("refurbished").should eql 6
+        this('refurbished').should eql 6
       end
     end
 
     describe "#kosher?" do
       it "returns true if condition is good or better" do
-        Condition.new("verygood").should be_kosher
-        Condition.new("good").should be_kosher
-        Condition.new("acceptable").should_not be_kosher
+        Condition.new('verygood').should be_kosher
+        Condition.new('good').should be_kosher
+        Condition.new('acceptable').should_not be_kosher
       end
     end
   end

data/spec/kosher/description_spec.rb

@@ -1,4 +1,4 @@
-require "spec_helper"
+require 'spec_helper'
 
 module Kosher
   describe Description do
@@ -11,45 +11,45 @@ module Kosher
     end
 
     it "validates a blank description" do
-      this("").should be_kosher
+      this('').should be_kosher
     end
 
     it "validates a non-blank description" do
-      this("foo").should be_kosher
+      this('foo').should be_kosher
     end
 
     it "does not validate advance review copies" do
-      this("Uncorrected review copy").should_not be_kosher
-      this("arc").should_not be_kosher
-      this("arc.").should_not be_kosher
+      this('Uncorrected review copy').should_not be_kosher
+      this('arc').should_not be_kosher
+      this('arc.').should_not be_kosher
 
-      this("marc").should be_kosher
+      this('marc').should be_kosher
     end
 
     it "does not validate marked books" do
-      this("Some highlighting").should_not be_kosher
-      this("Underlining.").should_not be_kosher
-      this("Good. Hiliting.").should_not be_kosher
+      this('Some highlighting').should_not be_kosher
+      this('Underlining.').should_not be_kosher
+      this('Good. Hiliting.').should_not be_kosher
 
-      this("No highlighting.").should be_kosher
+      this('No highlighting.').should be_kosher
     end
 
     it "does not validate books with missing volumes" do
-      this("First vol only.").should_not be_kosher
+      this('First vol only.').should_not be_kosher
     end
 
     it "does not validate damaged or worn books" do
-      this("Different").should be_kosher
-      this("Rental").should_not be_kosher
-      this("Torn pages").should_not be_kosher
+      this('Different').should be_kosher
+      this('Rental').should_not be_kosher
+      this('Torn pages').should_not be_kosher
     end
 
     it "does not validate withdrawn library copies" do
-      this("xlib").should_not be_kosher
-      this("ex-library").should_not be_kosher
-      this("retired library copy").should_not be_kosher
+      this('xlib').should_not be_kosher
+      this('ex-library').should_not be_kosher
+      this('retired library copy').should_not be_kosher
 
-      this("Not an ex-library").should be_kosher
+      this('Not an ex-library').should be_kosher
     end
   end
 end

data/spec/kosher/item_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 module Kosher
   describe Item do
     describe ".build" do
-      use_vcr_cassette '0143105825', :match_requests_on  => [:host]
+      use_vcr_cassette '0143105825'
 
       let(:asin) { '0143105825' }
 
@@ -24,6 +24,7 @@ module Kosher
       it "should build an item" do
         item.should be_a Item
         item.asin.should eql asin
+        item.sales_rank.should be > 0
       end
 
       it "should build the offers of an item" do

data/spec/kosher/offer_spec.rb

@@ -5,7 +5,7 @@ module Kosher
     let(:offer) { Fabricate(:offer) }
 
     describe ".build" do
-      use_vcr_cassette '0143105825', :match_requests_on  => [:host]
+      use_vcr_cassette '0143105825'
 
       let(:asin) { '0143105825' }
 

data/spec/kosher/seller_spec.rb

@@ -1,9 +1,9 @@
-require "spec_helper"
+require 'spec_helper'
 
 module Kosher
   describe Seller do
     describe ".build" do
-      use_vcr_cassette "0143105825", :match_requests_on  => [:host]
+      use_vcr_cassette '0143105825'
 
       let(:asin) { '0143105825' }
 

data/spec/support/vcr.rb

@@ -4,7 +4,7 @@ VCR.config do |c|
   c.cassette_library_dir     = "#{File.dirname(__FILE__)}/../fixtures/cassette_library"
   c.stub_with                  :webmock
   c.ignore_localhost         = true
-  c.default_cassette_options = { :record => :new_episodes }
+  c.default_cassette_options = { :record => :new_episodes, :match_requests_on  => [:host] }
 end
 
 RSpec.configure do |config|

metadata

@@ -2,7 +2,7 @@
 name: kosher
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors: 
 - Paper Cavalier