kookaburra 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 876b112f7d0a4bf348ff6eb5725b9acfba78231c
-  data.tar.gz: 5c9e9eb1859eae92ceeff6bdd27fb97508b2dbe0
+  metadata.gz: 5cadefaae85409b2b4db57ce339eea29091d9a87
+  data.tar.gz: 14ca8365ce3aecd80dbf5a78a8e7581d1461dac1
 SHA512:
-  metadata.gz: de33f1490e4bf1f0fbf8ebce836b63c5b0569da8e6a878377499c3b764bbc36fa5a8d57f534b79547e4ab89b965de8c5589ae037360e9d79763dab70804a4a70
-  data.tar.gz: 46b70542699935c33958a1712618c0eddc772971f07482077aa2aad13e0a4651ba845fb31032085916157d0edc98e34450e40aa37a95e4ec6cdd4e1527063f65
+  metadata.gz: b4ca6636a527e1a6de7af7b92ac9c87be2ca3ab507b5327ed4513635a522a3e794aff3930720cfbde751ad7dbb0236e52e9e5697f7a1f57569006a4ad6d7d355
+  data.tar.gz: a2badf5f817a513f45c4955bdb3ea0b9a8139a08fd4826fba07d43be6a8d11a0d9c8c07eb6a296904c562c22b556c834a1edba366953f2aa122a2af8240821d4

data/Rakefile

@@ -6,11 +6,9 @@ require 'rspec/core/rake_task'
 task :default => :spec
 RSpec::Core::RakeTask.new
 
-require 'reek/rake/task'
-Reek::Rake::Task.new do |t|
-  t.fail_on_error = true
-  t.verbose = false
-  t.source_files = 'lib/**/*.rb'
+desc 'Runs reek to detect code smells'
+task :reek do
+  sh 'reek lib/**/*.rb'
 end
 
 require 'yard'

data/lib/kookaburra/ui_driver/ui_component.rb

@@ -168,7 +168,7 @@ class Kookaburra
       def detect_server_error!
         return if @server_error_detection.nil?
         if @server_error_detection.call(browser)
-          raise UnexpectedResponse, "Your server error detection function detected a server error. Looks like your applications is busted. :-("
+          raise UnexpectedResponse, "Server Error Detected:\n#{browser.text}"
         end
       end
 

data/lib/kookaburra/version.rb

@@ -1,3 +1,3 @@
 class Kookaburra
-  VERSION = "1.3.0"
+  VERSION = "1.3.1"
 end

data/spec/kookaburra/ui_driver/ui_component/address_bar_spec.rb

@@ -3,7 +3,7 @@ require 'kookaburra/ui_driver/ui_component/address_bar'
 describe Kookaburra::UIDriver::UIComponent::AddressBar do
   describe '#go_to' do
     let(:browser) {
-      double('Capybara::Session').tap do |b|
+      double('Capybara::Session', text: '').tap do |b|
         b.should_receive(:visit).with('http://site.example.com')
       end
     }

data/spec/kookaburra/ui_driver/ui_component_spec.rb

@@ -3,55 +3,63 @@ require 'support/shared_examples/it_can_make_assertions'
 require 'support/shared_examples/it_can_have_ui_components'
 
 describe Kookaburra::UIDriver::UIComponent do
-  let(:configuration) { double('Configuration', :browser => nil, :app_host => nil, :server_error_detection => nil) }
+  let(:browser) { double('Browser Driver') }
+  let(:app_host) { 'http://my.example.com' }
+  let(:server_error_detection) { ->(browser) { false } }
+
+  let(:configuration) {
+    double('Configuration', browser: browser, app_host: app_host,
+           server_error_detection: server_error_detection)
+  }
+
   let(:component) { Kookaburra::UIDriver::UIComponent.new(configuration) }
 
   it_behaves_like :it_can_have_ui_components, Kookaburra::UIDriver::UIComponent
 
   describe '#visible?' do
+    before(:each) do
+      def component.component_locator
+        '#my_component'
+      end
+    end
+
     it 'returns true if the component_locator is found in the DOM and is visible' do
-      browser = double('Browser Driver')
       browser.should_receive(:has_css?) \
         .with('#my_component', :visible) \
         .and_return(true)
-      configuration.stub(:browser => browser)
-      def component.component_locator
-        '#my_component'
-      end
       component.visible?.should == true
     end
 
-    it 'returns false if the component_locator id not found in the DOM' do
-      browser = double('Browser Driver', :has_css? => false)
-      configuration.stub(:browser => browser)
-      server_error_detection = lambda { |browser|
-        false
-      }
-      configuration.stub(:server_error_detection => server_error_detection)
-      def component.component_locator
-        '#my_component'
+    context 'when the component_locator is not found in the DOM' do
+      let(:browser) { double('Browser Driver', has_css?: false, text: '') }
+
+      context 'and a server error is not detected' do
+        it 'returns false' do
+          component.visible?.should == false
+        end
       end
-      component.visible?.should == false
-    end
 
-    it 'raises UnexpectedResponse if the component_locator is not found and a server error is detected' do
-      browser = double('Browser Driver', :has_css? => false)
-      configuration.stub(:browser => browser)
-      server_error_detection = lambda { |browser|
-        true
-      }
-      configuration.stub(:server_error_detection => server_error_detection)
-      def component.component_locator
-        '#my_component'
+      context 'and a server error is detected' do
+        let(:server_error_detection) { ->(browser) { true } }
+
+        it 'raises UnexpectedResponse' do
+          lambda { component.visible? } \
+            .should raise_error(Kookaburra::UnexpectedResponse)
+        end
+
+        it 'adds the text of the HTTP response to the exception message' do
+          browser.stub(text: 'This is text from the HTTP response')
+          lambda { component.visible? } \
+            .should raise_error(Kookaburra::UnexpectedResponse,
+                                "Server Error Detected:\n" \
+                                + "This is text from the HTTP response")
+        end
       end
-      lambda { component.visible? } \
-        .should raise_error(Kookaburra::UnexpectedResponse)
     end
   end
 
   describe '#url' do
     it 'returns the app_host + #component_path' do
-      configuration.stub(:app_host => 'http://my.example.com')
       def component.component_path
         '/foo/bar'
       end
@@ -81,10 +89,8 @@ describe Kookaburra::UIDriver::UIComponent do
 
     describe '#this_element' do
       it 'returns the HTML element representing this component' do
-        browser = double('Browser Driver')
         element = double('Element')
 
-        configuration.stub(browser: browser)
         def component.component_locator
           '#my_component'
         end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: kookaburra
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - John Wilger
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-29 00:00:00.000000000 Z
+date: 2014-05-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client