kookaburra 0.14.2 → 0.14.3

data/VERSION

@@ -1 +1 @@
-0.14.2
+0.14.3

data/kookaburra.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "kookaburra"
-  s.version = "0.14.2"
+  s.version = "0.14.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Renewable Funding, LLC"]
-  s.date = "2012-02-01"
+  s.date = "2012-02-22"
   s.description = "Cucumber + Capybara = Kookaburra? It made sense at the time."
   s.email = "devteam@renewfund.com"
   s.extra_rdoc_files = [
@@ -40,6 +40,7 @@ Gem::Specification.new do |s|
     "test/helper.rb",
     "test/kookaburra/assertion_test.rb",
     "test/kookaburra/test_data_test.rb",
+    "test/kookaburra/ui_driver/mixins/has_browser_test.rb",
     "test/kookaburra/ui_driver/ui_component_test.rb",
     "test/kookaburra/ui_driver_test.rb",
     "test/kookaburra_test.rb"
@@ -47,7 +48,7 @@ Gem::Specification.new do |s|
   s.homepage = "http://github.com/projectdx/kookaburra"
   s.licenses = ["MIT"]
   s.require_paths = ["lib"]
-  s.rubygems_version = "1.8.15"
+  s.rubygems_version = "1.8.16"
   s.summary = "WindowDriver testing pattern for Ruby apps"
 
   if s.respond_to? :specification_version then

data/lib/kookaburra/ui_driver/mixins/has_browser.rb

@@ -21,7 +21,7 @@ module Kookaburra
       # Does not wait, so should only be used after failing a check
       # for being in the expected place.
       def no_500_error!
-        return if browser.all(:css, 'head title', :text => 'Internal Server Error').empty?
+        return true if browser.all(:css, 'head title', :text => 'Internal Server Error').empty?
         sleep 30 if ENV['GIMME_CRAP']
         raise Unexpected500, browser.body
       end

data/lib/kookaburra/ui_driver/ui_component.rb

@@ -46,16 +46,16 @@ module Kookaburra
       end
 
       # Default implementation navigates directly to this UIComponent's
-      # `#component_path`. If `opts[:query_params]` is set to a Hash, the
-      # request will be made with the resulting querystring on the URL.
-      def show(opts = {})
+      # `#component_path`.
+      #
+      # @param path_args [Argument List] Any arguments added to this method are
+      #        passed through to `#component_path`.
+      def show(*path_args)
         unless respond_to?(:component_path)
-          raise "You must either set component_path or redefine the #show method in UIComponent subclasses!"
+          raise NoMethodError, "You must either set component_path or redefine the #show method in UIComponent subclasses!"
         end
         return if visible?
-        path = component_path
-        path << ( '?' + opts[:query_params].map{|kv| "%s=%s" % kv}.join('&') ) if opts[:query_params]
-        visit path
+        visit component_path(*path_args)
       end
 
       def refresh

data/lib/kookaburra.rb

@@ -9,7 +9,19 @@ require 'kookaburra/ui_driver'
 # {file:README.markdown README} for more information on setting up Kookaburra
 # for your project.
 module Kookaburra
+  ConfigurationError = Class.new(RuntimeError)
+
   class << self
+    def self.config_var(*names)
+      names.each do |name|
+        attr_accessor name
+        define_method(name) do
+          instance_variable_get("@#{name}") \
+            or raise ConfigurationError.new("Please specify Kookaburra.#{name} in your configuration.")
+        end
+      end
+    end
+
     # Provides the default adapter for the Kookaburra library.
     #
     # If not using Capybara, the Object must respond to `#app` and return a Rack
@@ -18,25 +30,37 @@ module Kookaburra
     #
     # @example using Capybara
     #     Kookaburra.adapter = Capybara
-    attr_accessor :adapter
+    #
+    # @raise [ConfigurationError] raised by reader method if no adapter has been
+    #        assigned yet.
+    config_var :adapter
 
     # A reference to your application's subclass of `Kookaburra::APIDriver`
     #
     # @example setting your APIDriver
     #     Kookaburra.api_driver = MyApplication::Kookaburra::APIDriver
-    attr_accessor :api_driver
+    #
+    # @raise [ConfigurationError] raised by reader method if no api driver class
+    #        has been assigned yet.
+    config_var :api_driver
 
     # A reference to your application's subclass of `Kookaburra::GivenDriver`
     #
     # @example setting your GivenDriver
     #     Kookaburra.api_driver = MyApplication::Kookaburra::GivenDriver
-    attr_accessor :given_driver
+    #
+    # @raise [ConfigurationError] raised by reader method if no given driver
+    #        class has been assigned yet.
+    config_var :given_driver
 
     # A reference to your application's subclass of `Kookaburra::UIDriver`
     #
     # @example setting your UIDriver
     #     Kookaburra.api_driver = MyApplication::Kookaburra::UIDriver
-    attr_accessor :ui_driver
+    #
+    # @raise [ConfigurationError] raised by reader method if no ui driver
+    #        class has been assigned yet.
+    config_var :ui_driver
 
     # Configure the test data collections and default data for your tests
     #

data/test/helper.rb

@@ -15,6 +15,16 @@ $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 require 'kookaburra'
 
 class MiniTest::Unit::TestCase
+  # TODO: make this better, so that there is only one failure message
+  def assert_raises_with_message(expected_exception, expected_message, &block)
+    begin
+      yield
+      flunk "Expected to raise a #{expected_exception}"
+    rescue => e
+      assert_kind_of expected_exception, e
+      assert_match expected_message, e.message
+    end
+  end
 end
 
 MiniTest::Unit.autorun

data/test/kookaburra/ui_driver/mixins/has_browser_test.rb

@@ -0,0 +1,38 @@
+require 'helper'
+
+describe Kookaburra::UIDriver::HasBrowser do
+  describe '#no_500_error!' do
+    let(:klass) do
+      Class.new do
+        include Kookaburra::UIDriver::HasBrowser
+
+        def run_test
+          no_500_error!
+        end
+      end
+    end
+
+    let(:browser) do
+      b = MiniTest::Mock.new
+      def b.body; 'Hello'; end
+      b
+    end
+
+    let(:obj) { klass.new(:browser => browser) }
+
+    it 'raises Unexpected500 if the page title is "Internal Server Error"' do
+      browser.expect(:all, [:not_empty],
+                     [:css, 'head title', {:text => 'Internal Server Error'}])
+
+      assert_raises Kookaburra::UIDriver::HasBrowser::Unexpected500 do
+        obj.run_test
+      end
+    end
+
+    it 'returns true if the page title is not "Internal Server Error"' do
+      browser.expect(:all, [],
+                     [:css, 'head title', {:text => 'Internal Server Error'}])
+      assert_equal true, obj.run_test
+    end
+  end
+end

data/test/kookaburra/ui_driver/ui_component_test.rb

@@ -49,4 +49,53 @@ describe Kookaburra::UIDriver::UIComponent do
       assert_equal 3, component.count('.element')
     end
   end
+
+  describe '#show' do
+    let(:browser) { MiniTest::Mock.new }
+    let(:component) do
+      c = Kookaburra::UIDriver::UIComponent.new(:browser => browser)
+      def c.no_500_error!; true; end
+      c
+    end
+
+    it 'raises a NoMethodError if #component_path is not defined' do
+      assert_raises_with_message(NoMethodError, /set component_path/)  do
+        component.show
+      end
+    end
+
+    describe "when the component is not already visible" do
+      before(:each) do
+        def component.visible?; false; end
+      end
+
+      it 'visits the path returned by #component_path' do
+        def component.component_path; '/my/path'; end
+        browser.expect(:visit, nil, ['/my/path'])
+        component.show
+      end
+
+      it 'passes any arguments through to #component_path' do
+        def browser.visit(*args); nil; end
+
+        def component.component_path(*args)
+          unless args == %w[one two three]
+            raise "Expected #component_path('one', 'two', 'three') but called with #{args.inspect}"
+          end
+        end
+
+        component.show('one', 'two', 'three')
+      end
+    end
+
+    describe "when the component is already visible" do
+      it 'does not visit the component path' do
+        def component.component_path; '/my/path'; end
+        def component.visible?; true; end
+
+        def browser.visit(*args); raise "Shouldn't get called"; end
+        component.show
+      end
+    end
+  end
 end

data/test/kookaburra_test.rb

@@ -48,7 +48,7 @@ describe Kookaburra do
 
       it 'defaults to the value of Kookaburra.adapter' do
         begin
-          old_adapter = Kookaburra.adapter
+          old_adapter = Kookaburra.adapter rescue nil
           Kookaburra.adapter = :global_adapter
           mixer = mixer_class.new
           assert_equal :global_adapter, mixer.kookaburra_adapter
@@ -133,10 +133,16 @@ describe Kookaburra do
   describe 'methods on the Kookaburra object' do
     describe '#adapter' do
       it 'is a read/write attribute' do
-        assert_nil Kookaburra.adapter
         Kookaburra.adapter = :probably_Capybara
         assert_equal :probably_Capybara, Kookaburra.adapter
       end
+
+      it 'raises an exception when it is read while nil' do
+        assert_raises Kookaburra::ConfigurationError do
+          Kookaburra.adapter = nil
+          Kookaburra.adapter
+        end
+      end
     end
 
     describe '#api_driver' do
@@ -144,6 +150,13 @@ describe Kookaburra do
         Kookaburra.api_driver = :an_api_driver
         assert_equal :an_api_driver, Kookaburra.api_driver
       end
+
+      it 'raises an exception when it is read while nil' do
+        assert_raises Kookaburra::ConfigurationError do
+          Kookaburra.api_driver = nil
+          Kookaburra.api_driver
+        end
+      end
     end
 
     describe '#given_driver' do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: kookaburra
 version: !ruby/object:Gem::Version 
-  hash: 35
+  hash: 33
   prerelease: 
   segments: 
   - 0
   - 14
-  - 2
-  version: 0.14.2
+  - 3
+  version: 0.14.3
 platform: ruby
 authors: 
 - Renewable Funding, LLC
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-02-01 00:00:00 Z
+date: 2012-02-22 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   version_requirements: &id001 !ruby/object:Gem::Requirement 
@@ -192,6 +192,7 @@ files:
 - test/helper.rb
 - test/kookaburra/assertion_test.rb
 - test/kookaburra/test_data_test.rb
+- test/kookaburra/ui_driver/mixins/has_browser_test.rb
 - test/kookaburra/ui_driver/ui_component_test.rb
 - test/kookaburra/ui_driver_test.rb
 - test/kookaburra_test.rb
@@ -224,7 +225,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.8.15
+rubygems_version: 1.8.16
 signing_key: 
 specification_version: 3
 summary: WindowDriver testing pattern for Ruby apps