kontoapi-ruby 0.0.1 → 0.1.0

data/Gemfile

@@ -1,11 +1,12 @@
 source "http://rubygems.org"
 
 gem 'addressable'
-gem 'nibbler', '>= 1.2.0'
+gem 'yajl-ruby'
 
 group :development do
   gem "rspec", "~> 2.3.0"
   gem "bundler", "~> 1.0.0"
   gem "jeweler", "~> 1.5.2"
   gem "rcov", ">= 0"
+  gem "fakeweb"
 end

data/Gemfile.lock

@@ -3,12 +3,12 @@ GEM
   specs:
     addressable (2.2.5)
     diff-lcs (1.1.2)
+    fakeweb (1.3.0)
     git (1.2.5)
     jeweler (1.5.2)
       bundler (~> 1.0.0)
       git (>= 1.2.5)
       rake
-    nibbler (1.2.1)
     rake (0.8.7)
     rcov (0.9.9)
     rspec (2.3.0)
@@ -19,6 +19,7 @@ GEM
     rspec-expectations (2.3.0)
       diff-lcs (~> 1.1.2)
     rspec-mocks (2.3.0)
+    yajl-ruby (0.8.2)
 
 PLATFORMS
   ruby
@@ -26,7 +27,8 @@ PLATFORMS
 DEPENDENCIES
   addressable
   bundler (~> 1.0.0)
+  fakeweb
   jeweler (~> 1.5.2)
-  nibbler (>= 1.2.0)
   rcov
   rspec (~> 2.3.0)
+  yajl-ruby

data/VERSION

@@ -1 +1 @@
-0.0.1
+0.1.0

data/kontoapi-ruby.gemspec

@@ -0,0 +1,71 @@
+# Generated by jeweler
+# DO NOT EDIT THIS FILE DIRECTLY
+# Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
+# -*- encoding: utf-8 -*-
+
+Gem::Specification.new do |s|
+  s.name = %q{kontoapi-ruby}
+  s.version = "0.1.0"
+
+  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
+  s.authors = ["Jan Schwenzien"]
+  s.date = %q{2011-04-18}
+  s.description = %q{A ruby library to access the Konto API (https://www.kontoapi.de/), a webservice that performs validity checks and other services regarding german bank accounts.}
+  s.email = %q{jan@general-scripting.com}
+  s.extra_rdoc_files = [
+    "LICENSE",
+    "README.markdown"
+  ]
+  s.files = [
+    "Gemfile",
+    "Gemfile.lock",
+    "LICENSE",
+    "README.markdown",
+    "Rakefile",
+    "VERSION",
+    "kontoapi-ruby.gemspec",
+    "lib/kontoapi-ruby.rb",
+    "spec/kontoapi-ruby_spec.rb",
+    "spec/spec_helper.rb"
+  ]
+  s.homepage = %q{http://github.com/GeneralScripting/kontoapi-ruby}
+  s.licenses = ["MIT"]
+  s.require_paths = ["lib"]
+  s.rubygems_version = %q{1.7.2}
+  s.summary = %q{Konto API Ruby Library}
+  s.test_files = [
+    "spec/kontoapi-ruby_spec.rb",
+    "spec/spec_helper.rb"
+  ]
+
+  if s.respond_to? :specification_version then
+    s.specification_version = 3
+
+    if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
+      s.add_runtime_dependency(%q<addressable>, [">= 0"])
+      s.add_runtime_dependency(%q<yajl-ruby>, [">= 0"])
+      s.add_development_dependency(%q<rspec>, ["~> 2.3.0"])
+      s.add_development_dependency(%q<bundler>, ["~> 1.0.0"])
+      s.add_development_dependency(%q<jeweler>, ["~> 1.5.2"])
+      s.add_development_dependency(%q<rcov>, [">= 0"])
+      s.add_development_dependency(%q<fakeweb>, [">= 0"])
+    else
+      s.add_dependency(%q<addressable>, [">= 0"])
+      s.add_dependency(%q<yajl-ruby>, [">= 0"])
+      s.add_dependency(%q<rspec>, ["~> 2.3.0"])
+      s.add_dependency(%q<bundler>, ["~> 1.0.0"])
+      s.add_dependency(%q<jeweler>, ["~> 1.5.2"])
+      s.add_dependency(%q<rcov>, [">= 0"])
+      s.add_dependency(%q<fakeweb>, [">= 0"])
+    end
+  else
+    s.add_dependency(%q<addressable>, [">= 0"])
+    s.add_dependency(%q<yajl-ruby>, [">= 0"])
+    s.add_dependency(%q<rspec>, ["~> 2.3.0"])
+    s.add_dependency(%q<bundler>, ["~> 1.0.0"])
+    s.add_dependency(%q<jeweler>, ["~> 1.5.2"])
+    s.add_dependency(%q<rcov>, [">= 0"])
+    s.add_dependency(%q<fakeweb>, [">= 0"])
+  end
+end
+

data/lib/kontoapi-ruby.rb

@@ -1,4 +1,5 @@
 require 'addressable/uri'
+require 'yajl/json_gem'
 require 'net/http'
 require 'net/https'
 
@@ -27,13 +28,15 @@ module KontoAPI
   end
 
   def valid?(account_number, bank_code)
-    response = ask_for(:validity, { :ktn => account_number, :blz => bank_code })
-    response[:answer].eql?('yes')
+    return false if account_number.to_s.strip.empty? || bank_code.to_s.strip.empty?
+    response = ask_for(:validity, { :ktn => account_number.to_s, :blz => bank_code.to_s })
+    response['answer'].eql?('yes')
   end
 
   def bank_name(bank_code)
-    response = ask_for(:bankname, { :blz => bank_code })
-    response[:answer]
+    return nil if bank_code.to_s.strip.empty?
+    response = ask_for(:bankname, { :blz => bank_code.to_s })
+    response['answer'].empty? ? nil : response['answer']
   end
 
 
@@ -46,7 +49,7 @@ module KontoAPI
     options.merge!( :key => api_key )
     url.query_values = options
     body = get_url(url)
-    NibblerJSON.parse(body)
+    JSON.parse(body)
   end
 
   def get_url(url)
@@ -56,7 +59,8 @@ module KontoAPI
     # TODO include certs and enable SSL verification
     http.verify_mode = OpenSSL::SSL::VERIFY_NONE
     response = http.get url.request_uri, 'User-agent' => 'Konto API Ruby Client'
-    if Net::HTTPSuccess == response
+    case response
+    when Net::HTTPSuccess, Net::HTTPOK
       response.body
     else
       response.error!

data/spec/kontoapi-ruby_spec.rb

@@ -1,7 +1,61 @@
 require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 
-describe "KontoapiRuby" do
-  it "fails" do
-    fail "hey buddy, you should probably rename this file and start specing for real"
+describe "KontoAPI" do
+
+  it "should raise if no api key was provided" do
+    lambda { KontoAPI::valid?('1234567', '12312312') }.should raise_error(RuntimeError)
+  end
+
+  it "should raise if api key is invalid" do
+    FakeWeb.register_uri(:get, %r|https://ask\.kontoapi\.de/for/validity.json?.*|, :body => '{"error":"unauthenticated"}', :status => ["401", "Unauthorized"])
+    KontoAPI::api_key = 'abc123'
+    lambda { KontoAPI::valid?('1234567', '12312312') }.should raise_error(Net::HTTPServerException)
+  end
+
+  context "checking validity" do
+
+    it "should return false if account number or bank code are empty" do
+      KontoAPI::valid?(nil, nil).should be_false
+      KontoAPI::valid?('123', nil).should be_false
+      KontoAPI::valid?(nil, '123').should be_false
+      KontoAPI::valid?('', '').should be_false
+      KontoAPI::valid?('123', '').should be_false
+      KontoAPI::valid?('', '123').should be_false
+    end
+
+    it "should return true for successfull validity checks" do
+      FakeWeb.register_uri(:get, %r|https://ask\.kontoapi\.de/for/validity.json?.*|, :body => '{"answer":"yes"}')
+      KontoAPI::api_key = 'abc123'
+      KontoAPI::valid?('correct_account_number', '12312312').should be_true
+    end
+
+    it "should return false for unsuccessfull validity checks" do
+      FakeWeb.register_uri(:get, %r|https://ask\.kontoapi\.de/for/validity.json?.*|, :body => '{"answer":"no"}')
+      KontoAPI::api_key = 'abc123'
+      KontoAPI::valid?('incorrect_account_number', '12312312').should be_false
+    end
+
+  end
+
+  context "getting bank names" do
+
+    it "should return nil if no bank code was provided" do
+      KontoAPI::bank_name(nil).should be_nil
+      KontoAPI::bank_name('').should be_nil
+    end
+
+    it "should return nil if no bank was found" do
+      FakeWeb.register_uri(:get, %r|https://ask\.kontoapi\.de/for/bankname.json?.*|, :body => '{"answer":""}')
+      KontoAPI::api_key = 'abc123'
+      KontoAPI::bank_name('12312312').should be_nil
+    end
+
+    it "should return Postbank for bank code 10010010" do
+      FakeWeb.register_uri(:get, %r|https://ask\.kontoapi\.de/for/bankname.json?.*|, :body => '{"answer":"Postbank"}')
+      KontoAPI::api_key = 'abc123'
+      KontoAPI::bank_name('10010010').should == "Postbank"
+    end
+
   end
+
 end

data/spec/spec_helper.rb

@@ -2,6 +2,7 @@ $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 require 'rspec'
 require 'kontoapi-ruby'
+require 'fakeweb'
 
 # Requires supporting files with custom matchers and macros, etc,
 # in ./support/ and its subdirectories.

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: kontoapi-ruby
 version: !ruby/object:Gem::Version 
-  hash: 29
+  hash: 27
   prerelease: 
   segments: 
   - 0
-  - 0
   - 1
-  version: 0.0.1
+  - 0
+  version: 0.1.0
 platform: ruby
 authors: 
 - Jan Schwenzien
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-04-17 00:00:00 Z
+date: 2011-04-18 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: addressable
@@ -32,19 +32,17 @@ dependencies:
   type: :runtime
   version_requirements: *id001
 - !ruby/object:Gem::Dependency 
-  name: nibbler
+  name: yajl-ruby
   prerelease: false
   requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 31
+        hash: 3
         segments: 
-        - 1
-        - 2
         - 0
-        version: 1.2.0
+        version: "0"
   type: :runtime
   version_requirements: *id002
 - !ruby/object:Gem::Dependency 
@@ -109,6 +107,20 @@ dependencies:
         version: "0"
   type: :development
   version_requirements: *id006
+- !ruby/object:Gem::Dependency 
+  name: fakeweb
+  prerelease: false
+  requirement: &id007 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  type: :development
+  version_requirements: *id007
 description: A ruby library to access the Konto API (https://www.kontoapi.de/), a webservice that performs validity checks and other services regarding german bank accounts.
 email: jan@general-scripting.com
 executables: []
@@ -125,6 +137,7 @@ files:
 - README.markdown
 - Rakefile
 - VERSION
+- kontoapi-ruby.gemspec
 - lib/kontoapi-ruby.rb
 - spec/kontoapi-ruby_spec.rb
 - spec/spec_helper.rb