komenda 0.1.7 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 539e892cf6dd52f871008d73d4597f549c40664a
-  data.tar.gz: 6421357e13b63bb9e3c59f45532cd72b8e4ea4db
+  metadata.gz: 7363d1fd415448c30eb3c0f44f8ad366f2a9180a
+  data.tar.gz: ac53399da6a6e2bcda191b45e8d948e7eebfe110
 SHA512:
-  metadata.gz: b9c596b3f1c0cf1c50630ca6044793f85be884fb78367b1250840d7f90626cef45a1610d1044cddcabfb3a47089720bac0dc792a7ba4787df0d2d58dcf47685d
-  data.tar.gz: 5d0bd13566dfc652623f33240611830c1cf0fa205ba355e8ac98af28c4530d64c494db093201b5b94792065d11ae76faa4340b19c0fc59e699b202391753ffb9
+  metadata.gz: c5020b1f9715318ab60510e8884405d5b4d884f0e9e8897bc2d8786403304a51dd8b076da9fe248d50fd2d6aff5cc8e685b3a791f627170e1d7d6a1970d7e8a9
+  data.tar.gz: 35f4253ee44c608aa5ec532640f7891a9c3158327b3cc41ea6469bd3840bd4c1a33df166a7df5eb80e4b8e21b4bace67ddd03567128cdb91073ac59e60ca8b4e

data/README.md

@@ -22,6 +22,7 @@ result.stderr   # => ""
 result.output   # => "Tue Nov 26 14:45:03 EST 2013\n" (combined stdout + stderr)
 result.status   # => 0
 result.success? # => true
+result.error?   # => false
 result.pid      # => 32157
 ```
 The program and its arguments can be passed as an array:
@@ -74,3 +75,9 @@ Run the tests:
 ```
 bundle exec rake spec
 ```
+
+Release a new version:
+
+1. Bump the version in `komenda.gemspec`, merge to master.
+2. Push a new tag to master.
+3. Release to RubyGems with `bundle exec rake release`.

data/lib/komenda/process.rb

@@ -28,7 +28,7 @@ module Komenda
     def wait_for
       raise 'Process not started' unless started?
       @thread.join
-      if @process_builder.fail_on_fail && !result.success?
+      if @process_builder.fail_on_fail && result.error?
         raise "Process failed with exit status `#{result.exitstatus}` and output:\n#{result.output}"
       end
       result
@@ -53,7 +53,10 @@ module Komenda
 
     # @return [TrueClass, FalseClass]
     def running?
-      started? && !@pid.nil? && !finished?
+      return false if @pid.nil?
+      1 == ::Process.kill(0, @pid)
+    rescue Errno::ESRCH
+      false
     end
 
     # @return [Komenda::Result]

data/lib/komenda/process_builder.rb

@@ -69,24 +69,33 @@ module Komenda
 
     # @return [Hash]
     def env_final
-      env_original = if !use_bundler_env && Object.const_defined?('Bundler')
-                       bundler_clean_env
-                     else
-                       ENV.to_hash
-                     end
       env_original.merge(env)
     end
 
     private
 
     # @return [Hash]
-    def bundler_clean_env
-      if Bundler.methods(false).include?(:clean_env)
-        Bundler.clean_env
+    def env_original
+      if !use_bundler_env && Object.const_defined?('Bundler')
+        bundler_clean_env
       else
-        # For Bundler < 1.12.0
-        Bundler.with_clean_env { ENV.to_hash }
+        ENV.to_hash
       end
     end
+
+    # @return [Hash]
+    def bundler_clean_env
+      env = if Bundler.methods(false).include?(:clean_env)
+              Bundler.clean_env
+            else
+              # For Bundler < 1.12.0
+              Bundler.with_clean_env { ENV.to_hash }
+            end
+      # Work around limitations of `Bundler.clean_env`
+      env.delete('BUNDLER_VERSION')
+      env.delete('RUBYOPT') if env.key?('RUBYOPT') && env['RUBYOPT'] == ''
+      env.delete('RUBYLIB') if env.key?('RUBYLIB') && env['RUBYLIB'] == ''
+      env
+    end
   end
 end

data/lib/komenda/result.rb

@@ -31,6 +31,10 @@ module Komenda
       exitstatus == 0
     end
 
+    def error?
+      exitstatus != 0
+    end
+
     def pid
       @status.pid
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: komenda
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.8
 platform: ruby
 authors:
 - Cargo Media
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-06 00:00:00.000000000 Z
+date: 2017-05-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: events
@@ -127,7 +127,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Convenience wrapper around `Open3` to run shell commands in Ruby.