kobot 1.2.3 → 1.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3eba14b1e3b076a368dd700c2ac46a9db4fd13bf57a58e29797de7db7eb16fc3
-  data.tar.gz: 1926333cefbaf4272ae117cc7afb12284ed85d6ff41aa96a02094904599b5312
+  metadata.gz: 0e8cedf9053f994144d21b233b2c68fb4e03aff011192f1273e1ad24d347c4f9
+  data.tar.gz: 8daab86f87c5ffe5e0588c9029ccd062954ca7ad3557769861ef19fd07347c79
 SHA512:
-  metadata.gz: '08ad9cb2d55c2931a34ed4243884a7e16c189d1d914e5aa935cfd4d32fc3d3d7567cdaecdb53de54e980e84ec4c6e696761b7f9b15fb65e3a0eef11f829370e5'
-  data.tar.gz: f8662e41fe53d35df04b1b530f946621330124684d6bd955e6b18e53830efaef74c22db66818a8a3958aa8a4745b4d37090419f538962c3a4876e8dbb9b6c1d7
+  metadata.gz: 4aaaa2f0e8eebe98487536158b0f571e794b76db95dec5cd2eb268037dfd0888045d6cebbeb46876162ed9944813f7429e8a4466da20ca9010ecacfd552cd302
+  data.tar.gz: 9ede3410f3ad664982db308f382140eb19bc8140970fc4991f68829a0c63fe664a6978b99ef5753036954a0bbabb9731b3f7e5fe08aff11c589798898ce0ec59

data/CHANGELOG.md

@@ -22,3 +22,6 @@
 ### v1.2.3
 - Improved validation logic to skip running due to weekend or intentional skips
 - Refactored engine by reducing methods length based on reports by Rubocop
+
+### v1.2.4
+- Changed to use boolean values for validation instead of raising exceptions

data/lib/kobot/engine.rb

@@ -14,7 +14,7 @@ module Kobot
 
     # The entrance where the whole flow starts.
     #
-    # It exits early if today is weekend or treated as holiday by
+    # It exits early if today is weekend or marked as to skip by
     # the #{Config.skip} specified from command line option --skip.
     #
     # Unexpected behavior such as record appearing as holiday on
@@ -24,7 +24,8 @@ module Kobot
     # System errors or any unknown exceptions occurred if any are
     # to be popped up and should be handled by the outside caller.
     def start
-      validate_today!
+      return unless should_run_today?
+
       launch_browser
       login
       read_today_record
@@ -35,8 +36,6 @@ module Kobot
         clock_out!
       end
       logout
-    rescue KotSkip => e
-      Kobot.logger.warn(e.message)
     rescue KotRecordError => e
       Kobot.logger.warn(e.message)
       Mailer.send(clock_notify_message(status: e.message))
@@ -60,13 +59,16 @@ module Kobot
 
     private
 
-    def validate_today!
-      raise KotSkip, "Today=#{@today} is skipped as per: --skip=#{Config.skip}" if skip?
-
-      return unless weekend?
-      raise KotSkip, "Today=#{@today} is weekend" unless Config.force
+    def should_run_today?
+      if skip?
+        Kobot.logger.warn("Today=#{@today} is skipped as per: --skip=#{Config.skip}")
+        return false
+      end
+      return true unless weekend?
 
-      Kobot.logger.info("[Force] should have exited: today=#{@today} is weekend")
+      Kobot.logger.info("[Force] should have exited: today=#{@today} is weekend") if Config.force
+      Kobot.logger.warn("Today=#{@today} is weekend") unless Config.force
+      Config.force
     end
 
     def launch_browser

data/lib/kobot/exception.rb

@@ -1,15 +1,7 @@
 # frozen_string_literal: true
 
 module Kobot
-  class KotSkip < StandardError
-  end
-
-  class KotRecordError < StandardError
-  end
-
-  class KotClockInError < StandardError
-  end
-
-  class KotClockOutError < StandardError
-  end
+  class KotRecordError < StandardError; end
+  class KotClockInError < StandardError; end
+  class KotClockOutError < StandardError; end
 end

data/lib/kobot/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Kobot
-  VERSION = '1.2.3'
+  VERSION = '1.2.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kobot
 version: !ruby/object:Gem::Version
-  version: 1.2.3
+  version: 1.2.4
 platform: ruby
 authors:
 - Andy Jiang
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-09-05 00:00:00.000000000 Z
+date: 2020-09-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: webdrivers