koala 1.4.0.rc1 → 1.4.0

data/CHANGELOG

@@ -5,13 +5,13 @@ Updated methods:
 -- HTTPServices#encode_params sorts parameters to aid in URL comparison (thanks, sholden!)
 -- get_connections is now aliased as get_connection (use whichever makes sense to you)
 Internal improvements:
--- Fixed a readme typo (thanks, brycethornton!)
+-- Fixed typos (thanks, brycethornton and jpemberthy!)
+-- RealtimeUpdates will no longer execute challenge block unnecessarily (thanks, iainbeeston!)
 Testing improvements:
 -- Added parallel_tests to development gem file
 -- Fixed failing live tests
 -- Koala now tests against JRuby and Rubinius in 1.9 mode on Travis-CI
 
-
 v1.3
 New methods:
 -- OAuth#url_for_dialog creates URLs for Facebook dialog pages

data/koala.gemspec

@@ -5,13 +5,12 @@ require 'koala/version'
 Gem::Specification.new do |s|
   s.name    = %q{koala}
   s.version = Koala::VERSION
-  s.date    = %q{2011-10-04}
 
   s.summary     = %q{A lightweight, flexible library for Facebook with support for the Graph API, the REST API, realtime updates, and OAuth authentication.}
   s.description = %q{Koala is a lightweight, flexible Ruby SDK for Facebook.  It allows read/write access to the social graph via the Graph and REST APIs, as well as support for realtime updates and OAuth and Facebook Connect authentication.  Koala is fully tested and supports Net::HTTP and Typhoeus connections out of the box and can accept custom modules for other services.}
   s.homepage    = %q{http://github.com/arsduo/koala}
 
-  s.authors = ["Alex Koppel, Chris Baclig, Rafi Jacoby, Context Optional"]
+  s.authors = ["Alex Koppel"]
   s.email   = %q{alex@alexkoppel.com}
 
   s.files = `git ls-files`.split("\n")

data/lib/koala/http_service.rb

@@ -65,7 +65,7 @@ module Koala
 
       # figure out our options for this request   
       request_options = {:params => (verb == "get" ? params : {})}.merge(http_options || {}).merge(process_options(options))
-      request_options[:use_ssl] = true if args["access_token"] # require http if there's a token
+      request_options[:use_ssl] = true if args["access_token"] # require https if there's a token
 
       # set up our Faraday connection
       # we have to manually assign params to the URL or the

data/lib/koala/realtime_updates.rb

@@ -101,11 +101,11 @@ module Koala
             # you can make sure this is legitimate through two ways
             # if your store the token across the calls, you can pass in the token value
             # and we'll make sure it matches
-            (verify_token && params["hub.verify_token"] == verify_token) ||
+            ((verify_token && params["hub.verify_token"] == verify_token) ||
             # alternately, if you sent a specially-constructed value (such as a hash of various secret values)
             # you can pass in a block, which we'll call with the verify_token sent by Facebook
             # if it's legit, return anything that evaluates to true; otherwise, return nil or false
-            (verification_block && yield(params["hub.verify_token"]))
+            (verification_block && yield(params["hub.verify_token"])))
           params["hub.challenge"]
         else
           false

data/lib/koala/version.rb

@@ -1,3 +1,3 @@
 module Koala
-  VERSION = "1.4.0.rc1"
+  VERSION = "1.4.0"
 end

data/spec/cases/realtime_updates_spec.rb

@@ -243,6 +243,13 @@ describe "Koala::Facebook::RealtimeUpdates" do
       params = {'hub.mode' => 'not subscribe'}
       Koala::Facebook::RealtimeUpdates.meet_challenge(params).should be_false
     end
+
+    it "doesn't evaluate the block if hub.mode isn't subscribe" do
+      params = {'hub.mode' => 'not subscribe'}
+      block_evaluated = false
+      Koala::Facebook::RealtimeUpdates.meet_challenge(params){|token| block_evaluated = true}
+      block_evaluated.should be_false
+    end
     
     it "returns false if not given a verify_token or block" do
       params = {'hub.mode' => 'subscribe'}

metadata

@@ -1,19 +1,19 @@
 --- !ruby/object:Gem::Specification
 name: koala
 version: !ruby/object:Gem::Version
-  version: 1.4.0.rc1
-  prerelease: 6
+  version: 1.4.0
+  prerelease: 
 platform: ruby
 authors:
-- Alex Koppel, Chris Baclig, Rafi Jacoby, Context Optional
+- Alex Koppel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-10-04 00:00:00.000000000Z
+date: 2012-03-11 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
-  requirement: &70302319320000 !ruby/object:Gem::Requirement
+  requirement: &70104159239520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: '1.0'
   type: :runtime
   prerelease: false
-  version_requirements: *70302319320000
+  version_requirements: *70104159239520
 - !ruby/object:Gem::Dependency
   name: faraday
-  requirement: &70302319318660 !ruby/object:Gem::Requirement
+  requirement: &70104159238080 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: 0.7.0
   type: :runtime
   prerelease: false
-  version_requirements: *70302319318660
+  version_requirements: *70104159238080
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70302319317360 !ruby/object:Gem::Requirement
+  requirement: &70104159236640 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: 2.8.0rc1
   type: :development
   prerelease: false
-  version_requirements: *70302319317360
+  version_requirements: *70104159236640
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70302319316620 !ruby/object:Gem::Requirement
+  requirement: &70104159224060 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,7 +54,7 @@ dependencies:
         version: 0.8.7
   type: :development
   prerelease: false
-  version_requirements: *70302319316620
+  version_requirements: *70104159224060
 description: Koala is a lightweight, flexible Ruby SDK for Facebook.  It allows read/write
   access to the social graph via the Graph and REST APIs, as well as support for realtime
   updates and OAuth and Facebook Connect authentication.  Koala is fully tested and
@@ -143,7 +143,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1082598694545129071
+      hash: 3977306572275608217
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: