koala 1.11.0 → 1.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7c18d7418b80cc0f8659f1ed4e390a5ecae660d2
-  data.tar.gz: 03350209620bdcf14e9173eb8ccabcc0572d2a3a
+  metadata.gz: 44887034b965ebbac49df6389117a3482918a215
+  data.tar.gz: 0e49cb623168d97da705aed316df81eb7a1dfebf
 SHA512:
-  metadata.gz: d042dcd2dd67fa01043bd36de85eca5c85715003df73c9076da70fb5f4c6fa8a2df7510d8de1e7210839c475e15514b275861ed30e56c5de5ba92ac415c2be1c
-  data.tar.gz: 3c07f360639e395f661fc6f8068d3a6120ea9f2ed98a4460d88fce0e57b34b4871230b5649118ec12daf52db47ac0234b68f5c6be8b2e62c43d9de9654d977c7
+  metadata.gz: 27f94913be28e196b58ff0934611007025f9374b0f08c3925dc6ce66670493f6dc06c7c6907c22b437765215435fd177b7f858c288466dfa1aa424eae3107344
+  data.tar.gz: f58743aef73431532ca4a8e206ede00abaf43522b5c1e6638f4cd8e4d2a74277661ca1a20f2911fb3aac57309879c10be66561e5b5d30dbbdd5c07664da564f9

data/.travis.yml

@@ -1,3 +1,6 @@
+language: ruby
+sudo: false
+cache: bundler
 rvm:
   # MRI
   - 1.9.3

data/changelog.md

@@ -1,3 +1,9 @@
+v.1.11.1
+=======
+
+Bug fixes:
+* Properly import Facebook error attributes (thanks, isra17!)
+
 v.1.11.0
 ========
 

data/lib/koala/errors.rb

@@ -14,7 +14,7 @@ module Koala
     # http_status, then the error was detected before making a call to Facebook. (e.g. missing access token)
     class APIError < ::Koala::KoalaError
       attr_accessor :fb_error_type, :fb_error_code, :fb_error_subcode, :fb_error_message,
-                    :fb_error_user_message, :fb_error_user_title, :http_status, :response_body
+                    :fb_error_user_msg, :fb_error_user_title, :http_status, :response_body
 
       # Create a new API Error
       #
@@ -51,11 +51,11 @@ module Koala
           self.fb_error_code = error_info["code"]
           self.fb_error_subcode = error_info["error_subcode"]
           self.fb_error_message = error_info["message"]
-          self.fb_error_user_message = error_info["error_user_message"]
+          self.fb_error_user_msg = error_info["error_user_msg"]
           self.fb_error_user_title = error_info["error_user_title"]
 
           error_array = []
-          %w(type code error_subcode message error_user_title error_user_message).each do |key|
+          %w(type code error_subcode message error_user_title error_user_msg).each do |key|
             error_array << "#{key}: #{error_info[key]}" if error_info[key]
           end
 

data/lib/koala/version.rb

@@ -1,3 +1,3 @@
 module Koala
-  VERSION = "1.11.0"
+  VERSION = "1.11.1"
 end

data/spec/cases/error_spec.rb

@@ -5,7 +5,7 @@ describe Koala::Facebook::APIError do
     expect(Koala::Facebook::APIError.new(nil, nil)).to be_a(Koala::KoalaError)
   end
 
-  [:fb_error_type, :fb_error_code, :fb_error_subcode, :fb_error_message, :fb_error_user_message, :fb_error_user_title, :http_status, :response_body].each do |accessor|
+  [:fb_error_type, :fb_error_code, :fb_error_subcode, :fb_error_message, :fb_error_user_msg, :fb_error_user_title, :http_status, :response_body].each do |accessor|
     it "has an accessor for #{accessor}" do
       expect(Koala::Facebook::APIError.instance_methods.map(&:to_sym)).to include(accessor)
       expect(Koala::Facebook::APIError.instance_methods.map(&:to_sym)).to include(:"#{accessor}=")
@@ -28,7 +28,7 @@ describe Koala::Facebook::APIError do
         'message' => 'message',
         'code' => 1,
         'error_subcode' => 'subcode',
-        'error_user_message' => 'error user message',
+        'error_user_msg' => 'error user message',
         'error_user_title' => 'error user title'
       }
       Koala::Facebook::APIError.new(400, '', error_info)
@@ -39,7 +39,7 @@ describe Koala::Facebook::APIError do
       :fb_error_message => 'message',
       :fb_error_code => 1,
       :fb_error_subcode => 'subcode',
-      :fb_error_user_message => 'error user message',
+      :fb_error_user_msg => 'error user message',
       :fb_error_user_title => 'error user title'
     }.each_pair do |accessor, value|
       it "sets #{accessor} to #{value}" do
@@ -48,7 +48,7 @@ describe Koala::Facebook::APIError do
     end
 
     it "sets the error message appropriately" do
-      expect(error.message).to eq("type: type, code: 1, error_subcode: subcode, message: message, error_user_title: error user title, error_user_message: error user message [HTTP 400]")
+      expect(error.message).to eq("type: type, code: 1, error_subcode: subcode, message: message, error_user_title: error user title, error_user_msg: error user message [HTTP 400]")
     end
   end
 
@@ -62,14 +62,14 @@ describe Koala::Facebook::APIError do
 
   context "with no error_info and a response_body containing error JSON" do
     it "should extract the error info from the response body" do
-      response_body = '{ "error": { "type": "type", "message": "message", "code": 1, "error_subcode": "subcode", "error_user_message": "error user message", "error_user_title": "error user title" } }'
+      response_body = '{ "error": { "type": "type", "message": "message", "code": 1, "error_subcode": "subcode", "error_user_msg": "error user message", "error_user_title": "error user title" } }'
       error = Koala::Facebook::APIError.new(400, response_body)
       {
         :fb_error_type => 'type',
         :fb_error_message => 'message',
         :fb_error_code => 1,
         :fb_error_subcode => 'subcode',
-        :fb_error_user_message => 'error user message',
+        :fb_error_user_msg => 'error user message',
         :fb_error_user_title => 'error user title'
       }.each_pair do |accessor, value|
         expect(error.send(accessor)).to eq(value)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: koala
 version: !ruby/object:Gem::Version
-  version: 1.11.0
+  version: 1.11.1
 platform: ruby
 authors:
 - Alex Koppel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-15 00:00:00.000000000 Z
+date: 2015-01-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json