koala 1.10.1 → 1.11.0rc

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8b83335264188054c217fd836a1f6508b2fcf420
-  data.tar.gz: 43116e3f574b6c689bed8a6a47a0ff25b69f6f3f
+  metadata.gz: 44c50b37f43f7bc407a12420de96e89f181d7b6f
+  data.tar.gz: 21203b9c7703b5bbacd43711ce990d3684a9d34c
 SHA512:
-  metadata.gz: 5982606d43ac0435e33de8b1a74e6ed32077cc515f0a52162f2ae5fe043242051e23c49a3502fcfac97ba539b7d6bcf777b383ea3bbc70db0c846d8532c04a7f
-  data.tar.gz: abf6a0fbf049448a8d5195e353512307c0dc1d03c319fa3d61448457463ef3e994e14b9dff4b9712b846be47984c88b28225d8aec4a8e4227658807ffafd00a5
+  metadata.gz: 29b23719eaaedf448162e7d477525d5a999d975ad6d2847bf5a4170d08bb42efcfee924d99c9ea747aa0310b046ba38ea4804a69aa858e9b52be9097bc706d41
+  data.tar.gz: 89dd9133b9976792fda084c954046f0828c30e48c727a3c9f37c15a5f0905e24d6161f884c025a5ae5040b7d4cd5a0f7c3918f4ef6a70352656dae8a0749cb0b

data/.travis.yml

@@ -3,8 +3,9 @@ rvm:
   - 1.9.3
   - 2.0.0
   - 2.1.0
+  - 2.1.2
   # rbx
-  - rbx-2
+  - rbx-2.4.1
   # jruby
   - jruby-19mode
 bundler_args: --without development

data/Gemfile

@@ -13,6 +13,8 @@ end
 
 group :test do
   gem "rspec", '~> 3.0.0.beta1'
+  gem "vcr"
+  gem "webmock"
 end
 
 gem "jruby-openssl" if defined? JRUBY_VERSION

data/changelog.md

@@ -1,3 +1,19 @@
+v.1.11.0
+========
+
+Updated features:
+* OAuth now supports decoding the new JSON responses from the access token endpoints (thanks, ridiculous!)
+* Batch API now accepts either symbols or strings for the access token (thanks, mattmueller!)
+* Incorporate user message and title into error handling (thanks, richrines and isra17!)
+
+Bug fixes:
+* Fixed bug in GraphCollection URL versioning (thanks, deviousdodo and jankowy!)
+* TestUsers#create_network now properly handles options (thanks, crx!)
+
+Documentation improvements:
+* Updated gem version (thanks, thomasklemm!)
+
+
 v.1.10.1
 ========
 

data/lib/koala/api/graph_batch_api.rb

@@ -19,12 +19,15 @@ module Koala
       end
 
       def graph_call_in_batch(path, args = {}, verb = "get", options = {}, &post_processing)
-        # for batch APIs, we queue up the call details (incl. post-processing)
+        # normalize options for consistency
+        options = Koala::Utils.symbolize_hash(options)
+
+        # for batch APIs, we queue up the call details (incl. post-processing)        
         batch_calls << BatchOperation.new(
           :url => path,
           :args => args,
           :method => verb,
-          :access_token => options['access_token'] || access_token,
+          :access_token => options[:access_token] || access_token,
           :http_options => options,
           :post_processing => post_processing
         )

data/lib/koala/errors.rb

@@ -14,14 +14,14 @@ module Koala
     # http_status, then the error was detected before making a call to Facebook. (e.g. missing access token)
     class APIError < ::Koala::KoalaError
       attr_accessor :fb_error_type, :fb_error_code, :fb_error_subcode, :fb_error_message,
-                    :http_status, :response_body
+                    :fb_error_user_message, :fb_error_user_title, :http_status, :response_body
 
       # Create a new API Error
       #
       # @param http_status [Integer] The HTTP status code of the response
       # @param response_body [String] The response body
       # @param error_info One of the following:
-      #                   [Hash] The error information extracted from the request 
+      #                   [Hash] The error information extracted from the request
       #                          ("type", "code", "error_subcode", "message")
       #                   [String] The error description
       #                   If error_info is nil or not provided, the method will attempt to extract
@@ -51,9 +51,11 @@ module Koala
           self.fb_error_code = error_info["code"]
           self.fb_error_subcode = error_info["error_subcode"]
           self.fb_error_message = error_info["message"]
+          self.fb_error_user_message = error_info["error_user_message"]
+          self.fb_error_user_title = error_info["error_user_title"]
 
           error_array = []
-          %w(type code error_subcode message).each do |key|
+          %w(type code error_subcode message error_user_title error_user_message).each do |key|
             error_array << "#{key}: #{error_info[key]}" if error_info[key]
           end
 
@@ -78,7 +80,7 @@ module Koala
     # Any error with a 5xx HTTP status code
     class ServerError < APIError; end
 
-    # Any error with a 4xx HTTP status code 
+    # Any error with a 4xx HTTP status code
     class ClientError < APIError; end
 
     # All graph API authentication failures.

data/lib/koala/http_service.rb

@@ -88,8 +88,10 @@ module Koala
         ssl[:verify] = true unless ssl.has_key?(:verify)
       end
 
-      # if an api_version is specified, prepend it to the path
-      if api_version = request_options[:api_version] || Koala.config.api_version
+      # if an api_version is specified and the path does not already contain
+      # one, prepend it to the path
+      api_version = request_options[:api_version] || Koala.config.api_version
+      if api_version && !path_contains_api_version?(path)
         begins_with_slash = path[0] == "/"
         divider = begins_with_slash ? "" : "/"
         path = "/#{api_version}#{divider}#{path}"
@@ -123,6 +125,16 @@ module Koala
       end).join("&")
     end
 
+    # Determines whether a given path already contains an API version.
+    #
+    # @param path the URL path.
+    #
+    # @return true or false accordingly.
+    def self.path_contains_api_version?(path)
+      match = /^\/?(v\d+(?:\.\d+)?)\//.match(path)
+      !!(match && match[1])
+    end
+
     # deprecations
     # not elegant or compact code, but temporary
 

data/lib/koala/oauth.rb

@@ -316,11 +316,12 @@ module Koala
       end
 
       def parse_access_token(response_text)
-        components = response_text.split("&").inject({}) do |hash, bit|
+        MultiJson.load(response_text)
+      rescue MultiJson::ParseError
+        response_text.split("&").inject({}) do |hash, bit|
           key, value = bit.split("=")
           hash.merge!(key => value)
         end
-        components
       end
 
       def parse_unsigned_cookie(fb_cookie)

data/lib/koala/test_users.rb

@@ -166,7 +166,7 @@ module Koala
       #
       # @return the list of users created
       def create_network(network_size, installed = true, permissions = '', options = {})
-        users = (0...network_size).collect { create(installed, permissions, options) }
+        users = (0...network_size).collect { create(installed, permissions, {}, options) }
         friends = users.clone
         users.each do |user|
           # Remove this user from list of friends

data/lib/koala/utils.rb

@@ -29,5 +29,13 @@ module Koala
         @posted_deprecations << message
       end
     end
+
+    # Ensures that a hash uses symbols as opposed to strings
+    # Useful for allowing either syntax for end users
+    def symbolize_hash(hash)
+      return hash unless hash.is_a?(Hash)
+
+      hash.inject({}){ |memo,(key,value)| memo[key.to_sym] = symbolize_hash(value); memo }
+    end
   end
 end

data/lib/koala/version.rb

@@ -1,3 +1,3 @@
 module Koala
-  VERSION = "1.10.1"
+  VERSION = "1.11.0rc"
 end

data/readme.md

@@ -15,7 +15,7 @@ Installation
 
 In Bundler:
 ```ruby
-gem "koala", "~> 1.10.0rc"
+gem "koala", "~> 1.10.1"
 ```
 
 Otherwise:

data/spec/cases/error_spec.rb

@@ -5,7 +5,7 @@ describe Koala::Facebook::APIError do
     expect(Koala::Facebook::APIError.new(nil, nil)).to be_a(Koala::KoalaError)
   end
 
-  [:fb_error_type, :fb_error_code, :fb_error_subcode, :fb_error_message, :http_status, :response_body].each do |accessor|
+  [:fb_error_type, :fb_error_code, :fb_error_subcode, :fb_error_message, :fb_error_user_message, :fb_error_user_title, :http_status, :response_body].each do |accessor|
     it "has an accessor for #{accessor}" do
       expect(Koala::Facebook::APIError.instance_methods.map(&:to_sym)).to include(accessor)
       expect(Koala::Facebook::APIError.instance_methods.map(&:to_sym)).to include(:"#{accessor}=")
@@ -22,12 +22,14 @@ describe Koala::Facebook::APIError do
   end
 
   context "with an error_info hash" do
-    let(:error) { 
+    let(:error) {
       error_info = {
         'type' => 'type',
         'message' => 'message',
         'code' => 1,
-        'error_subcode' => 'subcode'
+        'error_subcode' => 'subcode',
+        'error_user_message' => 'error user message',
+        'error_user_title' => 'error user title'
       }
       Koala::Facebook::APIError.new(400, '', error_info)
     }
@@ -36,15 +38,17 @@ describe Koala::Facebook::APIError do
       :fb_error_type => 'type',
       :fb_error_message => 'message',
       :fb_error_code => 1,
-      :fb_error_subcode => 'subcode'
+      :fb_error_subcode => 'subcode',
+      :fb_error_user_message => 'error user message',
+      :fb_error_user_title => 'error user title'
     }.each_pair do |accessor, value|
       it "sets #{accessor} to #{value}" do
         expect(error.send(accessor)).to eq(value)
       end
     end
 
-    it "sets the error message \"type: error_info['type'], code: error_info['code'], error_subcode: error_info['error_subcode'], message: error_info['message'] [HTTP http_status]\"" do
-      expect(error.message).to eq("type: type, code: 1, error_subcode: subcode, message: message [HTTP 400]")
+    it "sets the error message appropriately" do
+      expect(error.message).to eq("type: type, code: 1, error_subcode: subcode, message: message, error_user_title: error user title, error_user_message: error user message [HTTP 400]")
     end
   end
 
@@ -58,13 +62,15 @@ describe Koala::Facebook::APIError do
 
   context "with no error_info and a response_body containing error JSON" do
     it "should extract the error info from the response body" do
-      response_body = '{ "error": { "type": "type", "message": "message", "code": 1, "error_subcode": "subcode" } }'
+      response_body = '{ "error": { "type": "type", "message": "message", "code": 1, "error_subcode": "subcode", "error_user_message": "error user message", "error_user_title": "error user title" } }'
       error = Koala::Facebook::APIError.new(400, response_body)
       {
         :fb_error_type => 'type',
         :fb_error_message => 'message',
         :fb_error_code => 1,
-        :fb_error_subcode => 'subcode'
+        :fb_error_subcode => 'subcode',
+        :fb_error_user_message => 'error user message',
+        :fb_error_user_title => 'error user title'
       }.each_pair do |accessor, value|
         expect(error.send(accessor)).to eq(value)
       end

data/spec/cases/graph_api_batch_spec.rb

@@ -519,6 +519,15 @@ describe "Koala::Facebook::GraphAPI in batch mode" do
       expect(insights).to be_an(Koala::Facebook::GraphCollection)
     end
 
+    it "handles requests passing the access token option as a symbol instead of a string" do
+      me, insights = @api.batch do |batch_api|
+        batch_api.get_object('me')
+        batch_api.get_connections(@app_id, 'insights', {}, {:access_token => @app_api.access_token})
+      end
+      expect(me['id']).not_to be_nil
+      expect(insights).to be_an(Koala::Facebook::GraphCollection)
+    end
+
     it "preserves batch-op specific access tokens in GraphCollection returned from batch" do
       # Provide an alternate token for a batch operation
       @other_access_token_args = { 'access_token' => @app_api.access_token }

data/spec/cases/graph_collection_spec.rb

@@ -145,15 +145,15 @@ describe Koala::Facebook::GraphCollection do
   end
 
   describe "#next_page" do
-    let(:paging){ {"next" => "http://example.com/?a=2&b=3"} }
+    let(:paging){ {"next" => "http://example.com/abc?a=2&b=3"} }
 
     it "should get next page" do
-      expect(@api).to receive(:get_page).with(["", {"a" => "2", "b" => "3"}])
+      expect(@api).to receive(:get_page).with(["abc", {"a" => "2", "b" => "3"}])
       @collection.next_page
     end
 
     it "should get next page with extra parameters" do
-      expect(@api).to receive(:get_page).with(["", {"a" => "2", "b" => "3", "c" => "4"}])
+      expect(@api).to receive(:get_page).with(["abc", {"a" => "2", "b" => "3", "c" => "4"}])
       @collection.next_page("c" => "4")
     end
   end
@@ -171,4 +171,4 @@ describe Koala::Facebook::GraphCollection do
       @collection.previous_page("c" => "4")
     end
   end
-end
+end

data/spec/cases/http_service_spec.rb

@@ -296,6 +296,12 @@ describe Koala::HTTPService do
         expect(@mock_connection).to receive(:get).with("/v12/anything", anything)
         Koala::HTTPService.make_request("/anything", {}, "get")
       end
+
+      it "doesn't add a version if the path already contains one" do
+        expect(Koala.config).to receive(:api_version).and_return("v11")
+        expect(@mock_connection).to receive(:get).with("/v12/anything", anything)
+        Koala::HTTPService.make_request("/v12/anything", {}, "get")
+      end
     end
 
     it "makes a POST request if the verb isn't get" do
@@ -378,6 +384,24 @@ describe Koala::HTTPService do
     end
   end
 
+  describe ".path_contains_api_version?" do
+    it "works when the path is prefixed by a slash" do
+      expect(Koala::HTTPService.path_contains_api_version?('/v2.1/anything')).to be true
+    end
+
+    it "works when the path is not prefixed by a slash" do
+      expect(Koala::HTTPService.path_contains_api_version?('v2.1/anything')).to be true
+    end
+
+    it "works with versions without a ." do
+      expect(Koala::HTTPService.path_contains_api_version?('v21/anything')).to be true
+    end
+
+    it "returns nil for paths without a version" do
+      expect(Koala::HTTPService.path_contains_api_version?('/anything')).to be false
+    end
+  end
+
   describe "deprecated options" do
     before :each do
       allow(Koala::HTTPService).to receive(:http_options).and_return({})

data/spec/cases/oauth_spec.rb

@@ -449,6 +449,34 @@ describe "Koala::Facebook::OAuth" do
         @oauth.get_access_token_info(@code)
       end
 
+      it "properly decodes JSON results" do
+        result =  {
+          "access_token" => "foo",
+          "expires_in" => "baz",
+          "machine_id" => "bar"
+        }
+        allow(Koala).to receive(:make_request).and_return(
+          Koala::HTTPService::Response.new(
+            200,
+            MultiJson.dump(result),
+            {}
+          )
+        )
+        expect(@oauth.get_access_token_info(@code)).to eq(result)
+      end
+
+      it "falls back to URL-style parsing " do
+        result = "access_token=foo&expires_in=baz&machine_id=bar"
+        allow(Koala).to receive(:make_request).and_return(
+          Koala::HTTPService::Response.new(200, result, {})
+        )
+        expect(@oauth.get_access_token_info(@code)).to eq({
+          "access_token" => "foo",
+          "expires_in" => "baz",
+          "machine_id" => "bar"
+        })
+      end
+
       if KoalaTest.code
         it "properly gets and parses an access token token results into a hash" do
           result = @oauth.get_access_token_info(@code)

data/spec/cases/test_users_spec.rb

@@ -328,7 +328,7 @@ describe "Koala::Facebook::TestUsers" do
       perms = ["read_stream", "offline_access"]
       installed = false
       count = 25
-      expect(@test_users).to receive(:create).exactly(count).times.with(installed, perms, anything)
+      expect(@test_users).to receive(:create).exactly(count).times.with(installed, perms, anything, anything)
       allow(@test_users).to receive(:befriend)
       @test_users.create_network(count, installed, perms)
     end
@@ -336,7 +336,7 @@ describe "Koala::Facebook::TestUsers" do
     it "accepts http options that are passed to both the create and befriend calls" do
       count = 25
       options = {:some_http_option => true}
-      expect(@test_users).to receive(:create).exactly(count).times.with(anything, anything, options).and_return({})
+      expect(@test_users).to receive(:create).exactly(count).times.with(anything, anything, anything, options).and_return({})
       # there are more befriends than creates, but we don't need to do the extra work to calculate out the exact #
       expect(@test_users).to receive(:befriend).at_least(count).times.with(anything, anything, options)
       @test_users.create_network(count, true, "", options)

data/spec/fixtures/facebook_data.yml

@@ -59,4 +59,7 @@ subscription_test_data:
   challenge_data:
     "hub.challenge": "1290024882"
     "hub.verify_token": "myverificationtoken|1f54545d5f722733e17faae15377928f"
-    "hub.mode": "subscribe"
+    "hub.mode": "subscribe"
+
+vcr_data:
+  oauth_token: CAACEdEose0cBAKuiUM40KZBEsq2l0iggaMGZBPI74svGQRMmZCPXb7eZCYPhNUbVXnnYZCjXKFKIc7HgYllr4RDIKrANHm6kKncOx0Y3UpDqLliRGZAnSEUypyFworUnBMOQJBlAuB1wlwYJZB7LIZCobCcnT2q9QwrZBpK3qAZB3u7ZAJaZAdsMZBsyALkAXatoj75leWXhgXfT1QiJHZBGoRlz07Q85z1dZBReK4ZD

data/spec/fixtures/vcr_cassettes/friend_list_next_page.yml

@@ -0,0 +1,121 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: https://graph.facebook.com/v2.2/me/friends?access_token=CAACEdEose0cBAKuiUM40KZBEsq2l0iggaMGZBPI74svGQRMmZCPXb7eZCYPhNUbVXnnYZCjXKFKIc7HgYllr4RDIKrANHm6kKncOx0Y3UpDqLliRGZAnSEUypyFworUnBMOQJBlAuB1wlwYJZB7LIZCobCcnT2q9QwrZBpK3qAZB3u7ZAJaZAdsMZBsyALkAXatoj75leWXhgXfT1QiJHZBGoRlz07Q85z1dZBReK4ZD
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - Faraday v0.9.0
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Facebook-Api-Version:
+      - v2.2
+      Etag:
+      - "\"405645cb180f38f9c1e373a1fe301c47c2a763db\""
+      Content-Type:
+      - application/json; charset=UTF-8
+      Pragma:
+      - no-cache
+      Access-Control-Allow-Origin:
+      - "*"
+      X-Fb-Rev:
+      - '1543964'
+      Cache-Control:
+      - private, no-cache, no-store, must-revalidate
+      Expires:
+      - Sat, 01 Jan 2000 00:00:00 GMT
+      X-Fb-Debug:
+      - sR8XVZI7FA7B7iZBo18REPDIaoeLkIbkg06WTYKMmJ/wzV/Gr5wYOYE47wIIgvnLBMgTe2D3RKvGo668AMWYXw==
+      Date:
+      - Fri, 26 Dec 2014 14:54:14 GMT
+      Connection:
+      - keep-alive
+      Content-Length:
+      - '834'
+    body:
+      encoding: UTF-8
+      string: "{\"data\":[{\"name\":\"Brian Rosenthal\",\"id\":\"6580\"},{\"name\":\"Waynn
+        Lue\",\"id\":\"202035\"},{\"name\":\"Chris Baclig\",\"id\":\"216743\"},{\"name\":\"Scott
+        Kleper\",\"id\":\"219493\"},{\"name\":\"Nick Elser\",\"id\":\"429772\"},{\"name\":\"Ian
+        Spivey\",\"id\":\"700103\"},{\"name\":\"Hong Dave\",\"id\":\"1215057\"},{\"name\":\"Trek
+        Glowacki\",\"id\":\"2203865\"},{\"name\":\"Tung Bach Ly\",\"id\":\"2803850\"},{\"name\":\"Isaac
+        Wolkerstorfer\",\"id\":\"2900100\"},{\"name\":\"Avishai Weiss\",\"id\":\"2900461\"},{\"name\":\"Harold
+        Liss\",\"id\":\"2900570\"},{\"name\":\"Ryo Chijiiwa\",\"id\":\"2901026\"},{\"name\":\"Luke
+        Shepard\",\"id\":\"2901279\"},{\"name\":\"Daniela Wellisz\",\"id\":\"2903998\"},{\"name\":\"Daniel
+        Hirschberg\",\"id\":\"2904437\"},{\"name\":\"Borja Sotomayor\",\"id\":\"2905626\"},{\"name\":\"David
+        Underwood\",\"id\":\"2906370\"},{\"name\":\"Avi Schwab\",\"id\":\"2908086\"},{\"name\":\"Kathleen
+        Burnett\",\"id\":\"6827168\"},{\"name\":\"Solomon Hursey\",\"id\":\"6857763\"},{\"name\":\"Sarah
+        Allen\",\"id\":\"10100146\"},{\"name\":\"Zach Wolfenbarger\",\"id\":\"10115065\"},{\"name\":\"JT
+        Archie\",\"id\":\"10603565\"},{\"name\":\"Colin McCloskey\",\"id\":\"11308679\"}],\"paging\":{\"next\":\"https:\\/\\/graph.facebook.com\\/v2.2\\/2905623\\/friends?access_token=CAACEdEose0cBAKuiUM40KZBEsq2l0iggaMGZBPI74svGQRMmZCPXb7eZCYPhNUbVXnnYZCjXKFKIc7HgYllr4RDIKrANHm6kKncOx0Y3UpDqLliRGZAnSEUypyFworUnBMOQJBlAuB1wlwYJZB7LIZCobCcnT2q9QwrZBpK3qAZB3u7ZAJaZAdsMZBsyALkAXatoj75leWXhgXfT1QiJHZBGoRlz07Q85z1dZBReK4ZD&limit=25&offset=25&__after_id=enc_Aez9Lwck5wLvRR_mHYNCzYNGmnYunJfnA3Z8hYXQ0xOluJfy4KVv4YYD1I4Im036hrA\"},\"summary\":{\"total_count\":821}}"
+    http_version: 
+  recorded_at: Fri, 26 Dec 2014 14:54:14 GMT
+- request:
+    method: get
+    uri: https://graph.facebook.com/v2.2/2905623/friends?__after_id=enc_Aez9Lwck5wLvRR_mHYNCzYNGmnYunJfnA3Z8hYXQ0xOluJfy4KVv4YYD1I4Im036hrA&access_token=CAACEdEose0cBAKuiUM40KZBEsq2l0iggaMGZBPI74svGQRMmZCPXb7eZCYPhNUbVXnnYZCjXKFKIc7HgYllr4RDIKrANHm6kKncOx0Y3UpDqLliRGZAnSEUypyFworUnBMOQJBlAuB1wlwYJZB7LIZCobCcnT2q9QwrZBpK3qAZB3u7ZAJaZAdsMZBsyALkAXatoj75leWXhgXfT1QiJHZBGoRlz07Q85z1dZBReK4ZD&limit=25&offset=25
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - Faraday v0.9.0
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Facebook-Api-Version:
+      - v2.2
+      Etag:
+      - "\"ad597c7482d414a109407197c49d9c102b245fec\""
+      Content-Type:
+      - application/json; charset=UTF-8
+      Pragma:
+      - no-cache
+      Access-Control-Allow-Origin:
+      - "*"
+      X-Fb-Rev:
+      - '1543964'
+      Cache-Control:
+      - private, no-cache, no-store, must-revalidate
+      Expires:
+      - Sat, 01 Jan 2000 00:00:00 GMT
+      X-Fb-Debug:
+      - 4rfPGqFD0OuxktinjEn9le7gO3aRg+E1a6367E4h3cFk3O/vsYMACfGJFCAgsLakTiOMJaaNj4ep+CkgFPnFiw==
+      Date:
+      - Fri, 26 Dec 2014 14:54:15 GMT
+      Connection:
+      - keep-alive
+      Content-Length:
+      - '972'
+    body:
+      encoding: UTF-8
+      string: "{\"data\":[{\"name\":\"Andrew Kane\",\"id\":\"12460925\"},{\"name\":\"Robin
+        Greenwood\",\"id\":\"34602916\"},{\"name\":\"Tom Elliott\",\"id\":\"36902548\"},{\"name\":\"Brian
+        Maula\",\"id\":\"77800072\"},{\"name\":\"Brian Wis\",\"id\":\"78500422\"},{\"name\":\"Ryan
+        Merket\",\"id\":\"136300045\"},{\"name\":\"Alex Coles\",\"id\":\"202905335\"},{\"name\":\"Chris
+        Vincent\",\"id\":\"205300220\"},{\"name\":\"Craig Stoe\",\"id\":\"500388531\"},{\"name\":\"Alex
+        Neill\",\"id\":\"504120418\"},{\"name\":\"Riste\\u00e1rd Br\\u00e9anainn\",\"id\":\"10152350043011181\"},{\"name\":\"Rafi
+        Jacoby\",\"id\":\"518938454\"},{\"name\":\"Marc Blinder\",\"id\":\"519467425\"},{\"name\":\"Erik
+        Ogan\",\"id\":\"542404932\"},{\"name\":\"Nigel Benito Griffin\",\"id\":\"566130340\"},{\"name\":\"Karla
+        Geci\",\"id\":\"569882615\"},{\"name\":\"Dennis Schneider\",\"id\":\"582757122\"},{\"name\":\"Chad
+        Krsek\",\"id\":\"605431196\"},{\"name\":\"Simon Cross\",\"id\":\"605665581\"},{\"name\":\"Matt
+        Patterson\",\"id\":\"629514342\"},{\"name\":\"Adeel Ahmad\",\"id\":\"630665156\"},{\"name\":\"Nicholas
+        Solter\",\"id\":\"647473136\"},{\"name\":\"David Morcillo Mu\\u00f1oz\",\"id\":\"674832191\"},{\"name\":\"Ana
+        Luisa Santos\",\"id\":\"685010072\"},{\"name\":\"Matthias Wiemann\",\"id\":\"693274202\"}],\"paging\":{\"next\":\"https:\\/\\/graph.facebook.com\\/v2.2\\/2905623\\/friends?limit=25&offset=50&access_token=CAACEdEose0cBAKuiUM40KZBEsq2l0iggaMGZBPI74svGQRMmZCPXb7eZCYPhNUbVXnnYZCjXKFKIc7HgYllr4RDIKrANHm6kKncOx0Y3UpDqLliRGZAnSEUypyFworUnBMOQJBlAuB1wlwYJZB7LIZCobCcnT2q9QwrZBpK3qAZB3u7ZAJaZAdsMZBsyALkAXatoj75leWXhgXfT1QiJHZBGoRlz07Q85z1dZBReK4ZD&__after_id=enc_Aez79XsNc6mXAfVDW2zvCkfHWTRTl_YprQ2VgrtLMqPa71dSOCoC34H-6YHCCNonr-w\",\"previous\":\"https:\\/\\/graph.facebook.com\\/v2.2\\/2905623\\/friends?limit=25&offset=0&access_token=CAACEdEose0cBAKuiUM40KZBEsq2l0iggaMGZBPI74svGQRMmZCPXb7eZCYPhNUbVXnnYZCjXKFKIc7HgYllr4RDIKrANHm6kKncOx0Y3UpDqLliRGZAnSEUypyFworUnBMOQJBlAuB1wlwYJZB7LIZCobCcnT2q9QwrZBpK3qAZB3u7ZAJaZAdsMZBsyALkAXatoj75leWXhgXfT1QiJHZBGoRlz07Q85z1dZBReK4ZD&__before_id=enc_Aey0OlxZalVBlh623QavOqlYyEOlclWjZMQ_7Hv2x4BHFV_JzG9H2j-_nOikaW5PsyY\"},\"summary\":{\"total_count\":821}}"
+    http_version: 
+  recorded_at: Fri, 26 Dec 2014 14:54:15 GMT
+recorded_with: VCR 2.9.3

data/spec/integration/graph_collection_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+module Koala
+  RSpec.describe "requests using GraphCollections" do
+    let(:api) { Facebook::API.new(KoalaTest.vcr_oauth_token) }
+
+    before :each do
+      # use the right version of the API as of the writing of this test
+      Koala.config.api_version = "v2.2"
+    end
+
+    it "can access the next page of a friend list" do
+      KoalaTest.with_vcr_unless_live("friend_list_next_page") do
+        result = api.get_connection("me", "friends")
+        expect(result).not_to be_empty
+        expect(result.next_page).not_to be_empty
+      end
+    end
+  end
+end
+

data/spec/support/koala_test.rb

@@ -5,6 +5,7 @@ module KoalaTest
     attr_accessor :oauth_token, :app_id, :secret, :app_access_token, :code, :session_key
     attr_accessor :oauth_test_data, :subscription_test_data, :search_time
     attr_accessor :test_user_api
+    attr_accessor :vcr_oauth_token
   end
 
   # Test setup
@@ -12,31 +13,13 @@ module KoalaTest
   def self.setup_test_environment!
     setup_rspec
 
-    unless ENV['LIVE']
-      # By default the Koala specs are run using stubs for HTTP requests,
-      # so they won't fail due to Facebook-imposed rate limits or server timeouts.
-      #
-      # However as a result they are more brittle since
-      # we are not testing the latest responses from the Facebook servers.
-      # To be certain all specs pass with the current Facebook services,
-      # run LIVE=true bundle exec rake spec.
-      Koala.http_service = Koala::MockHTTPService
-      KoalaTest.setup_test_data(Koala::MockHTTPService::TEST_DATA)
-    else
+    if live?
       # Runs Koala specs through the Facebook servers
       # using data for a real app
       live_data = YAML.load_file(File.join(File.dirname(__FILE__), '../fixtures/facebook_data.yml'))
       KoalaTest.setup_test_data(live_data)
 
-      # allow live tests with different adapters
-      adapter = ENV['ADAPTER'] || "typhoeus" # use Typhoeus by default if available
-      begin
-        require adapter
-        require 'typhoeus/adapters/faraday' if adapter.to_s == "typhoeus"
-        Faraday.default_adapter = adapter.to_sym
-      rescue LoadError
-        puts "Unable to load adapter #{adapter}, using Net::HTTP."
-      end
+      activate_adapter!
 
       Koala.http_service.http_options[:beta] = true if ENV["beta"] || ENV["BETA"]
 
@@ -46,6 +29,17 @@ module KoalaTest
       else
         KoalaTest.validate_user_info(token)
       end
+    else
+      # By default the Koala specs are run using stubs for HTTP requests,
+      # so they won't fail due to Facebook-imposed rate limits or server timeouts.
+      #
+      # However as a result they are more brittle since
+      # we are not testing the latest responses from the Facebook servers.
+      # To be certain all specs pass with the current Facebook services,
+      # run LIVE=true bundle exec rake spec.
+      activate_vcr!
+      Koala.http_service = Koala::MockHTTPService
+      KoalaTest.setup_test_data(Koala::MockHTTPService::TEST_DATA)
     end
   end
 
@@ -79,6 +73,28 @@ module KoalaTest
     end
   end
 
+  # If we're running live tests against the Facebook API, don't use the VCR
+  # fixtures. (Another alternative would be to rerecord those fixtures, but we
+  # don't necessarily want to do that.
+  def self.with_vcr_unless_live(name)
+    if live?
+      yield
+    else
+      begin
+        # if we're using VCR, we don't want to use the mock service, which was
+        # an early implementation of the same type of tool
+        old_adapter = Koala.http_service
+        Koala.http_service = Koala::HTTPService
+        activate_adapter!
+        VCR.use_cassette(name) do
+          yield
+        end
+      ensure
+        Koala.http_service = old_adapter
+      end
+    end
+  end
+
   def self.setup_test_data(data)
     # make data accessible to all our tests
     self.oauth_test_data = data["oauth_test_data"]
@@ -90,12 +106,14 @@ module KoalaTest
     self.code = data["oauth_test_data"]["code"]
     self.session_key = data["oauth_test_data"]["session_key"]
 
+    self.vcr_oauth_token = data["vcr_data"]["oauth_token"]
+
     # fix the search time so it can be used in the mock responses
     self.search_time = data["search_time"] || (Time.now - 3600).to_s
   end
 
   def self.testing_permissions
-    "read_stream, publish_stream, user_photos, user_videos, read_insights"
+    "read_stream, publish_actions, user_photos, user_videos, read_insights"
   end
 
   def self.setup_test_users
@@ -143,7 +161,7 @@ module KoalaTest
     perms.each_pair do |perm, value|
       if value == (perm == "read_insights" ? 1 : 0) # live testing depends on insights calls failing
         puts "failed!\n" # put a new line after the print above
-        raise ArgumentError, "Your access token must have the read_stream, publish_stream, and user_photos permissions, and lack read_insights.  You have: #{perms.inspect}"
+        raise ArgumentError, "Your access token must have #{testing_permissions.join(", ")}, and lack read_insights.  You have: #{perms.inspect}"
       end
     end
     puts "done!"
@@ -199,4 +217,36 @@ module KoalaTest
   def self.app_properties
     mock_interface? ? {"desktop" => 0} : {"description" => "A test framework for Koala and its users.  (#{rand(10000).to_i})"}
   end
+
+  def self.live?
+    ENV['LIVE']
+  end
+
+  def self.activate_vcr!
+    require 'vcr'
+
+    VCR.configure do |c|
+      c.cassette_library_dir = 'spec/fixtures/vcr_cassettes'
+      c.hook_into :webmock # or :fakeweb
+    end
+  end
+
+  def self.activate_adapter!
+    unless @adapter_activation_attempted
+      # allow live tests with different adapters
+      adapter = ENV['ADAPTER'] || "typhoeus" # use Typhoeus by default if available
+      begin
+        # JRuby doesn't support typhoeus on Travis
+        unless defined? JRUBY_VERSION
+          require adapter
+          require 'typhoeus/adapters/faraday' if adapter.to_s == "typhoeus"
+          Faraday.default_adapter = adapter.to_sym
+        end
+      rescue LoadError
+        puts "Unable to load adapter #{adapter}, using Net::HTTP."
+      ensure
+        @adapter_activation_attempted = true
+      end
+    end
+  end
 end

metadata

@@ -1,55 +1,55 @@
 --- !ruby/object:Gem::Specification
 name: koala
 version: !ruby/object:Gem::Version
-  version: 1.10.1
+  version: 1.11.0rc
 platform: ruby
 authors:
 - Alex Koppel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-03 00:00:00.000000000 Z
+date: 2014-12-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: addressable
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Koala is a lightweight, flexible Ruby SDK for Facebook.  It allows read/write
@@ -64,11 +64,11 @@ extra_rdoc_files:
 - readme.md
 - changelog.md
 files:
-- ".autotest"
-- ".gitignore"
-- ".rspec"
-- ".travis.yml"
-- ".yardopts"
+- .autotest
+- .gitignore
+- .rspec
+- .travis.yml
+- .yardopts
 - Gemfile
 - Guardfile
 - LICENSE
@@ -115,6 +115,8 @@ files:
 - spec/fixtures/cat.m4v
 - spec/fixtures/facebook_data.yml
 - spec/fixtures/mock_facebook_responses.yml
+- spec/fixtures/vcr_cassettes/friend_list_next_page.yml
+- spec/integration/graph_collection_spec.rb
 - spec/spec_helper.rb
 - spec/support/custom_matchers.rb
 - spec/support/graph_api_shared_examples.rb
@@ -128,25 +130,25 @@ licenses:
 metadata: {}
 post_install_message: 
 rdoc_options:
-- "--line-numbers"
-- "--inline-source"
-- "--title"
+- --line-numbers
+- --inline-source
+- --title
 - Koala
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>'
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.1
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: A lightweight, flexible library for Facebook with support for the Graph API,
@@ -171,6 +173,8 @@ test_files:
 - spec/fixtures/cat.m4v
 - spec/fixtures/facebook_data.yml
 - spec/fixtures/mock_facebook_responses.yml
+- spec/fixtures/vcr_cassettes/friend_list_next_page.yml
+- spec/integration/graph_collection_spec.rb
 - spec/spec_helper.rb
 - spec/support/custom_matchers.rb
 - spec/support/graph_api_shared_examples.rb