knife-vrealize 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 708beefdc328f337f9e817d73b7da0da4171e0b0
-  data.tar.gz: d410e43b9a5e2604ec9d6fe944c5566c0ed4c96d
+  metadata.gz: 578b154a3ccbf57ebe1e6ebc53ab5e0f787880fd
+  data.tar.gz: 387f75225a0c35f7e9da8c6fb8e89e0a966e2746
 SHA512:
-  metadata.gz: 07777dc8f5499c9fe416bd9b2d87e68fac6141a436dd2444e2e132d95e2d9fcde26f63e983abd80dccdf33b49ccbd758a8e9a9db5c0f9be9efbbd5adbaee26f4
-  data.tar.gz: b6d577dbff372cc9a80430ca0ddca03a5d5aefe9336cdb9d0ca0e5845159ec796aed9880bb501cbdbc835e4733d71e767581f05191a44c44842db8fed697d541
+  metadata.gz: d95052a813c5ca77126f8d223bc6808993fd63843379a0356ecf03b7c5dd2d44abb7c33ac1246e8eb09d6d8883eeee50b300d404fc633b5d6076cf00c4bb98ca
+  data.tar.gz: 0c8f5c49e7537f9ed02aaa1e2671ac4baee6a1f0d52fa1bcf382346faaaf7a098ce2c88874913bd86435838357ed28aee9863590d00094dfa2ed0bf8f8d022d3

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # knife-vrealize Change Log
 
+## Release: v1.3.0
+ * [pr#8](https://github.com/chef-partners/knife-vrealize/pull/8) Allow configuration of pagination result set size to work around known vRA pagination bug.
+
 ## Release: v1.2.0
  * [pr#6](https://github.com/chef-partners/knife-vrealize/pull/6) Fixing issue with --server-create-timeout not being honored
 

data/README.md

@@ -127,6 +127,15 @@ Current request status: IN_PROGRESS...
 ...
 ```
 
+### Known Issue: Pagination
+
+A bug in vRA v6 (as late as v6.2.1) causes resource/server lists to potentially return duplicate items and omit items in the returned data. This appears to be a bug in the pagination code in vRA and was initially discovered and discussed [in this GitHub issue](https://github.com/chef-partners/vmware-vra-gem/issues/10). `knife-vrealize` tries to work around this by setting a higher-than-normal page size of 200 items.  However, if you have more items in your returned data than this, you can attempt to work around this further by using:
+
+```
+--page-size NUMBER_OF_ITEMS_PER_PAGE
+```
+
+
 ## vRealize Orchestrator (vRO)
 
 ### Configuration

data/knife-vrealize.gemspec

@@ -11,7 +11,7 @@ Gem::Specification.new do |spec|
   spec.email         = ['partnereng@chef.io']
   spec.summary       = 'Knife plugin to interact with VMware vRealize.'
   spec.description   = spec.summary
-  spec.homepage      = 'https://gihub.com/chef-partners/knife-vrealize'
+  spec.homepage      = 'https://github.com/chef-partners/knife-vrealize'
   spec.license       = 'Apache 2.0'
 
   spec.files         = `git ls-files -z`.split("\x0")

data/lib/chef/knife/cloud/vra_service.rb

@@ -35,6 +35,7 @@ class Chef
           @base_url   = options[:base_url]
           @tenant     = options[:tenant]
           @verify_ssl = options[:verify_ssl]
+          @page_size  = options[:page_size]
         end
 
         def connection
@@ -43,6 +44,7 @@ class Chef
             username:   @username,
             password:   @password,
             tenant:     @tenant,
+            page_size:  @page_size,
             verify_ssl: @verify_ssl
           )
         end

data/lib/chef/knife/cloud/vra_service_helpers.rb

@@ -25,10 +25,11 @@ class Chef
         include Chef::Knife::Cloud::Helpers
 
         def create_service_instance
-          Chef::Knife::Cloud::VraService.new(username: locate_config_value(:vra_username),
-                                             password: locate_config_value(:vra_password),
-                                             base_url: locate_config_value(:vra_base_url),
-                                             tenant:   locate_config_value(:vra_tenant),
+          Chef::Knife::Cloud::VraService.new(username:  locate_config_value(:vra_username),
+                                             password:  locate_config_value(:vra_password),
+                                             base_url:  locate_config_value(:vra_base_url),
+                                             tenant:    locate_config_value(:vra_tenant),
+                                             page_size: locate_config_value(:vra_page_size),
                                              verify_ssl: verify_ssl?)
         end
 

data/lib/chef/knife/cloud/vra_service_options.rb

@@ -41,6 +41,12 @@ class Chef
               boolean:     true,
               default:     false
 
+            option :vra_page_size,
+              long:        '--page-size NUM_OF_ITEMS',
+              description: 'Maximum number of items to fetch from the vRA API when pagination is forced',
+              default:     200,
+              proc:        proc { |page_size| page_size.to_i }
+
             option :request_refresh_rate,
               long:        '--request-refresh-rate SECS',
               description: 'Number of seconds to sleep between each check of the request status, defaults to 2',

data/lib/knife-vrealize/version.rb

@@ -17,5 +17,5 @@
 #
 
 module KnifeVrealize
-  VERSION = '1.2.0'
+  VERSION = '1.3.0'
 end

data/spec/unit/cloud/vra_service_helpers_spec.rb

@@ -39,6 +39,7 @@ describe 'Chef::Knife::Cloud::VraServiceHelpers' do
       allow(subject).to receive(:locate_config_value).with(:vra_password).and_return('mypassword')
       allow(subject).to receive(:locate_config_value).with(:vra_base_url).and_return('https://vra.corp.local')
       allow(subject).to receive(:locate_config_value).with(:vra_tenant).and_return('mytenant')
+      allow(subject).to receive(:locate_config_value).with(:vra_page_size).and_return(50)
       allow(subject).to receive(:locate_config_value).with(:vra_disable_ssl_verify).and_return(false)
 
       expect(Chef::Knife::Cloud::VraService).to receive(:new)
@@ -46,6 +47,7 @@ describe 'Chef::Knife::Cloud::VraServiceHelpers' do
               password:   'mypassword',
               base_url:   'https://vra.corp.local',
               tenant:     'mytenant',
+              page_size:  50,
               verify_ssl: true)
 
       subject.create_service_instance

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knife-vrealize
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Chef Partner Engineering
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-17 00:00:00.000000000 Z
+date: 2015-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: chef
@@ -127,7 +127,7 @@ files:
 - spec/unit/vra_server_list_spec.rb
 - spec/unit/vra_server_show_spec.rb
 - spec/unit/vro_workflow_execute_spec.rb
-homepage: https://gihub.com/chef-partners/knife-vrealize
+homepage: https://github.com/chef-partners/knife-vrealize
 licenses:
 - Apache 2.0
 metadata: {}
@@ -147,7 +147,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.4
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Knife plugin to interact with VMware vRealize.