knife-openstack 1.2.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0c00775263f09abba7c70e8976430af5ff4b99ae
-  data.tar.gz: 2d61ed82c4db747e26c7258f422f9a907fe8261e
+  metadata.gz: 87e92a88883a178ca6fa4739e5113be9023bd5bd
+  data.tar.gz: 273697b3000cc203628fc2f42ca26f29da490467
 SHA512:
-  metadata.gz: 6c6ac27c1078fb3651987aadf4b19350adf5d9a084357ade2fc3d687c6dd89576621bb8b1a72d7d4610255f07f0c98f2342720d90ee47cb3addc7e767b064f91
-  data.tar.gz: 190ca4e8a68ffaac997928ff1d568d10221d1a0138561da8b7b9b87d6969ce1b41cac277a1cf769a59c40cb2c5ccda57e4b00eb23445ffae397f6d8e9ff07f4e
+  metadata.gz: 7bde3dfa21f8da3df278cd2f4ae1b20432d07d2f7622554064e2a73442a1944b7ae82691c07a52baec0ee7b6c2e990edc0408a4a41131375f298ef4b25be699b
+  data.tar.gz: 3e686c596764b992a02488b049ee9c56c329eda8c74168650e60711573b7bb0523eb7c14530bc4e0b2c2e6f49465726070bb42edd99561076fb26ce2be2a016f

data/.travis.yml

@@ -1,6 +1,15 @@
 rvm:
-  - 2.0.0
-  - 2.1.5
-  - 2.2.0
-
+- 2.0.0
+- 2.1.5
+- 2.2.0
 script: bundle exec rake spec
+deploy:
+  provider: rubygems
+  api_key:
+    secure: fHosXRjyuBtNwtLKiMdTQkvFdV7uHNZaK8VoeBAT6kIk9xVgTQRXnPq5AflJMwnALrLyYDZq2okWxquu3xljYu9u3bOnQDVTrrHtvWTmoMb9jcPPtIDAJ0eT1ctlmXNGBcq5/jk4YP/83qfByKvxj0w6gGx5KhQ0DqiYWxzxAus=
+  on:
+    tags: true
+notifications:
+    irc:
+      - "chat.freenode.net#openstack-chef"
+      - "chat.freenode.net#chef-hacking"

data/README.md

@@ -1,27 +1,26 @@
 [![Build Status](https://travis-ci.org/chef/knife-openstack.png)](https://travis-ci.org/chef/knife-openstack)
 
-Knife OpenStack
-===============
+# Knife OpenStack
 
 This is the official Chef Knife plugin for OpenStack Compute (Nova). This plugin gives knife the ability to create, bootstrap and manage instances in OpenStack Compute clouds. It has been tested against the `Diablo` through `Kilo` releases in configurations using Keystone against the OpenStack API (as opposed to the EC2 API).
 
 Please refer to the [CHANGELOG](CHANGELOG.md) for version history and known issues.
 
-# Installation #
+## Installation
 
 Be sure you are running the latest version Chef. Versions earlier than 0.10.0 don't support plugins:
 
     $ curl -L https://chef.io/chef/install.sh | sudo bash
-  
+
 This plugin is distributed as a Ruby Gem. To install it, run:
 
     $ chef gem install knife-openstack
     OR
     $ gem install knife-openstack
-    
+
 Depending on your system's configuration, you may need to run this command with root privileges.
 
-# Configuration #
+## Configuration
 
 In order to communicate with an OpenStack API you will need to tell Knife your OpenStack Auth API endpoint, your Dashboard username and password (tenant is optional). The easiest way to accomplish this is to create these entries in your `knife.rb` file:
 
@@ -60,11 +59,11 @@ Additionally the following options may be set in your `knife.rb`:
 * openstack_ssh_key_id
 * template_file
 
-# Working with Floating IPs #
+## Working with Floating IPs
 
 To use a floating IP address while bootstrapping nodes, use the `-a` or `--openstack-floating-ip` option.
 
-# Working with Windows Images #
+## Working with Windows Images
 
 Provisioning and bootstrapping for Windows 2003 and later images is now supported. The Windows images need to have WinRM enabled with Basic Authentication configured. Current support does not support Kerberos Authentication.
 
@@ -77,51 +76,47 @@ NOTE:
 * Administrator Username (`--winrm-user` or `-x`) and Password (`-P`) are required parameters.
 * If the Template File (`--template`) is not specified it defaults to a Linux distro (most likely Ubuntu).
 
-# Subcommands #
+## Subcommands
 
 This plugin provides the following Knife subcommands. Specific command options can be found by invoking the subcommand with a `--help` option.
 
-knife openstack server create
------------------------------
+### knife openstack server create
 
 Provisions a new server in an OpenStack Compute cloud and then perform a Chef bootstrap (using the SSH protocol). The goal of the bootstrap is to get Chef installed on the target system so it can run Chef Client with a Chef Server. The main assumption is a baseline OS installation exists (provided by the provisioning). It is primarily intended for Chef Client systems that talk to a Chef server. By default the server is bootstrapped using the [chef-full](https://github.com/opscode/chef/blob/master/chef/lib/chef/knife/bootstrap/chef-full.erb) template (default since the 10.10 release). This may be overridden using the `-d` or `--template-file` command options. If you do not have public IP addresses, use the `--openstack-private-network` option to use the private IP address for bootstrapping.  In addition, you can use the `--bootstrap-network NAME` option to specify an alternate network for either a private or public network. If a network name isn't specified, the default name will be `'public'` for a public network and `'private'` for a private network e.g. when the `--openstack-private-network` option is specified.  Please see `knife openstack server create --help` for all of the supported options.
 
-knife openstack server delete
------------------------------
+### knife openstack server delete
 
 Deletes an existing server in the currently configured OpenStack account. If a floating IP address has been assigned to the node, it is disassociated automatically by the OpenStack server. <b>PLEASE NOTE</b> - this does not delete the associated node and client objects from the Chef server without using the `-P` option to purge the client.
 
-knife openstack server list
----------------------------
+### knife openstack server list
 
 Outputs a list of all servers in the currently configured OpenStack account. <b>PLEASE NOTE</b> - this shows all instances associated with the account, some of which may not be currently managed by the Chef server.
 
-knife openstack flavor list
----------------------------
+### knife openstack flavor list
 
 Provides a list of all available flavors (available "hardware" configurations for a server) available to the currently configured OpenStack account. Each flavor has a unique combination of virtual cpus, disk space and memory capacity. This data may be useful when choosing a flavor to pass to the `knife openstack server create` subcommand.
 
-knife openstack volume list
----------------------------
+### knife openstack volume list
 
 Provides a list of all volumes in the currently configured OpenStack account. Each volume shows its size and its availibility to be attached to server. This data may be useful when choosing a volume to pass to the `knife openstack server create` subcommand.
 
-knife openstack image list
---------------------------
+### knife openstack image list
 
 Lists all available images and snapshots available to the currently configured OpenStack account. An image is a collection of files used to create or rebuild a server. The retuned list filters out image names ending in 'initrd', 'kernel', 'loader', 'virtual' or 'vmlinuz' (this may be disabled with `--disable-filter`). This data may be useful when choosing an image to pass to the `knife openstack server create` subcommand.
 
-knife openstack group list
---------------------
+### knife openstack group list
 
 Provides a list of the security groups available to the currently configured OpenStack account. Each group may have multiple rules. This data may be useful when choosing your security group(s) to pass to the `knife openstack server create` subcommand.
 
-knife openstack network list
---------------------
+### knife openstack network list
 
 Lists the networks available to the currently configured OpenStack account. This data may be useful when choosing your networks to pass to the `knife openstack server create` subcommand. This command is only available with OpenStack deployments using the Neutron network service (not nova-network). Please see `knife openstack server create --help` for all of the supported options.
 
-# License #
+### knife openstack floating_ip list
+
+Lists all of the available `floating-ips` you have associated with your account. You can ask for more via: `knife openstack floating_ip allocate --pool POOL` if you have run out. You can also `knife openstack floating_ip associate FLOATING_IP --instance-id INSTANCE_ID` and too. If you need to remove the `floating-ip` you can `disassociate` with the same command. If you would like to give back the `floating-ip` you can `knife openstack floating_ip release FLOATING_IP_ID`
+
+# License
 
 Author:: Seth Chisamore (<schisamo@chef.io>)
 

data/knife-openstack.gemspec

@@ -5,6 +5,7 @@ require "knife-openstack/version"
 Gem::Specification.new do |s|
   s.name        = "knife-openstack"
   s.version     = Knife::OpenStack::VERSION
+  s.version = "#{s.version}-alpha-#{ENV['TRAVIS_BUILD_NUMBER']}" if ENV['TRAVIS']
   s.platform    = Gem::Platform::RUBY
   s.has_rdoc = true
   s.extra_rdoc_files = ["README.md", "LICENSE" ]
@@ -21,7 +22,7 @@ Gem::Specification.new do |s|
 
   s.add_dependency "fog", "~> 1.23"
   s.add_dependency "chef", ">= 11"
-  s.add_dependency "knife-cloud", "~> 1.1.0"
+  s.add_dependency "knife-cloud", "~> 1.2.0"
 
   %w(rake rspec-core rspec-expectations rspec-mocks rspec_junit_formatter).each { |gem| s.add_development_dependency gem }
 end

data/lib/chef/knife/openstack_floating_ip_allocate.rb

@@ -0,0 +1,38 @@
+# Author:: Vasundhara Jagdale (<vasundhara.jagdale@clogeny.com>)
+# Copyright:: Copyright (c) 2015 Chef Software, Inc.
+
+require 'chef/knife/openstack_helpers'
+require 'chef/knife/cloud/openstack_service_options'
+
+class Chef
+  class Knife
+    class Cloud
+      class OpenstackFloatingIpAllocate < Command
+        include OpenstackHelpers
+        include OpenstackServiceOptions
+
+        banner 'knife openstack floating_ip allocate (options)'
+
+        option :pool,
+          :short => '-p POOL',
+          :long => '--pool POOL',
+          :description => 'Floating IP pool to allocate from.',
+          :proc => Proc.new { |key| Chef::Config[:knife][:pool] = key }
+
+        def execute_command
+          @resource = @service.allocate_address(locate_config_value(:pool))
+        end
+
+        def after_exec_command
+          @columns_with_info = [{ label: 'ID', value: @resource['floating_ip']['id'].to_s },
+                                { label: 'Instance ID', value: @resource['floating_ip']['instance_id'].to_s },
+                                { label: 'Floating IP', value: @resource['floating_ip']['ip'].to_s },
+                                { label: 'Fixed IP', value: @resource['floating_ip']['fixed_ip'].to_s },
+                                { label: 'Pool', value: @resource['floating_ip']['pool'].to_s }
+                               ]
+          @service.server_summary(nil, @columns_with_info)
+        end
+      end
+    end
+  end
+end

data/lib/chef/knife/openstack_floating_ip_associate.rb

@@ -0,0 +1,40 @@
+# Author:: Vasundhara Jagdale (<vasundhara.jagdale@clogeny.com>)
+# Copyright:: Copyright (c) 2015 Chef Software, Inc.
+
+require 'chef/knife/openstack_helpers'
+require 'chef/knife/cloud/openstack_service_options'
+require 'chef/knife/cloud/openstack_service'
+
+class Chef
+  class Knife
+    class Cloud
+      class OpenstackFloatingIpAssociate < Command
+        include OpenstackHelpers
+        include OpenstackServiceOptions
+
+        banner 'knife openstack floating_ip associate IP (options)'
+
+        option :instance_id,
+          :long => '--instance-id ID',
+          :description => 'Instance id to associate it with.',
+          :proc => Proc.new { |key| Chef::Config[:knife][:instance_id] = key },
+          :required => true
+
+        def execute_command
+          if @name_args[0]
+            floating_ip = @name_args[0]
+          else
+            ui.error "Please provide Floating IP to associate with."
+            exit 1
+          end
+
+          instance_id = locate_config_value(:instance_id)
+          response = @service.associate_address(instance_id, floating_ip)
+          if response && response.status == 202
+            ui.info "Floating IP #{floating_ip} associated with Instance #{instance_id}"
+          end
+        end
+      end
+    end
+  end
+end

data/lib/chef/knife/openstack_floating_ip_disassociate.rb

@@ -0,0 +1,39 @@
+# Author:: Vasundhara Jagdale (<vasundhara.jagdale@clogeny.com>)
+# Copyright:: Copyright (c) 2015 Chef Software, Inc.
+
+require 'chef/knife/openstack_helpers'
+require 'chef/knife/cloud/openstack_service_options'
+require 'chef/knife/cloud/openstack_service'
+
+class Chef
+  class Knife
+    class Cloud
+      class OpenstackFloatingIpDisassociate < Command
+        include OpenstackHelpers
+        include OpenstackServiceOptions
+
+        banner 'knife openstack floating_ip disassociate IP (options)'
+
+        option :instance_id,
+          :long => '--instance-id ID',
+          :description => 'Instance id to disassociate with.',
+          :proc => Proc.new { |key| Chef::Config[:knife][:instance_id] = key },
+          :required => true
+
+        def execute_command
+          if @name_args[0]
+            floating_ip = @name_args[0]
+          else
+            ui.error 'Please provide Floating IP to disassociate.'
+            exit 1
+          end
+          instance_id = locate_config_value(:instance_id)
+          response =  @service.disassociate_address(instance_id, floating_ip)
+          if response && response.status == 202
+            ui.info "Floating IP #{floating_ip} disassociated with Instance #{instance_id}"
+          end
+        end
+      end
+    end
+  end
+end

data/lib/chef/knife/openstack_floating_ip_list.rb

@@ -0,0 +1,34 @@
+# Author:: Vasundhara Jagdale (<vasundhara.jagdale@clogeny.com>)
+# Copyright:: Copyright (c) 2015 Chef Software, Inc.
+
+require 'chef/knife/cloud/list_resource_command'
+require 'chef/knife/openstack_helpers'
+require 'chef/knife/cloud/openstack_service_options'
+
+class Chef
+  class Knife
+    class Cloud
+      class OpenstackFloatingIpList < ResourceListCommand
+        include OpenstackHelpers
+        include OpenstackServiceOptions
+
+        banner 'knife openstack floating_ip list (options)'
+
+        def before_exec_command
+          # set columns_with_info map
+          @columns_with_info = [
+            { label: 'ID', key: 'id' },
+            { label: 'Instance ID', key: 'instance_id' },
+            { label: 'IP Address', key: 'ip' },
+            { label: 'Fixed IP', key: 'fixed_ip' },
+            { label: 'Floating IP Pool', key: 'pool' }
+          ]
+        end
+
+        def query_resource
+          @service.list_addresses
+        end
+      end
+    end
+  end
+end

data/lib/chef/knife/openstack_floating_ip_release.rb

@@ -0,0 +1,32 @@
+#
+# Author:: Vasundhara Jagdale (<vasundhara.jagdale@clogeny.com>)
+# Copyright:: Copyright (c) 2015 Chef Software, Inc.
+#
+\
+require 'chef/knife/openstack_helpers'
+require 'chef/knife/cloud/openstack_service_options'
+
+class Chef
+  class Knife
+    class Cloud
+      class OpenstackFloatingIpRelease < Command
+        include OpenstackServiceOptions
+        include OpenstackHelpers
+
+        banner 'knife openstack floating_ip release ID [ID] (options)'
+
+        def execute_command
+          if @name_args[0]
+            response = service.release_address(@name_args[0])
+            if response && response.status == 202
+              ui.info 'Floating IP released successfully.'
+            end
+          else
+            ui.error 'Please provide Floating IP to release.'
+            exit 1
+          end
+        end
+      end
+    end
+  end
+end

data/lib/chef/knife/openstack_group_list.rb

@@ -22,27 +22,32 @@ class Chef
         end
 
         def list(security_groups)
-          group_list = [
-            ui.color('Name', :bold),
-            ui.color('Protocol', :bold),
-            ui.color('From', :bold),
-            ui.color('To', :bold),
-            ui.color('CIDR', :bold),
-            ui.color('Description', :bold),
-          ]
-          security_groups.sort_by(&:name).each do |group|
-            group.security_group_rules.each do |rule|
-              unless rule.ip_protocol.nil?
-                group_list << group.name
-                group_list << rule.ip_protocol
-                group_list << rule.from_port.to_s
-                group_list << rule.to_port.to_s
-                group_list << rule.ip_range['cidr']
-                group_list << group.description
+          if(config[:format] == "summary")
+            group_list = [
+              ui.color('Name', :bold),
+              ui.color('Protocol', :bold),
+              ui.color('From', :bold),
+              ui.color('To', :bold),
+              ui.color('CIDR', :bold),
+              ui.color('Description', :bold),
+            ]
+            security_groups.sort_by(&:name).each do |group|
+              group.security_group_rules.each do |rule|
+                unless rule.ip_protocol.nil?
+                  group_list << group.name
+                  group_list << rule.ip_protocol
+                  group_list << rule.from_port.to_s
+                  group_list << rule.to_port.to_s
+                  group_list << rule.ip_range['cidr']
+                  group_list << group.description
+                end
               end
             end
+
+            puts ui.list(group_list, :uneven_columns_across, 6)
+          else
+            output(format_for_display(security_groups))
           end
-          puts ui.list(group_list, :uneven_columns_across, 6)
         end
       end
     end

data/lib/chef/knife/openstack_server_create.rb

@@ -165,6 +165,9 @@ class Chef
             raise CloudExceptions::BootstrapError, error_message
           end
           config[:bootstrap_ip_address] = bootstrap_ip_address
+
+          config[:hints] ||= {}
+          config[:hints]["openstack"] ||= {}
         end
 
         def validate_params!

data/lib/knife-openstack/version.rb

@@ -1,6 +1,6 @@
 module Knife
   module OpenStack
-    VERSION = "1.2.0"
+    VERSION = "1.3.1"
     MAJOR, MINOR, TINY = VERSION.split('.')
   end
 end

data/spec/functional/flavor_list_func_spec.rb

@@ -33,6 +33,7 @@ describe Chef::Knife::Cloud::OpenstackFlavorList do
       allow(instance).to receive(:puts)
       allow(instance).to receive(:create_service_instance).and_return(Chef::Knife::Cloud::Service.new)
       allow(instance).to receive(:validate!)
+      instance.config[:format] = "summary"
     end
 
     it "lists formatted list of resources" do

data/spec/functional/floating_ip_list_func_spec.rb

@@ -0,0 +1,47 @@
+#
+# Author:: Vasundhara Jagdale (<vasundhara.jagdale@clogeny.com>)
+# Copyright:: Copyright (c) 2013-2014 Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+require 'spec_helper'
+require 'chef/knife/openstack_floating_ip_list'
+require 'chef/knife/cloud/openstack_service'
+require 'support/shared_examples_for_command'
+
+describe Chef::Knife::Cloud::OpenstackFloatingIpList do
+  let (:instance) {Chef::Knife::Cloud::OpenstackFloatingIpList.new}
+
+  context 'functionality' do
+    before do
+      resources = [ TestResource.new({ "id" => "floatingip1", "instance_id" => "daed9e86-4b69-4242-993a-926a39352783", "ip" => "173.236.251.98", "fixed_ip" => "", "pool" => "test-pool"}
+),
+                    TestResource.new({ "id" => "floatingip2", "instance_id" => "", "ip" => "67.205.60.122", "fixed_ip" => "10.10.10.1", "pool" => "test-pool" }
+)
+                   ]
+      allow(instance).to receive(:query_resource).and_return(resources)
+      allow(instance).to receive(:puts)
+      allow(instance).to receive(:create_service_instance).and_return(Chef::Knife::Cloud::Service.new)
+      allow(instance).to receive(:validate!)
+      instance.config[:format] = "summary"
+    end
+
+    it "lists formatted list of resources" do
+      expect(instance.ui).to receive(:list).with(['ID', 'Instance ID', 'IP Address', 'Fixed IP', 'Floating IP Pool',
+                                             'floatingip1', 'daed9e86-4b69-4242-993a-926a39352783', '173.236.251.98', '', 'test-pool',
+                                             'floatingip2','', '67.205.60.122', '10.10.10.1', 'test-pool'], :uneven_columns_across, 5)
+      instance.run
+    end
+  end
+end

data/spec/functional/group_list_func_spec.rb

@@ -55,6 +55,7 @@ describe Chef::Knife::Cloud::OpenstackGroupList do
       allow(instance).to receive(:puts)
       allow(instance).to receive(:create_service_instance).and_return(Chef::Knife::Cloud::Service.new)
       allow(instance).to receive(:validate!)
+      instance.config[:format] = "summary"
     end
 
     it "lists formatted list of resources" do

data/spec/functional/image_list_func_spec.rb

@@ -32,6 +32,7 @@ describe Chef::Knife::Cloud::OpenstackImageList do
       allow(instance).to receive(:puts)
       allow(instance).to receive(:create_service_instance).and_return(Chef::Knife::Cloud::Service.new)
       allow(instance).to receive(:validate!)
+      instance.config[:format] = "summary"
     end
 
     it "displays formatted list of images, filtered by default" do

data/spec/functional/network_list_func_spec.rb

@@ -32,6 +32,7 @@ describe Chef::Knife::Cloud::OpenstackNetworkList do
       allow(instance).to receive(:puts)
       allow(instance).to receive(:create_service_instance).and_return(Chef::Knife::Cloud::Service.new)
       allow(instance).to receive(:validate!)
+      instance.config[:format] = "summary"
     end
 
     it "lists formatted list of network resources" do

data/spec/functional/server_list_func_spec.rb

@@ -35,6 +35,7 @@ describe Chef::Knife::Cloud::OpenstackServerList do
       allow(instance).to receive(:puts)
       allow(instance).to receive(:create_service_instance).and_return(Chef::Knife::Cloud::FogService.new)
       allow(instance).to receive(:validate!)
+      instance.config[:format] = "summary"
     end
 
     it "lists formatted list of resources" do

data/spec/unit/openstack_floating_ip_allocate_spec.rb

@@ -0,0 +1,56 @@
+#
+# Author:: Vasundhara Jagdale (<vasundhara.jagdale@clogeny.com>)
+# Copyright:: Copyright (c) 2013-2015 Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+require 'spec_helper'
+require 'chef/knife/openstack_floating_ip_allocate'
+require 'chef/knife/cloud/openstack_service'
+require 'support/shared_examples_for_command'
+
+describe Chef::Knife::Cloud::OpenstackFloatingIpAllocate do
+
+  it_behaves_like Chef::Knife::Cloud::Command, Chef::Knife::Cloud::OpenstackFloatingIpAllocate.new
+  include_context '#validate!', Chef::Knife::Cloud::OpenstackFloatingIpAllocate.new
+
+  before(:each) do
+    @instance = Chef::Knife::Cloud::OpenstackFloatingIpAllocate.new
+    allow(@instance.ui).to receive(:error)
+  end
+
+  describe 'create service instance' do
+    it 'return OpenstackService instance' do
+      expect(@instance.create_service_instance).to be_an_instance_of(Chef::Knife::Cloud::OpenstackService)
+    end
+  end
+
+  describe 'allocate floating ip' do
+    it 'calls allocate address' do
+      @instance.service = double
+      expect(@instance.service).to receive(:allocate_address).and_return(true)
+      @instance.execute_command
+    end
+  end
+
+  describe 'when user provides pool option ' do
+    it 'allocates floating ip in user specified pool' do
+      @instance = Chef::Knife::Cloud::OpenstackFloatingIpAllocate.new(["--pool", "test-pool"])
+      @instance.service = Chef::Knife::Cloud::Service.new
+      response = {:floating_ip => {'id' => 'test-id', 'instance_id' => 'test-instance-id', 'floating_ip' => '127.0.0.1', 'fixed_ip' => 'nil', 'pool' => 'test-pool' }}
+      expect(@instance.service).to receive(:allocate_address).and_return(response)
+      @instance.execute_command
+    end
+  end
+end

data/spec/unit/openstack_floating_ip_associate_spec.rb

@@ -0,0 +1,39 @@
+#
+# Author:: Vasundhara Jagdale (<vasundhara.jagdale@clogeny.com>)
+# Copyright:: Copyright (c) 2013-2015 Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+require 'spec_helper'
+require 'chef/knife/openstack_floating_ip_associate'
+require 'chef/knife/cloud/openstack_service'
+require 'support/shared_examples_for_command'
+require 'ostruct'
+
+describe Chef::Knife::Cloud::OpenstackFloatingIpAssociate do
+  before(:each) do
+    @instance = Chef::Knife::Cloud::OpenstackFloatingIpAssociate.new(["--instance-id", "23849038438240934n3294839248"])
+    @instance.name_args = [ '127.0.0.1' ]
+  end
+
+  describe 'associate floating ip' do
+    it 'calls associate address' do
+      success_message = 'Floating IP 127.0.0.1 associated with Instance 23849038438240934n3294839248'
+      @instance.service = Chef::Knife::Cloud::Service.new
+      response = OpenStruct.new(status: 202)
+      expect(@instance.service).to receive(:associate_address).and_return(response)
+      expect(@instance.ui).to receive(:info).and_return(success_message)
+      @instance.execute_command
+    end
+  end
+end

data/spec/unit/openstack_floating_ip_disassociate_spec.rb

@@ -0,0 +1,38 @@
+#
+# Author:: Vasundhara Jagdale (<vasundhara.jagdale@clogeny.com>)
+# Copyright:: Copyright (c) 2013-2015 Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+require 'spec_helper'
+require 'chef/knife/openstack_floating_ip_disassociate'
+require 'chef/knife/cloud/openstack_service'
+require 'support/shared_examples_for_command'
+require 'ostruct'
+
+describe Chef::Knife::Cloud::OpenstackFloatingIpDisassociate do
+  before(:each) do
+    @instance = Chef::Knife::Cloud::OpenstackFloatingIpDisassociate.new(["--instance-id", "23849038438240934n3294839248"])
+    @instance.name_args = [ '127.0.0.1' ]
+  end
+
+  describe 'associate floating ip' do
+    it 'calls associate address' do
+      @instance.service = Chef::Knife::Cloud::Service.new
+      response = OpenStruct.new(:status => 202)
+      expect(@instance.service).to receive(:disassociate_address).with('23849038438240934n3294839248', '127.0.0.1').and_return(response)
+      expect(@instance.ui).to receive(:info).and_return('Floating IP 127.0.0.1 disassociated with Instance 23849038438240934n3294839248')
+      @instance.execute_command
+    end
+  end
+end

data/spec/unit/openstack_floating_ip_list_spec.rb

@@ -0,0 +1,26 @@
+#
+# Author:: Vasundhara Jagdale (<vasundhara.jagdale@clogeny.com>)
+# Copyright:: Copyright (c) 2013-2015 Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+require 'spec_helper'
+require 'chef/knife/openstack_floating_ip_list'
+require 'chef/knife/cloud/openstack_service'
+require 'support/shared_examples_for_command'
+
+describe Chef::Knife::Cloud::OpenstackFloatingIpList do
+  it_behaves_like Chef::Knife::Cloud::Command, Chef::Knife::Cloud::OpenstackFloatingIpList.new
+  include_context '#validate!', Chef::Knife::Cloud::OpenstackFloatingIpList.new
+end

data/spec/unit/openstack_floating_ip_release_spec.rb

@@ -0,0 +1,48 @@
+#
+# Author:: Vasundhara Jagdale (<vasundhara.jagdale@clogeny.com>)
+# Copyright:: Copyright (c) 2013-2015 Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+require 'spec_helper'
+require 'chef/knife/openstack_floating_ip_release'
+require 'chef/knife/cloud/openstack_service'
+require 'support/shared_examples_for_command'
+
+describe Chef::Knife::Cloud::OpenstackFloatingIpRelease do
+  it_behaves_like Chef::Knife::Cloud::Command, Chef::Knife::Cloud::OpenstackFloatingIpRelease.new
+  include_context '#validate!', Chef::Knife::Cloud::OpenstackFloatingIpRelease.new
+
+  before(:each) do
+    @instance = Chef::Knife::Cloud::OpenstackFloatingIpRelease.new
+    allow(@instance.ui).to receive(:error)
+    @instance.name_args = [ '23849038438240934n3294839248' ]
+  end
+
+  describe 'create service instance' do
+    it 'return OpenstackService instance' do
+      expect(@instance.create_service_instance).to be_an_instance_of(Chef::Knife::Cloud::OpenstackService)
+    end
+  end
+
+  describe 'release floating ip' do
+    it 'calls release address' do
+      address_id = '23849038438240934n3294839248'
+      @instance.service = double
+      response = OpenStruct.new(status: 202)
+      expect(@instance.service).to receive(:release_address).and_return(response)
+      expect(@instance.ui).to receive(:info).and_return('Floating IP released successfully.')
+      @instance.execute_command
+    end
+  end
+end

data/spec/unit/openstack_group_list_spec.rb

@@ -32,6 +32,7 @@ describe Chef::Knife::Cloud::OpenstackGroupList do
   context "#list" do
     before(:each) do
       @security_groups = [TestResource.new({ "name" => "Unrestricted","description" => "testdescription", "security_group_rules" => [TestResource.new({"from_port"=>636, "group"=>{}, "ip_protocol"=>"tcp", "to_port"=>636, "parent_group_id"=>14, "ip_range"=>{"cidr"=>"0.0.0.0/0"}, "id"=>183})]})]
+      instance.config[:format] = "summary"
     end
 
     it "returns group list" do

data/spec/unit/openstack_server_create_spec.rb

@@ -315,6 +315,12 @@ describe Chef::Knife::Cloud::OpenstackServerCreate do
       @instance.before_bootstrap
       expect(@instance.config[:bootstrap_network]).to be == 'secure'
     end
+
+    it "set openstack ohai hint" do
+      allow(@instance.server).to receive(:addresses).and_return({"public"=>[{"version"=>4, "addr"=>"127.0.0.1"}]})
+      @instance.before_bootstrap
+      expect(@instance.config[:hints]).to be == {'openstack' => {}}
+    end
   end
 
   describe "#post_connection_validations" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knife-openstack
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.1
 platform: ruby
 authors:
 - JJ Asghar
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-18 00:00:00.000000000 Z
+date: 2015-07-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fog
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.1.0
+        version: 1.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.1.0
+        version: 1.2.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -143,6 +143,11 @@ files:
 - lib/chef/knife/cloud/openstack_service.rb
 - lib/chef/knife/cloud/openstack_service_options.rb
 - lib/chef/knife/openstack_flavor_list.rb
+- lib/chef/knife/openstack_floating_ip_allocate.rb
+- lib/chef/knife/openstack_floating_ip_associate.rb
+- lib/chef/knife/openstack_floating_ip_disassociate.rb
+- lib/chef/knife/openstack_floating_ip_list.rb
+- lib/chef/knife/openstack_floating_ip_release.rb
 - lib/chef/knife/openstack_group_list.rb
 - lib/chef/knife/openstack_helpers.rb
 - lib/chef/knife/openstack_image_list.rb
@@ -154,6 +159,7 @@ files:
 - lib/chef/knife/openstack_volume_list.rb
 - lib/knife-openstack/version.rb
 - spec/functional/flavor_list_func_spec.rb
+- spec/functional/floating_ip_list_func_spec.rb
 - spec/functional/group_list_func_spec.rb
 - spec/functional/image_list_func_spec.rb
 - spec/functional/network_list_func_spec.rb
@@ -169,6 +175,11 @@ files:
 - spec/spec_context.rb
 - spec/spec_helper.rb
 - spec/unit/openstack_flavor_list_spec.rb
+- spec/unit/openstack_floating_ip_allocate_spec.rb
+- spec/unit/openstack_floating_ip_associate_spec.rb
+- spec/unit/openstack_floating_ip_disassociate_spec.rb
+- spec/unit/openstack_floating_ip_list_spec.rb
+- spec/unit/openstack_floating_ip_release_spec.rb
 - spec/unit/openstack_group_list_spec.rb
 - spec/unit/openstack_image_list_spec.rb
 - spec/unit/openstack_network_list_spec.rb
@@ -203,6 +214,7 @@ specification_version: 4
 summary: A Chef knife plugin for OpenStack clouds.
 test_files:
 - spec/functional/flavor_list_func_spec.rb
+- spec/functional/floating_ip_list_func_spec.rb
 - spec/functional/group_list_func_spec.rb
 - spec/functional/image_list_func_spec.rb
 - spec/functional/network_list_func_spec.rb
@@ -218,6 +230,11 @@ test_files:
 - spec/spec_context.rb
 - spec/spec_helper.rb
 - spec/unit/openstack_flavor_list_spec.rb
+- spec/unit/openstack_floating_ip_allocate_spec.rb
+- spec/unit/openstack_floating_ip_associate_spec.rb
+- spec/unit/openstack_floating_ip_disassociate_spec.rb
+- spec/unit/openstack_floating_ip_list_spec.rb
+- spec/unit/openstack_floating_ip_release_spec.rb
 - spec/unit/openstack_group_list_spec.rb
 - spec/unit/openstack_image_list_spec.rb
 - spec/unit/openstack_network_list_spec.rb
@@ -227,3 +244,4 @@ test_files:
 - spec/unit/openstack_server_show_spec.rb
 - spec/unit/openstack_service_spec.rb
 - spec/unit/openstack_volume_list_spec.rb
+has_rdoc: true