knife-google 3.3.3 → 3.3.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 912225d3b18ae28eb1e4c1cdddff75077cf863917f4888fb85c8aeb261c71e47
-  data.tar.gz: 9827cb9f230891db43016ffe0fc1bd47b13158b0fda2f8db670643599335d40d
+  metadata.gz: 79bb948dc01979a7abe337108a6d908c6a5fd0aef3aad35f687a3570d0e0f2aa
+  data.tar.gz: 4e3d943d4ec4f4b9440d1cf2e59af79f72acb4010f49a7f6d590147cedd18b5f
 SHA512:
-  metadata.gz: a76733350635961937f0a3f44fba7877039eb3e66f51906ae5e587d6c101b262e443f13574429787f2cf5fe9de578c404b4be442691996462a419571ee5d5988
-  data.tar.gz: 21348ae47376ebbe56eb25917404079e3d7fad6160a46ef50c8986064beeb87102b9efac67fb10b61de43340bb2f1ed5e3f3e2429dde6a7954781e552b203c38
+  metadata.gz: 76e15187ff2749b8b9d91451368f95e7d38b6d4c671500c045402b1098ba2a24f1fc3e21bf06f56f9305bdf75f268dd7a516972fc9d88ab2447a3a1a3458dbca
+  data.tar.gz: ee18351ce616bc95a530d93dc3d84365f93736060c41565aec279b065645ad28b1aa2df5e7089396917de6a2e0843a26bcdd62180628d813b9311ea29580ac0f

data/CHANGELOG.md

@@ -4,24 +4,32 @@ Note: this log contains only changes from knife-google release 1.1.0 and later
 -- it does not contain the changes from prior releases. To view change history
 prior to release 1.1.0, please visit the [source repository](https://github.com/chef/knife-google/commits).
 
-<!-- latest_release 3.3.3 -->
-## [v3.3.3](https://github.com/chef/knife-google/tree/v3.3.3) (2018-10-17)
+<!-- latest_release 3.3.6 -->
+## [v3.3.6](https://github.com/chef/knife-google/tree/v3.3.6) (2018-11-20)
 
 #### Merged Pull Requests
-- Allow for newer google-api-client releases [#137](https://github.com/chef/knife-google/pull/137) ([tas50](https://github.com/tas50))
+- MSYS-917 Allows knife google zone list, region list, region quotas, project quotas to run without giving --gce_zone option [#142](https://github.com/chef/knife-google/pull/142) ([Vasu1105](https://github.com/Vasu1105))
 <!-- latest_release -->
 
-<!-- release_rollup since=3.3.0 -->
-### Changes since 3.3.0 release
+<!-- release_rollup since=3.3.3 -->
+### Changes not yet released to rubygems.org
 
 #### Merged Pull Requests
-- Allow for newer google-api-client releases [#137](https://github.com/chef/knife-google/pull/137) ([tas50](https://github.com/tas50)) <!-- 3.3.3 -->
-- Empty commit to test expeditor [#136](https://github.com/chef/knife-google/pull/136) ([btm](https://github.com/btm)) <!-- 3.3.2 -->
+- MSYS-917 Allows knife google zone list, region list, region quotas, project quotas to run without giving --gce_zone option [#142](https://github.com/chef/knife-google/pull/142) ([Vasu1105](https://github.com/Vasu1105)) <!-- 3.3.6 -->
+- Documenting the knife-google manual testing prerequisite [#141](https://github.com/chef/knife-google/pull/141) ([Vasu1105](https://github.com/Vasu1105)) <!-- 3.3.5 -->
+- Remove github_changelog_generator development dependency [#138](https://github.com/chef/knife-google/pull/138) ([tas50](https://github.com/tas50)) <!-- 3.3.4 -->
 <!-- release_rollup -->
 
 <!-- latest_stable_release -->
+## [v3.3.3](https://github.com/chef/knife-google/tree/v3.3.3) (2018-10-17)
+
+#### Merged Pull Requests
+- Empty commit to test expeditor [#136](https://github.com/chef/knife-google/pull/136) ([btm](https://github.com/btm))
+- Allow for newer google-api-client releases [#137](https://github.com/chef/knife-google/pull/137) ([tas50](https://github.com/tas50))
 <!-- latest_stable_release -->
 
+
+
 ## [3.3.0](https://github.com/chef/knife-google/tree/v3.3.0)
 
 [Full Changelog](https://github.com/chef/knife-google/compare/v3.2.0...v3.3.0)

data/TESTING.md

@@ -0,0 +1,48 @@
+## Manual Testing Prerequisite:
+
+To work with knife google commands following setup needs to be done.
+
+Configure google authentication and authorization as suggested [here](https://github.com/chef/knife-google#authentication-and-authorization).
+
+To work with knife google command you should create GCP project and assign zone and region to that project
+
+**Ref:** https://cloud.google.com/resource-manager/docs/creating-managing-projects
+https://cloud.google.com/compute/docs/regions-zones/changing-default-zone-region
+
+Some useful Google cloud commands which you can use with Google Cloud command line interface [#REF](https://cloud.google.com/compute/docs/gcloud-compute/#set_default_zone_and_region_in_your_local_client)
+
+``` gcloud projects create PROJECT_ID ```
+
+``` gcloud config configurations activate CONFIGURATION_NAME ```
+
+``` gcloud config set compute/zone ZONE ```
+
+``` gcloud config set compute/zone ZONE ```
+
+Once the above setup is done get the PROJECT_ID and Zone and set it in your knife configuration file(knife.rb/config.rb).
+```
+knife[:gce_project] = 'my-test-project'
+knife[:gce_zone]    = 'us-east1-b'
+```
+**NOTE** Not providing `gce_project` and `gce_zone` in knife configuartion file will run into following errors while running any knife google command.
+
+```
+ERROR: The following required parameters are missing: gce_project, gce_zone
+ERROR: RuntimeError: The following required parameters are missing: gce_project, gce_zone
+```
+
+## Valid knife google commands
+
+```
+knife google disk create NAME --gce-disk-size N (options)
+knife google disk delete NAME [NAME] (options)
+knife google disk list
+knife google project quotas
+knife google region list
+knife google region quotas
+knife google server create NAME -m MACHINE_TYPE -I IMAGE (options)
+knife google server delete INSTANCE_NAME [INSTANCE_NAME] (options)
+knife google server list
+knife google server show INSTANCE_NAME (options)
+knife google zone list
+```

data/VERSION

@@ -1 +1 @@
-3.3.3
+3.3.6

data/knife-google.gemspec

@@ -21,7 +21,5 @@ Gem::Specification.new do |s|
   s.add_dependency "google-api-client", ">= 0.19.8", "< 0.25" # each version introduces breaking changes which we need to validate
   s.add_dependency "gcewinpass",        "~> 1.1"
 
-  s.add_development_dependency "github_changelog_generator"
-
   s.files = `git ls-files -z`.split("\x0")
 end

data/lib/chef/knife/cloud/google_service.rb

@@ -51,7 +51,7 @@ class Chef::Knife::Cloud
       "useraccounts-ro"    => "cloud.useraccounts.readonly",
       "useraccounts-rw"    => "cloud.useraccounts",
       "userinfo-email"     => "userinfo.email",
-    }
+    }.freeze
 
     IMAGE_ALIAS_MAP = {
       "centos-6"           => { project: "centos-cloud",      prefix: "centos-6" },
@@ -76,7 +76,7 @@ class Chef::Knife::Cloud
       "ubuntu-1604-lts"    => { project: "ubuntu-os-cloud",   prefix: "ubuntu-1604-xenial" },
       "windows-2008-r2"    => { project: "windows-cloud",     prefix: "windows-server-2008-r2" },
       "windows-2012-r2"    => { project: "windows-cloud",     prefix: "windows-server-2012-r2" },
-    }
+    }.freeze
 
     def initialize(options = {})
       @project       = options[:project]

data/lib/chef/knife/cloud/google_service_helpers.rb

@@ -19,7 +19,7 @@
 
 class Chef::Knife::Cloud
   module GoogleServiceHelpers
-    REQUIRED_KEYS = [:gce_project, :gce_zone]
+    REQUIRED_KEYS = [:gce_project].freeze
 
     def create_service_instance
       Chef::Knife::Cloud::GoogleService.new(

data/lib/chef/knife/google_disk_create.rb

@@ -47,7 +47,7 @@ class Chef::Knife::Cloud
       default:     nil
 
     def validate_params!
-      check_for_missing_config_values!(:disk_size, :disk_type)
+      check_for_missing_config_values!(:gce_zone, :disk_size, :disk_type)
       raise "Please specify a disk name." unless @name_args.first
       raise "Disk size must be between 10 and 10,000" unless valid_disk_size?(locate_config_value(:disk_size))
       super

data/lib/chef/knife/google_disk_delete.rb

@@ -31,7 +31,7 @@ class Chef::Knife::Cloud
     banner "knife google disk delete NAME [NAME] (options)"
 
     def validate_params!
-      check_for_missing_config_values!
+      check_for_missing_config_values!(:gce_zone)
       raise "You must specify at least one disk to delete." if @name_args.empty?
       super
     end

data/lib/chef/knife/google_disk_list.rb

@@ -31,7 +31,7 @@ class Chef::Knife::Cloud
     banner "knife google disk list"
 
     def validate_params!
-      check_for_missing_config_values!
+      check_for_missing_config_values!(:gce_zone)
       super
     end
 

data/lib/chef/knife/google_server_create.rb

@@ -184,7 +184,7 @@ class Chef::Knife::Cloud
     end
 
     def validate_params!
-      check_for_missing_config_values!(:machine_type, :image, :boot_disk_size, :network)
+      check_for_missing_config_values!(:gce_zone, :machine_type, :image, :boot_disk_size, :network)
       raise "You must supply an instance name." if @name_args.first.nil?
       raise "Boot disk size must be between 10 and 10,000" unless valid_disk_size?(boot_disk_size)
       if locate_config_value(:bootstrap_protocol) == "winrm" && locate_config_value(:gce_email).nil?

data/lib/chef/knife/google_server_list.rb

@@ -32,7 +32,7 @@ class Chef::Knife::Cloud
     banner "knife google server list"
 
     def validate_params!
-      check_for_missing_config_values!
+      check_for_missing_config_values!(:gce_zone)
       super
     end
 

data/lib/chef/knife/google_server_show.rb

@@ -34,7 +34,7 @@ class Chef
         banner "knife google server show INSTANCE_NAME (options)"
 
         def validate_params!
-          check_for_missing_config_values!
+          check_for_missing_config_values!(:gce_zone)
           raise "You must supply an instance name to display" if @name_args.empty?
           raise "You may only supply one instance name" if @name_args.size > 1
           super

data/lib/knife-google/version.rb

@@ -15,7 +15,7 @@
 #
 module Knife
   module Google
-    VERSION = "3.3.3"
+    VERSION = "3.3.6"
     MAJOR, MINOR, TINY = VERSION.split(".")
   end
 end

data/spec/cloud/google_service_helpers_spec.rb

@@ -52,7 +52,6 @@ describe Chef::Knife::Cloud::GoogleServiceHelpers do
   describe "#check_for_missing_config_values" do
     it "does not raise an exception if all parameters are present" do
       expect(tester).to receive(:locate_config_value).with(:gce_project).and_return("project")
-      expect(tester).to receive(:locate_config_value).with(:gce_zone).and_return("zone")
       expect(tester).to receive(:locate_config_value).with(:key1).and_return("value1")
       expect(tester).to receive(:locate_config_value).with(:key2).and_return("value2")
 
@@ -63,10 +62,9 @@ describe Chef::Knife::Cloud::GoogleServiceHelpers do
       ui = double("ui")
       expect(tester).to receive(:ui).and_return(ui)
       expect(tester).to receive(:locate_config_value).with(:gce_project).and_return("project")
-      expect(tester).to receive(:locate_config_value).with(:gce_zone).and_return(nil)
       expect(tester).to receive(:locate_config_value).with(:key1).and_return("value1")
       expect(tester).to receive(:locate_config_value).with(:key2).and_return(nil)
-      expect(ui).to receive(:error).with("The following required parameters are missing: gce_zone, key2")
+      expect(ui).to receive(:error).with("The following required parameters are missing: key2")
       expect { tester.check_for_missing_config_values!(:key1, :key2) }.to raise_error(RuntimeError)
     end
   end

data/spec/google_disk_create_spec.rb

@@ -21,7 +21,12 @@ require "spec_helper"
 require "chef/knife/google_disk_create"
 require "support/shared_examples_for_command"
 
+class Tester
+  include Chef::Knife::Cloud::GoogleServiceHelpers
+end
+
 describe Chef::Knife::Cloud::GoogleDiskCreate do
+  let(:tester) { Tester.new }
   let(:command) { described_class.new(%w{disk1}) }
   let(:service) { double("service") }
 
@@ -38,7 +43,7 @@ describe Chef::Knife::Cloud::GoogleDiskCreate do
     end
 
     it "checks for missing config values" do
-      expect(command).to receive(:check_for_missing_config_values!).with(:disk_size, :disk_type)
+      expect(command).to receive(:check_for_missing_config_values!).with(:gce_zone, :disk_size, :disk_type)
 
       command.validate_params!
     end
@@ -52,6 +57,14 @@ describe Chef::Knife::Cloud::GoogleDiskCreate do
       expect { command.validate_params! }.to raise_error(RuntimeError, "Disk size must be between 10 and 10,000")
     end
 
+    it "raises an exception if the gce_project is missing" do
+      ui = double("ui")
+      expect(tester).to receive(:ui).and_return(ui)
+      expect(tester).to receive(:locate_config_value).with(:gce_project).and_return(nil)
+      expect(ui).to receive(:error).with("The following required parameters are missing: gce_project")
+      expect { tester.check_for_missing_config_values! }.to raise_error(RuntimeError)
+    end
+
     context "when no disk name is provided" do
       let(:command) { described_class.new }
       it "raises an exception" do

data/spec/google_disk_delete_spec.rb

@@ -21,7 +21,12 @@ require "spec_helper"
 require "chef/knife/google_disk_delete"
 require "support/shared_examples_for_command"
 
+class Tester
+  include Chef::Knife::Cloud::GoogleServiceHelpers
+end
+
 describe Chef::Knife::Cloud::GoogleDiskDelete do
+  let(:tester) { Tester.new }
   let(:command) { described_class.new(%w{disk1 disk2}) }
   let(:service) { double("service") }
 
@@ -37,7 +42,7 @@ describe Chef::Knife::Cloud::GoogleDiskDelete do
     end
 
     it "checks for missing config values" do
-      expect(command).to receive(:check_for_missing_config_values!)
+      expect(command).to receive(:check_for_missing_config_values!).with(:gce_zone)
 
       command.validate_params!
     end
@@ -46,6 +51,14 @@ describe Chef::Knife::Cloud::GoogleDiskDelete do
       expect { command.validate_params! }.not_to raise_error
     end
 
+    it "raises an exception if the gce_project is missing" do
+      ui = double("ui")
+      expect(tester).to receive(:ui).and_return(ui)
+      expect(tester).to receive(:locate_config_value).with(:gce_project).and_return(nil)
+      expect(ui).to receive(:error).with("The following required parameters are missing: gce_project")
+      expect { tester.check_for_missing_config_values! }.to raise_error(RuntimeError)
+    end
+
     context "when no disk name is provided" do
       let(:command) { described_class.new }
       it "raises an exception" do

data/spec/google_disk_list_spec.rb

@@ -21,7 +21,12 @@ require "spec_helper"
 require "chef/knife/google_disk_list"
 require "support/shared_examples_for_command"
 
+class Tester
+  include Chef::Knife::Cloud::GoogleServiceHelpers
+end
+
 describe Chef::Knife::Cloud::GoogleDiskList do
+  let(:tester) { Tester.new }
   let(:command) { described_class.new }
   let(:service) { double("service") }
 
@@ -33,10 +38,18 @@ describe Chef::Knife::Cloud::GoogleDiskList do
 
   describe "#validate_params!" do
     it "checks for missing config values" do
-      expect(command).to receive(:check_for_missing_config_values!)
+      expect(command).to receive(:check_for_missing_config_values!).with(:gce_zone)
 
       command.validate_params!
     end
+
+    it "raises an exception if the gce_project is missing" do
+      ui = double("ui")
+      expect(tester).to receive(:ui).and_return(ui)
+      expect(tester).to receive(:locate_config_value).with(:gce_project).and_return(nil)
+      expect(ui).to receive(:error).with("The following required parameters are missing: gce_project")
+      expect { tester.check_for_missing_config_values! }.to raise_error(RuntimeError)
+    end
   end
 
   describe "#query_resource" do

data/spec/google_project_quotas_spec.rb

@@ -21,7 +21,12 @@ require "spec_helper"
 require "chef/knife/google_project_quotas"
 require "support/shared_examples_for_command"
 
+class Tester
+  include Chef::Knife::Cloud::GoogleServiceHelpers
+end
+
 describe Chef::Knife::Cloud::GoogleProjectQuotas do
+  let(:tester) { Tester.new }
   let(:command) { described_class.new }
   let(:service) { double("service") }
 
@@ -37,6 +42,14 @@ describe Chef::Knife::Cloud::GoogleProjectQuotas do
 
       command.validate_params!
     end
+
+    it "raises an exception if the gce_project is missing" do
+      ui = double("ui")
+      expect(tester).to receive(:ui).and_return(ui)
+      expect(tester).to receive(:locate_config_value).with(:gce_project).and_return(nil)
+      expect(ui).to receive(:error).with("The following required parameters are missing: gce_project")
+      expect { tester.check_for_missing_config_values! }.to raise_error(RuntimeError)
+    end
   end
 
   describe "#query_resource" do

data/spec/google_region_list_spec.rb

@@ -21,7 +21,12 @@ require "spec_helper"
 require "chef/knife/google_region_list"
 require "support/shared_examples_for_command"
 
+class Tester
+  include Chef::Knife::Cloud::GoogleServiceHelpers
+end
+
 describe Chef::Knife::Cloud::GoogleRegionList do
+  let(:tester) { Tester.new }
   let(:command) { described_class.new }
   let(:service) { double("service") }
 
@@ -37,6 +42,14 @@ describe Chef::Knife::Cloud::GoogleRegionList do
 
       command.validate_params!
     end
+
+    it "raises an exception if the gce_project is missing" do
+      ui = double("ui")
+      expect(tester).to receive(:ui).and_return(ui)
+      expect(tester).to receive(:locate_config_value).with(:gce_project).and_return(nil)
+      expect(ui).to receive(:error).with("The following required parameters are missing: gce_project")
+      expect { tester.check_for_missing_config_values! }.to raise_error(RuntimeError)
+    end
   end
 
   describe "#query_resource" do

data/spec/google_region_quotas_spec.rb

@@ -21,7 +21,12 @@ require "spec_helper"
 require "chef/knife/google_region_quotas"
 require "support/shared_examples_for_command"
 
+class Tester
+  include Chef::Knife::Cloud::GoogleServiceHelpers
+end
+
 describe Chef::Knife::Cloud::GoogleRegionQuotas do
+  let(:tester) { Tester.new }
   let(:command) { described_class.new }
   let(:service) { double("service") }
 
@@ -37,6 +42,14 @@ describe Chef::Knife::Cloud::GoogleRegionQuotas do
 
       command.validate_params!
     end
+
+    it "raises an exception if the gce_project is missing" do
+      ui = double("ui")
+      expect(tester).to receive(:ui).and_return(ui)
+      expect(tester).to receive(:locate_config_value).with(:gce_project).and_return(nil)
+      expect(ui).to receive(:error).with("The following required parameters are missing: gce_project")
+      expect { tester.check_for_missing_config_values! }.to raise_error(RuntimeError)
+    end
   end
 
   describe "#execute_command" do

data/spec/google_server_create_spec.rb

@@ -22,7 +22,12 @@ require "chef/knife/google_server_create"
 require "support/shared_examples_for_command"
 require "gcewinpass"
 
+class Tester
+  include Chef::Knife::Cloud::GoogleServiceHelpers
+end
+
 describe Chef::Knife::Cloud::GoogleServerCreate do
+  let(:tester) { Tester.new }
   let(:command) { described_class.new(["test_instance"]) }
   let(:service) { double("service") }
   let(:server)  { double("server") }
@@ -57,7 +62,7 @@ describe Chef::Knife::Cloud::GoogleServerCreate do
     end
 
     it "checks for missing config values" do
-      expect(command).to receive(:check_for_missing_config_values!).with(:machine_type, :image, :boot_disk_size, :network)
+      expect(command).to receive(:check_for_missing_config_values!).with(:gce_zone, :machine_type, :image, :boot_disk_size, :network)
 
       command.validate_params!
     end
@@ -67,6 +72,14 @@ describe Chef::Knife::Cloud::GoogleServerCreate do
       expect { command.validate_params! }.to raise_error(RuntimeError)
     end
 
+    it "raises an exception if the gce_project is missing" do
+      ui = double("ui")
+      expect(tester).to receive(:ui).and_return(ui)
+      expect(tester).to receive(:locate_config_value).with(:gce_project).and_return(nil)
+      expect(ui).to receive(:error).with("The following required parameters are missing: gce_project")
+      expect { tester.check_for_missing_config_values! }.to raise_error(RuntimeError)
+    end
+
     it "raises an exception if bootstrap is WinRM but no gcloud user email as supplied" do
       expect(command).to receive(:locate_config_value).with(:bootstrap_protocol).and_return("winrm")
       expect(command).to receive(:locate_config_value).with(:gce_email).and_return(nil)

data/spec/google_server_delete_spec.rb

@@ -21,7 +21,12 @@ require "spec_helper"
 require "chef/knife/google_server_delete"
 require "support/shared_examples_for_serverdeletecommand"
 
+class Tester
+  include Chef::Knife::Cloud::GoogleServiceHelpers
+end
+
 describe Chef::Knife::Cloud::GoogleServerDelete do
+  let(:tester) { Tester.new }
   let(:command) { described_class.new(["test_instance"]) }
   let(:service) { double("service") }
 
@@ -36,5 +41,13 @@ describe Chef::Knife::Cloud::GoogleServerDelete do
       expect(command).to receive(:check_for_missing_config_values!)
       command.validate_params!
     end
+
+    it "raises an exception if the gce_project is missing" do
+      ui = double("ui")
+      expect(tester).to receive(:ui).and_return(ui)
+      expect(tester).to receive(:locate_config_value).with(:gce_project).and_return(nil)
+      expect(ui).to receive(:error).with("The following required parameters are missing: gce_project")
+      expect { tester.check_for_missing_config_values! }.to raise_error(RuntimeError)
+    end
   end
 end

data/spec/google_server_list_spec.rb

@@ -21,7 +21,12 @@ require "spec_helper"
 require "chef/knife/google_server_list"
 require "support/shared_examples_for_command"
 
+class Tester
+  include Chef::Knife::Cloud::GoogleServiceHelpers
+end
+
 describe Chef::Knife::Cloud::GoogleServerList do
+  let(:tester) { Tester.new }
   let(:command) { described_class.new }
   let(:service) { double("service") }
 
@@ -33,10 +38,18 @@ describe Chef::Knife::Cloud::GoogleServerList do
 
   describe "#validate_params!" do
     it "checks for missing config values" do
-      expect(command).to receive(:check_for_missing_config_values!)
+      expect(command).to receive(:check_for_missing_config_values!).with(:gce_zone)
 
       command.validate_params!
     end
+
+    it "raises an exception if the gce_project is missing" do
+      ui = double("ui")
+      expect(tester).to receive(:ui).and_return(ui)
+      expect(tester).to receive(:locate_config_value).with(:gce_project).and_return(nil)
+      expect(ui).to receive(:error).with("The following required parameters are missing: gce_project")
+      expect { tester.check_for_missing_config_values! }.to raise_error(RuntimeError)
+    end
   end
 
   describe "#format_status_value" do

data/spec/google_server_show_spec.rb

@@ -21,7 +21,12 @@ require "spec_helper"
 require "chef/knife/google_server_show"
 require "support/shared_examples_for_command"
 
+class Tester
+  include Chef::Knife::Cloud::GoogleServiceHelpers
+end
+
 describe Chef::Knife::Cloud::GoogleServerShow do
+  let(:tester) { Tester.new }
   let(:command) { described_class.new(["test_instance"]) }
   let(:service) { double("service") }
 
@@ -37,11 +42,19 @@ describe Chef::Knife::Cloud::GoogleServerShow do
     end
 
     it "checks for missing config values" do
-      expect(command).to receive(:check_for_missing_config_values!)
+      expect(command).to receive(:check_for_missing_config_values!).with(:gce_zone)
 
       command.validate_params!
     end
 
+    it "raises an exception if the gce_project is missing" do
+      ui = double("ui")
+      expect(tester).to receive(:ui).and_return(ui)
+      expect(tester).to receive(:locate_config_value).with(:gce_project).and_return(nil)
+      expect(ui).to receive(:error).with("The following required parameters are missing: gce_project")
+      expect { tester.check_for_missing_config_values! }.to raise_error(RuntimeError)
+    end
+
     context "when no server name is provided" do
       let(:command) { described_class.new }
 

data/spec/google_zone_list_spec.rb

@@ -21,7 +21,12 @@ require "spec_helper"
 require "chef/knife/google_zone_list"
 require "support/shared_examples_for_command"
 
+class Tester
+  include Chef::Knife::Cloud::GoogleServiceHelpers
+end
+
 describe Chef::Knife::Cloud::GoogleZoneList do
+  let(:tester) { Tester.new }
   let(:command) { described_class.new }
   let(:service) { double("service") }
 
@@ -37,6 +42,14 @@ describe Chef::Knife::Cloud::GoogleZoneList do
 
       command.validate_params!
     end
+
+    it "raises an exception if the gce_project is missing" do
+      ui = double("ui")
+      expect(tester).to receive(:ui).and_return(ui)
+      expect(tester).to receive(:locate_config_value).with(:gce_project).and_return(nil)
+      expect(ui).to receive(:error).with("The following required parameters are missing: gce_project")
+      expect { tester.check_for_missing_config_values! }.to raise_error(RuntimeError)
+    end
   end
 
   describe "#query_resource" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: knife-google
 version: !ruby/object:Gem::Version
-  version: 3.3.3
+  version: 3.3.6
 platform: ruby
 authors:
 - Chiraq Jog
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-17 00:00:00.000000000 Z
+date: 2018-11-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: knife-cloud
@@ -63,20 +63,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.1'
-- !ruby/object:Gem::Dependency
-  name: github_changelog_generator
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Google Compute Engine Support for Chef's Knife Command
 email:
 - paulrossman@google.com
@@ -101,6 +87,7 @@ files:
 - README.md
 - RELEASE_NOTES.md
 - Rakefile
+- TESTING.md
 - VERSION
 - knife-google.gemspec
 - lib/chef/knife/cloud/google_service.rb