knife-foodcritic 0.2.0 → 0.2.1

data/.travis.yml

@@ -0,0 +1,6 @@
+language: ruby
+rvm:
+  - 1.9.3
+  - 2.0.0
+
+script: bundle exec rake

data/README.md

@@ -3,6 +3,8 @@ knife-foodcritic
 
 A knife plugin that generates boiler plate code for developing and testing custom foodcritic rules
 
+[![Build Status](https://travis-ci.org/DevopsNinjas/knife-foodcritic.svg?branch=master)](https://travis-ci.org/DevopsNinjas/knife-foodcritic)
+
 Installation
 ------------
 

data/Rakefile

@@ -1 +1,7 @@
-require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+require 'bundler/gem_tasks'
+
+desc 'Runs specs'
+RSpec::Core::RakeTask.new :spec
+
+task :default => [:spec]

data/knife-foodcritic.gemspec

@@ -18,7 +18,9 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "rake"
+  spec.add_development_dependency 'rake', '~> 10'
+  spec.add_development_dependency 'rspec', '~> 2.14'
+  spec.add_development_dependency "fakefs", '>= 0.5.3'
   spec.add_dependency "chef"
   spec.add_dependency "foodcritic", "~> 4.0.0"
 

data/lib/chef/knife/create_foodcritic_rule.rb

@@ -1,7 +1,7 @@
 require 'chef/knife'
 require 'chef/knife/cookbook_create'
 
-module Foodcritic
+module Knife
   class FoodcriticRuleCreate < Chef::Knife
 
     banner "knife foodcritic rule create"
@@ -16,8 +16,8 @@ module Foodcritic
     def run
 
       unless name_args.size == 1
-        puts "You need to name the rule (eg. FOURTH004)"
         show_usage
+        ui.fatal('You must specify a rule ID (eg. CUSTOM001)')
         exit 1
       end
 

data/lib/chef/knife/delete_foodcritic_rule.rb

@@ -1,6 +1,6 @@
 require 'chef/knife'
 
-module Foodcritic
+module Knife
   class FoodcriticRuleDelete < Chef::Knife
 
     banner "knife foodcritic rule delete"  
@@ -17,7 +17,7 @@ module Foodcritic
     end
 
     def delete_foodcritic_rule(foodcritic_path, ruleID)
-      path = File.join(foodcritic_path, "lib","Fourth", "#{ruleID.upcase}.rb")
+      path = File.join(foodcritic_path, "rules", "#{ruleID.upcase}.rb")
 
       if File.exists? path
         puts "** Deleting rule file at #{path}"

data/lib/knife-foodcritic/version.rb

@@ -1,3 +1,3 @@
 module KnifeFoodcritic
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/spec/chef/knife/create_foodcritic_rule_spec.rb

@@ -0,0 +1,34 @@
+require_relative '../../spec_helper'
+
+require 'fakefs/spec_helpers'
+require 'chef/knife/create_foodcritic_rule'
+
+describe Knife::FoodcriticRuleCreate do
+    include FakeFS::SpecHelpers
+
+    before(:each) do
+        @knife = Knife::FoodcriticRuleCreate.new
+        @knife.config = {}
+        @knife.name_args = ['TEST001']
+        @stdout = StringIO.new
+        @knife.stub(:stdout).and_return(@stdout)
+        @foodcritic_path = File.expand_path("./foodcritic")
+    end
+
+    describe 'run' do
+
+        it 'should show usage if there is no rule ID' do
+          @knife.config = {}
+          @knife.name_args = []
+          @knife.ui.should_receive(:fatal).with('You must specify a rule ID (eg. CUSTOM001)')
+          -> { @knife.run }.should raise_error SystemExit
+        end
+
+        it 'should create a new cookbook' do
+          @knife.should_receive(:create_cookbook).with(@foodcritic_path, 'TEST001')
+          @knife.run
+        end
+
+    end
+
+end

data/spec/spec_helper.rb

@@ -0,0 +1,5 @@
+$LOAD_PATH << File.expand_path('../../lib', __FILE__)
+
+RSpec.configure do |c|
+  c.before { allow($stdout).to receive(:puts) }
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: knife-foodcritic
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -29,12 +29,44 @@ dependencies:
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '10'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '10'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.14'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.14'
+- !ruby/object:Gem::Dependency
+  name: fakefs
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.5.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -42,7 +74,7 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.5.3
 - !ruby/object:Gem::Dependency
   name: chef
   requirement: !ruby/object:Gem::Requirement
@@ -86,6 +118,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .travis.yml
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -94,6 +127,9 @@ files:
 - lib/chef/knife/create_foodcritic_rule.rb
 - lib/chef/knife/delete_foodcritic_rule.rb
 - lib/knife-foodcritic/version.rb
+- spec/chef/knife/create_foodcritic_rule_spec.rb
+- spec/chef/knife/delete_foodcritic_rule_spec.rb
+- spec/spec_helper.rb
 homepage: http://www.devopsninjas.com
 licenses:
 - GPL
@@ -109,7 +145,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3583670318698646123
+      hash: -873183254715860800
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -118,7 +154,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3583670318698646123
+      hash: -873183254715860800
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.25
@@ -126,4 +162,7 @@ signing_key:
 specification_version: 3
 summary: A knife plugin for Chef that generates boiler plate code to help develop
   and test custom foodcritic rules
-test_files: []
+test_files:
+- spec/chef/knife/create_foodcritic_rule_spec.rb
+- spec/chef/knife/delete_foodcritic_rule_spec.rb
+- spec/spec_helper.rb