knife-changelog 1.2.3 → 1.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b8a6814c2c33a531b39095d40b5a29eac42e0d1d9f9771594eab6acf5585a2c1
-  data.tar.gz: 7e0be550e063acdb2b24fd8053815ddf5c19b9599c05147761227c28d2a946be
+  metadata.gz: 4f1c7e863b74d109a6621879de1419046bbc5a2afb08ce618772f349d6aea0da
+  data.tar.gz: 5c6014713f79e60f1f517073166e114936d75f57db163f51e8f3aee6880e4614
 SHA512:
-  metadata.gz: 6aa98d7ed974e17573f0ee28898f0475dc7629d1cd1f547e96152fafbe6e0c62ba5f1e6ab14228864e909bd1de7bc9be72e516dc2260cf431e4a90567f7a91c7
-  data.tar.gz: 6e40a18276224d6de4cff58176e18f3a7b2467949b6328504c0704514fc518519cdb49fa2eab7bbc5b735205e284e37f69fae6889176b5f9d73faf18b362f9e5
+  metadata.gz: bff9ad82bfe2d79b1b0d5094ee5b88e396b61013fb453aed9f57a584b48458428a7ec15dd88e63b6affb2e5b1c6e441112847b269312578d3d6f1505382d5660
+  data.tar.gz: c8e4d5741503d05cea8eaf23f1b8a120292733b8b7d723ac56c9b9f13977d0a501ffce943b6203f86d40e5f5cf16047d7b5a088b412e5a46c235c5a212419bee

data/knife-changelog.gemspec

@@ -5,7 +5,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'knife-changelog'
-  spec.version       = '1.2.3'
+  spec.version       = '1.2.4'
   spec.authors       = ['Gregoire Seux']
   spec.email         = ['kamaradclimber@gmail.com']
   spec.summary       = 'Facilitate access to cookbooks changelog'

data/lib/knife/changelog/policyfile.rb

@@ -29,7 +29,7 @@ class PolicyChangelog
     backup_dir = Dir.mktmpdir
     FileUtils.cp(File.join(@policyfile_dir, 'Policyfile.lock.json'), backup_dir)
     updater = ChefDK::Command::Update.new
-    updater.run([@policyfile_path, @cookbooks_to_update].flatten)
+    raise "Error updating Policyfile lock #{@policyfile_path}" unless updater.run([@policyfile_path, @cookbooks_to_update].flatten).zero?
     updated_policyfile_lock = read_policyfile_lock(@policyfile_dir)
     FileUtils.cp(File.join(backup_dir, 'Policyfile.lock.json'), @policyfile_dir)
     updated_policyfile_lock
@@ -55,7 +55,7 @@ class PolicyChangelog
   # @return [Hash] cookbooks with their versions
   def versions(locks, type)
     raise 'Use "current" or "target" as type' unless %w[current target].include?(type)
-    raise 'Cookbook locks empty or nil' if locks.nil? or locks.empty?
+    raise 'Cookbook locks empty or nil' if locks.nil? || locks.empty?
     cookbooks = {}
     locks.each do |name, data|
       cookbooks[name] = if data['source_options'].keys.include?('git')
@@ -141,7 +141,8 @@ class PolicyChangelog
         Gem::Version.new(t.name.gsub(/^v/, ''))
       rescue ArgumentError => e
         # Skip tag if version is not valid (i.e. a String)
-        Gem::Version.new(nil) if e.to_s.include?('Malformed version number string')
+        raise unless e.message && e.message.include?('Malformed version number string')
+        Gem::Version.new('0.0.0')
       end
     end
   end

data/spec/unit/policyfile_spec.rb

@@ -40,6 +40,8 @@ RSpec.describe PolicyChangelog do
 
   let(:url) { 'https://supermarket.chef.io/api/v1/cookbooks/users' }
 
+  let(:fake_update) { double('fake_update') }
+
   let(:tags) do
     [
       double(name: '1.0.0'),
@@ -310,6 +312,14 @@ RSpec.describe PolicyChangelog do
 
         expect(changelog.generate_changelog).to eq(output)
       end
+      it 'raises an exception' do
+        allow(ChefDK::Command::Update).to receive(:new).and_return(fake_update)
+        allow(fake_update).to receive(:run).and_return(1)
+        allow(changelog).to receive(:git_changelog)
+          .and_return('e1b971a Add test commit message')
+
+        expect { changelog.generate_changelog }.to raise_error(RuntimeError)
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knife-changelog
 version: !ruby/object:Gem::Version
-  version: 1.2.3
+  version: 1.2.4
 platform: ruby
 authors:
 - Gregoire Seux
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-17 00:00:00.000000000 Z
+date: 2018-05-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -244,7 +244,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: Facilitate access to cookbooks changelog