knife-changelog 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 95499efdf53e4b358f0915a77503a9e9b7fd22fcd548f8c8cde457647407ad52
-  data.tar.gz: 74b012abf17ffd90825355ad5d1441be039a6ec035af288603ad225f1856d4bf
+  metadata.gz: 86dbce0b63b7c41f34366f494d98c4d98c3276c237a952558a88db0b259b5df8
+  data.tar.gz: 56f786a8cf798e7bd03e8340ed36079b559f0e880504e6d5b0dd09ca40d2f173
 SHA512:
-  metadata.gz: 614b3a5eee0ed8f588aa2839ff2308527d754c523e0dbbb4d7d6b73a34c9d1656c5e12d54de7a1fb657c4adec7b2676c6cee5205e16c4eacf7d9cab38574eec0
-  data.tar.gz: 2bcb867befe00f2d0b4fa7e24e01acd6249406096a1d0630cd242f6802cf40a06e23c3e572a63f6a10357ce122230b2b70e03f3497501cdf8627f9ca825cfbff
+  metadata.gz: 20006e01c5ddee8a8a9a6fbe980840bfcc8b94ac65fdae3e0254b82e03fedf915719f20f09cb72ee653cfc2c66b3e87523fffdcb7ea8981a3ebc0fdd71b5698a
+  data.tar.gz: 5f745773984fcc7cddf037c0c78847604994252cdf1dec9626683acf63f6da6f3f28e303a2daaecf49ca1bcc96d3e4b14b88522db71d94156a352a82cbe34030

data/knife-changelog.gemspec

@@ -5,7 +5,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'knife-changelog'
-  spec.version       = '1.2.0'
+  spec.version       = '1.2.1'
   spec.authors       = ['Gregoire Seux']
   spec.email         = ['kamaradclimber@gmail.com']
   spec.summary       = 'Facilitate access to cookbooks changelog'

data/lib/knife/changelog/policyfile.rb

@@ -180,8 +180,7 @@ class PolicyChangelog
     output.join("\n")
   end
 
-  # Filters out cookbooks which are not updated, are not used after update or
-  # are newly added as dependencies during update
+  # Filters out cookbooks which are not updated, are not used after update
   #
   # @param [Hash] cookbook versions and source url data
   # @return [true, false]
@@ -215,9 +214,9 @@ class PolicyChangelog
   # @return [String] formatted version changelog
   def generate_changelog_from_versions(cookbook_versions)
     lock_current = read_policyfile_lock(@policyfile_dir)
-    sources = cookbook_versions.keys.map do |name|
-      [name, get_source_url(lock_current['cookbook_locks'][name]['source_options'])]
-    end.to_h
+    sources = cookbook_versions.map do |name, data|
+      [name, get_source_url(lock_current['cookbook_locks'][name]['source_options'])] if data['current_version']
+    end.compact.to_h
     cookbook_versions.deep_merge(sources).map { |name, data| format_output(name, data) }.join("\n")
   end
 end

data/spec/unit/policyfile_spec.rb

@@ -279,16 +279,24 @@ RSpec.describe PolicyChangelog do
         expect(changelog).not_to receive(:update_policyfile_lock)
 
         origin_and_target = {
-          'users' => { 'current_version' => '4.0.0', 'target_version' => '5.0.0' }
+          'users' => { 'current_version' => '4.0.0', 'target_version' => '5.0.0' },
+          'new_cookbook' => { 'target_version' => '8.0.0' }
         }
 
         allow(changelog).to receive(:git_changelog)
           .with(instance_of(String), '4.0.0', '5.0.0')
           .and_return('e1b971a Add test commit message')
 
-        output = "\nChangelog for users: 4.0.0->5.0.0\n" \
-          "==================================\n"         \
-          "e1b971a Add test commit message"
+        output = <<~COMMIT.chomp
+
+          Changelog for users: 4.0.0->5.0.0
+          ==================================
+          e1b971a Add test commit message
+
+          Changelog for new_cookbook: ->8.0.0
+          ====================================
+          Cookbook was not in the Policyfile.lock.json
+        COMMIT
 
         expect(changelog.generate_changelog_from_versions(origin_and_target)).to eq(output)
       end
@@ -305,7 +313,7 @@ RSpec.describe PolicyChangelog do
 
         output = "\nChangelog for users: 4.0.0->5.3.1\n" \
           "==================================\n"         \
-          "e1b971a Add test commit message"
+          'e1b971a Add test commit message'
 
         expect(changelog.generate_changelog).to eq(output)
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knife-changelog
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Gregoire Seux
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-16 00:00:00.000000000 Z
+date: 2018-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler