knapsack_pro 7.5.0 → 7.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cea03959b8de66cd8cbb686deb3ac76129f9cce7ee24b1da2a0ef9e57dd790df
-  data.tar.gz: ec12a1f99f57207e967846df739a5dfea4a1423e6823431ee9cf26f1d2f9a473
+  metadata.gz: 1c0358e24e8030869e858b896df6bbb3188433fcd973e073e773e6f6735b481a
+  data.tar.gz: 33c9a7233e1fc1c14450d3e72eea10568bbab8dd37c90df93db37253db78b8b3
 SHA512:
-  metadata.gz: cd53605f0d47ce2a3bc83410eb56d459a65aa1b75b169c420f5a11e3693b2aa7abee8e5b984eff35ab876de53809a2c113abb38b253e1e1b42726c817bccae6b
-  data.tar.gz: 93eaec09e20ba573cfb69b0f1ad2e8a04f5db2ab95637767a1abed0d8640cf131447b1adae67196998d73165232ea1a23e2c1fe547ab01b14436ace7d422edc5
+  metadata.gz: 43966d1dc8df454ede86e53226927e43f7d622e7605a04b1eb6331ca33e8e1c5e5ab7ba3e1ed9e9616088bd729cf95baf5aa28503ab36062828869ef5d5a8943
+  data.tar.gz: f1ace143ed62bbbb8d210470990cbf44baeef4473c23d5a303ad28fbf9aa8708ad04c95f920639af588406a7541542c2db8a04db7021c7144a583cc6c120ba41

data/.github/pull_request_template.md

@@ -16,6 +16,7 @@ TODO: changes introduced by this PR
 
 # Checklist reminder
 
+- [ ] You added the changes to the `UNRELEASED` section of the `CHANGELOG.md`, including the needed bump (ie, patch, minor, major)
 - [ ] You follow the architecture outlined below for RSpec in Queue Mode, which is a work in progress (feel free to propose changes):
   - Pure: `lib/knapsack_pro/pure/queue/rspec_pure.rb` contains pure functions that are unit tested.
   - Extension: `lib/knapsack_pro/extensions/rspec_extension.rb` encapsulates calls to RSpec internals and is integration and e2e tested.

data/CHANGELOG.md

@@ -1,6 +1,13 @@
 # Changelog
 
+### UNRELEASED
+
+### 7.5.1
+
+Revert to 7.4.0.
+
 ### 7.5.0
+
 * Raise when `KNAPSACK_PRO_CI_NODE_TOTAL` or `KNAPSACK_PRO_CI_NODE_INDEX` is missing and can't be determined from supported CI environments, instead of defaulting to arbitrary numbers.
 
   https://github.com/KnapsackPro/knapsack_pro-ruby/pull/256
@@ -8,6 +15,7 @@
 https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v7.4.0...v7.5.0
 
 ### 7.4.0
+
 * Warn when `KNAPSACK_PRO_*` environment variables are set manually if their values could be automatically determined from supported CI environments.
 
   https://github.com/KnapsackPro/knapsack_pro-ruby/pull/254

data/README.md

@@ -74,28 +74,13 @@ Scripted tests can be found in the [Rails App With Knapsack Pro repository](http
 
 ### Publishing
 
-1. Update the `CHANGELOG.md` as part of your PR.
+1. Move the changes listed in the `UNRELEASED` section of the `CHANGELOG.md` to the proper version
 
-2. After your PR has been merged, update the gem version in `lib/knapsack_pro/version.rb` directly on the `master` branch:
+2. Update the gem version in `lib/knapsack_pro/version.rb`
 
-```bash
-git commit -m "Bump version X.X.X"
-git push origin master
-```
-
-3. Create a git tag for the release:
+3. `git commit -am "chore: prepare release"`
 
-```bash
-git tag -a vX.X.X -m "Release vX.X.X"
-git push --tags
-```
-
-4. Build the gem and publish it to RubyGems:
-
-```bash
-gem build knapsack_pro.gemspec
-gem push knapsack_pro-X.X.X.gem
-```
+4. Build, tag, push, release: `bundle exec rake release`
 
 5. Update the latest available gem version in `TestSuiteClientVersionChecker` for the Knapsack Pro API repository.
 

data/lib/knapsack_pro/config/env.rb

@@ -13,17 +13,11 @@ module KnapsackPro
 
       class << self
         def ci_node_total
-          env_name = 'KNAPSACK_PRO_CI_NODE_TOTAL'
-          env_value = env_for(env_name, :node_total)
-
-          env_value ? env_value.to_i : raise_missing_env_for(env_name)
+          (env_for('KNAPSACK_PRO_CI_NODE_TOTAL', :node_total) || 1).to_i
         end
 
         def ci_node_index
-          env_name = 'KNAPSACK_PRO_CI_NODE_INDEX'
-          env_value = env_for(env_name, :node_index)
-
-          env_value ? env_value.to_i : raise_missing_env_for(env_name)
+          (env_for('KNAPSACK_PRO_CI_NODE_INDEX', :node_index) || 0).to_i
         end
 
         def ci_node_build_id
@@ -280,7 +274,7 @@ module KnapsackPro
         private
 
         def required_env(env_name)
-          ENV[env_name] || raise_missing_env_for(env_name)
+          ENV[env_name] || raise("Missing environment variable #{env_name}")
         end
 
         def env_for(knapsack_env_name, ci_env_method)
@@ -297,10 +291,6 @@ module KnapsackPro
         def ci_env_for(env_name)
           detected_ci.new.send(env_name)
         end
-
-        def raise_missing_env_for(env_name)
-          raise("Missing environment variable #{env_name}")
-        end
       end
     end
   end

data/lib/knapsack_pro/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module KnapsackPro
-  VERSION = '7.5.0'
+  VERSION = '7.5.1'
 end

data/spec/knapsack_pro/config/env_spec.rb

@@ -54,9 +54,7 @@ describe KnapsackPro::Config::Env do
     end
 
     context "when ENV doesn't exist" do
-      it 'raises' do
-        expect { subject }.to raise_error(/Missing environment variable KNAPSACK_PRO_CI_NODE_TOTAL/)
-      end
+      it { should eq 1 }
     end
   end
 
@@ -120,9 +118,7 @@ describe KnapsackPro::Config::Env do
     end
 
     context "when ENV doesn't exist" do
-      it 'raises' do
-        expect { subject }.to raise_error(/Missing environment variable KNAPSACK_PRO_CI_NODE_INDEX/)
-      end
+      it { should eq 0 }
     end
   end
 

data/spec/knapsack_pro_spec.rb

@@ -36,11 +36,13 @@ describe KnapsackPro do
           stub_const('ENV', {
             'KNAPSACK_PRO_LOG_DIR' => 'log',
           })
-        end
 
-        it 'raises' do
-          expect { subject }.to raise_error(/Missing environment variable KNAPSACK_PRO_CI_NODE_INDEX/)
+          expect(Logger).to receive(:new).with('log/knapsack_pro_node_0.log').and_return(logger)
+          expect(logger).to receive(:level=).with(Logger::INFO)
+          expect(KnapsackPro::LoggerWrapper).to receive(:new).with(logger).and_return(logger_wrapper)
         end
+
+        it { should eql logger_wrapper }
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 7.5.0
+  version: 7.5.1
 platform: ruby
 authors:
 - ArturT
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-05-27 00:00:00.000000000 Z
+date: 2024-05-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake