knapsack_pro 3.6.0 → 3.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ba65a6353675fce4c06920c5dca6b7dcc90aee4a978db714f28bf9305f5208e3
-  data.tar.gz: 345aa8cf66464faeeb05cc3adcd2fcf904862aa02ea3f6a0109ca83f37c7c332
+  metadata.gz: 98e74bc85a91b0e94977b272f81e7efcd85a3ca242b4c7afc3d61340e56b02e4
+  data.tar.gz: 8732eb25ee525d4d3d73a7dc0c23ed92ebe3597bf4a24946a8ae7a291a7746ee
 SHA512:
-  metadata.gz: c12d293d3ac2ca00f33e5802f4c6cf0c8f9ef08dd76d5217892efcb14a8bc090b6f5a118514c79a7066baf8449c3b2406e7b6d4a867b4b479a9bda841d057dbf
-  data.tar.gz: 757a63fd917a7fc685659fe6d64d01b19800fa3cc81b4f66d7e9fd08ed9631b28c727544577bae13faae3e54c3b1b3fb3624b2d69e6b74287887c3cb1fb95c44
+  metadata.gz: 87f2bbebde7460541fa539fea85fa195b52e1e84cd4a40e296287ba6e35dd682ab7676b28822911483e2aee1ff711421995c3b75a7cd31b2a095e7c76971acdc
+  data.tar.gz: d4ed38d722c0b7a3bdad17bb292c20a5040f583ad3b3aa45371e364a0d9d0bac6168d1d37350a224d4494ff88cb2db1c641d2e45b88fe812eed2c5c3f37d2d50

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Change Log
 
+### 3.7.0
+
+* Adjust the timer behaviour in the RSpec adapter
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/184
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.6.0...v3.7.0
+
 ### 3.6.0
 
 * Add an attempt to read from the cache for Regular Mode API

data/lib/knapsack_pro/adapters/rspec_adapter.rb

@@ -48,12 +48,16 @@ module KnapsackPro
           end
 
           config.around(:each) do |example|
-            # stop timer to update time for a previously run test example
-            # this way we count time spend in runtime for the previous test example after around(:each) is already done
-            KnapsackPro.tracker.stop_timer
-
             current_test_path = KnapsackPro::Adapters::RSpecAdapter.test_path(example)
 
+            # Stop timer to update time for a previously run test example.
+            # This way we count time spent in runtime for the previous test example after around(:each) is already done.
+            # Only do that if we're in the same test file. Otherwise, `before(:all)` execution time in the current file
+            # will be applied to the previously ran test file.
+            if KnapsackPro.tracker.current_test_path&.start_with?(KnapsackPro::TestFileCleaner.clean(current_test_path))
+              KnapsackPro.tracker.stop_timer
+            end
+
             KnapsackPro.tracker.current_test_path =
               if KnapsackPro::Config::Env.rspec_split_by_test_examples? && KnapsackPro::Adapters::RSpecAdapter.slow_test_file?(RSpecAdapter, current_test_path)
                 example.id

data/lib/knapsack_pro/tracker.rb

@@ -46,7 +46,8 @@ module KnapsackPro
     end
 
     def current_test_path
-      raise("current_test_path needs to be set by Knapsack Pro Adapter's bind method") unless @current_test_path
+      return unless @current_test_path
+
       KnapsackPro::TestFileCleaner.clean(@current_test_path)
     end
 

data/lib/knapsack_pro/version.rb

@@ -1,3 +1,3 @@
 module KnapsackPro
-  VERSION = '3.6.0'
+  VERSION = '3.7.0'
 end

data/spec/knapsack_pro/adapters/rspec_adapter_spec.rb

@@ -243,6 +243,7 @@ describe KnapsackPro::Adapters::RSpecAdapter do
           expect(config).to receive(:around).with(:each).and_yield(current_example)
           expect(::RSpec).to receive(:configure).and_yield(config)
 
+          expect(tracker).to receive(:current_test_path).ordered.and_return(test_path)
           expect(tracker).to receive(:stop_timer).ordered
 
           expect(described_class).to receive(:test_path).with(current_example).and_return(test_path)
@@ -273,6 +274,7 @@ describe KnapsackPro::Adapters::RSpecAdapter do
           expect(config).to receive(:after).with(:suite).and_yield
           expect(::RSpec).to receive(:configure).and_yield(config)
 
+          expect(tracker).to receive(:current_test_path).ordered.and_return(test_path)
           expect(tracker).to receive(:stop_timer).ordered
 
           expect(described_class).to receive(:test_path).with(current_example).and_return(test_path)
@@ -316,6 +318,7 @@ describe KnapsackPro::Adapters::RSpecAdapter do
             expect(config).to receive(:after).with(:suite).and_yield
             expect(::RSpec).to receive(:configure).and_yield(config)
 
+            expect(tracker).to receive(:current_test_path).ordered.and_return(test_path)
             expect(tracker).to receive(:stop_timer).ordered
 
             expect(described_class).to receive(:test_path).with(current_example).and_return(test_path)
@@ -352,6 +355,7 @@ describe KnapsackPro::Adapters::RSpecAdapter do
 
             expect(described_class).to receive(:test_path).with(current_example).and_return(test_path)
 
+            expect(tracker).to receive(:current_test_path).ordered.and_return(test_path)
             expect(tracker).to receive(:stop_timer).ordered
 
             expect(tracker).to receive(:current_test_path=).with(test_path).ordered

data/spec/knapsack_pro/tracker_spec.rb

@@ -19,9 +19,7 @@ describe KnapsackPro::Tracker do
     subject { tracker.current_test_path }
 
     context 'when current_test_path not set' do
-      it do
-        expect { subject }.to raise_error("current_test_path needs to be set by Knapsack Pro Adapter's bind method")
-      end
+      it { should eql nil }
     end
 
     context 'when current_test_path set' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 3.6.0
+  version: 3.7.0
 platform: ruby
 authors:
 - ArturT
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-12-09 00:00:00.000000000 Z
+date: 2022-12-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -390,7 +390,7 @@ metadata:
   documentation_uri: https://docs.knapsackpro.com/integration/
   homepage_uri: https://knapsackpro.com
   source_code_uri: https://github.com/KnapsackPro/knapsack_pro-ruby
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -405,8 +405,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
-signing_key:
+rubygems_version: 3.1.6
+signing_key: 
 specification_version: 4
 summary: Knapsack Pro splits tests across parallel CI nodes and ensures each parallel
   job finish work at a similar time.