knapsack_pro 3.3.0 → 3.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '099f5615951240d49a1087c5ebbb89169f161a35bfc2f0dc4ea7de80f188e3f9'
-  data.tar.gz: d4939ae9f79b358038147cd5f9a40dcee95760f1fa17d84314fc183cfad722a7
+  metadata.gz: 11036d33c04d07966ab4acadc55b1fb20a885b0e9b0d78fc8cf03fe798b7c3bf
+  data.tar.gz: 8ddfce179b4f7fce9bd28ae965bf15bec132b26b217326d5ce156e94e21cb145
 SHA512:
-  metadata.gz: adfe023532b15509a4bc1cb993c3d259ffde7df5078c76cf7cf392ec5ce8b6f8eb322ca093e77eadf3ec0c8eba4748ccd0f5ccf6666fd3559eb3bd1a55c0893a
-  data.tar.gz: 072f8d809aa4600ed5f4987f39946cd0030faac8e4ca9bae08cf38680c3aef24226744023d5c6a74aa53b76c2fe481c35692b2f33b98ba9a8d85d17ddeb990c6
+  metadata.gz: 4c27910d9850ad2d229864dac8b07cb17d9d23a9bd2d14aa05052b6e95a3e218667b32fb40f711324651d2bcd6ee8d180fc7d743ba5cd3b990908ab05d5c57de
+  data.tar.gz: a868ac3c2ef9c1fdefc655b2dbb59c8034cc21101717be46400fdeec087bd99c62c43c5357fbba1eccfe8a8cc23b032ee1e9e8eb14e75304357ccbe6a179a32b

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Change Log
 
+### 3.3.1
+
+* Skip loading a test file path for Minitest in Queue Mode when it does not exist on the disk
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/174
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.3.0...v3.3.1
+
 ### 3.3.0
 
 * Show a JSON report file content when RSpec fails during a dry run 

data/lib/knapsack_pro/runners/queue/minitest_runner.rb

@@ -91,7 +91,13 @@ module KnapsackPro
 
         def self.minitest_run(runner, test_file_paths, args)
           test_file_paths.each do |test_file_path|
-            require "./#{test_file_path}"
+            relative_test_file_path = "./#{test_file_path}"
+
+            if File.exist?(relative_test_file_path)
+              require relative_test_file_path
+            else
+              KnapsackPro.logger.warn("Skip loading the #{relative_test_file_path} test file path because it does not exist on the disk. Most likely, the test file path should not be loaded. The test file path could have been recorded during the previous CI build when the knapsack_pro gem could not attribute the execution time of a test to a correct test file path. For instance, you have shared examples in your test suite, and the knapsack_pro gem could not correctly determine for which test file path they were executed. In such a case, the test file path should not be loaded because the actual test cases will be executed by loading a correct test file path. You can ignore this warning.")
+            end
           end
 
           # duplicate args because Minitest modifies args

data/lib/knapsack_pro/version.rb

@@ -1,3 +1,3 @@
 module KnapsackPro
-  VERSION = '3.3.0'
+  VERSION = '3.3.1'
 end

data/spec/knapsack_pro/runners/queue/minitest_runner_spec.rb

@@ -100,7 +100,7 @@ describe KnapsackPro::Runners::Queue::MinitestRunner do
     end
 
     context 'when test files exist' do
-      let(:test_file_paths) { ['a_test.rb', 'b_test.rb'] }
+      let(:test_file_paths) { ['a_test.rb', 'b_test.rb', 'fake_path_test.rb'] }
 
       before do
         subset_queue_id = 'fake-subset-queue-id'
@@ -114,8 +114,12 @@ describe KnapsackPro::Runners::Queue::MinitestRunner do
         expect(tracker).to receive(:set_prerun_tests).with(test_file_paths)
 
         # .minitest_run
+        expect(File).to receive(:exist?).with('./a_test.rb').and_return(true)
+        expect(File).to receive(:exist?).with('./b_test.rb').and_return(true)
+        expect(File).to receive(:exist?).with('./fake_path_test.rb').and_return(false)
         expect(described_class).to receive(:require).with('./a_test.rb')
         expect(described_class).to receive(:require).with('./b_test.rb')
+        expect(described_class).to_not receive(:require).with('./fake_path_test.rb')
 
         expect(Minitest).to receive(:run).with(args).and_return(is_tests_green)
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 3.3.0
+  version: 3.3.1
 platform: ruby
 authors:
 - ArturT
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-07-11 00:00:00.000000000 Z
+date: 2022-07-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake