knapsack_pro 1.15.0 → 1.16.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6de10d3f404a03841c25d3a554c9b44a9b0c9ca97386d46ebe38a3b9eb0eed5f
-  data.tar.gz: 625ad48ee1f6d3a1961f60bf7ce23fe209b26f4f03ec565876050969630eca3e
+  metadata.gz: 19a2cee7a78789810cdeca8df09ab0ebce2141cc4682c8a58fb8db4c5c7fafe2
+  data.tar.gz: 2fd92dbf8190a930ef46b84d96b94e680f0d36dbd6353a85535bcb88488cdce3
 SHA512:
-  metadata.gz: 5c05eec67c0d656f85049b73f625678b15c813997d84d3ecbdefaa063532a445ecb888b8a08c928dbcf46314dafbf155b1bfb8a2319c923be3e7f958fc04f879
-  data.tar.gz: 0ffbca55a18ab1e35e741edcc90020e3ff7ef1fe58296aa860e9397b48557f85d0d0ae327d3be84794ac062528220e4ed9165aa7223e65d37534be71403bd2e3
+  metadata.gz: bbe18332a829d8af9a1dccc3717a7868fc5dad3c64c66320019ade8278689d1080380ece596788917ae31b5afb516a6109b2f5db7ef5e202bfbb909bb485367c
+  data.tar.gz: d5d5a6877d2f29f067eadfb711bd1504bff3fcba172d13840f60c8b7dbf7ba9c17b9d33f82b265626a59f8211da2cbc3c820755c9acb464e471ae98490e8751e

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Change Log
 
+### 1.16.0
+
+* Add test runner name to `KNAPSACK-PRO-CLIENT-NAME` header send to Knapsack Pro API
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/95
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v1.15.0...v1.16.0
+
 ### 1.15.0
 
 * Add support for Codefresh.io CI provider

data/README.md

@@ -42,7 +42,11 @@ The knapsack_pro has also [queue mode](#queue-mode) to get an optimal test suite
 
 ## FAQ
 
-You can see list of questions for common problems and tips in below [Table of Contents](#table-of-contents). Scroll 1 page down and you will see the FAQ in the table of contents.
+__NEW:__ Up to date [FAQ for knapsack_pro gem can be found here](https://knapsackpro.com/faq/knapsack_pro_client/knapsack_pro_ruby).
+
+__OLD:__ This README also contains FAQ questions but we keep adding new info only to our new FAQ page mentioned above.
+
+We keep this old FAQ in README to not break old links spread across the web. You can see old FAQ list of questions for common problems and tips in below [Table of Contents](#table-of-contents). Scroll 1 page down and you will see the FAQ in the table of contents.
 
 # Requirements
 
@@ -175,6 +179,7 @@ You can see list of questions for common problems and tips in below [Table of Co
     - [How to call `before(:suite)` and `after(:suite)` RSpec hooks only once in Queue Mode?](#how-to-call-beforesuite-and-aftersuite-rspec-hooks-only-once-in-queue-mode)
     - [What hooks are supported in Queue Mode?](#what-hooks-are-supported-in-queue-mode)
     - [How to run knapsack_pro with parallel_tests gem?](#how-to-run-knapsack_pro-with-parallel_tests-gem)
+      - [Should I use parallel_tests gem (what are pitfalls)?](#should-i-use-parallel_tests-gem-what-are-pitfalls)
       - [parallel_tests with knapsack_pro on parallel CI nodes](#parallel_tests-with-knapsack_pro-on-parallel-ci-nodes)
       - [parallel_tests with knapsack_pro on single CI machine](#parallel_tests-with-knapsack_pro-on-single-ci-machine)
     - [How to retry failed tests (flaky tests)?](#how-to-retry-failed-tests-flaky-tests)
@@ -869,13 +874,31 @@ end
 # Here is additional configuration to ensure the xml report will be visible by CircleCI
 KnapsackPro::Hooks::Queue.after_queue do |queue_id|
   # Metadata collection
-  # https://circleci.com/docs/1.0/test-metadata/#metadata-collection-in-custom-test-steps
+  # https://circleci.com/docs/2.0/collect-test-data/#metadata-collection-in-custom-test-steps
   if File.exist?(FINAL_RSPEC_XML_REPORT) && ENV['CIRCLE_TEST_REPORTS']
     FileUtils.cp(FINAL_RSPEC_XML_REPORT, "#{ENV['CIRCLE_TEST_REPORTS']}/rspec.xml")
   end
 end
 ```
 
+Ensure you have in CircleCI config yml
+
+```yaml
+- run:
+    name: RSpec via knapsack_pro Queue Mode
+    command: |
+      export CIRCLE_TEST_REPORTS=/tmp/test-results
+      mkdir $CIRCLE_TEST_REPORTS
+      bundle exec rake "knapsack_pro:queue:rspec[--format documentation --format RspecJunitFormatter --out tmp/rspec.xml]"
+
+# collect reports
+- store_test_results:
+    path: /tmp/test-results
+- store_artifacts:
+    path: /tmp/test-results
+    destination: test-results
+```
+
 #### Info for Travis users
 
 You can parallelize your builds across virtual machines with [travis matrix feature](http://docs.travis-ci.com/user/speeding-up-the-build/#parallelizing-your-builds-across-virtual-machines). Edit `.travis.yml`
@@ -1212,7 +1235,7 @@ KNAPSACK_PRO_CI_NODE_TOTAL=2 KNAPSACK_PRO_CI_NODE_INDEX=1 bundle exec rake knaps
 
 Remember to add API tokens like `KNAPSACK_PRO_TEST_SUITE_TOKEN_CUCUMBER` and `KNAPSACK_PRO_TEST_SUITE_TOKEN_RSPEC` to `Environment` page of your project settings in Codeship.
 
-If you want to use Codeship retry single CI node feature to retry just failed tests on particular CI node then you should set [`KNAPSACK_PRO_FIXED_QUEUE_SPLIT=true`](#knapsack_pro_fixed_queue_split-remember-queue-split-on-retry-ci-node).
+CodeShip uses the same build number if you restart a build. Because of that you need to set [`KNAPSACK_PRO_FIXED_QUEUE_SPLIT=true`](#knapsack_pro_fixed_queue_split-remember-queue-split-on-retry-ci-node) in order to be able to restart CI build in Queue Mode.
 
 #### Info for Heroku CI users
 
@@ -2648,6 +2671,23 @@ end
 
 #### How to run knapsack_pro with parallel_tests gem?
 
+##### Should I use parallel_tests gem (what are pitfalls)?
+
+If you plan to use parallel_tests please be careful how many parallel processes with running tests you will start on a single CI node.
+Often it happens that running 2 or more processes with tests using parallel_tests gem on the CI node that has low performance leads to slower execution of test suite. You can accidentally make your whole test suite running slower by using parallel_tests if you have not enough powerful CI server (slow CPU, not enough RAM, slow disk).
+
+If you use parallel_tests and knapsack_pro you can see recorded tests timing in Knapsack Pro [user dashboard](https://knapsackpro.com/dashboard). See the "Build metrics" link next to your API token and check the last recorded CI build time. You will be able to see there how long each test files took to execute. If you notice that after adding parallel_tests gem your test files started to take more time than before it means you overloaded your CI server.
+
+You should:
+
+* reduce the number of parallel processes in parallel_tests gem
+* or buy a more powerful CI node to allow running more parallel processes (vertical scaling)
+* or don't use parallel_tests gem at all (recommended)
+
+In case of tests execution time increase (slower tests) I recommend using more parallel nodes offered by your CI provider to scale your tests horizontally. Basically, adding parallel CI nodes instead of vertically adding more CPU/RAM to CI node is a better option. Parallel_tests gem has mixed output results from the parallel processes so it's easier to just browse tests output from parallel CI nodes when you scale horizontally by using knapsack_pro without parallel_tests.
+
+If you want to use parallel_tests you can use it with Knapsack Pro Queue Mode to auto-balance tests split across parallel processes started by parallel_tests gem. See below tips on how to do it on [many parallel CI nodes where each node starts many parallel_tests processes](#parallel_tests-with-knapsack_pro-on-parallel-ci-nodes) or [on a single powerful CI server](#parallel_tests-with-knapsack_pro-on-single-ci-machine).
+
 ##### parallel_tests with knapsack_pro on parallel CI nodes
 
 You can run knapsack_pro with [parallel_tests](https://github.com/grosser/parallel_tests) gem to run multiple concurrent knapsack_pro commands per CI node.
@@ -2804,7 +2844,7 @@ bundle exec rspec --only-failures
 
 #### How can I run tests from multiple directories?
 
-The test file pattern config option supports any glob pattern handled by [`Dir.glob`](http://ruby-doc.org/core-2.4.1/Dir.html#method-c-glob) and can be configured to pull test files from multiple directories. An example of this when using RSpec would be `""{spec,engines/*/spec}/**/*_spec.rb" "`. For complex cases like this, the test directory can't be extracted and must be specified manually using the `KNAPSACK_PRO_TEST_DIR` environment variable:
+The test file pattern config option supports any glob pattern handled by [`Dir.glob`](http://ruby-doc.org/core-2.4.1/Dir.html#method-c-glob) and can be configured to pull test files from multiple directories. An example of this when using RSpec would be `"{spec,engines/*/spec}/**/*_spec.rb"`. For complex cases like this, the test directory can't be extracted and must be specified manually using the `KNAPSACK_PRO_TEST_DIR` environment variable:
 
 ```
 # This is example where you have in engines directory multiple projects

data/lib/knapsack_pro.rb

@@ -47,17 +47,17 @@ require_relative 'knapsack_pro/test_file_pattern'
 require_relative 'knapsack_pro/test_flat_distributor'
 require_relative 'knapsack_pro/task_loader'
 require_relative 'knapsack_pro/tracker'
-require_relative 'knapsack_pro/allocator'
-require_relative 'knapsack_pro/queue_allocator'
-require_relative 'knapsack_pro/base_allocator_builder'
-require_relative 'knapsack_pro/allocator_builder'
-require_relative 'knapsack_pro/queue_allocator_builder'
 require_relative 'knapsack_pro/adapters/base_adapter'
 require_relative 'knapsack_pro/adapters/rspec_adapter'
 require_relative 'knapsack_pro/adapters/cucumber_adapter'
 require_relative 'knapsack_pro/adapters/minitest_adapter'
 require_relative 'knapsack_pro/adapters/test_unit_adapter'
 require_relative 'knapsack_pro/adapters/spinach_adapter'
+require_relative 'knapsack_pro/allocator'
+require_relative 'knapsack_pro/queue_allocator'
+require_relative 'knapsack_pro/base_allocator_builder'
+require_relative 'knapsack_pro/allocator_builder'
+require_relative 'knapsack_pro/queue_allocator_builder'
 require_relative 'knapsack_pro/runners/base_runner'
 require_relative 'knapsack_pro/runners/rspec_runner'
 require_relative 'knapsack_pro/runners/cucumber_runner'

data/lib/knapsack_pro/base_allocator_builder.rb

@@ -1,7 +1,16 @@
 module KnapsackPro
   class BaseAllocatorBuilder
+    TEST_RUNNER_MAP = {
+      KnapsackPro::Adapters::RSpecAdapter => 'rspec',
+      KnapsackPro::Adapters::CucumberAdapter => 'cucumber',
+      KnapsackPro::Adapters::MinitestAdapter => 'minitest',
+      KnapsackPro::Adapters::SpinachAdapter => 'spinach',
+      KnapsackPro::Adapters::TestUnitAdapter => 'test-unit',
+    }
+
     def initialize(adapter_class)
       @adapter_class = adapter_class
+      ENV['KNAPSACK_PRO_TEST_RUNNER'] = TEST_RUNNER_MAP[adapter_class]
     end
 
     def allocator

data/lib/knapsack_pro/client/connection.rb

@@ -67,11 +67,18 @@ module KnapsackPro
         {
           'Content-Type' => 'application/json',
           'Accept' => 'application/json',
-          'KNAPSACK-PRO-CLIENT-NAME' => 'knapsack_pro-ruby',
+          'KNAPSACK-PRO-CLIENT-NAME' => client_name,
           'KNAPSACK-PRO-CLIENT-VERSION' => KnapsackPro::VERSION,
         }
       end
 
+      def client_name
+        [
+          'knapsack_pro-ruby',
+          ENV['KNAPSACK_PRO_TEST_RUNNER'],
+        ].compact.join('/')
+      end
+
       def parse_response_body(body)
         return '' if body == '' || body.nil?
         JSON.parse(body)

data/lib/knapsack_pro/version.rb

@@ -1,3 +1,3 @@
 module KnapsackPro
-  VERSION = '1.15.0'
+  VERSION = '1.16.0'
 end

data/spec/knapsack_pro/base_allocator_builder_spec.rb

@@ -2,6 +2,62 @@ describe KnapsackPro::BaseAllocatorBuilder do
   let(:adapter_class) { KnapsackPro::Adapters::BaseAdapter }
   let(:allocator_builder) { described_class.new(adapter_class) }
 
+  describe 'initialize method' do
+    context 'when unknown adapter (base adapter)' do
+      let(:adapter_class) { KnapsackPro::Adapters::BaseAdapter }
+
+      it do
+        allocator_builder
+        expect(ENV['KNAPSACK_PRO_TEST_RUNNER']).to be_nil
+      end
+    end
+
+    context 'when RSpec adapter' do
+      let(:adapter_class) { KnapsackPro::Adapters::RSpecAdapter }
+
+      it do
+        allocator_builder
+        expect(ENV['KNAPSACK_PRO_TEST_RUNNER']).to eq 'rspec'
+      end
+    end
+
+    context 'when Cucumber adapter' do
+      let(:adapter_class) { KnapsackPro::Adapters::CucumberAdapter }
+
+      it do
+        allocator_builder
+        expect(ENV['KNAPSACK_PRO_TEST_RUNNER']).to eq 'cucumber'
+      end
+    end
+
+    context 'when Minitest adapter' do
+      let(:adapter_class) { KnapsackPro::Adapters::MinitestAdapter }
+
+      it do
+        allocator_builder
+        expect(ENV['KNAPSACK_PRO_TEST_RUNNER']).to eq 'minitest'
+      end
+    end
+
+    context 'when Spinach adapter' do
+      let(:adapter_class) { KnapsackPro::Adapters::SpinachAdapter }
+
+      it do
+        allocator_builder
+        expect(ENV['KNAPSACK_PRO_TEST_RUNNER']).to eq 'spinach'
+      end
+    end
+
+    context 'when Test::Unit adapter' do
+      let(:adapter_class) { KnapsackPro::Adapters::TestUnitAdapter }
+
+      it do
+        allocator_builder
+        expect(ENV['KNAPSACK_PRO_TEST_RUNNER']).to eq 'test-unit'
+      end
+    end
+  end
+
   describe '#allocator' do
     subject { allocator_builder.allocator }
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 1.15.0
+  version: 1.16.0
 platform: ruby
 authors:
 - ArturT
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-10-11 00:00:00.000000000 Z
+date: 2020-01-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake