knapsack_pro 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cd3738b3ce978cfd66c03f8a3a125bbf243c51ded0ca237d911b39e5e1bd49a1
-  data.tar.gz: b840297f936a9a9d81af47a67795a7287fd69e996449f88291b5c8a7cd6dc5d8
+  metadata.gz: 8608ce6cc56baf7be7b0be2a09c8ecbb0e4f5aa2e0e80ce796284aba9d2fc9bf
+  data.tar.gz: b249d1169e73ecf370d055169189e158b0d0b2cee526540a07eb13b92bb12f6e
 SHA512:
-  metadata.gz: c6b64eef137993948a9ab9e6fd001c2bf55d1a05adeb25d1de46c6548db0cc47505019ee9b0b8da4bf0620944be61639eb4372aef620f9ee976dc64219668b28
-  data.tar.gz: d51a9c073f15feb17455a0151d6e655307be2dbdb16796795b2ef751a66f046040256d6549dd2e27b1a27dcd7789c6160d55a624080d2d71ab97fc085c73ac85
+  metadata.gz: 5868feda23ff81b692ba3053876c3036379e373f77e9004460b29691f18beb35ccbccd32175434f2b98ca8bb973a321f28cd4ac096f346e034a664534b82ccb1
+  data.tar.gz: 76efa329752999c325af61c9479f5b496719b84aac9e0b0de2b8ab4838ebd2303a3ba05951e54adcf1f5eb32d552fb482ac2b9e6a836d0a8780ff1687f9d3384

data/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 * TODO
 
+### 1.0.2
+
+* Track time execution of all tests assigned to CI node in Queue Mode even when they did not run due syntax error or being pending/empty in test run.
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/71
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v1.0.1...v1.0.2
+
 ### 1.0.1
 
 * Fix bug with not being able to set log level via logger wrapper.

data/lib/knapsack_pro/adapters/base_adapter.rb

@@ -31,23 +31,13 @@ module KnapsackPro
         raise NotImplementedError
       end
 
-      def bind_save_queue_report
-        raise NotImplementedError
-      end
-
-      def bind_tracker_reset
-        raise NotImplementedError
-      end
-
       def bind_before_queue_hook
         raise NotImplementedError
       end
 
       def bind_queue_mode
-        bind_tracker_reset
         bind_before_queue_hook
         bind_time_tracker
-        bind_save_queue_report
       end
     end
   end

data/lib/knapsack_pro/adapters/rspec_adapter.rb

@@ -51,22 +51,6 @@ module KnapsackPro
         end
       end
 
-      def bind_save_queue_report
-        ::RSpec.configure do |config|
-          config.after(:suite) do
-            KnapsackPro::Report.save_subset_queue_to_file
-          end
-        end
-      end
-
-      def bind_tracker_reset
-        ::RSpec.configure do |config|
-          config.before(:suite) do
-            KnapsackPro.tracker.reset!
-          end
-        end
-      end
-
       def bind_before_queue_hook
         ::RSpec.configure do |config|
           config.before(:suite) do

data/lib/knapsack_pro/runners/queue/minitest_runner.rb

@@ -59,6 +59,7 @@ module KnapsackPro
             ENV['KNAPSACK_PRO_SUBSET_QUEUE_ID'] = subset_queue_id
 
             KnapsackPro.tracker.reset!
+            KnapsackPro.tracker.set_prerun_tests(test_file_paths)
 
             all_test_file_paths += test_file_paths
 

data/lib/knapsack_pro/runners/queue/rspec_runner.rb

@@ -69,6 +69,9 @@ module KnapsackPro
             subset_queue_id = KnapsackPro::Config::EnvGenerator.set_subset_queue_id
             ENV['KNAPSACK_PRO_SUBSET_QUEUE_ID'] = subset_queue_id
 
+            KnapsackPro.tracker.reset!
+            KnapsackPro.tracker.set_prerun_tests(test_file_paths)
+
             all_test_file_paths += test_file_paths
             cli_args = args + test_file_paths
 
@@ -82,6 +85,8 @@ module KnapsackPro
 
             KnapsackPro::Hooks::Queue.call_after_subset_queue
 
+            KnapsackPro::Report.save_subset_queue_to_file
+
             return {
               status: :next,
               runner: runner,

data/lib/knapsack_pro/tracker.rb

@@ -30,6 +30,16 @@ module KnapsackPro
       @current_test_path.sub(/^\.\//, '')
     end
 
+    def set_prerun_tests(test_file_paths)
+      test_file_paths.each do |test_file_path|
+        # Set a default time for test file
+        # in case when the test file will not be run
+        # due syntax error or being pending.
+        # The time is required by Knapsack Pro API.
+        @test_files_with_time[test_file_path] = 0.1
+      end
+    end
+
     def to_a
       test_files = []
       @test_files_with_time.each do |path, time_execution|

data/lib/knapsack_pro/version.rb

@@ -1,3 +1,3 @@
 module KnapsackPro
-  VERSION = '1.0.1'
+  VERSION = '1.0.2'
 end

data/spec/knapsack_pro/adapters/base_adapter_spec.rb

@@ -48,10 +48,8 @@ describe KnapsackPro::Adapters::BaseAdapter do
       let(:queue_recording_enabled?) { true }
 
       before do
-        allow(subject).to receive(:bind_tracker_reset)
         allow(subject).to receive(:bind_before_queue_hook)
         allow(subject).to receive(:bind_time_tracker)
-        allow(subject).to receive(:bind_save_queue_report)
       end
 
       it do
@@ -59,17 +57,13 @@ describe KnapsackPro::Adapters::BaseAdapter do
         expect(KnapsackPro).to receive(:logger).and_return(logger)
         expect(logger).to receive(:debug).with('Test suite time execution queue recording enabled.')
       end
-      it { expect(subject).to receive(:bind_tracker_reset) }
       it { expect(subject).to receive(:bind_before_queue_hook) }
       it { expect(subject).to receive(:bind_time_tracker) }
-      it { expect(subject).to receive(:bind_save_queue_report) }
     end
 
     context 'when recording disabled' do
-      it { expect(subject).not_to receive(:bind_tracker_reset) }
       it { expect(subject).not_to receive(:bind_time_tracker) }
       it { expect(subject).not_to receive(:bind_save_report) }
-      it { expect(subject).not_to receive(:bind_save_queue_report) }
       it { expect(subject).not_to receive(:bind_before_queue_hook) }
     end
   end
@@ -90,22 +84,6 @@ describe KnapsackPro::Adapters::BaseAdapter do
     end
   end
 
-  describe '#bind_save_queue_report' do
-    it do
-      expect {
-        subject.bind_save_queue_report
-      }.to raise_error(NotImplementedError)
-    end
-  end
-
-  describe '#bind_tracker_reset' do
-    it do
-      expect {
-        subject.bind_tracker_reset
-      }.to raise_error(NotImplementedError)
-    end
-  end
-
   describe '#bind_before_queue_hook' do
     it do
       expect {

data/spec/knapsack_pro/adapters/rspec_adapter_spec.rb

@@ -115,30 +115,6 @@ describe KnapsackPro::Adapters::RSpecAdapter do
       end
     end
 
-    describe '#bind_save_queue_report' do
-      it do
-        expect(config).to receive(:after).with(:suite).and_yield
-        expect(::RSpec).to receive(:configure).and_yield(config)
-
-        expect(KnapsackPro::Report).to receive(:save_subset_queue_to_file)
-
-        subject.bind_save_queue_report
-      end
-    end
-
-    describe '#bind_tracker_reset' do
-      it do
-        expect(config).to receive(:before).with(:suite).and_yield
-        expect(::RSpec).to receive(:configure).and_yield(config)
-
-        tracker = instance_double(KnapsackPro::Tracker)
-        expect(KnapsackPro).to receive(:tracker).and_return(tracker)
-        expect(tracker).to receive(:reset!)
-
-        subject.bind_tracker_reset
-      end
-    end
-
     describe '#bind_before_queue_hook' do
       it do
         expect(config).to receive(:before).with(:suite).and_yield

data/spec/knapsack_pro/runners/queue/minitest_runner_spec.rb

@@ -106,7 +106,10 @@ describe KnapsackPro::Runners::Queue::MinitestRunner do
 
         expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_SUBSET_QUEUE_ID', subset_queue_id)
 
-        expect(KnapsackPro).to receive_message_chain(:tracker, :reset!)
+        tracker = instance_double(KnapsackPro::Tracker)
+        expect(KnapsackPro).to receive(:tracker).twice.and_return(tracker)
+        expect(tracker).to receive(:reset!)
+        expect(tracker).to receive(:set_prerun_tests).with(test_file_paths)
 
         # .minitest_run
         expect(described_class).to receive(:require).with('./a_test.rb')

data/spec/knapsack_pro/runners/queue/rspec_runner_spec.rb

@@ -138,6 +138,11 @@ describe KnapsackPro::Runners::Queue::RSpecRunner do
 
         expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_SUBSET_QUEUE_ID', subset_queue_id)
 
+        tracker = instance_double(KnapsackPro::Tracker)
+        expect(KnapsackPro).to receive(:tracker).twice.and_return(tracker)
+        expect(tracker).to receive(:reset!)
+        expect(tracker).to receive(:set_prerun_tests).with(test_file_paths)
+
         options = double
         expect(RSpec::Core::ConfigurationOptions).to receive(:new).with([
           '--example-arg', 'example-value',
@@ -152,6 +157,8 @@ describe KnapsackPro::Runners::Queue::RSpecRunner do
         expect(described_class).to receive(:rspec_clear_examples)
 
         expect(KnapsackPro::Hooks::Queue).to receive(:call_after_subset_queue)
+
+        expect(KnapsackPro::Report).to receive(:save_subset_queue_to_file)
       end
 
       context 'when exit code is zero' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - ArturT
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-20 00:00:00.000000000 Z
+date: 2018-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake