knapsack_pro 0.7.1 → 0.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c1b41d8fa8f1fbc4132753ff2bed7bd753fa5e70
-  data.tar.gz: 2274a0c7340c7095e1a118a232025df0f54d6995
+  metadata.gz: 2613a884f776c2208358e8118f866e2c05e979ce
+  data.tar.gz: d34a6924e6f52598b2a6dd19d6573a479f0c68aa
 SHA512:
-  metadata.gz: 767bf32a466b2049bdc802d4080da52c80387c375f6ad7c4162eb3042b40e6210f0cfd05543a984fc549c9d2f353c72191e4ef8554651da9a9d5676dd9db72d4
-  data.tar.gz: e16b193127919aa1132fc55746e7ae444b446d6dda38170d59bc8246a9a8f6d5f1d0965e0fca66093ef83aa72475638a195bd588f687d519a877dca0976fb350
+  metadata.gz: 3f7e78a1356322c7a083134bc8b2b8e52e3f0f0177375c59c9a0010fb32a64cf1afce7566fbabf500429d8b69e93c12796438a711afe2d9c1f230f98a9348262
+  data.tar.gz: 90093af068fe34b8a808e7474365617e5f793387732e83e12282b9df08fba57ce8261745c703f39752f69bb0397ee7cf84f158596b10e90c2adacf7192c67cd6

data/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 * TODO
 
+### 0.7.2
+
+* Preserve cucumber latest error message with exit code to fix problem with false positive cucumber failed tests
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/10
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v0.7.1...v0.7.2
+
 ### 0.7.1
 
 * Don't fail when there are no tests to run on a node

data/lib/knapsack_pro/adapters/cucumber_adapter.rb

@@ -41,9 +41,16 @@ module KnapsackPro
         end
       end
 
-      def bind_save_report
+      def bind_save_report(latest_error = nil)
         ::Kernel.at_exit do
+          # $! is latest error message
+          latest_error = (latest_error || $!)
+          exit_status = latest_error.status if latest_error.is_a?(SystemExit)
+          #require 'pry'; binding.pry
+          # saving report makes API call which changes exit status
+          # from cucumber so we need to preserve cucumber exit status
           KnapsackPro::Report.save
+          ::Kernel.exit exit_status if exit_status
         end
       end
 

data/lib/knapsack_pro/version.rb

@@ -1,3 +1,3 @@
 module KnapsackPro
-  VERSION = '0.7.1'
+  VERSION = '0.7.2'
 end

data/spec/knapsack_pro/adapters/cucumber_adapter_spec.rb

@@ -129,6 +129,21 @@ describe KnapsackPro::Adapters::CucumberAdapter do
 
         subject.bind_save_report
       end
+
+      context 'when cucumber tests failed' do
+        let(:exit_status) { double }
+        let(:latest_error) { instance_double(SystemExit, status: exit_status) }
+
+        it 'preserves cucumber latest error message exit status' do
+          expect(::Kernel).to receive(:at_exit).and_yield
+
+          expect(latest_error).to receive(:is_a?).with(SystemExit).and_return(true)
+          expect(KnapsackPro::Report).to receive(:save)
+          expect(::Kernel).to receive(:exit).with(exit_status)
+
+          subject.bind_save_report(latest_error)
+        end
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.7.2
 platform: ruby
 authors:
 - ArturT
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-17 00:00:00.000000000 Z
+date: 2016-05-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake