knapsack_pro 0.46.0 → 0.47.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: faf69acd6fc43b314a341d426e48898c9939eee7
-  data.tar.gz: 92b80713554443d3a82c87f12c839ac874adc75e
+  metadata.gz: 134f144c4fb7cd10705a73ccf858439ee3d9e907
+  data.tar.gz: 4edada383933812bbb739d7f471a28b21530492a
 SHA512:
-  metadata.gz: 8caf5c2763a65260bd56f345c263388da4b8f0ba6df6ee4654f2daf746ef581808bb7c209afa9c49b68671866e35eb743aec45cd12f9318f1b1adcd8ec7ce37c
-  data.tar.gz: f1e17e64c0141d7517e4fa13348b0aadeea4181b727f02a2cfa39c9b3e393bbf3ee9045ab05a4e38c2aff40f71fa91a16e6801fe45f1602b477866d6f15cb7e8
+  metadata.gz: 6ab40a05f0201ce49cc2c184741d31327e2a2ae2317b1895e7e6cba258c53062aa3bb9b8032141c9476f9ed20bb617c2c9fd55c84250cb7eaeec58c63d7d66c9
+  data.tar.gz: 482638d2f37f274b7cc3cc512d8dc24a8e5a6dd562e35c31cc8d373d8b3690cea0a23d1965844ce060d742b3e3493b3557d4118b7b2baef14b77f385efefd3f9

data/CHANGELOG.md

@@ -2,9 +2,18 @@
 
 * TODO
 
+### 0.47.0
+
+* Add in Queue Mode the RSpec summary with info about examples, failures and pending tests.
+* Fix not working message `Global time execution for tests` at end of each subset of tests from work queue.
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/48
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v0.46.0...v0.47.0
+
 ### 0.46.0
 
-* Autoload knapsack_pro rake tasks with Rails Railties
+* Autoload knapsack_pro rake tasks with Rails Railties.
 
     https://github.com/KnapsackPro/knapsack_pro-ruby/pull/47
 

data/lib/knapsack_pro/adapters/base_adapter.rb

@@ -19,6 +19,7 @@ module KnapsackPro
 
         if KnapsackPro::Config::Env.queue_recording_enabled?
           KnapsackPro.logger.debug('Test suite time execution queue recording enabled.')
+          bind_tracker_reset
           bind_before_queue_hook
           bind_time_tracker
           bind_save_queue_report
@@ -37,6 +38,10 @@ module KnapsackPro
         raise NotImplementedError
       end
 
+      def bind_tracker_reset
+        raise NotImplementedError
+      end
+
       def bind_before_queue_hook
         raise NotImplementedError
       end

data/lib/knapsack_pro/adapters/rspec_adapter.rb

@@ -58,6 +58,14 @@ module KnapsackPro
         end
       end
 
+      def bind_tracker_reset
+        ::RSpec.configure do |config|
+          config.before(:suite) do
+            KnapsackPro.tracker.reset!
+          end
+        end
+      end
+
       def bind_before_queue_hook
         ::RSpec.configure do |config|
           config.before(:suite) do

data/lib/knapsack_pro/formatters/rspec_queue_summary_formatter.rb

@@ -10,7 +10,7 @@ module KnapsackPro
     end
 
     class RSpecQueueSummaryFormatter < RSpec::Core::Formatters::BaseFormatter
-      RSpec::Core::Formatters.register self, :dump_failures, :dump_pending
+      RSpec::Core::Formatters.register self, :dump_summary, :dump_failures, :dump_pending
 
       def self.registered_output=(output)
         @registered_output = {
@@ -86,6 +86,21 @@ module KnapsackPro
         return if notification.pending_examples.empty?
         self.class.most_recent_pending = notification.fully_formatted_pending_examples
       end
+
+      def dump_summary(summary)
+        colorizer = ::RSpec::Core::Formatters::ConsoleCodes
+        duration = KnapsackPro.tracker.global_time_since_beginning
+        formatted_duration = ::RSpec::Core::Formatters::Helpers.format_duration(duration)
+
+        formatted = "\nFinished in #{formatted_duration}\n" \
+          "#{summary.colorized_totals_line(colorizer)}\n"
+
+        unless summary.failed_examples.empty?
+          formatted += (summary.colorized_rerun_commands(colorizer) + "\n")
+        end
+
+        self.class.most_recent_summary = formatted
+      end
     end
   end
 end

data/lib/knapsack_pro/report.rb

@@ -12,7 +12,6 @@ module KnapsackPro
 
     def self.save_subset_queue_to_file
       test_files = KnapsackPro.tracker.to_a
-      KnapsackPro.tracker.reset!
 
       subset_queue_id = KnapsackPro::Config::Env.subset_queue_id
 

data/lib/knapsack_pro/tracker.rb

@@ -2,10 +2,11 @@ module KnapsackPro
   class Tracker
     include Singleton
 
-    attr_reader :global_time, :test_files_with_time
+    attr_reader :global_time_since_beginning, :global_time, :test_files_with_time
     attr_writer :current_test_path
 
     def initialize
+      @global_time_since_beginning = 0
       set_defaults
     end
 
@@ -18,10 +19,10 @@ module KnapsackPro
     end
 
     def stop_timer
-      @execution_time = @start_time ? now_without_mock_time.to_f - @start_time : 0.0
-      update_global_time
-      update_test_file_time
-      @execution_time
+      execution_time = @start_time ? now_without_mock_time.to_f - @start_time : 0.0
+      update_global_time(execution_time)
+      update_test_file_time(execution_time)
+      execution_time
     end
 
     def current_test_path
@@ -48,13 +49,14 @@ module KnapsackPro
       @test_path = nil
     end
 
-    def update_global_time
-      @global_time += @execution_time
+    def update_global_time(execution_time)
+      @global_time += execution_time
+      @global_time_since_beginning += execution_time
     end
 
-    def update_test_file_time
+    def update_test_file_time(execution_time)
       @test_files_with_time[current_test_path] ||= 0
-      @test_files_with_time[current_test_path] += @execution_time
+      @test_files_with_time[current_test_path] += execution_time
     end
 
     def now_without_mock_time

data/lib/knapsack_pro/version.rb

@@ -1,3 +1,3 @@
 module KnapsackPro
-  VERSION = '0.46.0'
+  VERSION = '0.47.0'
 end

data/spec/knapsack_pro/adapters/base_adapter_spec.rb

@@ -48,6 +48,7 @@ describe KnapsackPro::Adapters::BaseAdapter do
       let(:queue_recording_enabled?) { true }
 
       before do
+        allow(subject).to receive(:bind_tracker_reset)
         allow(subject).to receive(:bind_before_queue_hook)
         allow(subject).to receive(:bind_time_tracker)
         allow(subject).to receive(:bind_save_queue_report)
@@ -58,12 +59,14 @@ describe KnapsackPro::Adapters::BaseAdapter do
         expect(KnapsackPro).to receive(:logger).and_return(logger)
         expect(logger).to receive(:debug).with('Test suite time execution queue recording enabled.')
       end
+      it { expect(subject).to receive(:bind_tracker_reset) }
       it { expect(subject).to receive(:bind_before_queue_hook) }
       it { expect(subject).to receive(:bind_time_tracker) }
       it { expect(subject).to receive(:bind_save_queue_report) }
     end
 
     context 'when recording disabled' do
+      it { expect(subject).not_to receive(:bind_tracker_reset) }
       it { expect(subject).not_to receive(:bind_time_tracker) }
       it { expect(subject).not_to receive(:bind_save_report) }
       it { expect(subject).not_to receive(:bind_save_queue_report) }
@@ -95,6 +98,14 @@ describe KnapsackPro::Adapters::BaseAdapter do
     end
   end
 
+  describe '#bind_tracker_reset' do
+    it do
+      expect {
+        subject.bind_tracker_reset
+      }.to raise_error(NotImplementedError)
+    end
+  end
+
   describe '#bind_before_queue_hook' do
     it do
       expect {

data/spec/knapsack_pro/adapters/rspec_adapter_spec.rb

@@ -124,6 +124,19 @@ describe KnapsackPro::Adapters::RSpecAdapter do
       end
     end
 
+    describe '#bind_tracker_reset' do
+      it do
+        expect(config).to receive(:before).with(:suite).and_yield
+        expect(::RSpec).to receive(:configure).and_yield(config)
+
+        tracker = instance_double(KnapsackPro::Tracker)
+        expect(KnapsackPro).to receive(:tracker).and_return(tracker)
+        expect(tracker).to receive(:reset!)
+
+        subject.bind_tracker_reset
+      end
+    end
+
     describe '#bind_before_queue_hook' do
       it do
         expect(config).to receive(:before).with(:suite).and_yield

data/spec/knapsack_pro/report_spec.rb

@@ -20,8 +20,7 @@ describe KnapsackPro::Report do
     before do
       test_files = [{path: fake_path}]
       tracker = instance_double(KnapsackPro::Tracker, to_a: test_files)
-      expect(KnapsackPro).to receive(:tracker).twice.and_return(tracker)
-      expect(tracker).to receive(:reset!)
+      expect(KnapsackPro).to receive(:tracker).and_return(tracker)
 
       subset_queue_id = 'fake-subset-queue-id'
       expect(KnapsackPro::Config::Env).to receive(:subset_queue_id).and_return(subset_queue_id)

data/spec/knapsack_pro/tracker_spec.rb

@@ -114,5 +114,9 @@ describe KnapsackPro::Tracker do
     end
 
     it_behaves_like 'default trakcer attributes'
+
+    it "global time since beginning won't be reset" do
+      expect(tracker.global_time_since_beginning).to be >= 0.1
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 0.46.0
+  version: 0.47.0
 platform: ruby
 authors:
 - ArturT
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-12 00:00:00.000000000 Z
+date: 2017-08-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake