knapsack 1.7.0 → 1.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1d9f16bd65a7c6af4fdd57f421108b1f3cc22008
-  data.tar.gz: aca4f9264ed06bc1ca55ba107c4382d05f2821b9
+  metadata.gz: 2b17f8f22c07cec90c96b69733d76b3541e50688
+  data.tar.gz: 52faf95b024af94704b398ed3b20a2020d90d400
 SHA512:
-  metadata.gz: eba6f582a89e2df694accf1b63b9d213c8db0781102276323514c41702837ee1749c775d912df95a5510704adf7ac3518acbd307311ac62475f68002ba867c00
-  data.tar.gz: bc55f58146b90c4acaf835566be3e657341eca9c0653f64c47a908d1151725de4bb17d0cf55e4a28fb692d969870248b2151afcca1efa419b49e76c4a72519d0
+  metadata.gz: 2f6fa8d3d06a1976af851644f6e8c199847117326d1f65bfa1f1e8ae00d3eefb1ee806f04136db8e83aa301033a71c3dd2954d246dbbd6aefc1e1a9865dc21d2
+  data.tar.gz: e4c5859043ef81dab06791948db8b0f1c49f19eb4d6f880354c0a2ddb2d871f96650b84bdfa220f6ee531a55cb14c955b914959c39e1471e03253d43c80f65aa

data/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 * TODO
 
+### 1.8.0
+
+* Add support for older cucumber versions than 1.3
+
+https://github.com/ArturT/knapsack/compare/v1.7.0...v1.8.0
+
 ### 1.7.0
 
 * Add ability to run tests from multiple directories

data/README.md

@@ -72,6 +72,7 @@ Presentations about gem:
   - [How to generate knapsack report?](#how-to-generate-knapsack-report)
   - [What does "leftover specs" mean?](#what-does-leftover-specs-mean)
   - [How can I run tests from multiple directories?](#how-can-i-run-tests-from-multiple-directories)
+  - [How to update existing knapsack report for a few test files?](#how-to-update-existing-knapsack-report-for-a-few-test-files)
 - [Gem tests](#gem-tests)
   - [Spec](#spec)
   - [Spec examples](#spec-examples)
@@ -545,6 +546,10 @@ The test file pattern config option supports any glob pattern handled by [`Dir.g
 
     $ KNAPSACK_TEST_DIR=spec KNAPSACK_TEST_FILE_PATTERN="{spec,engines/**/spec}/**{,/*/**}/*_spec.rb" bundle exec rake knapsack:rspec
 
+### How to update existing knapsack report for a few test files?
+
+You may want to look at monkey patch in [this issue](https://github.com/ArturT/knapsack/issues/34). Take into account that there are some cons of this approach.
+
 ## Gem tests
 
 ### Spec

data/knapsack.gemspec

@@ -24,7 +24,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler', '~> 1.6'
   spec.add_development_dependency 'rspec', '~> 3.0', '>= 2.0.0'
   spec.add_development_dependency 'rspec-its', '~> 1.2'
-  spec.add_development_dependency 'cucumber', '>= 1.3'
+  spec.add_development_dependency 'cucumber', '>= 0'
   spec.add_development_dependency 'minitest', '>= 5.0.0'
   spec.add_development_dependency 'codeclimate-test-reporter', '~> 0'
   spec.add_development_dependency 'pry', '~> 0'

data/lib/knapsack/adapters/cucumber_adapter.rb

@@ -35,11 +35,22 @@ module Knapsack
           test_case = object
           test_case.location.file
         else
-          scenario_or_outline_table = object
-          if scenario_or_outline_table.respond_to?(:file)
-            scenario_or_outline_table.file
+          if object.respond_to?(:scenario_outline)
+            if object.scenario_outline.respond_to?(:feature)
+              # Cucumber < 1.3
+              object.scenario_outline.feature.file
+            else
+              # Cucumber >= 1.3
+              object.scenario_outline.file
+            end
           else
-            scenario_or_outline_table.scenario_outline.file
+            if object.respond_to?(:feature)
+              # Cucumber < 1.3
+              object.feature.file
+            else
+              # Cucumber >= 1.3
+              object.file
+            end
           end
         end
       end

data/lib/knapsack/version.rb

@@ -1,3 +1,3 @@
 module Knapsack
-  VERSION = '1.7.0'
+  VERSION = '1.8.0'
 end

data/spec/knapsack/adapters/cucumber_adapter_spec.rb

@@ -100,20 +100,40 @@ describe Knapsack::Adapters::CucumberAdapter do
 
       before { stub_const('Cucumber::VERSION', '1') }
 
-      context 'when scenario' do
-        let(:scenario_file) { 'features/scenario.feature' }
-        let(:scenario_or_outline_table) { double(file: scenario_file) }
+      context 'when cucumber >= 1.3' do
+        context 'when scenario' do
+          let(:scenario_file) { 'features/scenario.feature' }
+          let(:scenario_or_outline_table) { double(file: scenario_file) }
 
-        it { should eql scenario_file }
+          it { should eql scenario_file }
+        end
+
+        context 'when scenario outline' do
+          let(:scenario_outline_file) { 'features/scenario_outline.feature' }
+          let(:scenario_or_outline_table) do
+            double(scenario_outline: double(file: scenario_outline_file))
+          end
+
+          it { should eql scenario_outline_file }
+        end
       end
 
-      context 'when scenario outline' do
-        let(:scenario_outline_file) { 'features/scenario_outline.feature' }
-        let(:scenario_or_outline_table) do
-          double(scenario_outline: double(file: scenario_outline_file))
+      context 'when cucumber < 1.3' do
+        context 'when scenario' do
+          let(:scenario_file) { 'features/scenario.feature' }
+          let(:scenario_or_outline_table) { double(feature: double(file: scenario_file)) }
+
+          it { should eql scenario_file }
         end
 
-        it { should eql scenario_outline_file }
+        context 'when scenario outline' do
+          let(:scenario_outline_file) { 'features/scenario_outline.feature' }
+          let(:scenario_or_outline_table) do
+            double(scenario_outline: double(feature: double(file: scenario_outline_file)))
+          end
+
+          it { should eql scenario_outline_file }
+        end
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack
 version: !ruby/object:Gem::Version
-  version: 1.7.0
+  version: 1.8.0
 platform: ruby
 authors:
 - ArturT
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-11 00:00:00.000000000 Z
+date: 2016-04-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -92,14 +92,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement