knapsack 1.3.3 → 1.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0974720e7e8e9f9aa97785ba24e51c894659e169
-  data.tar.gz: 80ce683d5dcc6347686ae8b632fe428da6273d75
+  metadata.gz: d3884defa102a784ebc24edee1f7f0bce15e47c2
+  data.tar.gz: 54a6980e2ae231d9048a5d864a345995af50bba9
 SHA512:
-  metadata.gz: cda9a461a9b1916bbcc228ec35ca9d0181d2200c2b756dee6ae5d251c4a72b89598f874c3b04d206aadcdc3391f704cea8415acf968ceeb3805417a542ab0208
-  data.tar.gz: bfc05588f5864fa8879029f1a2f8783501b29d953e1fbe41161000852493e04a2bbd0f51f2a4672795792a5a815831517dc1aaacab61fe0b59da247f2fb58f80
+  metadata.gz: 99669c6406a29636495159672d56dfe176ed4573c690929e18a8b092c54b269408ca3eecc76b005a6a5842d34496d08bb8cdcb644af01feeaca38d7deca87409
+  data.tar.gz: f09fbc5afeac38e7ec5a943e3527c049fb2f7b77c2df42dff9967f0db4840fb17a681fcbe052546ab36be9aaf6544648ecc1610b06cd7c816d20441358790a22

data/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 * TODO
 
+### 1.3.4
+
+* Make knapsack backwards compatible with earlier version of minitest
+
+    https://github.com/ArturT/knapsack/pull/26
+
+https://github.com/ArturT/knapsack/compare/v1.3.3...v1.3.4
+
 ### 1.3.3
 
 * Fix wrong dependency for timecop

data/lib/knapsack/adapters/minitest_adapter.rb

@@ -23,20 +23,20 @@ module Knapsack
       def bind_time_tracker
         ::Minitest::Test.send(:include, BindTimeTrackerMinitestPlugin)
 
-        ::Minitest.after_run do
+        add_post_run_callback do
           Knapsack.logger.info(Presenter.global_time)
         end
       end
 
       def bind_report_generator
-        Minitest.after_run do
+        add_post_run_callback do
           Knapsack.report.save
           Knapsack.logger.info(Presenter.report_details)
         end
       end
 
       def bind_time_offset_warning
-        Minitest.after_run do
+        add_post_run_callback do
           Knapsack.logger.warn(Presenter.time_offset_warning)
         end
       end
@@ -47,7 +47,8 @@ module Knapsack
       end
 
       def self.test_path(obj)
-        test_method_name = obj.name
+        # Pick the first public method in the class itself, that starts with "test_"
+        test_method_name = obj.public_methods(false).select{|m| m =~ /^test_/ }.first
         method_object = obj.method(test_method_name)
         full_test_path = method_object.source_location.first
         parent_of_test_dir_regexp = Regexp.new("^#{@@parent_of_test_dir}")
@@ -55,6 +56,16 @@ module Knapsack
         # test_path will look like ./test/dir/unit_test.rb
         test_path
       end
+
+      private
+
+      def add_post_run_callback(&block)
+        if Minitest.respond_to?(:after_run)
+          Minitest.after_run { block.call }
+        else
+          Minitest::Unit.after_tests { block.call }
+        end
+      end
     end
   end
 end

data/lib/knapsack/runners/cucumber_runner.rb

@@ -15,7 +15,7 @@ module Knapsack
         cmd = %Q[bundle exec cucumber #{args} -- #{allocator.stringify_node_tests}]
 
         system(cmd)
-        exit($?.exitstatus) unless $?.exitstatus == 0
+        exit($?.exitstatus) unless $?.exitstatus.zero?
       end
     end
   end

data/lib/knapsack/runners/rspec_runner.rb

@@ -15,7 +15,7 @@ module Knapsack
         cmd = %Q[bundle exec rspec #{args} --default-path #{allocator.test_dir} -- #{allocator.stringify_node_tests}]
 
         system(cmd)
-        exit($?.exitstatus) unless $?.exitstatus == 0
+        exit($?.exitstatus) unless $?.exitstatus.zero?
       end
     end
   end

data/lib/knapsack/version.rb

@@ -1,3 +1,3 @@
 module Knapsack
-  VERSION = '1.3.3'
+  VERSION = '1.3.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack
 version: !ruby/object:Gem::Version
-  version: 1.3.3
+  version: 1.3.4
 platform: ruby
 authors:
 - ArturT
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-19 00:00:00.000000000 Z
+date: 2015-10-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake