knapsack 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4dd54024c966f2cff5fab7934d6aa1c255297cdc
-  data.tar.gz: f797b4b30cea8498d98c0dc89af3a41426979e62
+  metadata.gz: b3792c60ac290034623012572800ec6f0785dca5
+  data.tar.gz: e5a54f8845f9461dabab4b6a5c4a58852c23b624
 SHA512:
-  metadata.gz: 9bf63ca1824864e3148af5244ac357055320f22daf1180768b1dc922a058a05265e9d3b3f70c2ea60d4f23e92349dacb2f49cb9cc03f23cf7b633500202c729a
-  data.tar.gz: 2a88cb3402e1791a3e03c00af64a0872d099945c82f90c6a0ac8894c23a79a40062ea57984b6b2cba1ce57d17d742136d84db48b5b90d7b6786c9c9001e53985
+  metadata.gz: d32a7b3290080f0e9fd3d33b8b9be720118773fd64aea1ddcd9f680894cc53cf33ef2b760772984b28698f5de7d554ec3af31fb78f6ea898b20e324b8a2f95cc
+  data.tar.gz: f04e7db28903d5aed5a88beed25db026c9fcfc03da9f769bde58c32bc797962073a28e7b61094e1423eadde5515d11f9a9ce2a62ab01a5bbd0bf72073127f491

data/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 * TODO
 
+### 1.3.1
+
+* Treat KNAPSACK_GENERATE_REPORT=false as generate_report -> false
+
+    https://github.com/ArturT/knapsack/pull/22
+
+https://github.com/ArturT/knapsack/compare/v1.3.0...v1.3.1
+
 ### 1.3.0
 
 * Add knapsack binary

data/README.md

@@ -179,6 +179,10 @@ Commit generated report `knapsack_rspec_report.json`, `knapsack_cucumber_report.
 
 This report should be updated only after you add a lot of new slow tests or you change existing ones which causes a big time execution difference between CI nodes. Either way, you will get time offset warning at the end of the rspec/cucumber/minitest results which reminds you when it’s a good time to regenerate the knapsack report.
 
+`KNAPSACK_GENERATE_REPORT` is truthy when `"true"` or `0`.  All other values are falsy, though
+[`"false"`, and `1` are semantically
+preferrable](https://en.wikipedia.org/wiki/True_and_false_(commands)).
+
 #### Adding or removing tests
 
 There is no need to regenerate the report every time when you add/remove test file. If you remove a test file then Knapsack will ignore its entry in report. In case when you add a new file and it doesn't already exist in report, the test file will be assigned to one of the CI node.

data/lib/knapsack/config/tracker.rb

@@ -11,7 +11,7 @@ module Knapsack
         end
 
         def generate_report
-          ENV['KNAPSACK_GENERATE_REPORT'] || false
+          !!(ENV['KNAPSACK_GENERATE_REPORT'] =~ /\Atrue|0\z/i)
         end
       end
     end

data/lib/knapsack/tracker.rb

@@ -80,8 +80,6 @@ module Knapsack
       })
     end
 
-    private
-
     def now_without_mock_time
       if defined?(Timecop)
         Time.now_without_mock_time

data/lib/knapsack/version.rb

@@ -1,3 +1,3 @@
 module Knapsack
-  VERSION = '1.3.0'
+  VERSION = '1.3.1'
 end

data/spec/knapsack/config/tracker_spec.rb

@@ -13,8 +13,35 @@ describe Knapsack::Config::Tracker do
     subject { described_class.generate_report }
 
     context 'when ENV exists' do
-      before { stub_const("ENV", { 'KNAPSACK_GENERATE_REPORT' => true }) }
-      it { should be true }
+      it 'should be true when KNAPSACK_GENERATE_REPORT=true' do
+        with_env 'KNAPSACK_GENERATE_REPORT' => 'true' do
+          expect(subject).to eq(true)
+        end
+      end
+
+      it 'should be true when KNAPSACK_GENERATE_REPORT=0' do
+        with_env 'KNAPSACK_GENERATE_REPORT' => '0' do
+          expect(subject).to eq(true)
+        end
+      end
+
+      it 'should be false when KNAPSACK_GENERATE_REPORT is ""' do
+        with_env 'KNAPSACK_GENERATE_REPORT' => '' do
+          expect(subject).to eq(false)
+        end
+      end
+
+      it 'should be false when KNAPSACK_GENERATE_REPORT is "false"' do
+        with_env 'KNAPSACK_GENERATE_REPORT' => 'false' do
+          expect(subject).to eq(false)
+        end
+      end
+
+      it 'should be false when KNAPSACK_GENERATE_REPORT is not "true" or "0"' do
+        with_env 'KNAPSACK_GENERATE_REPORT' => '1' do
+          expect(subject).to eq(false)
+        end
+      end
     end
 
     context "when ENV doesn't exist" do

data/spec/knapsack/tracker_spec.rb

@@ -9,12 +9,8 @@ describe Knapsack::Tracker do
   it_behaves_like 'default trakcer attributes'
 
   describe '#config' do
-    before do
-      stub_const("ENV", { 'KNAPSACK_GENERATE_REPORT' => generate_report })
-    end
-
     context 'when passed options' do
-      let(:generate_report) { true }
+      let(:generate_report) { 'true' }
       let(:opts) do
         {
           enable_time_offset_warning: false,
@@ -23,12 +19,14 @@ describe Knapsack::Tracker do
       end
 
       it do
-        expect(tracker.config(opts)).to eql({
-          enable_time_offset_warning: false,
-          time_offset_in_seconds: 30,
-          generate_report: true,
-          fake: true
-        })
+        with_env 'KNAPSACK_GENERATE_REPORT' => generate_report do
+          expect(tracker.config(opts)).to eql({
+            enable_time_offset_warning: false,
+            time_offset_in_seconds: 30,
+            generate_report: true,
+            fake: true
+          })
+        end
       end
     end
 
@@ -121,13 +119,6 @@ describe Knapsack::Tracker do
     let(:test_paths) { ['a_spec.rb', 'b_spec.rb'] }
     let(:delta) { 0.02 }
 
-    shared_examples 'test tracker' do
-      it { expect(tracker.global_time).to be_within(delta).of(0.3) }
-      it { expect(tracker.test_files_with_time.keys.size).to eql 2 }
-      it { expect(tracker.test_files_with_time['a_spec.rb']).to be_within(delta).of(0.1) }
-      it { expect(tracker.test_files_with_time['b_spec.rb']).to be_within(delta).of(0.2) }
-    end
-
     context 'without Timecop' do
       before do
         test_paths.each_with_index do |test_path, index|

data/spec/support/env_helper.rb

@@ -0,0 +1,13 @@
+module EnvHelper
+  def with_env(vars)
+    original = ENV.to_hash
+    vars.each { |k, v| ENV[k] = v }
+
+    begin
+      yield
+    ensure
+      ENV.replace(original)
+    end
+  end
+end
+RSpec.configuration.include EnvHelper

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - ArturT
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-20 00:00:00.000000000 Z
+date: 2015-09-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -202,8 +202,9 @@ files:
 - spec/knapsack/tracker_spec.rb
 - spec/knapsack_spec.rb
 - spec/spec_helper.rb
-- spec/support/mocks/cucumber.rb
-- spec/support/mocks/minitest.rb
+- spec/support/env_helper.rb
+- spec/support/fakes/cucumber.rb
+- spec/support/fakes/minitest.rb
 - spec/support/shared_examples/adapter.rb
 - spec_examples/fast/1_spec.rb
 - spec_examples/fast/2_spec.rb
@@ -243,7 +244,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: Knapsack splits tests across CI nodes and makes sure that tests will run
@@ -267,6 +268,7 @@ test_files:
 - spec/knapsack/tracker_spec.rb
 - spec/knapsack_spec.rb
 - spec/spec_helper.rb
-- spec/support/mocks/cucumber.rb
-- spec/support/mocks/minitest.rb
+- spec/support/env_helper.rb
+- spec/support/fakes/cucumber.rb
+- spec/support/fakes/minitest.rb
 - spec/support/shared_examples/adapter.rb