knapsack 1.11.0 → 1.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 586b4f20bd1e8eeaa8cecd582028c38bbda68798
-  data.tar.gz: ba890d94aeb726731268b2138c81106c8d1dd21b
+  metadata.gz: 9707d40522261fe0ed81e7e607b6fb46ed220703
+  data.tar.gz: 6ffe1d23a0ab0e1b373989d9042469799fe339f9
 SHA512:
-  metadata.gz: 0d826026f771d18064f2fc0c4fd48f41b0193d015f1c655bee098c8e887665271245ef1293140347a49ebb93b1b34868ed05f1c1ff5342374eb6dd8bc8c80d1f
-  data.tar.gz: f92c71f48e7a86142903714034d2e1e6a08412592159e544159d89b01bc3841008d173d2fe461ab6597961533d2c8e9ec246f163b7cec046dc86d65075c1784c
+  metadata.gz: 74bb98c429c28db932d514d8090042a55767834949fc1a219d69334a9582474f4a5e195020a03b8ada025815d62ab5cf7e74081a2dd8344d734e3ab43ec30354
+  data.tar.gz: 2c640c9d958f91fab219f040b1a87b9e27664b999b23742b701c342b565d72abf7b4a0dcf86e22313e351ff35eae847916155702d5230bea00ffd94e66576083

data/CHANGELOG.md

@@ -2,6 +2,15 @@
 
 * TODO
 
+### 1.11.1
+
+* Require spinach in spec helper so tests will pass but don't require it in spinach adapter because it breaks for users who don't use spinach and they don't want to add it to their Gemfile
+
+    Related PR:
+    https://github.com/ArturT/knapsack/pull/41
+
+https://github.com/ArturT/knapsack/compare/v1.11.0...v1.11.1
+
 ### 1.11.0
 
 * Add support for Spinach

data/lib/knapsack/adapters/cucumber_adapter.rb

@@ -34,7 +34,7 @@ module Knapsack
       end
 
       def self.test_path(object)
-        if Cucumber::VERSION.to_i >= 2
+        if ::Cucumber::VERSION.to_i >= 2
           test_case = object
           test_case.location.file
         else

data/lib/knapsack/adapters/spinach_adapter.rb

@@ -1,5 +1,3 @@
-require 'spinach'
-
 module Knapsack
   module Adapters
     class SpinachAdapter < BaseAdapter
@@ -7,29 +5,29 @@ module Knapsack
       REPORT_PATH = 'knapsack_spinach_report.json'
 
       def bind_time_tracker
-        Spinach.hooks.before_scenario do |scenario_data, step_definitions|
+        ::Spinach.hooks.before_scenario do |scenario_data, step_definitions|
           Knapsack.tracker.test_path = SpinachAdapter.test_path(scenario_data)
           Knapsack.tracker.start_timer
         end
 
-        Spinach.hooks.after_scenario do
+        ::Spinach.hooks.after_scenario do
           Knapsack.tracker.stop_timer
         end
 
-        Spinach.hooks.after_run do
+        ::Spinach.hooks.after_run do
           Knapsack.logger.info(Presenter.global_time)
         end
       end
 
       def bind_report_generator
-        Spinach.hooks.after_run do
+        ::Spinach.hooks.after_run do
           Knapsack.report.save
           Knapsack.logger.info(Presenter.report_details)
         end
       end
 
       def bind_time_offset_warning
-        Spinach.hooks.after_run do
+        ::Spinach.hooks.after_run do
           Knapsack.logger.log(
             Presenter.time_offset_log_level,
             Presenter.time_offset_warning

data/lib/knapsack/version.rb

@@ -1,3 +1,3 @@
 module Knapsack
-  VERSION = '1.11.0'
+  VERSION = '1.11.1'
 end

data/spec/spec_helper.rb

@@ -1,4 +1,5 @@
 require 'rspec/its'
+require 'spinach'
 
 require 'timecop'
 Timecop.safe_mode = true

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: knapsack
 version: !ruby/object:Gem::Version
-  version: 1.11.0
+  version: 1.11.1
 platform: ruby
 authors:
 - ArturT