knapsack 1.0.3 → 1.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7c687c34dd940bdf5c7594c114be9332548944ff
-  data.tar.gz: 38a10eaa09e1b6b87d4110a5c6173997f6dd73f2
+  metadata.gz: e248debc4bc1dd04e46fe1be7ed75a54d245b782
+  data.tar.gz: 084848b68ebf859224d460bc74684cbc4d3b5c98
 SHA512:
-  metadata.gz: 4f4784ef9d81e7b1110269a1b280fdc7fd9b4ce8c16c08612c91a6524754d4e1c35a9fe88512b7d5512d03c26423bd70d2bea7eea15949b06d7eebb728800077
-  data.tar.gz: 6121b44a1c65b71d0a3c44478889cdfd80104448defcefe1b65f0a294b03fb38d6cfb4742e759bc4162ca71d8e54c25375fcb1578a224c87f527d05b7f831cb3
+  metadata.gz: 2acdbf01e8c49ac212a82013a8a6295b891d69b557960f40a0f5152bf0d5d7cfea06e748a7e318e54588f40c196b003c6f51208d3f79a032675075e2cc69cddb
+  data.tar.gz: 0048c16e8d0bcf0ee4d1333f25e8f346b95f76ea7eab9b182d7599c20943172fdd2e25123b3912284212df3031f128d853785e845809779760cc928e0ea3438d

data/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 * TODO
 
+### 1.0.4
+
+* Pull request #12 - Raise error when CI_NODE_INDEX >= CI_NODE_TOTAL
+
+    https://github.com/ArturT/knapsack/pull/12
+
 ### 1.0.3
 
 * Fix bug #11 - Track properly time when using Timecop gem in tests.

data/lib/knapsack/distributors/base_distributor.rb

@@ -8,6 +8,10 @@ module Knapsack
         @test_file_pattern = args[:test_file_pattern] || raise('Missing test_file_pattern')
         @ci_node_total = args[:ci_node_total] || raise('Missing ci_node_total')
         @ci_node_index = args[:ci_node_index] || raise('Missing ci_node_index')
+
+        if ci_node_index >= ci_node_total
+          raise("Node indexes are 0-based. Can't be higher or equal to the total number of nodes.")
+        end
       end
 
       def ci_node_total

data/lib/knapsack/version.rb

@@ -1,3 +1,3 @@
 module Knapsack
-  VERSION = '1.0.3'
+  VERSION = '1.0.4'
 end

data/spec/knapsack/distributors/base_distributor_spec.rb

@@ -49,6 +49,22 @@ describe Knapsack::Distributors::BaseDistributor do
       let(:custom_args) { { ci_node_index: nil } }
       it { expect { subject }.to raise_error('Missing ci_node_index') }
     end
+
+    context 'when ci_node_index has not allowed value' do
+      let(:expected_exception_message) do
+        "Node indexes are 0-based. Can't be higher or equal to the total number of nodes."
+      end
+
+      context 'when ci_node_index is equal to ci_node_total' do
+        let(:custom_args) { { ci_node_index: 1, ci_node_total: 1 } }
+        it { expect { subject }.to raise_error(expected_exception_message) }
+      end
+
+      context 'when ci_node_index is higher than ci_node_total' do
+        let(:custom_args) { { ci_node_index: 2, ci_node_total: 1 } }
+        it { expect { subject }.to raise_error(expected_exception_message) }
+      end
+    end
   end
 
   describe '#tests_for_current_node' do

data/spec/knapsack/tracker_spec.rb

@@ -161,7 +161,7 @@ describe Knapsack::Tracker do
         end
       end
 
-      it { expect(tracker.global_time).to be >= 0 }
+      it { expect(tracker.global_time).to be > 0 }
       it { expect(tracker.global_time).to be_within(delta).of(0) }
       it { expect(tracker.test_files_with_time.keys.size).to eql 2 }
       it { expect(tracker.test_files_with_time['a_spec.rb']).to be_within(delta).of(0) }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.4
 platform: ruby
 authors:
 - ArturT
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-09 00:00:00.000000000 Z
+date: 2015-02-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler