knapsack 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b9c0c3f2c4c9ade9a8b93a9285ae2ec1fef1810f
-  data.tar.gz: ba827b1b39aa68a0df7052f579d635dc91331700
+  metadata.gz: 4e3602511178e7e6b3bb0168469029544f340147
+  data.tar.gz: 1fb89b2f440839a87138c1ae76d6da189b3d4543
 SHA512:
-  metadata.gz: 210967c7a39fb22ee932848d362b15356173270e62e58cd427fecc9b4d6e732dfee5a4501d4947440d13a134b9a149e38bb160ebf052ef577dfaf24e978a533a
-  data.tar.gz: 76ad4ccb462dd2e732add681a6db6274b300866fe4ef58266e812914c768ced59e88bbac60d1cf6f7e92a8c0c69ebbb9635d0ffca3d83dd3e71718b6eb60f225
+  metadata.gz: 0806c636f359a05c237b87d5b552b685223913fc864ce34681603858b572e6cd033239f1439d22374fdfbe3e0c830376dc03b518947dcfd5b29c9f51fdb429c7
+  data.tar.gz: 90d5fdb32e0518574cc2aa1de6ab5d29f7733530e348b0ee34d37f0c560afdb1ee73935c1c0f32b0037c8093361b8d25c2129e93862b87ccc9f63d3fc9168665

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 * TODO
 
+### 0.1.3
+
+* Better time presentation instead of seconds.
+
 ### 0.1.2
 
 * Fix case when someone removes spec file which exists in knapsack report.

data/TODO.md

@@ -1,5 +1,5 @@
 # TODO
 
-* Add other adapters than RSpec.
+* Add other adapters and rake tasks than RSpec.
 * Add support for ENV CI node total and CI node index other than CircleCI.
 

data/lib/knapsack/presenter.rb

@@ -17,7 +17,8 @@ module Knapsack
       end
 
       def global_time
-        "\nKnapsack global time execution for specs: #{Knapsack.tracker.global_time}s"
+        global_time = pretty_seconds(Knapsack.tracker.global_time)
+        "\nKnapsack global time execution for specs: #{global_time}"
       end
 
       def time_offset
@@ -25,11 +26,13 @@ module Knapsack
       end
 
       def max_allowed_node_time_execution
-        "Max allowed node time execution: #{Knapsack.tracker.max_node_time_execution}s"
+        max_node_time_execution = pretty_seconds(Knapsack.tracker.max_node_time_execution)
+        "Max allowed node time execution: #{max_node_time_execution}"
       end
 
       def exceeded_time
-        "Exceeded time: #{Knapsack.tracker.exceeded_time}s"
+        exceeded_time = pretty_seconds(Knapsack.tracker.exceeded_time)
+        "Exceeded time: #{exceeded_time}"
       end
 
       def time_offset_warning
@@ -52,6 +55,10 @@ Happy testing!}
         str << "\n=================================================\n"
         str
       end
+
+      def pretty_seconds(seconds)
+        Time.at(seconds).gmtime.strftime('%Hh %Mm %Ss').gsub(/00(h|m|s)/, '').strip
+      end
     end
   end
 end

data/lib/knapsack/version.rb

@@ -1,3 +1,3 @@
 module Knapsack
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'
 end

data/spec/knapsack/presenter_spec.rb

@@ -29,10 +29,10 @@ describe Knapsack::Presenter do
 
     before do
       expect(Knapsack).to receive(:tracker) { tracker }
-      expect(tracker).to receive(:global_time).and_return(4.2)
+      expect(tracker).to receive(:global_time).and_return(60*62+3)
     end
 
-    it { should eql "\nKnapsack global time execution for specs: 4.2s" }
+    it { should eql "\nKnapsack global time execution for specs: 01h 02m 03s" }
   end
 
   describe '.report_details' do
@@ -62,8 +62,8 @@ describe Knapsack::Presenter do
 
     shared_examples 'knapsack time offset warning' do
       it { should include 'Time offset: 30s' }
-      it { should include 'Max allowed node time execution: 60s' }
-      it { should include 'Exceeded time: 3s' }
+      it { should include 'Max allowed node time execution: 01m' }
+      it { should include 'Exceeded time: 03s' }
     end
 
     context 'when time exceeded' do
@@ -80,4 +80,33 @@ describe Knapsack::Presenter do
       it { should include 'Global time execution for this CI node is fine.' }
     end
   end
+
+  describe '.pretty_seconds' do
+    subject { described_class.pretty_seconds(seconds) }
+
+    context 'when only seconds' do
+      let(:seconds) { 5 }
+      it { should eql '05s' }
+    end
+
+    context 'when only minutes' do
+      let(:seconds) { 120 }
+      it { should eql '02m' }
+    end
+
+    context 'when only hours' do
+      let(:seconds) { 60*60*3 }
+      it { should eql '03h' }
+    end
+
+    context 'when minutes and seconds' do
+      let(:seconds) { 180+9 }
+      it { should eql '03m 09s' }
+    end
+
+    context 'when all' do
+      let(:seconds) { 60*60*4+120+7 }
+      it { should eql '04h 02m 07s' }
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - ArturT
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-12 00:00:00.000000000 Z
+date: 2014-07-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler