kitty_policy 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 36bb0e98df928a03bb4e18761f8e23e7b7868da05d15bb70f81425d76f936da1
-  data.tar.gz: 6a00a72433c6cc7016f5d62427395d52914bab78fea76e2cdd1faf3b6f526924
+  metadata.gz: '0159e69ff0c1cd85d24083361b3bcc707159b4999e3dd4a2282ecfae44d29168'
+  data.tar.gz: f5f5cf029c27f6f5994447c3076da6f25ac679addddef3d27e9a56114fc78ae6
 SHA512:
-  metadata.gz: fc35eeb00ba8e1ec5d43ed4a20fa710fc2e1c347dea3d3f8424809f8eaf5a80300a99bb760d08660cb3ae5a9a32909fd61e6e2336bf95df27af3fdc59f5219ee
-  data.tar.gz: 81905f36f0b2cc4f2b007b53b5599d05f9be8777818a713706ec93c687fad1fcb76a9f49f27a651c2542e1323c4e389219ea2129e870b0e2d5f97a93d9bd7c2a
+  metadata.gz: 52573700c0ab4b4e2128125394e90861499e45aed9bd9fb9996dd8053c0b1db5372e5e0d0981cf04749c65c038251029ab6a3e074b4d4789912c55966db05237
+  data.tar.gz: 0fabbfd1c4bcb1fe472fafd1dfc4911e718191b6a5c518f5b73712aa99e3be719ce1a8517a89c0447a9a36e9af2d95a33e15b40d5db2976af28f8db9b1daaacb

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## Version 0.1.3
+
+* **[feature]** Added `authorize_object` for field authorization (@tgroutars)
+  - *no support for connections and arrays*
+
 ## Version 0.1.2
 
 * **[fix]** Allow `fallback: []` to work for Relay connections (@rstankov)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    kitty_policy (0.1.2)
+    kitty_policy (0.1.3)
 
 GEM
   remote: https://rubygems.org/
@@ -14,7 +14,7 @@ GEM
     parser (2.6.3.0)
       ast (~> 2.4.0)
     rainbow (3.0.0)
-    rake (10.5.0)
+    rake (13.0.1)
     rspec (3.8.0)
       rspec-core (~> 3.8.0)
       rspec-expectations (~> 3.8.0)
@@ -47,7 +47,7 @@ DEPENDENCIES
   bundler (~> 2.0)
   graphql (~> 1.8)
   kitty_policy!
-  rake (~> 10.0)
+  rake (~> 13.0)
   rspec (~> 3.8)
   rspec-mocks (~> 3.8)
   rubocop (= 0.72.0)

data/README.md

@@ -8,9 +8,9 @@ Minimalistic authorization library extracted from [Product Hunt](https://www.pro
 
 Features:
 
-* small DSL for defining abilities
-* not class initializations when performing abilities check
-* integrations with [GraphQL gem](https://rubygems.org/gems/graphql).
+- small DSL for defining abilities
+- not class initializations when performing abilities check
+- integrations with [GraphQL gem](https://rubygems.org/gems/graphql).
 
 ## Installation
 
@@ -190,6 +190,32 @@ module Types
 end
 ```
 
+```ruby
+module Types
+  class QueryType < BaseObject
+    # With fallback, same as:
+    # if ApplicationPolicy.can?(context[:current_user], :view, post)
+    #   return post
+    # else
+    #   return nil
+    # end
+    field :post, PostType, null: false, authorize_object: :view, fallback: nil do
+      argument :id, ID, required: true
+    end
+
+    # Without fallback, same as:
+    # if ApplicationPolicy.can?(context[:current_user], :view, post)
+    #   return post
+    # else
+    #   raise KittyPolicy::AccessDenied(context[:current_user], :view, post)
+    # end
+    field :post, PostType, null: false, authorize_object: :view do
+      argument :id, ID, required: true
+    end
+  end
+end
+```
+
 #### Can resolver
 
 Exposes if current user can perform certain action.

data/kitty_policy.gemspec

@@ -30,7 +30,7 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency 'bundler', '~> 2.0'
   spec.add_development_dependency 'graphql', '~> 1.8'
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rake', '~> 13.0'
   spec.add_development_dependency 'rspec', '~> 3.8'
   spec.add_development_dependency 'rspec-mocks', '~> 3.8'
   spec.add_development_dependency 'rubocop', '0.72.0'

data/lib/kitty_policy/graphql/field_authorization.rb

@@ -9,8 +9,15 @@ module KittyPolicy
       end
 
       def instrument(_type, field)
-        return field unless field.metadata.key?(:authorize)
+        return instrument_with_authorize(field) if field.metadata.key?(:authorize)
+        return instrument_with_authorize_object(field) if field.metadata.key?(:authorize_object)
 
+        field
+      end
+
+      private
+
+      def instrument_with_authorize(field)
         policy = @policy
         current_user_key = @current_user_key
 
@@ -40,6 +47,31 @@ module KittyPolicy
           resolve new_resolve
         end
       end
+
+      def instrument_with_authorize_object(field)
+        raise "Can't use `authorize_object` on a connection" if field.connection?
+        raise "Can't use `authorize_object` on an array" if field.type.list?
+
+        policy = @policy
+        current_user_key = @current_user_key
+
+        old_resolve = field.resolve_proc
+        new_resolve = lambda do |type_or_object, arguments, context|
+          object = old_resolve.call(type_or_object, arguments, context)
+          if object.nil?
+            object
+          elsif field.metadata.key?(:fallback)
+            policy.can?(context[current_user_key], field.metadata[:authorize_object], object) ? object : field.metadata[:fallback]
+          else
+            policy.authorize!(context[current_user_key], field.metadata[:authorize_object], object)
+            object
+          end
+        end
+
+        field.redefine do
+          resolve new_resolve
+        end
+      end
     end
 
     class AssignFallbackKey
@@ -60,10 +92,12 @@ if defined?(::GraphQL::Field)
   ::GraphQL::Field.accepts_definitions(
     fallback: KittyPolicy::GraphQL::AssignFallbackKey.new(:fallback),
     authorize: GraphQL::Define.assign_metadata_key(:authorize),
+    authorize_object: GraphQL::Define.assign_metadata_key(:authorize_object),
   )
 end
 
 if defined?(::GraphQL::Schema::Field)
   ::GraphQL::Schema::Field.accepts_definition(:fallback)
   ::GraphQL::Schema::Field.accepts_definition(:authorize)
+  ::GraphQL::Schema::Field.accepts_definition(:authorize_object)
 end

data/lib/kitty_policy/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module KittyPolicy
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kitty_policy
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Radoslav Stankov
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-03-04 00:00:00.000000000 Z
+date: 2020-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement