kindle_highlights_api 0.2.3 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 31a28a034f72cd65578f891e4b31b80bb306bf30
-  data.tar.gz: a3dde5c6f549b6bfa44fe4ec351f92c50bc68e6b
+  metadata.gz: d88880472a411d98de9d6c577f557a1f9a78c1b2
+  data.tar.gz: 935b5303889bfb1ceeb38fbb134eef2ea7852288
 SHA512:
-  metadata.gz: c4b231326438932d45dcb7821704d129f182fd2d7c067cc65231567a13e875f8ee47ec79a0a53c94f7360ead6fd97b15bab8d2b2f61aaf4616784ad1c651a4d0
-  data.tar.gz: a4f22146f3f666725506bad3df7a405f4e48e3daa436e0d1fe616644ed12e7d22d4b40f33ecde2390a13091488a560a7f16c6fcfcef38d450a92e188ec31b1b1
+  metadata.gz: 68d8df2004c4ed1e6b975a27da214f5a334817c48eb3ff473850866295cfd2f620bf017b028e29ac93637a0c1328ffc829c08bbe6ed21830f44d10ac5ee2d706
+  data.tar.gz: c2fdb6fb03d4b65b6010d3abbc8ac9659bc697923c09b3f76ae4b1070f950e39bd804e3dc855794cf8f00731a93e55fa120ccbf3a1c4150f41b882f77c9ad5ae

data/Gemfile

@@ -7,7 +7,7 @@ group :development, :test do
   gem 'mocha'
   gem 'fakeweb'
   gem 'pry'
-  gem 'pry-debugger'
-  gem 'pry-rescue'
+  gem 'pry-doc'
+  gem 'pry-byebug'
   gem 'pry-stack_explorer'
 end

data/kindle_highlights_api.gemspec

@@ -8,7 +8,7 @@ Gem::Specification.new do |spec|
   spec.version       = KindleHighlightsAPI::VERSION
   spec.authors       = ["Gaurav Chande"]
   spec.email         = ["gmail@gauravchande.com"]
-  spec.summary       = %q{A wrapper that helps fetch Kindle highlights and play around with them.}
+  spec.summary       = %q{A small library that helps fetch book highlights from Amazon's Kindle service.}
   spec.homepage      = "https://github.com/gauravmc/kindle_highlights_api"
   spec.license       = "MIT"
 
@@ -19,5 +19,5 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 1.6"
   spec.add_development_dependency "rake", "~> 0"
-  spec.add_dependency "mechanize", "~> 2.7.2"
+  spec.add_runtime_dependency 'mechanize', '~> 2.7', '>= 2.7.2'
 end

data/lib/kindle_highlights_api/fetcher.rb

@@ -6,23 +6,25 @@ module KindleHighlightsAPI
       @email, @password = email, password
     end
 
-    def fetch
-      fetch_all_books
+    def fetch_all
+      Array.new.tap do |books|
+        fetch_each do |book|
+          books << book
+        end
+      end
     end
 
-    private
-
-    def fetch_all_books
+    def fetch_each
       page = get_highlights_page
 
-      Array.new.tap do |books|
-        while next_book_link = page.link(id: 'nextBookLink') do
-          books << Book.from_page(page)
-          page = next_book_link.click
-        end
+      while next_book_link = page.link(id: 'nextBookLink') do
+        yield Book.from_page(page)
+        page = next_book_link.click
       end
     end
 
+    private
+
     def get_highlights_page
       kindle_home_page = login_to_amazon_kindle
       kindle_home_page.link(href: "/your_highlights").click

data/lib/kindle_highlights_api/version.rb

@@ -1,3 +1,3 @@
 module KindleHighlightsAPI
-  VERSION = "0.2.3"
+  VERSION = "0.3.0"
 end

data/test/fetcher_test.rb

@@ -5,9 +5,28 @@ module KindleHighlightsAPI
     def test_fetch_returns_an_array_of_all_the_books
       fetcher = Fetcher.new('some@email.com', 'password')
 
-      books = fetcher.fetch
+      books = fetcher.fetch_all
 
-      expected_books = [
+      assert_equal expected_book_titles, books.map(&:title)
+      assert_equal 6, books.size
+    end
+
+    def test_fetch_each_returns_one_book_at_a_time
+      fetcher = Fetcher.new('some@email.com', 'password')
+      books = []
+
+      fetcher.fetch_each do |book|
+        books << book
+      end
+
+      assert_equal expected_book_titles, books.map(&:title)
+      assert_equal 6, books.size
+    end
+
+    private
+
+    def expected_book_titles
+      [
         "Drawing on the Right Side of the Brain: The Definitive, 4th Edition",
         "Mucusless Diet Healing System",
         "Crucial Conversations Tools for Talking When Stakes Are High, Second Edition",
@@ -15,9 +34,6 @@ module KindleHighlightsAPI
         "Smalltalk Best Practice Patterns",
         "A Short History of Nearly Everything"
       ]
-
-      assert_equal expected_books, books.map(&:title)
-      assert_equal 6, books.size
     end
   end
 end

data/test/test_helper.rb

@@ -4,11 +4,17 @@ require 'minitest/autorun'
 require 'kindle_highlights_api'
 require 'pry'
 require 'mocha/mini_test'
-require 'pry-rescue/minitest'
 require 'fakeweb'
 
 TEST_ROOT = File.expand_path('..', __FILE__)
 
+module FakeWeb
+  class StubSocket
+    def read_timeout=(ignored)
+    end
+  end
+end
+
 def mock_web_requests
   FakeWeb.allow_net_connect = false
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kindle_highlights_api
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.3.0
 platform: ruby
 authors:
 - Gaurav Chande
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-03 00:00:00.000000000 Z
+date: 2014-12-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -43,6 +43,9 @@ dependencies:
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.7'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.7.2
   type: :runtime
@@ -50,6 +53,9 @@ dependencies:
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.7'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.7.2
 description: 
@@ -105,7 +111,7 @@ rubyforge_project:
 rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
-summary: A wrapper that helps fetch Kindle highlights and play around with them.
+summary: A small library that helps fetch book highlights from Amazon's Kindle service.
 test_files:
 - test/book_test.rb
 - test/fetcher_test.rb