killbill-orbital 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: caf9e96477c8998f8775bafa6ac5880e9864ff52
-  data.tar.gz: a2db465f2f8dbbba3f2f348ad04946147fe62acd
+  metadata.gz: 5fdf4dd372bc62747159a023b57278bf8a3360c4
+  data.tar.gz: 09e7bb10d1658c5051c0bd7024eefa65b6e6fa4c
 SHA512:
-  metadata.gz: 63322da8cd5cd93f014c19a8f160641f34847a22ceac9cb8dabf06efb25353755cf75839ed8a6aacc542b69dca4b2b85e00209fbd5dc8d1baba3469642808064
-  data.tar.gz: 50548d3981b5fba7f051c1feda33ff772666826392967265a79bead2ef987eaf02102599cda739450c2cbde5868d30631c17adb9fa71ab4e206227e6e93bbe76
+  metadata.gz: 855adf13295a186d53847336e8cb1f6a3ed5c52994386151d6bbf1b69817a856f887d96fe8e5bf29550cd61312d412665c824050f3a40bb030131aeae20726bb
+  data.tar.gz: 6078161015ec05e872faf8e8960fc075e6adc9c8f73affc08a76087d1914a7201c29ad4a046c49452ec0e43d231150e20feff215c6e9b51e16c151fa932400ad

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    killbill-orbital (0.1.2)
+    killbill-orbital (0.1.3)
       actionpack (~> 4.1.0)
       actionview (~> 4.1.0)
       activemerchant (~> 1.55.0)

data/NEWS

@@ -1,3 +1,6 @@
+0.1.3
+    Convert non-standard Orbital AVS codes
+
 0.1.2
     Upgrade Orbital API version to 7.0.1
     Add network tokenization support

data/VERSION

@@ -1 +1 @@
-0.1.2
+0.1.3

data/lib/orbital/ext/active_merchant/active_merchant.rb

@@ -211,6 +211,67 @@ module ActiveMerchant
         end
       end
 
+      class AVSResult
+
+        # Convert the Orbital's AVS code (See https://github.com/activemerchant/active_merchant/blob/0f6fb4fcb442c310fa21307d9f233fbb56f5c0ad/lib/active_merchant/billing/gateways/orbital.rb#L744)
+        # to
+        # the 'standard' one (https://www.wellsfargo.com/downloads/pdf/biz/merchant/visa_avs.pdf
+        #                     http://en.wikipedia.org/wiki/Address_Verification_System)
+        # Note that 2, 8, D, E, UK are not converted because no suitable target codes in the standard codes are found
+        CONVERT_MAP = {
+            '1'  => 'U', # 'No address supplied' => 'Address information unavailable.' => 'Address information unavailable.'
+            '2'  => '2', # Unchanged: 'Bill-to address did not pass Auth Host edit checks'
+            '3'  => 'I', # 'AVS not performed' => 'Address not verified.'=> 'Address not verified.'
+            '4'  => 'S', # 'Issuer does not participate in AVS', => 'U.S.-issuing bank does not support AVS.'
+            '5'  => 'E', # 'Edit-error - AVS data is invalid', => 'AVS data is invalid or AVS is not allowed for this card type.'
+            '6'  => 'R', # 'System unavailable or time-out', => 'System unavailable.'
+            '7'  => 'U', # 'Address information unavailable', => 'Address information unavailable.'
+            '8'  => '8', # Unchanged: 'Transaction Ineligible for AVS'
+            '9'  => 'X', # 'Zip Match/Zip 4 Match/Locale match', => 'Street address and 9-digit postal code match.'
+            'A'  => 'W', # 'Zip Match/Zip 4 Match/Locale no match', => 'Street address does not match, but 9-digit postal code matches.'
+            'B'  => 'Y', # 'Zip Match/Zip 4 no Match/Locale match', => 'Street address and 5-digit postal code match.'
+            'C'  => 'Z', # 'Zip Match/Zip 4 no Match/Locale no match', => 'Street address does not match, but 5-digit postal code matches.'
+            'D'  => 'D', # Unchanged: 'Zip No Match/Zip 4 Match/Locale match'
+            'E'  => 'E', # Unchanged: 'Zip No Match/Zip 4 Match/Locale no match',
+            'F'  => 'A', # 'Zip No Match/Zip 4 No Match/Locale match', => 'Street address matches, but 5-digit and 9-digit postal code do not match.'
+            'G'  => 'C', # 'No match at all', => 'Street address and postal code do not match.'
+            'H'  => 'Y', # 'Zip Match/Locale match', => 'Street address and 5-digit postal code match.'
+            'J'  => 'G', # 'Issuer does not participate in Global AVS', => 'Non-U.S. issuing bank does not support AVS.'
+            'JA' => 'D', # 'International street address and postal match', => 'Street address and postal code match'
+            'JB' => 'B', # 'International street address match. Postal code not verified', => 'Street address matches, but postal code not verified.'
+            'JC' => 'I', # 'International street address and postal code not verified', => 'Address not verified.'
+            'JD' => 'P', # 'International postal code match. Street address not verified', => 'Postal code matches, but street address not verified.'
+            'M1' => 'K', # 'Cardholder name matches', => 'Card member's name matches but billing address and billing postal code do not match.'
+            'M2' => 'V', # 'Cardholder name, billing address, and postal code matches', => 'Card member's name, billing address, and billing postal code match.'
+            'M3' => 'L', # 'Cardholder name and billing code matches', => 'Card member's name and billing postal code match, but billing address does not match.'
+            'M4' => 'O', # 'Cardholder name and billing address match', => 'Card member's name and billing address match, but billing postal code does not match.	'
+            'M5' => 'H', # 'Cardholder name incorrect, billing address and postal code match', => 'Card member's name does not match. Street address and postal code match.	'
+            'M6' => 'F', # 'Cardholder name incorrect, billing postal code matches', => 'Card member's name does not match, but billing postal code matches.	'
+            'M7' => 'T', # 'Cardholder name incorrect, billing address matches', => 'Card member's name does not match, but street address matches.	'
+            'M8' => 'C', # 'Cardholder name, billing address and postal code are all incorrect', => 'Street address and postal code do not match.	'
+            'N3' => 'B', # 'Address matches, ZIP not verified', => 'Street address matches, but postal code not verified.	'
+            'N4' => 'I', # 'Address and ZIP code not verified due to incompatible formats', => 'Address not verified.	'
+            'N5' => 'D', # 'Address and ZIP code match (International only)', => 'Street address and postal code match. '
+            'N6' => 'I', # 'Address not verified (International only)', => 'Address not verified.'
+            'N7' => 'P', # 'ZIP matches, address not verified', => 'Postal code matches, but street address not verified.	'
+            'N8' => 'D', # 'Address and ZIP code match (International only)', => 'Street address and postal code match.'
+            'N9' => 'D', # 'Address and ZIP code match (UK only)', => 'Street address and postal code match.'
+            'R'  => 'S', # 'Issuer does not participate in AVS', => 'U.S. Bank does not support AVS.	'
+            'UK' => 'UK',# Unchanged: UNKNOWN
+            'X'  => 'X', # 'Zip Match/Zip 4 Match/Address Match', => 'Street address and 9-digit postal code match.	'
+            'Z'  => 'Z'  # 'Zip Match/Locale no match', => 'Street address does not match, but 5-digit postal code matches.	'
+        }
+
+        def initialize(code)
+          @code = code.blank? ? nil : code.to_s.strip.upcase
+          if @code
+            @message      = CODES[@code]
+            @postal_match = ORBITAL_POSTAL_MATCH_CODE[@code]
+            @street_match = ORBITAL_STREET_MATCH_CODE[@code]
+            @code         = CONVERT_MAP[@code] unless CONVERT_MAP[@code].nil?
+          end
+        end
+      end
     end
   end
 end

data/pom.xml

@@ -25,7 +25,7 @@
     <groupId>org.kill-bill.billing.plugin.ruby</groupId>
     <artifactId>orbital-plugin</artifactId>
     <packaging>pom</packaging>
-    <version>0.1.2</version>
+    <version>0.1.3</version>
     <name>orbital-plugin</name>
     <url>http://github.com/killbill/killbill-orbital-plugin</url>
     <description>Plugin for accessing Orbital as a payment gateway</description>

data/spec/orbital/avs_response_spec.rb

@@ -0,0 +1,54 @@
+require 'spec_helper'
+
+include ::Killbill::Plugin::ActiveMerchant::RSpec
+
+ActiveMerchant::Billing::Base.mode = :test
+
+shared_examples "avs_response_code_specs" do |raw_code, expected_code|
+  it 'should translate to correct AVS codes from Orbital AVS codes' do
+      ::ActiveMerchant::Billing::OrbitalGateway.any_instance.stub(:ssl_post) do
+        mock_authorize_response(raw_code)
+      end
+      validate_avs_response expected_code
+  end
+
+  def mock_authorize_response(code)
+    <<-XML
+<?xml version=\"1.0\" encoding=\"UTF-8\"?><Response><NewOrderResp><IndustryType></IndustryType><MessageType>A</MessageType><MerchantID>1111111</MerchantID><TerminalID>001</TerminalID><CardBrand>CC</CardBrand><AccountNum>XXXXXXXXXXXX5454</AccountNum><OrderID>5b257b31-1f84-44bc-b32</OrderID><TxRefNum>5834AA75E4466AEA59512165057C37DD810053C2</TxRefNum><TxRefIdx>0</TxRefIdx><ProcStatus>0</ProcStatus><ApprovalStatus>1</ApprovalStatus><RespCode>00</RespCode><AVSRespCode>#{code}</AVSRespCode><CVV2RespCode> </CVV2RespCode><AuthCode>tst424</AuthCode><RecurringAdviceCd></RecurringAdviceCd><CAVVRespCode></CAVVRespCode><StatusMsg>Approved</StatusMsg><RespMsg></RespMsg><HostRespCode>100</HostRespCode><HostAVSRespCode>I3</HostAVSRespCode><HostCVV2RespCode>  </HostCVV2RespCode><CustomerRefNum></CustomerRefNum><CustomerName></CustomerName><ProfileProcStatus></ProfileProcStatus><CustomerProfileMessage></CustomerProfileMessage><RespTime>152837</RespTime><PartialAuthOccurred></PartialAuthOccurred><RequestedAmount></RequestedAmount><RedeemedAmount></RedeemedAmount><RemainingBalance></RemainingBalance><CountryFraudFilterStatus></CountryFraudFilterStatus><IsoCountryCode></IsoCountryCode></NewOrderResp></Response>
+    XML
+  end
+
+  def validate_avs_response(expected_code)
+    kb_payment_id, kb_transaction_id = create_payment
+    payment_response = @plugin.authorize_payment(SecureRandom.uuid, kb_payment_id, kb_transaction_id, SecureRandom.uuid, @amount, @currency, @properties, @call_context)
+    find_value_from_properties(payment_response.properties, 'avsResultCode').should == expected_code
+  end
+end
+
+describe 'Should present correct AVS codes' do
+
+  before(:each) do
+    # Start the plugin early to configure ActiveRecord
+    @plugin = build_plugin(::Killbill::Orbital::PaymentPlugin, 'orbital')
+    @plugin.start_plugin
+    ::Killbill::Orbital::OrbitalPaymentMethod.delete_all
+    ::Killbill::Orbital::OrbitalResponse.delete_all
+    ::Killbill::Orbital::OrbitalTransaction.delete_all
+    @call_context = build_call_context
+    @properties = build_pm_properties(nil,
+                                      {
+                                          :cc_number => 4111111111111111,
+                                          :cc_type => 'visa'
+                                      })
+    @amount     = BigDecimal.new('100')
+    @currency   = 'USD'
+  end
+
+  after(:each) do
+    @plugin.stop_plugin
+  end
+
+  ::ActiveMerchant::Billing::OrbitalGateway::AVSResult::CONVERT_MAP.each do |raw_code, expected_code|
+    include_examples "avs_response_code_specs", raw_code, expected_code
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: killbill-orbital
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Kill Bill core team
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-02-02 00:00:00.000000000 Z
+date: 2017-02-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -316,6 +316,7 @@ files:
 - orbital.yml
 - pom.xml
 - release.sh
+- spec/orbital/avs_response_spec.rb
 - spec/orbital/base_plugin_spec.rb
 - spec/orbital/cvv_indicator_spec.rb
 - spec/orbital/remote/integration_spec.rb