killbill-orbital 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 76aa751f41e2cbc1975e7c464347048495a9370e
-  data.tar.gz: 0b17e7b61ebcad2e58a7dc51c214fbb3c4f91706
+  metadata.gz: 5ca43827edf81bbf093c563e2853aa32397481d5
+  data.tar.gz: b0427c2944d18a31475069f3956e15dd2d50972d
 SHA512:
-  metadata.gz: 2cb67b537f0033408ef2457f0b8dbbb5492629dcba7e37fd407e7fb0c15ebc9ad212dac02e145dd6b430b5a1b0db4a2348867b0105d48f30fe6d123ccbb8195f
-  data.tar.gz: 9b532c7d6224c75dfa5ec4abbc001e58786557cf73c0400cdaa18efe815f5dfb93e372e7b91c6950bffadfd0e993e5c5ca72289a6e5ae981d156b628ecc4e27c
+  metadata.gz: 52c0aa7c85ebe0d7a85627f18792132e0d6707959c1148427a8ad20d332958aee59d5edd7530e026b5d6911183c43a0552565beb5e51ad6a45bc9bb84016ac54
+  data.tar.gz: 86cbf36800c48de95f36d5c9ef51adbbe39235e8a39d95b040ca4ebab398b0580cb329d6670a7d9c5dc19a3c0fd69d048ae3ae4e7d7c93dcf6581132db4c77be

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    killbill-orbital (0.0.1)
+    killbill-orbital (0.0.2)
       actionpack (~> 4.1.0)
       actionview (~> 4.1.0)
       activemerchant (~> 1.55.0)
@@ -19,13 +19,13 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    actionpack (4.1.14.1)
-      actionview (= 4.1.14.1)
-      activesupport (= 4.1.14.1)
+    actionpack (4.1.16)
+      actionview (= 4.1.16)
+      activesupport (= 4.1.16)
       rack (~> 1.5.2)
       rack-test (~> 0.6.2)
-    actionview (4.1.14.1)
-      activesupport (= 4.1.14.1)
+    actionview (4.1.16)
+      activesupport (= 4.1.16)
       builder (~> 3.1)
       erubis (~> 2.7.0)
     active_utils (3.0.0)
@@ -36,17 +36,17 @@ GEM
       builder (>= 2.1.2, < 4.0.0)
       i18n (>= 0.6.9)
       nokogiri (~> 1.4)
-    activemodel (4.1.14.1)
-      activesupport (= 4.1.14.1)
+    activemodel (4.1.16)
+      activesupport (= 4.1.16)
       builder (~> 3.1)
-    activerecord (4.1.14.1)
-      activemodel (= 4.1.14.1)
-      activesupport (= 4.1.14.1)
+    activerecord (4.1.16)
+      activemodel (= 4.1.16)
+      activesupport (= 4.1.16)
       arel (~> 5.0.0)
-    activerecord-bogacs (0.4.1)
-    activerecord-jdbc-adapter (1.3.19)
+    activerecord-bogacs (0.5.0)
+    activerecord-jdbc-adapter (1.3.21)
       activerecord (>= 2.2)
-    activesupport (4.1.14.1)
+    activesupport (4.1.16)
       i18n (~> 0.6, >= 0.6.9)
       json (~> 1.7, >= 1.7.7)
       minitest (~> 5.1)
@@ -65,9 +65,9 @@ GEM
     diff-lcs (1.1.3)
     equalizer (0.0.11)
     erubis (2.7.0)
-    ethon (0.8.1)
+    ethon (0.9.1)
       ffi (>= 1.3.0)
-    ffi (1.9.10-java)
+    ffi (1.9.14-java)
     i18n (0.7.0)
     ice_nine (0.11.2)
     jar-dependencies (0.3.2)
@@ -79,21 +79,21 @@ GEM
     jdbc-mariadb (1.3.4)
     jdbc-postgres (9.4.1206)
     jdbc-sqlite3 (3.8.11.2)
-    jruby-openssl (0.9.15-java)
+    jruby-openssl (0.9.18-java)
     json (1.8.3-java)
-    killbill (7.0.2)
+    killbill (7.0.6)
       rack (>= 1.5.2)
       sinatra (~> 1.3.4)
       typhoeus (~> 0.6.9)
       tzinfo (~> 1.2.0)
     maven-tools (1.0.13)
       virtus (~> 1.0)
-    minitest (5.8.4)
+    minitest (5.9.1)
     monetize (1.1.0)
       money (~> 6.5.0)
     money (6.5.1)
       i18n (>= 0.6.4, <= 0.7.0)
-    nokogiri (1.6.7.2-java)
+    nokogiri (1.6.8.1-java)
     offsite_payments (2.1.0)
       actionpack (>= 3.2.20, < 5.0.0)
       active_utils (~> 3.0.0)

data/Jarfile.lock

@@ -14,6 +14,8 @@
 - org.osgi:org.osgi.core:jar:5.0.0
 - org.slf4j:slf4j-api:jar:1.7.12
 - com.samskivert:jmustache:jar:1.5
+- org.bouncycastle:bcprov-jdk15on:jar:1.55
+- org.bouncycastle:bcpkix-jdk15on:jar:1.55
 - org.kill-bill.billing:killbill-util:jar:tests:0.15.10
 - org.kill-bill.billing.plugin:killbill-plugin-api-currency:jar:0.18
 - org.bgee.log4jdbc-log4j2:log4jdbc-log4j2-jdbc4:jar:1.16
@@ -22,8 +24,8 @@
 - org.skife.config:config-magic:jar:0.14
 - com.fasterxml.jackson.dataformat:jackson-dataformat-csv:jar:2.4.3
 - org.kill-bill.billing.plugin:killbill-plugin-api-control:jar:0.18
-- org.apache.commons:commons-email:jar:1.2
 - org.mockito:mockito-all:jar:1.10.19
+- org.apache.commons:commons-email:jar:1.2
 - antlr:antlr:jar:2.7.7
 - aopalliance:aopalliance:jar:1.0
 - com.fasterxml.jackson.core:jackson-annotations:jar:2.4.3
@@ -36,12 +38,10 @@
 - org.jdbi:jdbi:jar:2.62
 - org.kill-bill.billing:killbill-platform-api:jar:0.15
 - org.kill-bill.billing:killbill-platform-osgi:jar:0.15
-- org.bouncycastle:bcpkix-jdk15on:jar:1.54
 - org.apache.felix:org.apache.felix.framework:jar:4.4.1
 - org.joda:joda-money:jar:0.9
 - org.kill-bill.commons:killbill-jdbi:jar:0.11
 - org.kill-bill.commons:killbill-embeddeddb-common:jar:0.11
-- org.bouncycastle:bcprov-jdk15on:jar:1.54
 - org.apache.shiro:shiro-core:jar:1.2.3
 - org.kill-bill.billing:killbill-platform-osgi-api:jar:0.15
 - org.kill-bill.billing.plugin:killbill-plugin-api-payment:jar:0.18

data/NEWS

@@ -1,2 +1,5 @@
+0.1.0
+    Initial release for 0.18.x
+
 0.0.1
-    Initial release
+    Initial release for 0.16.x

data/README.md

@@ -11,6 +11,7 @@ Kill Bill compatibility
 | Plugin version | Kill Bill version |
 | -------------: | ----------------: |
 | 0.0.x          | 0.16.z            |
+| 0.1.x          | 0.18.z            |
 
 Requirements
 ------------
@@ -141,6 +142,8 @@ Plugin properties
 | cc_expiration_month          | Credit card expiration month                                      |
 | cc_expiration_year           | Credit card expiration year                                       |
 | cc_verification_value        | CVC/CVV/CVN                                                       |
+| cvv_indicator_visa_discover  | If true, set '9' as `CardSecValInd` when CVV is absent (Visa / Discover only ) |
+| cvv_indicator_override_visa_discover | `CardSecValInd` value when CVV is absent (Visa / Discover only) |
 | email                        | Purchaser email                                                   |
 | address1                     | Billing address first line                                        |
 | address2                     | Billing address second line                                       |

data/VERSION

@@ -1 +1 @@
-0.0.1
+0.0.2

data/lib/orbital/ext/active_merchant/active_merchant.rb

@@ -1,10 +1,116 @@
 module ActiveMerchant
   module Billing
+
+    KB_PLUGIN_VERSION = Gem.loaded_specs['killbill-orbital'].version.version rescue nil
+
     class OrbitalGateway
 
       def store(creditcard, options = {})
-        add_customer_profile(creditcard, options)
+        response = add_customer_profile(creditcard, options)
+
+        # Workaround: unmask the PAN if needed
+        # TODO We could call on-the-fly retrieve_customer_profile instead in PaymentPlugin#get_payment_source to
+        # avoid having to store the PAN, but this requires a specific merchant account setting
+        response.params['cc_account_num'] = creditcard.number if response.params['cc_account_num'].starts_with?('XXXX')
+
+        response
+      end
+
+      def user_agent
+        @@ua ||= JSON.dump({
+                               :bindings_version => KB_PLUGIN_VERSION,
+                               :lang => 'ruby',
+                               :lang_version => "#{RUBY_VERSION} p#{RUBY_PATCHLEVEL} (#{RUBY_RELEASE_DATE})",
+                               :platform => RUBY_PLATFORM,
+                               :publisher => 'killbill'
+                           })
       end
+
+      def x_request_id
+        # See KillbillMDCInsertingServletFilter
+        org::slf4j::MDC::get('req.requestId') rescue nil
+      end
+
+      def commit(order, message_type, trace_number=nil)
+        x_r_id = x_request_id
+
+        headers = POST_HEADERS.merge('Content-length' => order.size.to_s,
+                                     'User-Agent' => user_agent,
+                                     'Interface-Version' => 'Ruby|KillBill|Open-Source Gateway')
+        headers['X-Request-Id'] = x_r_id unless x_r_id.blank?
+        headers.merge!('Trace-number' => trace_number.to_s,
+                       'Merchant-Id' => @options[:merchant_id]) if @options[:retry_logic] && trace_number
+        request = lambda { |url| parse(ssl_post(url, order, headers)) }
+
+        # Failover URL will be attempted in the event of a connection error
+        response = begin
+          request.call(remote_url)
+        rescue ConnectionError
+          request.call(remote_url(:secondary))
+        end
+
+        Response.new(success?(response, message_type),
+                     message_from(response),
+                     response,
+                     {
+                         :authorization => authorization_string(response[:tx_ref_num], response[:order_id]),
+                         :test => self.test?,
+                         :avs_result => OrbitalGateway::AVSResult.new(response[:avs_resp_code]),
+                         :cvv_result => OrbitalGateway::CVVResult.new(response[:cvv2_resp_code])
+                     })
+      end
+
+      # A – Authorization request
+      def authorize(money, creditcard, options = {})
+        order = build_new_order_xml(AUTH_ONLY, money, options) do |xml|
+          add_creditcard(xml, creditcard, options)
+          add_address(xml, creditcard, options)
+          if @options[:customer_profiles]
+            add_customer_data(xml, creditcard, options)
+            add_managed_billing(xml, options)
+          end
+        end
+        commit(order, :authorize, options[:trace_number])
+      end
+
+      # AC – Authorization and Capture
+      def purchase(money, creditcard, options = {})
+        order = build_new_order_xml(AUTH_AND_CAPTURE, money, options) do |xml|
+          add_creditcard(xml, creditcard, options)
+          add_address(xml, creditcard, options)
+          if @options[:customer_profiles]
+            add_customer_data(xml, creditcard, options)
+            add_managed_billing(xml, options)
+          end
+        end
+        commit(order, :purchase, options[:trace_number])
+      end
+
+      def add_creditcard(xml, creditcard, options = {})
+        currency = options[:currency]
+        cvv_indicator_visa_discover = options[:cvv_indicator_visa_discover]
+        cvv_indicator_override_visa_discover = options[:cvv_indicator_override_visa_discover]
+
+        unless creditcard.nil?
+          xml.tag! :AccountNum, creditcard.number
+          xml.tag! :Exp, expiry_date(creditcard)
+        end
+
+        xml.tag! :CurrencyCode, currency_code(currency)
+        xml.tag! :CurrencyExponent, currency_exponents(currency)
+
+        unless creditcard.nil?
+          if %w( visa discover ).include?(creditcard.brand)
+            if cvv_indicator_visa_discover
+              xml.tag! :CardSecValInd, (creditcard.verification_value? ? '1' : cvv_indicator_override_visa_discover || '9')
+            else
+              xml.tag! :CardSecValInd, '1' if creditcard.verification_value?
+            end
+          end
+          xml.tag! :CardSecVal,  creditcard.verification_value if creditcard.verification_value?
+        end
+      end
+
     end
   end
 end

data/lib/orbital/models/response.rb

@@ -79,6 +79,18 @@ module Killbill #:nodoc:
           :params_tx_ref_num => extract(response, 'tx_ref_num'),
         }
       end
+
+      def first_reference_id
+        params_tx_ref_num
+      end
+
+      def second_reference_id
+        params_order_id
+      end
+
+      def gateway_error_code
+        params_resp_code
+      end
     end
   end
 end

data/pom.xml

@@ -25,7 +25,7 @@
     <groupId>org.kill-bill.billing.plugin.ruby</groupId>
     <artifactId>orbital-plugin</artifactId>
     <packaging>pom</packaging>
-    <version>0.0.1</version>
+    <version>0.0.2</version>
     <name>orbital-plugin</name>
     <url>http://github.com/killbill/killbill-orbital-plugin</url>
     <description>Plugin for accessing Orbital as a payment gateway</description>

data/spec/orbital/remote/integration_spec.rb

@@ -2,45 +2,20 @@ require 'spec_helper'
 
 ActiveMerchant::Billing::Base.mode = :test
 
-describe Killbill::Orbital::PaymentPlugin do
-
-  include ::Killbill::Plugin::ActiveMerchant::RSpec
-
+shared_examples 'common_specs' do
   before(:each) do
-    # Start the plugin early to configure ActiveRecord
-    @plugin = build_plugin(::Killbill::Orbital::PaymentPlugin, 'orbital')
-    @plugin.start_plugin
-
-    ::Killbill::Orbital::OrbitalPaymentMethod.delete_all
-    ::Killbill::Orbital::OrbitalResponse.delete_all
-    ::Killbill::Orbital::OrbitalTransaction.delete_all
-
-    @call_context = build_call_context
-
-    @properties = []
-    @pm         = create_payment_method(::Killbill::Orbital::OrbitalPaymentMethod, nil, @call_context.tenant_id, @properties, { :cc_number => '5454545454545454' })
-    @amount     = BigDecimal.new('100')
-    @currency   = 'USD'
-
-    kb_payment_id = SecureRandom.uuid
-    1.upto(6) do
-      @kb_payment = @plugin.kb_apis.proxied_services[:payment_api].add_payment(kb_payment_id)
-    end
+    create_payment
   end
 
   after(:each) do
     @plugin.stop_plugin
   end
 
-  it 'should be able to charge a Credit Card directly' do
-    account = @plugin.kb_apis.account_user_api.get_account_by_id(nil, @call_context)
-    properties = build_pm_properties(account, { :cc_number => '5454545454545454' })
-
-    # We created the payment method, hence the rows
+  it 'should be able to purchase' do
     Killbill::Orbital::OrbitalResponse.all.size.should == 1
     Killbill::Orbital::OrbitalTransaction.all.size.should == 0
 
-    payment_response = @plugin.purchase_payment(@pm.kb_account_id, @kb_payment.id, @kb_payment.transactions[0].id, @pm.kb_payment_method_id, @amount, @currency, properties, @call_context)
+    payment_response = @plugin.purchase_payment(@pm.kb_account_id, @kb_payment.id, @kb_payment.transactions[0].id, @pm.kb_payment_method_id, @amount, @currency, @properties, @call_context)
     payment_response.status.should eq(:PROCESSED), payment_response.gateway_error
     payment_response.amount.should == @amount
     payment_response.transaction_type.should == :PURCHASE
@@ -125,3 +100,201 @@ describe Killbill::Orbital::PaymentPlugin do
     payment_response.transaction_type.should == :VOID
   end
 end
+
+shared_examples 'cvv_indicator_specs' do
+  after(:each) do
+    @plugin.stop_plugin
+  end
+
+  it 'should set correct indicator for visa and discover if cvv value is present regardless of cvv_indicator_visa_discover' do
+    validate_cvv_indicator_field 1
+
+    @properties = build_pm_properties(nil, { :cc_number => '5454545454545454', :cc_type => 'discover' })
+    validate_cvv_indicator_field 1
+
+    @properties = build_pm_properties(nil, { :cc_number => '5454545454545454', :cvv_indicator_visa_discover => true })
+    validate_cvv_indicator_field 1
+
+    @properties = build_pm_properties(nil, { :cc_number => '5454545454545454', :cc_type => 'discover', :cvv_indicator_visa_discover => true  })
+    validate_cvv_indicator_field 1
+  end
+
+  it 'should set correct indicator for visa and discover if cvv value is not present and cvv_indicator_visa_discover is true' do
+    @properties = build_pm_properties(nil, { :cc_number => '5454545454545454', :cvv_indicator_visa_discover => true })
+    @properties.reject! {|property| property.key == 'ccVerificationValue' }
+    validate_cvv_indicator_field 9
+
+    @properties = build_pm_properties(nil, { :cc_number => '5454545454545454', :cc_type => 'discover', :cvv_indicator_visa_discover => true })
+    @properties.reject! {|property| property.key == 'ccVerificationValue' }
+    validate_cvv_indicator_field 9
+  end
+
+  it 'should set customized indicator for visa and discover if cvv value is not present and cvv_indicator_visa_discover is true and cvv_indicator_override_visa_discover is given' do
+    @properties = build_pm_properties(nil, { :cc_number => '5454545454545454', :cvv_indicator_visa_discover => true, :cvv_indicator_override_visa_discover => '2' })
+    @properties.reject! {|property| property.key == 'ccVerificationValue' }
+    validate_cvv_indicator_field 2
+
+    @properties = build_pm_properties(nil, { :cc_number => '5454545454545454', :cc_type => 'discover', :cvv_indicator_visa_discover => true, :cvv_indicator_override_visa_discover => '2' })
+    @properties.reject! {|property| property.key == 'ccVerificationValue' }
+    validate_cvv_indicator_field 2
+  end
+
+  it 'should set correct indicator for visa and discover if cvv value is not present and cvv_indicator_visa_discover is nil or false' do
+    @properties = build_pm_properties(nil, { :cc_number => '5454545454545454'})
+    @properties.reject! {|property| property.key == 'ccVerificationValue' }
+    validate_cvv_indicator_field
+
+    @properties = build_pm_properties(nil, { :cc_number => '5454545454545454', :cc_type => 'discover'})
+    @properties.reject! {|property| property.key == 'ccVerificationValue' }
+    validate_cvv_indicator_field
+
+    @properties = build_pm_properties(nil, { :cc_number => '5454545454545454', :cvv_indicator_visa_discover => false })
+    @properties.reject! {|property| property.key == 'ccVerificationValue' }
+    validate_cvv_indicator_field
+
+    @properties = build_pm_properties(nil, { :cc_number => '5454545454545454', :cc_type => 'discover', :cvv_indicator_visa_discover => false })
+    @properties.reject! {|property| property.key == 'ccVerificationValue' }
+    validate_cvv_indicator_field
+  end
+
+  it 'should not include indicator except visa and discover for all cases' do
+    @properties = build_pm_properties(nil, { :cc_number => '5454545454545454', :cc_type => 'master' })
+    validate_cvv_indicator_field
+
+    @properties = build_pm_properties(nil, { :cc_number => '5454545454545454', :cc_type => 'american_express' })
+    validate_cvv_indicator_field
+
+    @properties = build_pm_properties(nil, { :cc_number => '5454545454545454', :cc_type => 'master', :cvv_indicator_visa_discover => false })
+    validate_cvv_indicator_field
+
+    @properties = build_pm_properties(nil, { :cc_number => '5454545454545454', :cc_type => 'american_express', :cvv_indicator_visa_discover => false })
+    validate_cvv_indicator_field
+
+    @properties = build_pm_properties(nil, { :cc_number => '5454545454545454', :cc_type => 'master', :cvv_indicator_visa_discover => true})
+    validate_cvv_indicator_field
+
+    @properties = build_pm_properties(nil, { :cc_number => '5454545454545454', :cc_type => 'american_express', :cvv_indicator_visa_discover => true })
+    validate_cvv_indicator_field
+
+    @properties = build_pm_properties(nil, { :cc_number => '5454545454545454', :cc_type => 'master' })
+    @properties.reject! {|property| property.key == 'ccVerificationValue' }
+    validate_cvv_indicator_field
+
+    @properties = build_pm_properties(nil, { :cc_number => '5454545454545454', :cc_type => 'american_express' })
+    @properties.reject! {|property| property.key == 'ccVerificationValue' }
+    validate_cvv_indicator_field
+
+    @properties = build_pm_properties(nil, { :cc_number => '5454545454545454', :cc_type => 'master', :cvv_indicator_visa_discover => false})
+    @properties.reject! {|property| property.key == 'ccVerificationValue' }
+    validate_cvv_indicator_field
+
+    @properties = build_pm_properties(nil, { :cc_number => '5454545454545454', :cc_type => 'american_express', :cvv_indicator_visa_discover => false })
+    @properties.reject! {|property| property.key == 'ccVerificationValue' }
+    validate_cvv_indicator_field
+
+    @properties = build_pm_properties(nil, { :cc_number => '5454545454545454', :cc_type => 'master', :cvv_indicator_visa_discover => true})
+    @properties.reject! {|property| property.key == 'ccVerificationValue' }
+    validate_cvv_indicator_field
+
+    @properties = build_pm_properties(nil, { :cc_number => '5454545454545454', :cc_type => 'american_express', :cvv_indicator_visa_discover => true })
+    @properties.reject! {|property| property.key == 'ccVerificationValue' }
+    validate_cvv_indicator_field
+  end
+end
+
+
+describe Killbill::Orbital::PaymentPlugin do
+
+  include ::Killbill::Plugin::ActiveMerchant::RSpec
+
+  before(:each) do
+    # Start the plugin early to configure ActiveRecord
+    @plugin = build_plugin(::Killbill::Orbital::PaymentPlugin, 'orbital')
+    @plugin.start_plugin
+
+    ::Killbill::Orbital::OrbitalPaymentMethod.delete_all
+    ::Killbill::Orbital::OrbitalResponse.delete_all
+    ::Killbill::Orbital::OrbitalTransaction.delete_all
+
+    @call_context = build_call_context
+  end
+
+  context 'credit card flow' do
+    before(:each) do
+      @properties = build_pm_properties(nil, { :cc_number => '5454545454545454' })
+      @pm         = create_payment_method(::Killbill::Orbital::OrbitalPaymentMethod, nil, @call_context.tenant_id, @properties, {})
+      @amount     = BigDecimal.new('100')
+      @currency   = 'USD'
+    end
+
+    include_examples 'common_specs'
+  end
+
+  context 'custom profile flow' do
+    before(:each) do
+      @properties = []
+      @pm         = create_payment_method(::Killbill::Orbital::OrbitalPaymentMethod, nil, @call_context.tenant_id, @properties, { :cc_number => '5454545454545454' })
+      @amount     = BigDecimal.new('100')
+      @currency   = 'USD'
+    end
+
+    include_examples 'common_specs'
+  end
+
+  context 'cvv indicator spec' do
+    before(:each) do
+      @properties = build_pm_properties(nil, { :cc_number => '5454545454545454' })
+      @pm         = create_payment_method(::Killbill::Orbital::OrbitalPaymentMethod, nil, @call_context.tenant_id, @properties, {})
+      @amount     = BigDecimal.new('100')
+      @currency   = 'USD'
+    end
+
+    include_examples 'cvv_indicator_specs'
+  end
+
+  def successful_authorize_response
+    <<-XML
+<?xml version=\"1.0\" encoding=\"UTF-8\"?><Response><NewOrderResp><IndustryType></IndustryType><MessageType>A</MessageType><MerchantID>1111111</MerchantID><TerminalID>001</TerminalID><CardBrand>CC</CardBrand><AccountNum>XXXXXXXXXXXX5454</AccountNum><OrderID>5b257b31-1f84-44bc-b32</OrderID><TxRefNum>5834AA75E4466AEA59512165057C37DD810053C2</TxRefNum><TxRefIdx>0</TxRefIdx><ProcStatus>0</ProcStatus><ApprovalStatus>1</ApprovalStatus><RespCode>00</RespCode><AVSRespCode>B </AVSRespCode><CVV2RespCode> </CVV2RespCode><AuthCode>tst424</AuthCode><RecurringAdviceCd></RecurringAdviceCd><CAVVRespCode></CAVVRespCode><StatusMsg>Approved</StatusMsg><RespMsg></RespMsg><HostRespCode>100</HostRespCode><HostAVSRespCode>I3</HostAVSRespCode><HostCVV2RespCode>  </HostCVV2RespCode><CustomerRefNum></CustomerRefNum><CustomerName></CustomerName><ProfileProcStatus></ProfileProcStatus><CustomerProfileMessage></CustomerProfileMessage><RespTime>152837</RespTime><PartialAuthOccurred></PartialAuthOccurred><RequestedAmount></RequestedAmount><RedeemedAmount></RedeemedAmount><RemainingBalance></RemainingBalance><CountryFraudFilterStatus></CountryFraudFilterStatus><IsoCountryCode></IsoCountryCode></NewOrderResp></Response>
+    XML
+  end
+
+  def successful_purchase_response
+    <<-XML
+<?xml version=\"1.0\" encoding=\"UTF-8\"?><Response><NewOrderResp><IndustryType></IndustryType><MessageType>AC</MessageType><MerchantID>1111111</MerchantID><TerminalID>001</TerminalID><CardBrand>CC</CardBrand><AccountNum>XXXXXXXXXXXX5454</AccountNum><OrderID>88132d30-f4f7-4028-949</OrderID><TxRefNum>5834EAC9C7A53FEB600A479629FB6C6427A2532C</TxRefNum><TxRefIdx>1</TxRefIdx><ProcStatus>0</ProcStatus><ApprovalStatus>1</ApprovalStatus><RespCode>00</RespCode><AVSRespCode>3 </AVSRespCode><CVV2RespCode>I</CVV2RespCode><AuthCode>tst703</AuthCode><RecurringAdviceCd></RecurringAdviceCd><CAVVRespCode></CAVVRespCode><StatusMsg>Approved</StatusMsg><RespMsg></RespMsg><HostRespCode>100</HostRespCode><HostAVSRespCode>  </HostAVSRespCode><HostCVV2RespCode>I</HostCVV2RespCode><CustomerRefNum></CustomerRefNum><CustomerName></CustomerName><ProfileProcStatus></ProfileProcStatus><CustomerProfileMessage></CustomerProfileMessage><RespTime>200306</RespTime><PartialAuthOccurred></PartialAuthOccurred><RequestedAmount></RequestedAmount><RedeemedAmount></RedeemedAmount><RemainingBalance></RemainingBalance><CountryFraudFilterStatus></CountryFraudFilterStatus><IsoCountryCode></IsoCountryCode></NewOrderResp></Response>    XML
+    XML
+  end
+
+  def validate_cvv_indicator_field(expected_field = nil)
+    ::ActiveMerchant::Billing::OrbitalGateway.any_instance.stub(:ssl_post) do |host, request_body|
+      if expected_field.nil?
+        request_body.should_not match('<CardSecValInd>')
+      else
+        request_body.should match("<CardSecValInd>#{expected_field}</CardSecValInd>")
+      end
+      if request_body.include? '<MessageType>A</MessageType>'
+        successful_authorize_response
+      else
+        successful_purchase_response
+      end
+    end
+    create_payment
+    payment_response = @plugin.authorize_payment(@pm.kb_account_id, @kb_payment.id, @kb_payment.transactions[0].id, @pm.kb_payment_method_id, @amount, @currency, @properties, @call_context)
+    payment_response.status.should eq(:PROCESSED), payment_response.gateway_error
+    payment_response.amount.should == @amount
+    payment_response.transaction_type.should == :AUTHORIZE
+
+    create_payment
+    payment_response = @plugin.purchase_payment(@pm.kb_account_id, @kb_payment.id, @kb_payment.transactions[0].id, @pm.kb_payment_method_id, @amount, @currency, @properties, @call_context)
+    payment_response.status.should eq(:PROCESSED), payment_response.gateway_error
+    payment_response.amount.should == @amount
+    payment_response.transaction_type.should == :PURCHASE
+  end
+
+  def create_payment
+    kb_payment_id = SecureRandom.uuid
+    1.upto(6) do
+      @kb_payment = @plugin.kb_apis.proxied_services[:payment_api].add_payment(kb_payment_id)
+    end
+    kb_payment_id
+  end
+end

metadata

@@ -1,295 +1,295 @@
 --- !ruby/object:Gem::Specification
 name: killbill-orbital
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Kill Bill core team
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-02-19 00:00:00.000000000 Z
+date: 2016-11-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: killbill
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '7.0'
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '7.0'
+  name: killbill
   prerelease: false
   type: :runtime
-- !ruby/object:Gem::Dependency
-  name: sinatra
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.4
+        version: '7.0'
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.3.4
+  name: sinatra
   prerelease: false
   type: :runtime
-- !ruby/object:Gem::Dependency
-  name: thread_safe
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.3.4
+        version: 1.3.4
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.3.4
+  name: thread_safe
   prerelease: false
   type: :runtime
-- !ruby/object:Gem::Dependency
-  name: activerecord
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.1.0
+        version: 0.3.4
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 4.1.0
+  name: activerecord
   prerelease: false
   type: :runtime
-- !ruby/object:Gem::Dependency
-  name: activerecord-bogacs
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: 4.1.0
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.3'
+  name: activerecord-bogacs
   prerelease: false
   type: :runtime
-- !ruby/object:Gem::Dependency
-  name: activerecord-jdbc-adapter
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '1.3'
-    - - <
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '0.3'
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '1.5'
+  name: activerecord-jdbc-adapter
   prerelease: false
   type: :runtime
-- !ruby/object:Gem::Dependency
-  name: jruby-openssl
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.7
+        version: '1.3'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '1.5'
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.9.7
+  name: jruby-openssl
   prerelease: false
   type: :runtime
-- !ruby/object:Gem::Dependency
-  name: actionpack
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.1.0
+        version: 0.9.7
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 4.1.0
+  name: actionpack
   prerelease: false
   type: :runtime
-- !ruby/object:Gem::Dependency
-  name: actionview
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 4.1.0
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 4.1.0
+  name: actionview
   prerelease: false
   type: :runtime
-- !ruby/object:Gem::Dependency
-  name: activemerchant
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.55.0
+        version: 4.1.0
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.55.0
+  name: activemerchant
   prerelease: false
   type: :runtime
-- !ruby/object:Gem::Dependency
-  name: offsite_payments
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.1.0
+        version: 1.55.0
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 2.1.0
+  name: offsite_payments
   prerelease: false
   type: :runtime
-- !ruby/object:Gem::Dependency
-  name: monetize
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.1.0
+        version: 2.1.0
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.1.0
+  name: monetize
   prerelease: false
   type: :runtime
-- !ruby/object:Gem::Dependency
-  name: money
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 6.5.1
+        version: 1.1.0
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 6.5.1
+  name: money
   prerelease: false
   type: :runtime
-- !ruby/object:Gem::Dependency
-  name: jbundler
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.2
+        version: 6.5.1
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.9.2
+  name: jbundler
   prerelease: false
   type: :development
-- !ruby/object:Gem::Dependency
-  name: rake
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 10.0.0
+        version: 0.9.2
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 10.0.0
+  name: rake
   prerelease: false
   type: :development
-- !ruby/object:Gem::Dependency
-  name: rspec
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.12.0
+        version: 10.0.0
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 2.12.0
+  name: rspec
   prerelease: false
   type: :development
-- !ruby/object:Gem::Dependency
-  name: jdbc-sqlite3
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: 2.12.0
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.7'
+  name: jdbc-sqlite3
   prerelease: false
   type: :development
-- !ruby/object:Gem::Dependency
-  name: jdbc-mariadb
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '3.7'
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.1'
+  name: jdbc-mariadb
   prerelease: false
   type: :development
-- !ruby/object:Gem::Dependency
-  name: jdbc-postgres
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '9.4'
+        version: '1.1'
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '9.4'
+  name: jdbc-postgres
   prerelease: false
   type: :development
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '9.4'
 description: Kill Bill payment plugin for Orbital.
 email: killbilling-users@googlegroups.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - Gemfile
 - Gemfile.head
 - Gemfile.lock
@@ -325,23 +325,23 @@ licenses:
 metadata: {}
 post_install_message:
 rdoc_options:
-- --exclude
-- .
+- "--exclude"
+- "."
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project:
-rubygems_version: 2.1.9
+rubygems_version: 2.4.8
 signing_key:
 specification_version: 4
 summary: Plugin to use Orbital as a gateway.