killbill-client 3.2.0 → 3.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 8e8ef20872ffaa7ed2ae3389efa305af47a71a5458a81f23399fcdc403b55fe8
-  data.tar.gz: b86df21f75c0e2791cc0a17253ff917ebea6543e338c6550ed94fb3086ab679b
+SHA1:
+  metadata.gz: 3be1314e1b773cf9f381995047bd08907957bd18
+  data.tar.gz: 2b16aa7aa39dd1239b548b393aff5c4f8de30f32
 SHA512:
-  metadata.gz: 9cc5394ccd1288a6ba86cf422f7a9ca715499c737c1b578b86e31ee38f8a3eba1090bfa58ae58bfab6fae23866f4737f615c605292b505088fcf4c4fc64f226f
-  data.tar.gz: f9eca5b4bd522edebc5a0d3bccfb5e736e5f91b5323be764093ff553783d4e6012f3f5744090566d4050e85dac86786a25b94d0bc582aa39b15f54a70ed1954a
+  metadata.gz: b1bc847df0c8987f35e0fe54ee3fb2707f3084945f00866b681189940eefd2b0d0d58afa9405d2a42cccf1170e023fc9666094c4a58db52fc256be86134e19e5
+  data.tar.gz: 73c08847cb57745d1a762bd174a5e747f2aa082e7b65f445f504236b2934b1ac7fdd83323c831a773ffd19fc7ac4816bd4bff458d0f04e832c7d1aee6cda6ec0

data/.circleci/config.yml

@@ -5,90 +5,10 @@ defaults: &defaults
 
 version: 2
 jobs:
-  build-jruby-1.7.26:
-    <<: *defaults
-    docker:
-      - image: killbill/kbbuild:0.5.0
-    steps:
-      - checkout
-      - restore_cache:
-          key: v2-dependencies-jruby-1.7.26-{{ .Branch }}-{{ checksum "killbill_client.gemspec" }}
-      - run:
-          name: Install gem dependencies
-          command: |
-            bundle install --jobs=4 --retry=3 --path=vendor/bundle
-      - save_cache:
-          paths:
-            - Gemfile.lock
-            - .bundle
-            - vendor/bundle
-          key: v2-dependencies-jruby-1.7.26-{{ .Branch }}-{{ checksum "killbill_client.gemspec" }}
-
-  test-mysql-jruby-1.7.26:
-    <<: *defaults
-    docker:
-      - image: killbill/kbbuild:0.5.0
-      - image: killbill/killbill:0.19.18
-      - image: killbill/mariadb:0.19
-        environment:
-        - MYSQL_ROOT_PASSWORD=root
-    steps:
-      - checkout
-      - restore_cache:
-          key: v2-dependencies-jruby-1.7.26-{{ .Branch }}-{{ checksum "killbill_client.gemspec" }}
-      - run:
-          name: Setup DDL
-          command: |
-            set +e
-            count=0
-            until mysqladmin ping -h 127.0.0.1 -u root --password=root --silent; do
-              if [[ "$count" == "25" ]]; then
-                exit 1
-              fi
-              (( count++ ))
-              printf '.'
-              sleep 5
-            done
-            set -e
-      - run:
-          name: Setup Kill Bill
-          command: |
-            set +e
-            count=0
-            until $(curl --output /dev/null --silent --fail http://127.0.0.1:8080/1.0/healthcheck); do
-              if [[ "$count" == "25" ]]; then
-                exit 1
-              fi
-              (( count++ ))
-
-              printf '.'
-              sleep 5
-            done
-            set -e
-            curl -v \
-                 -X POST \
-                 -u admin:password \
-                 -H 'Content-Type: application/json' \
-                 -H 'X-Killbill-CreatedBy: CircleCI' \
-                 -d '{"apiKey": "bob", "apiSecret": "lazar"}' \
-                 "http://127.0.0.1:8080/1.0/kb/tenants?useGlobalDefault=true"
-      - run:
-          name: Run tests
-          command: |
-            mkdir /tmp/test-results
-            bundle exec rspec --format documentation \
-                              --out /tmp/test-results/rspec.txt \
-                              $(circleci tests glob "spec/**/*_spec.rb")
-      - store_test_results:
-          path: /tmp/test-results
-      - store_artifacts:
-          path: /tmp/test-results
-          destination: test-results
-
   build-ruby-2.2.2:
     <<: *defaults
     docker:
-      - image: killbill/kbbuild:0.5.0
+      - image: killbill/kbbuild:0.6.0
     steps:
       - checkout
       - restore_cache:
@@ -109,9 +29,9 @@ jobs:
   test-mysql-ruby-2.2.2:
     <<: *defaults
     docker:
-      - image: killbill/kbbuild:0.5.0
-      - image: killbill/killbill:0.19.18
-      - image: killbill/mariadb:0.19
+      - image: killbill/kbbuild:0.6.0
+      - image: killbill/killbill:0.21.9
+      - image: killbill/mariadb:0.21
         environment:
         - MYSQL_ROOT_PASSWORD=root
     steps:
@@ -172,7 +92,7 @@ jobs:
   build-ruby-2.4.2:
     <<: *defaults
     docker:
-      - image: killbill/kbbuild:0.5.0
+      - image: killbill/kbbuild:0.6.0
     steps:
       - checkout
       - restore_cache:
@@ -193,9 +113,9 @@ jobs:
   test-mysql-ruby-2.4.2:
     <<: *defaults
     docker:
-      - image: killbill/kbbuild:0.5.0
-      - image: killbill/killbill:0.19.18
-      - image: killbill/mariadb:0.19
+      - image: killbill/kbbuild:0.6.0
+      - image: killbill/killbill:0.21.9
+      - image: killbill/mariadb:0.21
         environment:
         - MYSQL_ROOT_PASSWORD=root
     steps:
@@ -256,7 +176,7 @@ jobs:
   build-jruby-9.1.14.0:
     <<: *defaults
     docker:
-      - image: killbill/kbbuild:0.5.0
+      - image: killbill/kbbuild:0.6.0
     steps:
       - checkout
       - restore_cache:
@@ -277,9 +197,9 @@ jobs:
   test-mysql-jruby-9.1.14.0:
     <<: *defaults
     docker:
-      - image: killbill/kbbuild:0.5.0
-      - image: killbill/killbill:0.19.18
-      - image: killbill/mariadb:0.19
+      - image: killbill/kbbuild:0.6.0
+      - image: killbill/killbill:0.21.9
+      - image: killbill/mariadb:0.21
         environment:
         - MYSQL_ROOT_PASSWORD=root
     steps:
@@ -340,32 +260,18 @@ workflows:
   version: 2
   build-and-test:
     jobs:
-      # Kill Bill plugins
-      - build-jruby-1.7.26
       # Self-contained KPM
-      - build-ruby-2.2.2:
-          requires:
-            - build-jruby-1.7.26
+      - build-ruby-2.2.2
       # Kaui and other gems
-      - build-ruby-2.4.2:
-          requires:
-            - build-jruby-1.7.26
+      - build-ruby-2.4.2
       # Self-contained Kaui
-      - build-jruby-9.1.14.0:
-          requires:
-            - build-jruby-1.7.26
-      - test-mysql-jruby-1.7.26:
-          requires:
-            - build-jruby-1.7.26
+      - build-jruby-9.1.14.0
       - test-mysql-ruby-2.2.2:
           requires:
             - build-ruby-2.2.2
-            - test-mysql-jruby-1.7.26
       - test-mysql-ruby-2.4.2:
           requires:
             - build-ruby-2.4.2
-            - test-mysql-jruby-1.7.26
       - test-mysql-jruby-9.1.14.0:
           requires:
             - build-jruby-9.1.14.0
-            - test-mysql-jruby-1.7.26

data/.github/CONTRIBUTING.md

@@ -0,0 +1,20 @@
+## How to contribute to Kill Bill
+
+**Do not open up a GitHub issue before reaching out to our [Mailing-List](https://groups.google.com/forum/#!forum/killbilling-users)**. GitHub issues are primarily intended for tracking bug reports and fixes by the core team.
+
+#### **Did you find a bug?**
+
+In your [Mailing-List](https://groups.google.com/forum/#!forum/killbilling-users) post, specify:
+
+* Step by step description on how to reproduce the issue
+* [Account data and system dump](http://docs.killbill.io/0.19/debugging.html#_seeking_help) via KPM of an affected account
+
+#### **Do you intend to add a new feature or change an existing one?**
+
+Do not open an issue or pull request on GitHub until you have collected positive feedback about the change on the [Mailing-List](https://groups.google.com/forum/#!forum/killbilling-users).
+
+When submitting code, make sure to add [new tests](http://docs.killbill.io/0.19/development.html#_navigating_the_kill_bill_codebase).
+
+#### **Do you want to contribute to the Kill Bill documentation?**
+
+Open a pull request on GitHub in the [killbill-docs](https://github.com/killbill/killbill-docs) repository.

data/.github/FUNDING.yml

@@ -0,0 +1,3 @@
+# These are supported funding model platforms
+
+github: [killbill]

data/.github/workflows/ci.yml

@@ -0,0 +1,145 @@
+name: ci
+
+on:
+  push:
+  workflow_dispatch:
+
+env:
+  COMPOSE_DOCKER_CLI_BUILD: 1
+  DB_NAME: kaui
+  DOCKER_BUILDKIT: 1
+  JRUBY_OPTS: --2.0 -J-Xmx1024M
+  KB_ADDRESS: 127.0.0.1
+  KB_PORT: 8080
+  RAILS_ENV: test
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        include:
+          - ruby-version: '2.4.2'
+            database-adapter: 'mysql2'
+            database-user: 'root'
+            database-password: 'root'
+            database-port: '3306'
+            docker-compose-file: 'docker-compose.ci.mysql.yml'
+          - ruby-version: 'jruby-9.1.17.0'
+            database-adapter: 'mysql2'
+            database-user: 'root'
+            database-password: 'root'
+            database-port: '3306'
+            docker-compose-file: 'docker-compose.ci.mysql.yml'
+          - ruby-version: '2.4.2'
+            database-adapter: 'postgresql'
+            database-user: 'postgres'
+            database-password: 'postgres'
+            database-port: '5432'
+            docker-compose-file: 'docker-compose.ci.postgresql.yml'
+          - ruby-version: 'jruby-9.1.17.0'
+            database-adapter: 'postgresql'
+            database-user: 'postgres'
+            database-password: 'postgres'
+            database-port: '5432'
+            docker-compose-file: 'docker-compose.ci.postgresql.yml'
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true
+      - name: Start stack
+        run: |
+          cd docker
+          docker-compose -p it -f ${{ matrix.docker-compose-file }} up --no-start
+          docker start it_db_1
+      - name: Wait for MySQL
+        if: ${{ matrix.docker-compose-file == 'docker-compose.ci.mysql.yml' }}
+        run: |
+          set +e
+          count=0
+          until mysqladmin ping -h 127.0.0.1 -u root --password=root --silent; do
+            if [[ "$count" == "25" ]]; then
+              exit 1
+            fi
+            (( count++ ))
+            printf '.'
+            sleep 5
+          done
+          set -e
+      - name: Wait for PostgreSQL
+        if: ${{ matrix.docker-compose-file == 'docker-compose.ci.postgresql.yml' }}
+        run: |
+          set +e
+          count=0
+          until $(psql -h 127.0.0.1 -U postgres -p 5432 -l > /dev/null); do
+            if [[ "$count" == "25" ]]; then
+              exit 1
+            fi
+            (( count++ ))
+            printf '.'
+            sleep 5
+          done
+          set -e
+      - name: Start Kill Bill
+        # Sometimes it gets stuck (if Kill Bill starts when the DB isn't ready?)
+        timeout-minutes: 4
+        run: |
+          docker start it_killbill_1
+          count=0
+          until $(curl --connect-timeout 10 --max-time 30 --output /dev/null --silent --fail http://${KB_ADDRESS}:${KB_PORT}/1.0/healthcheck); do
+            if [[ "$count" == "180" ]]; then
+              exit 64
+            fi
+            count=$(( count + 1 ))
+            sleep 1
+          done
+          curl --connect-timeout 10 --max-time 30 -v \
+               -X POST \
+               -u admin:password \
+               -H 'Content-Type: application/json' \
+               -H 'X-Killbill-CreatedBy: GitHub' \
+               -d '{"apiKey": "bob", "apiSecret": "lazar"}' \
+               "http://${KB_ADDRESS}:${KB_PORT}/1.0/kb/tenants"
+      - name: Run fast tests
+        env:
+          DB_ADAPTER: ${{ matrix.database-adapter }}
+          DB_USER: ${{ matrix.database-user }}
+          DB_PASSWORD: ${{ matrix.database-password }}
+          DB_PORT: ${{ matrix.database-port }}
+        run: |
+          # Some flakiness unfortunately
+          ./bin/retry bundle exec rake test:spec
+      - name: Run remote tests
+        env:
+          DB_ADAPTER: ${{ matrix.database-adapter }}
+          DB_USER: ${{ matrix.database-user }}
+          DB_PASSWORD: ${{ matrix.database-password }}
+          DB_PORT: ${{ matrix.database-port }}
+        run: |
+          # Some flakiness unfortunately
+          ./bin/retry bundle exec rake test:remote:spec
+      - name: Debugging after failure
+        if: failure()
+        run: |
+          echo "[DEBUG] killbill healthcheck"
+          curl --connect-timeout 10 --max-time 30 -v http://${KB_ADDRESS}:${KB_PORT}/1.0/healthcheck || true
+          echo "[DEBUG] hostname"
+          hostname
+          echo "[DEBUG] netstat -tulpn"
+          sudo netstat -tulpn
+          echo "[DEBUG] docker network ls"
+          docker network ls
+          echo "[DEBUG] docker ps -a"
+          docker ps -a
+          echo "[DEBUG] killbill env"
+          docker exec it_killbill_1 env || true
+          echo "[DEBUG] db env"
+          docker exec it_db_1 env || true
+          echo "[DEBUG] killbill logs"
+          docker logs -t --details it_killbill_1 || true
+          echo "[DEBUG] db logs"
+          docker logs -t --details it_db_1 || true

data/.github/workflows/release.yml

@@ -0,0 +1,46 @@
+name: release
+
+on:
+  workflow_dispatch:
+    inputs:
+      target_version:
+        description: 'Target version: next [major|minor|patch|pre|release] or a given version number [x.x.x]'
+        required: true
+        default: 'patch'
+
+jobs:
+  release:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+      - name: Setup git user
+        env:
+          BUILD_USER: ${{ secrets.BUILD_USER }}
+          BUILD_TOKEN: ${{ secrets.BUILD_TOKEN }}
+        run: |
+          git config --global user.email "contact@killbill.io"
+          git config --global user.name "Kill Bill core team"
+          git config --global url."https://${BUILD_USER}:${BUILD_TOKEN}@github.com/".insteadOf "git@github.com:"
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '2.4.2'
+      - name: Download Ruby dependencies
+        run: |
+          bundle install
+      - name: Tag repository
+        run: |
+          bundle exec gem bump -c -p -t -v ${{ github.event.inputs.target_version }}
+      - name: Release Gem
+        env:
+          RUBYGEMS_API_KEY: ${{ secrets.RUBYGEMS_API_KEY }}
+        run: |
+          mkdir -p ~/.gem
+          cat << EOF > ~/.gem/credentials
+          ---
+          :rubygems_api_key: ${RUBYGEMS_API_KEY}
+          EOF
+          chmod 0600 ~/.gem/credentials
+          bundle install
+          bundle exec gem release
+          rm -f ~/.gem/credentials

data/bin/retry

@@ -0,0 +1,21 @@
+#!/usr/bin/env bash
+
+set -euo pipefail
+
+x() {
+    echo "+ $*" >&2
+    "$@"
+}
+
+retry_delay_seconds=10
+
+i="0"
+while [ $i -lt 4 ]
+do
+    x "$@" && exit 0
+    sleep "${retry_delay_seconds}"
+    i=$[$i+1]
+done
+
+echo "$0: retrying [$*] timed out" >&2
+exit 1

data/docker/docker-compose.ci.mysql.yml

@@ -0,0 +1,21 @@
+version: '3.8'
+
+services:
+  killbill:
+    network_mode: host
+    image: killbill/killbill:0.22.20
+    environment:
+      - KILLBILL_CATALOG_URI=SpyCarAdvanced.xml
+      - KILLBILL_DAO_URL=jdbc:mysql://127.0.0.1:3306/killbill
+      - KILLBILL_DAO_USER=root
+      - KILLBILL_DAO_PASSWORD=root
+      - KILLBILL_SERVER_TEST_MODE=true
+      - KILLBILL_INVOICE_SANITY_SAFETY_BOUND_ENABLED=false
+      - KILLBILL_INVOICE_MAX_DAILY_NUMBER_OF_ITEMS_SAFETY_BOUND=-1
+    depends_on:
+      - db
+  db:
+    network_mode: host
+    image: killbill/mariadb:0.22
+    environment:
+      - MYSQL_ROOT_PASSWORD=root

data/docker/docker-compose.ci.postgresql.yml

@@ -0,0 +1,21 @@
+version: '3.8'
+
+services:
+  killbill:
+    network_mode: host
+    image: killbill/killbill:0.22.20
+    environment:
+      - KILLBILL_CATALOG_URI=SpyCarAdvanced.xml
+      - KILLBILL_DAO_URL=jdbc:postgresql://127.0.0.1:5432/killbill
+      - KILLBILL_DAO_USER=postgres
+      - KILLBILL_DAO_PASSWORD=postgres
+      - KILLBILL_SERVER_TEST_MODE=true
+      - KILLBILL_INVOICE_SANITY_SAFETY_BOUND_ENABLED=false
+      - KILLBILL_INVOICE_MAX_DAILY_NUMBER_OF_ITEMS_SAFETY_BOUND=-1
+    depends_on:
+      - db
+  db:
+    network_mode: host
+    image: killbill/postgresql:0.22
+    environment:
+      - POSTGRES_PASSWORD=postgres

data/killbill_client.gemspec

@@ -19,7 +19,7 @@ require 'killbill_client/version'
 
 Gem::Specification.new do |s|
   s.name        = 'killbill-client'
-  s.version     = KillBillClient::Version.to_s
+  s.version     = KillBillClient::VERSION
   s.summary     = 'Kill Bill client library.'
   s.description = 'An API client library for Kill Bill.'
 
@@ -43,6 +43,7 @@ Gem::Specification.new do |s|
     s.add_dependency 'json', '>= 1.2.0', '< 2.0.0'
   end
 
+  s.add_development_dependency 'gem-release', '~> 2.2'
   s.add_development_dependency 'rake', '>= 10.0.0', '< 11.0.0'
   s.add_development_dependency 'rspec', '~> 3.4'
 end

data/lib/killbill_client.rb

@@ -41,6 +41,8 @@ module KillBillClient
 
     attr_writer :url
 
+    attr_accessor :read_timeout
+    attr_accessor :connection_timeout
     attr_accessor :disable_ssl_verification
     attr_accessor :return_full_stacktraces
 

data/lib/killbill_client/api/api.rb

@@ -70,7 +70,7 @@ module KillBillClient
 
       # @return [String]
       def user_agent
-        "killbill/#{Version}; #{RUBY_DESCRIPTION}"
+        "killbill/#{VERSION}; #{RUBY_DESCRIPTION}"
       end
 
       private

data/lib/killbill_client/api/net_http_adapter.rb

@@ -86,8 +86,16 @@ module KillBillClient
 
         def create_http_client(uri, options = {})
           http = ::Net::HTTP.new uri.host, uri.port
-          http.read_timeout = options[:read_timeout].to_f / 1000 if options[:read_timeout].is_a? Numeric
-          http.open_timeout = options[:connection_timeout].to_f / 1000 if options[:connection_timeout].is_a? Numeric
+          if options[:read_timeout].is_a? Numeric
+            http.read_timeout = options[:read_timeout].to_f / 1000
+          elsif KillBillClient.read_timeout.is_a? Numeric
+            http.read_timeout = KillBillClient.read_timeout.to_f / 1000
+          end
+          if options[:connection_timeout].is_a? Numeric
+            http.open_timeout = options[:connection_timeout].to_f / 1000
+          elsif KillBillClient.connection_timeout.is_a? Numeric
+            http.open_timeout = KillBillClient.connection_timeout.to_f / 1000
+          end
           http.use_ssl = uri.scheme == 'https'
           http.verify_mode = OpenSSL::SSL::VERIFY_NONE if (options[:disable_ssl_verification] || KillBillClient.disable_ssl_verification)
           http

data/lib/killbill_client/models/helpers/custom_field_helper.rb

@@ -71,7 +71,7 @@ module KillBillClient
             self.class.delete "#{url_prefix}/#{send(id_alias)}/customFields",
                               {},
                               {
-                                  :customFieldList => custom_fields_param
+                                  :customField => custom_fields_param
                               },
                               {
                                   :user    => user,

data/lib/killbill_client/version.rb

@@ -1,18 +1,3 @@
 module KillBillClient
-  module Version
-    MAJOR = 3
-    MINOR = 2
-    PATCH = 0
-    PRE = nil
-
-    VERSION = [MAJOR, MINOR, PATCH, PRE].compact.join('.').freeze
-
-    class << self
-      def inspect
-        VERSION.dup
-      end
-
-      alias to_s inspect
-    end
-  end
+  VERSION = '3.3.0'
 end

data/spec/killbill_client/http_adapter_spec.rb

@@ -1,6 +1,14 @@
 require 'spec_helper'
 
 describe KillBillClient::API do
+
+  before do
+    KillBillClient.url = nil
+    KillBillClient.disable_ssl_verification = nil
+    KillBillClient.read_timeout = nil
+    KillBillClient.connection_timeout = nil
+  end
+
   let(:expected_query_params) {
     [
         'controlPluginName=killbill-example-plugin',
@@ -55,11 +63,33 @@ describe KillBillClient::API do
     http_adapter = DummyForHTTPAdapter.new
     http_client = http_adapter.send(:create_http_client, uri)
     expect(http_client.read_timeout).to eq(60)
+    # The default value has changed from nil to 60 in 2.4
+    #expect(http_client.open_timeout).to eq(60)
     expect(http_client.use_ssl?).to be false
     expect(http_client.verify_mode).to be_nil
   end
 
+  it 'should set the global parameters for http client' do
+    KillBillClient.url = 'https://example.com'
+    KillBillClient.read_timeout = 123000
+    KillBillClient.connection_timeout = 456000
+    KillBillClient.disable_ssl_verification = true
+
+    http_adapter = DummyForHTTPAdapter.new
+    http_client = http_adapter.send(:create_http_client, ssl_uri, {})
+    expect(http_client.read_timeout).to eq(123)
+    expect(http_client.open_timeout).to eq(456)
+    expect(http_client.use_ssl?).to be true
+    expect(http_client.verify_mode).to eq(OpenSSL::SSL::VERIFY_NONE)
+  end
+
   it 'should set the correct parameters for http client' do
+    # These don't matter (overridden by options)
+    KillBillClient.url = 'https://example.com'
+    KillBillClient.read_timeout = 123000
+    KillBillClient.connection_timeout = 456000
+    KillBillClient.disable_ssl_verification = false
+
     http_adapter = DummyForHTTPAdapter.new
     http_client = http_adapter.send(:create_http_client, ssl_uri, options)
     expect(http_client.read_timeout).to eq(options[:read_timeout] / 1000)
@@ -70,6 +100,8 @@ describe KillBillClient::API do
 
   # See https://github.com/killbill/killbill-client-ruby/issues/69
   it 'should construct URIs' do
+    KillBillClient.url = 'http://example.com:8080'
+
     http_adapter = DummyForHTTPAdapter.new
     uri = http_adapter.send(:build_uri, KillBillClient::Model::Account::KILLBILL_API_ACCOUNTS_PREFIX, options)
     expect(uri).to eq(URI.parse("#{KillBillClient::API.base_uri.to_s}/1.0/kb/accounts"))

data/spec/killbill_client/remote/model_spec.rb

@@ -101,13 +101,17 @@ describe KillBillClient::Model do
     custom_field = KillBillClient::Model::CustomField.new
     custom_field.name = SecureRandom.uuid.to_s
     custom_field.value = SecureRandom.uuid.to_s
+    custom_field_other = KillBillClient::Model::CustomField.new
+    custom_field_other.name = SecureRandom.uuid.to_s
+    custom_field_other.value = SecureRandom.uuid.to_s
     account.add_custom_field(custom_field, 'KillBill Spec test')
+    account.add_custom_field(custom_field_other, 'KillBill Spec test other')
     custom_fields = account.custom_fields
-    expect(custom_fields.size).to eq(1)
+    expect(custom_fields.size).to eq(2)
     expect(custom_fields.first.name).to eq(custom_field.name)
     expect(custom_fields.first.value).to eq(custom_field.value)
     account.remove_custom_field(custom_fields.first.custom_field_id, 'KillBill Spec test')
-    expect(account.custom_fields.size).to eq(0)
+    expect(account.custom_fields.size).to eq(1)
 
     # Add a payment method
     pm = KillBillClient::Model::PaymentMethod.new
@@ -163,13 +167,13 @@ describe KillBillClient::Model do
     invoice.commit 'KillBill Spec test'
 
     # Add/Remove a invoice item tag
-    expect(invoice_item.tags.size).to eq(0)
-    invoice_item.add_tag('TEST', 'KillBill Spec test')
-    tags = invoice_item.tags
+    expect(invoice.tags.size).to eq(0)
+    invoice.add_tag('WRITTEN_OFF', 'KillBill Spec test')
+    tags = invoice.tags
     expect(tags.size).to eq(1)
-    expect(tags.first.tag_definition_name).to eq('TEST')
-    invoice_item.remove_tag('TEST', 'KillBill Spec test')
-    expect(invoice_item.tags.size).to eq(0)
+    expect(tags.first.tag_definition_name).to eq('WRITTEN_OFF')
+    invoice.remove_tag('WRITTEN_OFF', 'KillBill Spec test')
+    expect(invoice.tags.size).to eq(0)
 
     # Add/Remove a invoice item custom field
     expect(invoice_item.custom_fields.size).to eq(0)
@@ -285,7 +289,7 @@ describe KillBillClient::Model do
     expect(invoice_payment.credited_amount).to eq(0)
 
     # Refund the payment (with item adjustment)
-    invoice_item = KillBillClient::Model::Invoice.find_by_number(invoice_number, true).items.first
+    invoice_item = KillBillClient::Model::Invoice.find_by_number(invoice_number).items.first
     item = KillBillClient::Model::InvoiceItem.new
     item.invoice_item_id = invoice_item.invoice_item_id
     item.amount = invoice_item.amount

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: killbill-client
 version: !ruby/object:Gem::Version
-  version: 3.2.0
+  version: 3.3.0
 platform: ruby
 authors:
 - Killbill core team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-12-24 00:00:00.000000000 Z
+date: 2021-06-02 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: gem-release
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.2'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.2'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -46,15 +60,23 @@ dependencies:
         version: '3.4'
 description: An API client library for Kill Bill.
 email: killbilling-users@googlegroups.com
-executables: []
+executables:
+- retry
 extensions: []
 extra_rdoc_files: []
 files:
 - ".circleci/config.yml"
+- ".github/CONTRIBUTING.md"
+- ".github/FUNDING.yml"
+- ".github/workflows/ci.yml"
+- ".github/workflows/release.yml"
 - ".gitignore"
 - Gemfile
 - README.md
 - Rakefile
+- bin/retry
+- docker/docker-compose.ci.mysql.yml
+- docker/docker-compose.ci.postgresql.yml
 - gen_config/model.conf
 - killbill_client.gemspec
 - lib/killbill_client.rb
@@ -214,7 +236,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubyforge_project: 
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Kill Bill client library.