kiba-common 0.7.0 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 73129b07c0c847b9a1ed5b2a88e0fe3b9449200589fea6e0b88696959c86448f
-  data.tar.gz: 1a73e5414c054fbb233c92c5459087153a6ad413bfa194c192d8ea54cd4ee3ef
+  metadata.gz: 76aa97f6f777aa6e96f05a088346cdca52426732a0f033b8dcfd2856d78770b8
+  data.tar.gz: 820fddae1f7b853075e927a5fc878a0cbbf3cbda31ad61e2b06b7a446fe8531e
 SHA512:
-  metadata.gz: f984de5843f926e3c153c381a1e05d171275fa185c3b0b2c7d855250b75c6ed85841ad78d87cb55b9cc4d6759e7d50c585765483ef27f0c3c64f80b8a739e957
-  data.tar.gz: 1e05cefc61c51f474f93b8f331e3d17a1de7c2ec3683212336796e3dcbc164bc9d5bc9049a8f255c25d237a8f8e38516d02db45f343a903d2bd76ad439515330
+  metadata.gz: a5c036121f7955527bd983afcd37ca71547d99d5b6e48f3ef88351a082b9e7729ae118f8251896c6474410ad8a8674da96140f7ea47f04dabe024aca15e64eea
+  data.tar.gz: 0fcec0f0342151ce1a408292b80e41852ae0094aa20887ae23abdebdee73a6604cfa3086cc980bfc6d368667460765cb28a7d6e1b11464e147545ca6ee7e6764

data/Changes.md

@@ -1,6 +1,14 @@
 HEAD
 ----
 
+0.8.0
+-----
+
+- Bugfix: `show_me!` used with a block should not modify the processed row.
+
+0.7.0
+-----
+
 - New: Kiba::Common::Transforms::SourceTransformAdapter let you transform rows into parameters for source instantiation.
 
 0.6.0

data/README.md

@@ -48,7 +48,7 @@ But since Kiba v2 introduction of `StreamingRunner`, it is possible for transfor
 
 Leveraging that possibility, you can use a `SourceTransformAdapter` to dynamically instantiate the source for each of your input rows.
 
-This allows to mix-and-match components in a much more versatile & powerful way.
+This allows you to mix-and-match components in a much more versatile & powerful way.
 
 Requirements: Kiba v2 with `StreamingRunner` enabled.
 
@@ -85,7 +85,7 @@ require 'kiba-common/transforms/enumerable_exploder'
 transform Kiba::Common::Transforms::EnumerableExploder
 ```
 
-For instance, this can help if you are reading XML/JSON documents from a source, and each input document contains multiple rows that you'd want to extract.
+This can help if you are reading XML/JSON documents from a source and each input document contains multiple rows that you want to extract.
 
 ```ruby
 source Kiba::Common::Sources::Enumerable, -> { Dir["input/*.xml"] }
@@ -104,7 +104,7 @@ Similarly, if you have a CSV document as your input:
 | ------------- | ------------- |
 | 00001  | John:Mary:Sally  |
 
-and you want to reformat it to get this instead:
+and you want to reformat it to the following:
 
 | po_number | buyer |
 |-------------|---------|
@@ -135,11 +135,11 @@ A way to dump `Hash` rows as CSV.
 
 All rows are expected to have the exact same set of keys as the first row.
 
-The headers will be the first row keys, unless you pass an array of keys via `headers`.
+The headers will be the first row keys unless you pass an array of keys via `headers`.
 
-All keys are mandatory (although they can have a nil value).
+All keys are mandatory (although they can have a `nil` value).
 
-Use the `csv_options` keyword to control the output format like you would do when using [Ruby CSV class](http://ruby-doc.org/stdlib-2.4.0/libdoc/csv/rdoc/CSV.html#method-c-new).
+Use the `csv_options` keyword to control the output format like when using [Ruby CSV class](http://ruby-doc.org/stdlib-2.4.0/libdoc/csv/rdoc/CSV.html#method-c-new).
 
 Usage:
 
@@ -189,7 +189,7 @@ logger = Logger.new(xxx)
 
 ### Kiba::Common::DSLExtensions::ShowMe
 
-A way to color-dump rows on the screen, useful at development time while you are looking at the data (requires the `awesome_print` gem).
+A way to color-dump rows on the screen, useful during development when you are inspecting the data (requires the `awesome_print` gem).
 
 Usage:
 
@@ -212,6 +212,8 @@ show_me! { |r| r.except(:some_noisy_field) }
 
 ## Contributing & Legal
 
+See [LICENSE](LICENSE) for license.
+
 (agreement below borrowed from Sidekiq Legal)
 
 By submitting a Pull Request, you disavow any rights or claims to any changes submitted to the Kiba Common project and assign the copyright of those changes to LoGeek SARL.

data/lib/kiba-common/dsl_extensions/show_me.rb

@@ -6,12 +6,12 @@ module Kiba
       # Color print your row.
       module ShowMe
         def show_me!(&pre_process)
-          transform do |row|
-            row = pre_process ? pre_process.call(row) : row
+          transform do |original_row|
+            row = pre_process ? pre_process.call(original_row) : original_row
             # NOTE: invoking Kernel.ap for testing since
             # ap itself is harder to mock (Kiba Context)
             Kernel.ap(row)
-            row
+            original_row
           end
         end
       end

data/lib/kiba-common/version.rb

@@ -1,5 +1,5 @@
 module Kiba
   module Common
-    VERSION = '0.7.0'
+    VERSION = '0.8.0'
   end
 end

data/test/test_show_me.rb

@@ -18,14 +18,18 @@ class TestShowMe < Minitest::Test
   end
   
   def test_show_me_pre_process
+    output = []
     job = Kiba.parse do
       extend Kiba::Common::DSLExtensions::ShowMe
       source Kiba::Common::Sources::Enumerable, [{this: "OK", not_this: "KO"}]
       show_me! { |r| r.fetch(:this) }
+      destination TestArrayDestination, output
     end
 
     assert_called(Kernel, :ap, ['OK']) do
       Kiba.run(job)
     end
+    
+    assert_equal [{this: "OK", not_this: "KO"}], output
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kiba-common
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0
 platform: ruby
 authors:
 - Thibaut Barrère
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-06 00:00:00.000000000 Z
+date: 2018-02-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: kiba