khalti 0.1.5 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b20511cc14806c470c53f8ec138616c0863f6b57e5db496ce314f4506ee51184
-  data.tar.gz: 5acfb0d08b2201176fba040081eaac1b03e1077a47d1dd85826ea708b8915cb8
+  metadata.gz: 0d349aa4b31e87cb15894680e1164ffa59a7bab668388ffe98b05eaf3a6bfb44
+  data.tar.gz: 825b86c0034a05286bf996a7790b2aa7d427a73b853e49fd1f0a01f412ad1671
 SHA512:
-  metadata.gz: ffa68561315dff3dba7c81e1e1449fed9f7036f3fe8c639549237dcd84d66c642b8d9d27947f500f092b2ede9a7334f2bb53f3c6553ed02423b0f33cffa99896
-  data.tar.gz: 825340bb128d07112998e87120a4dadfefdff52db263bc3a91ade2da2ad93e8b69a86290532b31209d2e0299899d686b9068e7036ec91d4fe35cf6a2d24ea273
+  metadata.gz: 6a30ec1cc2a1b44ce39c3fc74eabe373aeb454f897b55476f3f506fef2c154d185f46c4384c9effc25a95f336655106c2ab8b2d88d62cd72aa4bf3d60af03203
+  data.tar.gz: 22bc9c2fb9180066fa6d54112aa74de1174e883433b70c33867afa69ff45585db448271d6f50fd04251a95a5ca93c408c45fe2a0201715d9438eace5755769b2

data/.rubocop.yml

@@ -0,0 +1,2 @@
+AllCops:
+  TargetRubyVersion: 2.5

data/Gemfile

@@ -1,6 +1,8 @@
-source "https://rubygems.org"
+# frozen_string_literal: true
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+source 'https://rubygems.org'
+
+git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in khalti.gemspec
 gemspec

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    khalti (0.1.5)
+    khalti (0.2.0)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -1,4 +1,4 @@
-[![Build Status](https://travis-ci.org/degendra/khalti-ruby.png)](https://travis-ci.org/degendra/khalti-ruby) [![codecov](https://codecov.io/gh/degendra/khalti-ruby/branch/master/graph/badge.svg)](https://codecov.io/gh/degendra/khalti-ruby) [![Gem Version](https://badge.fury.io/rb/khalti.svg)](https://badge.fury.io/rb/khalti) [![Open Source Love](https://badges.frapsoft.com/os/v2/open-source.png?v=103)](https://github.com/ellerbrock/open-source-badges/) [![MIT Licence](https://badges.frapsoft.com/os/mit/mit.svg?v=103)](https://opensource.org/licenses/mit-license.php)
+[![Build Status](https://travis-ci.org/bajratech/khalti-ruby.png)](https://travis-ci.org/bajratech/khalti-ruby) [![codecov](https://codecov.io/gh/bajratech/khalti-ruby/branch/master/graph/badge.svg)](https://codecov.io/gh/bajratech/khalti-ruby) [![Gem Version](https://badge.fury.io/rb/khalti.svg)](https://badge.fury.io/rb/khalti) [![Open Source Love](https://badges.frapsoft.com/os/v2/open-source.png?v=103)](https://github.com/ellerbrock/open-source-badges/) [![MIT Licence](https://badges.frapsoft.com/os/mit/mit.svg?v=103)](https://opensource.org/licenses/mit-license.php)
 
 # Khalti
 

data/Rakefile

@@ -1,6 +1,8 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+# frozen_string_literal: true
+
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/bin/console

@@ -1,7 +1,8 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
-require "bundler/setup"
-require "khalti"
+require 'bundler/setup'
+require 'khalti'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -10,5 +11,5 @@ require "khalti"
 # require "pry"
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start(__FILE__)

data/khalti.gemspec

@@ -1,38 +1,38 @@
+# frozen_string_literal: true
 
-lib = File.expand_path("../lib", __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require "khalti/version"
+require 'khalti/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "khalti"
+  spec.name          = 'khalti'
   spec.version       = Khalti::VERSION
-  spec.authors       = ["Degendra Sivakoti"]
-  spec.email         = ["degendra.sivakoti@gmail.com"]
-
-  spec.summary       = %q{Ruby gem for Khalti online transaction platform.}
-  spec.description   = %q{Welcome to the khalti ruby gem. It is an API wrapper for Khalti payment gateway. For more info visit Khalti Gateway Docs.}
-  spec.homepage      = "https://github.com/bajratech/khalti-ruby"
-  spec.license       = "MIT"
-
-  # Prevent pushing this gem to RubyGems.org. To allow pushes either set the 'allowed_push_host'
-  # to allow pushing to a single host or delete this section to allow pushing to any host.
+  spec.authors       = ['Degendra Sivakoti']
+  spec.email         = ['degendra.sivakoti@gmail.com']
+  spec.summary       = 'Ruby gem for Khalti online transaction platform.'
+  spec.description   = 'https://github.com/bajratech/khalti-ruby'
+  spec.homepage      = 'https://github.com/bajratech/khalti-ruby'
+  spec.license       = 'MIT'
+  # Prevent pushing this gem to RubyGems.org. To allow pushes either
+  # set the 'allowed_push_host' to allow pushing to a single host or
+  # delete this section to allow pushing to any host.
   if spec.respond_to?(:metadata)
-    # spec.metadata["allowed_push_host"] = "TODO: Set to 'http://mygemserver.com'"
+    # spec.metadata["allowed_push_host"] = "Set to 'http://mygemserver.com'"
   else
-    raise "RubyGems 2.0 or newer is required to protect against " \
-      "public gem pushes."
+    raise 'RubyGems 2.0 or newer is required to protect against ' \
+      'public gem pushes.'
   end
 
-  spec.files         = `git ls-files -z`.split("\x0").reject do |f|
+  spec.files = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
   end
-  spec.bindir        = "exe"
+  spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_development_dependency "bundler", "~> 1.16"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "rspec", "~> 3.0"
-  spec.add_development_dependency "webmock", "~> 3.3"
-  spec.add_development_dependency "codecov", "~> 0.1"
+  spec.add_development_dependency 'bundler', '~> 1.16'
+  spec.add_development_dependency 'codecov', '~> 0.1'
+  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rspec', '~> 3.0'
+  spec.add_development_dependency 'webmock', '~> 3.3'
 end

data/lib/khalti.rb

@@ -1,9 +1,12 @@
-require_relative "khalti/version"
-require_relative "khalti/verification"
-require_relative "khalti/transaction"
-require_relative "khalti/request_helper"
-require_relative "khalti/errors"
+# frozen_string_literal: true
 
+require_relative 'khalti/version'
+require_relative 'khalti/verification'
+require_relative 'khalti/transaction'
+require_relative 'khalti/request_helper'
+require_relative 'khalti/errors'
+
+# Khalti payment gateway API wrapper
 module Khalti
   # Your code goes here...
 end

data/lib/khalti/errors.rb

@@ -1,23 +1,20 @@
+# frozen_string_literal: true
+
 module Khalti
   module Errors
-    class KhaltiError < RuntimeError
-      attr_reader :data
-      def initialize(data)
-        @data = data
-        super
-      end
-    end
+    # Custom error class to handle RuntimeError
+    class KhaltiError < RuntimeError; end
 
-    class BlankError < RuntimeError
-    end
+    # Custom error class to handle blank variables
+    class BlankError < KhaltiError; end
 
-    class InvalidAmountError < RuntimeError
-    end
+    # Custom error class to handle invalid amount
+    class InvalidAmountError < KhaltiError; end
 
-    class InvalidTokenError < RuntimeError
-    end
+    # Custom error class to handle invalid token
+    class InvalidTokenError < KhaltiError; end
 
-    class InvalidResponseError < RuntimeError
-    end
+    # Custom error class to handle invalid response data
+    class InvalidResponseError < KhaltiError; end
   end
 end

data/lib/khalti/request_helper.rb

@@ -1,48 +1,55 @@
+# frozen_string_literal: true
+
 module Khalti
+  # Handles API calls
   module RequestHelper
-    SECRET_KEY = ENV['KHALTI_SECRET_KEY']
-    def self.get(path)
-      self.validate_secret_key
-      uri = URI.parse(path)
-      req = Net::HTTP::Get.new(uri)
-      req['authorization'] = "Key #{SECRET_KEY}"
-      res = Net::HTTP.start(uri.hostname, uri.port, use_ssl: true) {|http|
-        http.request(req)
-      }
-      case res
-        when Net::HTTPSuccess
-          self.validate_content_type(res['content-type'])
-          JSON.parse res.body
-        else
-          raise Errors::KhaltiError.new(res.message)
+    class << self
+      SECRET_KEY = ENV['KHALTI_SECRET_KEY']
+      def get(path)
+        validate_secret_key
+        uri = URI.parse(path)
+        req = Net::HTTP::Get.new(uri)
+        req['authorization'] = "Key #{SECRET_KEY}"
+        res = Net::HTTP.start(uri.hostname, uri.port, use_ssl: true) do |http|
+          http.request(req)
+        end
+        extract_response(res)
       end
-    end
 
-    def self.post(path, params)
-      self.validate_secret_key
-      uri = URI.parse(path)
-      req = Net::HTTP::Post.new(uri)
-      req['authorization'] = "Key #{SECRET_KEY}"
-      req.set_form_data(params)
-      res = Net::HTTP.start(uri.hostname, uri.port, use_ssl: true) {|http|
-        http.request(req)
-      }
-      case res
+      def post(path, params)
+        validate_secret_key
+        uri = URI.parse(path)
+        req = Net::HTTP::Post.new(uri)
+        req['authorization'] = "Key #{SECRET_KEY}"
+        req.set_form_data(params)
+        res = Net::HTTP.start(uri.hostname, uri.port, use_ssl: true) do |http|
+          http.request(req)
+        end
+        extract_response(res)
+      end
+
+      private
+
+      def validate_secret_key
+        return unless SECRET_KEY.nil? || SECRET_KEY.strip.empty?
+        raise Errors::BlankError, 'Ensure KHALTI_SECRET_KEY is not blank.'
+      end
+
+      def validate_content_type(content_type)
+        return if content_type == 'application/json'
+        raise Errors::InvalidResponseError,
+              'Content-type is not application/json.'
+      end
+
+      def extract_response(res)
+        case res
         when Net::HTTPSuccess
-          self.validate_content_type(res['content-type'])
+          validate_content_type(res['content-type'])
           JSON.parse res.body
         else
-          raise Errors::KhaltiError.new(res.message)
+          raise Errors::KhaltiError, res.message
+        end
       end
     end
-
-    private
-    def self.validate_secret_key
-      raise Errors::BlankError.new('Ensure KHALTI_SECRET_KEY is not blank.') if SECRET_KEY.nil? || SECRET_KEY.strip.empty?
-    end
-
-    def self.validate_content_type(content_type)
-      Errors::InvalidResponseError.new('Content-type is not application/json.') unless content_type ==='application/json'
-    end
   end
 end

data/lib/khalti/transaction.rb

@@ -1,12 +1,16 @@
+# frozen_string_literal: true
+
 require 'uri'
 require 'net/http'
 require 'json'
 
 module Khalti
+  # Khalti Transaction API wrapper
   class Transaction
     API_URL = 'https://khalti.com/api/merchant-transaction'
     def self.find(idx)
-      raise Errors::BlankError.new('Ensure idx is not blank.') if idx.nil? || idx.strip.empty?
+      raise Errors::BlankError, 'Ensure idx is not blank.' \
+        if idx.nil? || idx.strip.empty?
       RequestHelper.get("#{API_URL}/#{idx}/")
     end
 

data/lib/khalti/verification.rb

@@ -1,17 +1,39 @@
+# frozen_string_literal: true
+
 require 'uri'
 require 'net/http'
 require 'json'
 
 module Khalti
+  # Khalti verification API wrapper
   class Verification
-    API_URL = "https://khalti.com/api/payment/verify/"
+    API_URL = 'https://khalti.com/api/payment/verify/'
     SECRET_KEY = ENV['KHALTI_SECRET_KEY']
-    def self.verify(token, amount)
-      raise Errors::BlankError.new('Ensure token is not blank.') if token.nil? || token.strip.empty?
-      raise Errors::InvalidTokenError.new('Ensure token has at least 22 characters.') if token.strip.size < 22
-      raise Errors::InvalidAmountError.new('Ensure amount is greate than 0 paisa.') if Integer(amount) < 0
-      params = {'token': token, 'amount': Integer(amount)}
-      RequestHelper.post(API_URL, params)
+    class << self
+      def verify(token, amount)
+        validate_blank_token(token)
+        validate_token_length(token)
+        validate_ammount(amount)
+        params = { 'token': token, 'amount': amount.to_i }
+        RequestHelper.post(API_URL, params)
+      end
+
+      def validate_blank_token(val)
+        return unless val.nil? || val.strip.empty?
+        raise Errors::BlankError, 'Ensure token is not blank.'
+      end
+
+      def validate_token_length(val)
+        return if val.strip.size >= 22
+        raise Errors::InvalidTokenError, 'Ensure token has at least ' \
+          '22 characters.'
+      end
+
+      def validate_ammount(val)
+        return if Integer(val).positive?
+        raise Errors::InvalidAmountError, 'Ensure amount is ' \
+          'greater than 0 paisa.'
+      end
     end
   end
 end

data/lib/khalti/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Khalti
-  VERSION = "0.1.5"
+  VERSION = '0.2.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: khalti
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.2.0
 platform: ruby
 authors:
 - Degendra Sivakoti
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-04-02 00:00:00.000000000 Z
+date: 2018-04-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -25,63 +25,62 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.16'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: codecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0.1'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '10.0'
 - !ruby/object:Gem::Dependency
-  name: webmock
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.3'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.3'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: codecov
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.1'
+        version: '3.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.1'
-description: Welcome to the khalti ruby gem. It is an API wrapper for Khalti payment
-  gateway. For more info visit Khalti Gateway Docs.
+        version: '3.3'
+description: https://github.com/bajratech/khalti-ruby
 email:
 - degendra.sivakoti@gmail.com
 executables: []
@@ -90,6 +89,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile