keynote 0.3.1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 47958b0ca9563a46f28a202ea59a741acbf676a2
-  data.tar.gz: 9a55df1090430b85ca9b497cd078301a98024e3c
+  metadata.gz: 4bb2837127985cda52b837475d149b7a0445de3d
+  data.tar.gz: 1c76f12e8ab9ac25fbcd18183d3e5687a560faed
 SHA512:
-  metadata.gz: a959170d01ffa63fca236402d1463354f7546009ec6ba1c92b304d6b4bb7070b00eb22d496721c85420dcac5fe5a4c584bbd6ab084973dd7476df478238e40cc
-  data.tar.gz: 67d243d0e99eb17291f58f889f7f6bafcb853649585a8a58a9b2eb7211d770650b6f26abf5d6f4d4fa2164f4e6527e61f6ea5896711e68205168f99703a18dea
+  metadata.gz: a95130c4b619eefa804e6bb2df56eb1f07271a7163e63f7b635aaa518485e7dc252ef41102325b8f09f5a0c7dd21aeb62045ed579a43262843b403d188e23258
+  data.tar.gz: 713dd5c6bbb3d69dc74e5e15360706ab61b92b81cfef00169279ddfb30dde8577ce2d7e680566d88a549d9908d65539ad57a8d1ddfff2207ae27cae37bfbe0e9

data/.travis.yml

@@ -1,31 +1,11 @@
-language: ruby
-rvm:
-  - 2.1.9
-  - 2.2.5
-  - 2.3.1
-  - jruby-9.1.5.0
-gemfile:
-  - gemfiles/rails31.gemfile
-  - gemfiles/rails32.gemfile
-  - gemfiles/rails40.gemfile
-  - gemfiles/rails41.gemfile
-  - gemfiles/rails42.gemfile
-  - gemfiles/rails50.gemfile
-matrix:
-  exclude:
-    - rvm: 2.2.5
-      gemfile: gemfiles/rails31.gemfile
-    - rvm: 2.2.5
-      gemfile: gemfiles/rails32.gemfile
-    - rvm: 2.3.1
-      gemfile: gemfiles/rails31.gemfile
-    - rvm: 2.3.1
-      gemfile: gemfiles/rails32.gemfile
-    - rvm: jruby-9.1.5.0
-      gemfile: gemfiles/rails31.gemfile
-    - rvm: jruby-9.1.5.0
-      gemfile: gemfiles/rails32.gemfile
-    - rvm: 2.1.9
-      gemfile: gemfiles/rails50.gemfile
+sudo: required
+services:
+  - docker
+before_install:
+  - wget https://github.com/rf-/roadshow/releases/download/v1.0.0/roadshow-linux64
+  - chmod +x roadshow-linux64
+install: "true" # disable default `bundle install`
+script:
+  - ./roadshow-linux64 run
 notifications:
   email: false

data/CHANGELOG.md

@@ -1,3 +1,15 @@
+## v1.0.0
+* Add support for Rails 5.1.
+* Fix all Ruby warnings generated by Keynote itself.
+* Rumble: Always escape quotation marks in HTML attributes, even if the string
+  is already marked as HTML-safe.
+* Rumble: Allow user to pass in a `data` hash to generate data attributes.
+* Rumble: Allow user to pass in an array value for an attribute, which will be
+  joined by spaces.
+
+## v0.3.1
+* Add support for Rails 5.0. (@dra)
+
 ## v0.3.0
 * Drop support for Rails 3.0 and Ruby 1.9.2; add support for Rails 4.2.
 * Drop support for MiniTest::Rails versions older than 2.0; add support for 2.0

data/README.md

@@ -29,7 +29,7 @@ class UserPresenter < Keynote::Presenter
   end
 
   def profile_link
-    link_to user, display_name, data: {user_id: user.id}
+    link_to user, display_name, data: { user_id: user.id }
   end
 end
 ```
@@ -62,8 +62,8 @@ fragments. Here's a small example:
 
 ``` ruby
 build_html do
-  div :id => :content do
-    h1 'Hello World', :class => :main
+  div id: :content do
+    h1 'Hello World', class: :main
   end
 end
 ```
@@ -147,7 +147,7 @@ underlying objects, it's easy to do it explicitly with ActiveSupport's
 
 class UserPresenter < Keynote::Presenter
   presents :user
-  delegate :first_name, :last_name, :to => :user
+  delegate :first_name, :last_name, to: :user
 
   def display_name
     "#{first_name} #{last_name}"
@@ -156,7 +156,7 @@ end
 ```
 
 You can also generate prefixed methods like `user_first_name` by passing
-`:prefix => true` to the `delegate` method.
+`prefix: true` to the `delegate` method.
 
 ## Rationale
 
@@ -225,23 +225,32 @@ Test::Unit or MiniTest::Rails if applicable.
 
 ## Compatibility
 
-Keynote is supported on Rails 3.1, 3.2, 4.0, 4.1, and 4.2. Keynote presenters
-are testable with Test::Unit, RSpec, and MiniTest::Rails (>= 2.0).
+Keynote is supported on Rails 3.1 through 5.1. Keynote presenters are testable
+with Test::Unit, RSpec, and MiniTest::Rails (>= 2.0).
 
 If you find problems with any of the above integrations, please open an issue.
 
 ## Development
 
-You can run Keynote's tests across all supported versions of Rails as follows:
+This repo uses [Roadshow] to generate a [Docker Compose] file for each
+supported version of Rails (with a compatible version of Ruby for each one).
+
+To run specs across all versions, you can either [get the Roadshow tool] and
+run `roadshow run`, or use Docker Compose directly:
 
-``` bash
-$ bundle install
-$ bundle exec appraisal install
-$ bundle exec rake appraisal
 ```
+$ for fn in scenarios/*.docker-compose-yml; do docker-compose -f $fn run --rm scenario; done
+```
+
+To update the set of scenarios, edit `scenarios.yml` and run `roadshow
+generate`, although the Gemfiles in the `scenarios` directory need to be
+maintained manually.
 
 Feel free to submit pull requests according to the usual conventions for Ruby
 projects.
 
 [DisplayCase]: https://github.com/objects-on-rails/display-case
 [Draper]: https://github.com/drapergem/draper
+[Roadshow]: https://github.com/rf-/roadshow
+[Docker Compose]: https://docs.docker.com/compose/
+[get the Roadshow tool]: https://github.com/rf-/roadshow/releases

data/lib/keynote/cache.rb

@@ -26,7 +26,9 @@ module Keynote
       end
 
       # Initialize our cache on the view context if it doesn't already exist.
-      if (cache = view.instance_variable_get(:@_keynote_cache)).nil?
+      if view.instance_variable_defined?(:@_keynote_cache)
+        cache = view.instance_variable_get(:@_keynote_cache)
+      else
         cache = {}
         view.instance_variable_set(:@_keynote_cache, cache)
       end

data/lib/keynote/inline.rb

@@ -173,10 +173,10 @@ module Keynote
 
       private
 
-      def read_template(source_file, line)
+      def read_template(source_file, line_num)
         result = ""
 
-        File.foreach(source_file).drop(line).each do |line|
+        File.foreach(source_file).drop(line_num).each do |line|
           if line =~ COMMENTED_LINE
             result << $1 << "\n"
           else
@@ -228,7 +228,7 @@ module Keynote
 
           compile(view, view.class)
 
-          @source = nil if @virtual_path
+          @source = nil if defined?(@virtual_path) && @virtual_path
           @compiled = true
         end
       end
@@ -248,7 +248,7 @@ module Keynote
 
           compile(view.class)
 
-          @source = nil if @virtual_path
+          @source = nil if defined?(@virtual_path) && @virtual_path
           @compiled = true
         end
       end

data/lib/keynote/presenter.rb

@@ -34,7 +34,7 @@ module Keynote
         self.object_names = objects.dup
 
         objects.unshift :view
-        attr_reader *objects
+        attr_reader(*objects)
 
         param_list = objects.join(', ')
         ivar_list  = objects.map { |o| "@#{o}" }.join(', ')

data/lib/keynote/rumble.rb

@@ -228,6 +228,7 @@ module Keynote
         @instance = instance
         @name = name
         @sc = sc
+        @done, @content = nil
       end
 
       def attributes
@@ -266,6 +267,14 @@ module Keynote
           content = nil
         end
 
+        # Flatten `data` hash into individual attributes if necessary
+        if attrs && attrs[:data].is_a?(Hash)
+          attrs = attrs.dup
+          attrs.delete(:data).each do |key, value|
+            attrs[:"data-#{key}"] = value.to_s
+          end
+        end
+
         merge_attributes(attrs) if attrs
 
         if block_given?
@@ -314,10 +323,18 @@ module Keynote
 
       def attrs_to_s
         attributes.inject("") do |res, (name, value)|
-          if value
-            value = (value == true) ? name : Rumble.html_escape(value)
-            res << " #{name}=\"#{value}\""
-          end
+          next unless value
+
+          value =
+            if value.is_a?(Array)
+              value.map { |val| Rumble.html_escape(val) }.join(" ")
+            elsif value == true
+              name
+            else
+              Rumble.html_escape(value)
+            end
+
+          res << " #{name}=\"#{value.gsub('"'.freeze, '&quot;'.freeze)}\""
           res
         end
       end
@@ -326,7 +343,9 @@ module Keynote
     # Generate HTML using Rumble tag methods. If tag methods are called
     # outside a `build_html` block, they'll raise an exception.
     def build_html
-      ctx = @rumble_context
+      if defined?(@rumble_context)
+        ctx = @rumble_context
+      end
       @rumble_context = Context.new
       yield
       rumble_cleanup(ctx).to_s
@@ -337,7 +356,7 @@ module Keynote
     def text(str = nil, &blk)
       str = Rumble.html_escape(str || blk.call)
 
-      if @rumble_context
+      if defined?(@rumble_context) && @rumble_context
         @rumble_context << str
       else
         str
@@ -346,12 +365,12 @@ module Keynote
 
     # @private
     def rumble_context
-      @rumble_context
+      defined?(@rumble_context) ? @rumble_context : nil
     end
 
     # @private
     def rumble_cleanup(value = nil)
-      @rumble_context
+      defined?(@rumble_context) ? @rumble_context : nil
     ensure
       @rumble_context = value
     end
@@ -359,7 +378,7 @@ module Keynote
     private
 
     def rumble_tag(name, sc, content = nil, attrs = nil, &blk)
-      if !@rumble_context
+      if !defined?(@rumble_context) || !@rumble_context
         raise Rumble::Error, "Must enclose tags in `rumble { ... }` block"
       end
 

data/lib/keynote/version.rb

@@ -2,5 +2,5 @@
 
 module Keynote
   # @private
-  VERSION = "0.3.1"
+  VERSION = "1.0.0"
 end

data/scenarios.yml

@@ -0,0 +1,25 @@
+project: keynote
+
+shared:
+  from: ruby:2.4
+  cmd: "(bundle check || bundle install) && bundle exec rake"
+  service:
+    volumes:
+      - bundle_{{scenario_name}}:/usr/local/bundle
+    environment:
+      BUNDLE_GEMFILE: scenarios/{{scenario_name}}.gemfile
+  volumes:
+    bundle_{{scenario_name}}:
+
+scenarios:
+  rails31:
+    from: ruby:2.0
+  rails32:
+    from: ruby:2.0
+  rails40:
+    from: ruby:2.3
+  rails41:
+    from: ruby:2.3
+  rails42: {}
+  rails50: {}
+  rails51: {}

data/scenarios/rails31.docker-compose.yml

@@ -0,0 +1,15 @@
+---
+version: "2"
+services:
+  scenario:
+    build:
+      context: ..
+      dockerfile: scenarios/rails31.dockerfile
+    image: keynote_scenario_rails31
+    volumes:
+    - "..:/scenario"
+    - "bundle_rails31:/usr/local/bundle"
+    environment:
+      BUNDLE_GEMFILE: scenarios/rails31.gemfile
+volumes:
+  bundle_rails31: {}

data/scenarios/rails31.dockerfile

@@ -0,0 +1,5 @@
+FROM ruby:2.0
+RUN mkdir -p /scenario
+WORKDIR /scenario
+ENV LANG=C.UTF-8
+CMD (bundle check || bundle install) && bundle exec rake

data/{gemfiles → scenarios}/rails31.gemfile

@@ -1,8 +1,7 @@
-# This file was generated by Appraisal
-
 source "https://rubygems.org"
 
-gem "rails", "3.1.12"
+gem "rails", "~> 3.1.0"
 gem "minitest", "< 5"
+gem "haml", "~> 4.0.4"
 
 gemspec :path => "../"

data/scenarios/rails32.docker-compose.yml

@@ -0,0 +1,15 @@
+---
+version: "2"
+services:
+  scenario:
+    build:
+      context: ..
+      dockerfile: scenarios/rails32.dockerfile
+    image: keynote_scenario_rails32
+    volumes:
+    - "..:/scenario"
+    - "bundle_rails32:/usr/local/bundle"
+    environment:
+      BUNDLE_GEMFILE: scenarios/rails32.gemfile
+volumes:
+  bundle_rails32: {}

data/scenarios/rails32.dockerfile

@@ -0,0 +1,5 @@
+FROM ruby:2.0
+RUN mkdir -p /scenario
+WORKDIR /scenario
+ENV LANG=C.UTF-8
+CMD (bundle check || bundle install) && bundle exec rake

data/{gemfiles → scenarios}/rails32.gemfile

@@ -1,8 +1,6 @@
-# This file was generated by Appraisal
-
 source "https://rubygems.org"
 
-gem "rails", "3.2.21"
+gem "rails", "~> 3.2.0"
 gem "minitest", "< 5"
 
 gemspec :path => "../"

data/scenarios/rails40.docker-compose.yml

@@ -0,0 +1,15 @@
+---
+version: "2"
+services:
+  scenario:
+    build:
+      context: ..
+      dockerfile: scenarios/rails40.dockerfile
+    image: keynote_scenario_rails40
+    volumes:
+    - "..:/scenario"
+    - "bundle_rails40:/usr/local/bundle"
+    environment:
+      BUNDLE_GEMFILE: scenarios/rails40.gemfile
+volumes:
+  bundle_rails40: {}

data/scenarios/rails40.dockerfile

@@ -0,0 +1,5 @@
+FROM ruby:2.3
+RUN mkdir -p /scenario
+WORKDIR /scenario
+ENV LANG=C.UTF-8
+CMD (bundle check || bundle install) && bundle exec rake

data/{gemfiles → scenarios}/rails40.gemfile

@@ -1,8 +1,6 @@
-# This file was generated by Appraisal
-
 source "https://rubygems.org"
 
-gem "rails", "4.0.13"
+gem "rails", "~> 4.0.0"
 gem "minitest", "< 5"
 
 gemspec :path => "../"

data/scenarios/rails41.docker-compose.yml

@@ -0,0 +1,15 @@
+---
+version: "2"
+services:
+  scenario:
+    build:
+      context: ..
+      dockerfile: scenarios/rails41.dockerfile
+    image: keynote_scenario_rails41
+    volumes:
+    - "..:/scenario"
+    - "bundle_rails41:/usr/local/bundle"
+    environment:
+      BUNDLE_GEMFILE: scenarios/rails41.gemfile
+volumes:
+  bundle_rails41: {}

data/scenarios/rails41.dockerfile

@@ -0,0 +1,5 @@
+FROM ruby:2.3
+RUN mkdir -p /scenario
+WORKDIR /scenario
+ENV LANG=C.UTF-8
+CMD (bundle check || bundle install) && bundle exec rake

data/{gemfiles → scenarios}/rails41.gemfile

@@ -1,8 +1,6 @@
-# This file was generated by Appraisal
-
 source "https://rubygems.org"
 
-gem "rails", "4.1.9"
+gem "rails", "~> 4.1.0"
 gem "minitest", "~> 5.0"
 
 gemspec :path => "../"

data/scenarios/rails42.docker-compose.yml

@@ -0,0 +1,15 @@
+---
+version: "2"
+services:
+  scenario:
+    build:
+      context: ..
+      dockerfile: scenarios/rails42.dockerfile
+    image: keynote_scenario_rails42
+    volumes:
+    - "..:/scenario"
+    - "bundle_rails42:/usr/local/bundle"
+    environment:
+      BUNDLE_GEMFILE: scenarios/rails42.gemfile
+volumes:
+  bundle_rails42: {}

data/scenarios/rails42.dockerfile

@@ -0,0 +1,5 @@
+FROM ruby:2.4
+RUN mkdir -p /scenario
+WORKDIR /scenario
+ENV LANG=C.UTF-8
+CMD (bundle check || bundle install) && bundle exec rake

data/{gemfiles → scenarios}/rails42.gemfile

@@ -1,8 +1,6 @@
-# This file was generated by Appraisal
-
 source "https://rubygems.org"
 
-gem "rails", "4.2.0"
+gem "rails", "~> 4.2.0"
 gem "minitest", "~> 5.0"
 
 gemspec :path => "../"

data/scenarios/rails50.docker-compose.yml

@@ -0,0 +1,15 @@
+---
+version: "2"
+services:
+  scenario:
+    build:
+      context: ..
+      dockerfile: scenarios/rails50.dockerfile
+    image: keynote_scenario_rails50
+    volumes:
+    - "..:/scenario"
+    - "bundle_rails50:/usr/local/bundle"
+    environment:
+      BUNDLE_GEMFILE: scenarios/rails50.gemfile
+volumes:
+  bundle_rails50: {}

data/scenarios/rails50.dockerfile

@@ -0,0 +1,5 @@
+FROM ruby:2.4
+RUN mkdir -p /scenario
+WORKDIR /scenario
+ENV LANG=C.UTF-8
+CMD (bundle check || bundle install) && bundle exec rake

data/{gemfiles → scenarios}/rails50.gemfile

@@ -1,8 +1,6 @@
-# This file was generated by Appraisal
-
 source "https://rubygems.org"
 
-gem "rails", "5.0.0.1"
+gem "rails", "~> 5.0.0"
 gem "minitest", "~> 5.0"
 
 gemspec :path => "../"

data/scenarios/rails51.docker-compose.yml

@@ -0,0 +1,15 @@
+---
+version: "2"
+services:
+  scenario:
+    build:
+      context: ..
+      dockerfile: scenarios/rails51.dockerfile
+    image: keynote_scenario_rails51
+    volumes:
+    - "..:/scenario"
+    - "bundle_rails51:/usr/local/bundle"
+    environment:
+      BUNDLE_GEMFILE: scenarios/rails51.gemfile
+volumes:
+  bundle_rails51: {}

data/scenarios/rails51.dockerfile

@@ -0,0 +1,5 @@
+FROM ruby:2.4
+RUN mkdir -p /scenario
+WORKDIR /scenario
+ENV LANG=C.UTF-8
+CMD (bundle check || bundle install) && bundle exec rake

data/scenarios/rails51.gemfile

@@ -0,0 +1,6 @@
+source "https://rubygems.org"
+
+gem "rails", "~> 5.1.0"
+gem "minitest", "~> 5.0"
+
+gemspec :path => "../"

data/spec/generator_spec.rb

@@ -28,7 +28,7 @@ describe "generators" do
   end
 
   def file_contents(path)
-    file_contents = File.read(File.join(output_path, path))
+    File.read(File.join(output_path, path))
   end
 
   describe "when the test_framework is :test_unit" do
@@ -46,24 +46,24 @@ describe "generators" do
         )
 
         file_contents('app/presenters/post_presenter.rb').
-          must_match /class PostPresenter < Keynote::Presenter/
+          must_match(/class PostPresenter < Keynote::Presenter/)
 
         file_contents('test/unit/presenters/post_presenter_test.rb').
-          must_match /class PostPresenterTest < Keynote::TestCase/
+          must_match(/class PostPresenterTest < Keynote::TestCase/)
       end
     end
 
     it "does not add a 'presents' line" do
       invoke_generator 'post' do |files|
         file_contents('app/presenters/post_presenter.rb').
-          wont_match /presents/
+          wont_match(/presents/)
       end
     end
 
     it "generates an appropriate present() call" do
       invoke_generator 'post' do |files|
         file_contents('test/unit/presenters/post_presenter_test.rb').
-          must_match /present\(:post\)/
+          must_match(/present\(:post\)/)
       end
     end
 
@@ -71,14 +71,14 @@ describe "generators" do
       it "adds a 'presents' line" do
         invoke_generator 'post', 'foo' do |files|
           file_contents('app/presenters/post_presenter.rb').
-            must_match /presents :foo$/
+            must_match(/presents :foo$/)
         end
       end
 
       it "generates an appropriate present() call" do
         invoke_generator 'post', 'foo' do |files|
           file_contents('test/unit/presenters/post_presenter_test.rb').
-            must_match /present\(:post, :foo\)/
+            must_match(/present\(:post, :foo\)/)
         end
       end
     end
@@ -87,14 +87,14 @@ describe "generators" do
       it "adds a 'presents' line" do
         invoke_generator 'post', 'foo', 'bar' do |files|
           file_contents('app/presenters/post_presenter.rb').
-            must_match /presents :foo, :bar$/
+            must_match(/presents :foo, :bar$/)
         end
       end
 
       it "generates an appropriate present() call" do
         invoke_generator 'post', 'foo', 'bar' do |files|
           file_contents('test/unit/presenters/post_presenter_test.rb').
-            must_match /present\(:post, :foo, :bar\)/
+            must_match(/present\(:post, :foo, :bar\)/)
         end
       end
     end
@@ -112,10 +112,10 @@ describe "generators" do
       )
 
       file_contents('app/presenters/post_presenter.rb').
-        must_match /class PostPresenter < Keynote::Presenter/
+        must_match(/class PostPresenter < Keynote::Presenter/)
 
       file_contents('spec/presenters/post_presenter_spec.rb').
-        must_match /describe PostPresenter do/
+        must_match(/describe PostPresenter do/)
     end
   end
 
@@ -131,10 +131,10 @@ describe "generators" do
       )
 
       file_contents('app/presenters/post_presenter.rb').
-        must_match /class PostPresenter < Keynote::Presenter/
+        must_match(/class PostPresenter < Keynote::Presenter/)
 
       file_contents('test/presenters/post_presenter_test.rb').
-        must_match /describe PostPresenter do/
+        must_match(/describe PostPresenter do/)
     end
   end
 
@@ -150,10 +150,10 @@ describe "generators" do
       )
 
       file_contents('app/presenters/post_presenter.rb').
-        must_match /class PostPresenter < Keynote::Presenter/
+        must_match(/class PostPresenter < Keynote::Presenter/)
 
       file_contents('test/presenters/post_presenter_test.rb').
-        must_match /class PostPresenterTest < Keynote::TestCase/
+        must_match(/class PostPresenterTest < Keynote::TestCase/)
     end
   end
 end

data/spec/inline_spec.rb

@@ -114,8 +114,14 @@ module Keynote
       end
 
       e.must_be_instance_of ActionView::Template::Error
-      e.original_exception.must_be_instance_of RuntimeError
-      e.original_exception.message.must_equal "UH OH"
+
+      if e.respond_to?(:original_exception)
+        e.original_exception.must_be_instance_of RuntimeError
+        e.original_exception.message.must_equal "UH OH"
+      else
+        e.cause.must_be_instance_of RuntimeError
+        e.cause.message.must_equal "UH OH"
+      end
     end
 
     it "should remove leading indentation" do

data/spec/keynote_spec.rb

@@ -118,11 +118,10 @@ describe Keynote do
 
     describe "when there's no view context" do
       it "shouldn't cache" do
-        model_1 = Normal.new
-        model_2 = Normal.new
+        model = Normal.new
 
-        presented_1 = Keynote.present(nil, model_1)
-        presented_2 = Keynote.present(nil, model_1)
+        presented_1 = Keynote.present(nil, model)
+        presented_2 = Keynote.present(nil, model)
 
         presented_1.wont_be :equal?, presented_2
       end

data/spec/presenter_spec.rb

@@ -122,7 +122,7 @@ describe Keynote::Presenter do
   describe "#inspect" do
     it "includes the class name" do
       CombinedPresenter.new(:view, :a, :b).inspect.
-        must_match /^#<CombinedPresenter /
+        must_match(/^#<CombinedPresenter /)
     end
 
     it "shows .inspect output for each presented object" do
@@ -173,7 +173,7 @@ describe Keynote::Presenter do
       end
 
       err.wont_be_nil
-      err.message.must_match /Keynote::Presenter/
+      err.message.must_match(/Keynote::Presenter/)
     end
   end
 end

data/spec/rumble_spec.rb

@@ -24,6 +24,7 @@ class TestRumble < klass
   end
 
   def setup
+    @rumble_context = nil
     super
     assert_nil @rumble_context
   end
@@ -58,6 +59,34 @@ class TestRumble < klass
     end
   end
 
+  def test_string_data
+    assert_rumble '<div data="whatever"></div>' do
+      div data: "whatever"
+    end
+  end
+
+  def test_hash_data
+    str = <<-HTML
+      <div data-modal="true" data-safe="&quot;&quot;&quot;" data-unsafe="&quot;&amp;quot;&quot;">
+      </div>
+    HTML
+
+    assert_rumble str do
+      div data: { modal: true, safe: '"&quot;"'.html_safe, unsafe: '"&quot;"' }
+    end
+  end
+
+  def test_array_attrs
+    str = <<-HTML
+      <div class="hello &quot;uns&amp;amp;fe&quot; &quot;w&amp;rld&quot;">
+      </div>
+    HTML
+
+    assert_rumble str do
+      div class: ["hello", '"uns&amp;fe"', '"w&amp;rld"'.html_safe]
+    end
+  end
+
   def test_several
     str = <<-HTML
       <p>Hello</p>

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: keynote
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 1.0.0
 platform: ruby
 authors:
 - Ryan Fitzgerald
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-13 00:00:00.000000000 Z
+date: 2017-07-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -163,18 +163,11 @@ files:
 - ".gitignore"
 - ".travis.yml"
 - ".yardopts"
-- Appraisals
 - CHANGELOG.md
 - Gemfile
 - LICENSE
 - README.md
 - Rakefile
-- gemfiles/rails31.gemfile
-- gemfiles/rails32.gemfile
-- gemfiles/rails40.gemfile
-- gemfiles/rails41.gemfile
-- gemfiles/rails42.gemfile
-- gemfiles/rails50.gemfile
 - keynote.gemspec
 - lib/generators/presenter_generator.rb
 - lib/generators/templates/keynote_mini_test_spec.rb
@@ -196,6 +189,28 @@ files:
 - lib/keynote/testing/test_present_method.rb
 - lib/keynote/testing/test_unit.rb
 - lib/keynote/version.rb
+- scenarios.yml
+- scenarios/rails31.docker-compose.yml
+- scenarios/rails31.dockerfile
+- scenarios/rails31.gemfile
+- scenarios/rails32.docker-compose.yml
+- scenarios/rails32.dockerfile
+- scenarios/rails32.gemfile
+- scenarios/rails40.docker-compose.yml
+- scenarios/rails40.dockerfile
+- scenarios/rails40.gemfile
+- scenarios/rails41.docker-compose.yml
+- scenarios/rails41.dockerfile
+- scenarios/rails41.gemfile
+- scenarios/rails42.docker-compose.yml
+- scenarios/rails42.dockerfile
+- scenarios/rails42.gemfile
+- scenarios/rails50.docker-compose.yml
+- scenarios/rails50.dockerfile
+- scenarios/rails50.gemfile
+- scenarios/rails51.docker-compose.yml
+- scenarios/rails51.dockerfile
+- scenarios/rails51.gemfile
 - spec/benchmarks.rb
 - spec/generator_spec.rb
 - spec/helper.rb
@@ -224,7 +239,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.4
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Flexible presenters for Rails.

data/Appraisals

@@ -1,29 +0,0 @@
-appraise "rails31" do
-  gem "rails", "3.1.12"
-  gem "minitest", "< 5"
-end
-
-appraise "rails32" do
-  gem "rails", "3.2.22.5"
-  gem "minitest", "< 5"
-end
-
-appraise "rails40" do
-  gem "rails", "4.0.13"
-  gem "minitest", "< 5"
-end
-
-appraise "rails41" do
-  gem "rails", "4.1.16"
-  gem "minitest", "~> 5.0"
-end
-
-appraise "rails42" do
-  gem "rails", "4.2.7.1"
-  gem "minitest", "~> 5.0"
-end
-
-appraise "rails50" do
-  gem "rails", "5.0.0.1"
-  gem "minitest", "~> 5.0"
-end