keynote-client 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cfaa12b5f307472074fcc60d5e2a330bdf6fcf13
-  data.tar.gz: 5ca99f47532d3e67991094d08e3af33f1199715d
+  metadata.gz: 5a92dba499c9e0a5edd26ed9bd77af46c1334bc9
+  data.tar.gz: c7dff278572003d453b5662294b0e65ce8be7a27
 SHA512:
-  metadata.gz: 15ddfbbd78cd5b0a84eab6b0345748a7b3479333731321566df2ec0ea17842a0fdad29ba7b72f75cb2a4b6ba1bad66fef63dc161a0780cbd51786feda459df06
-  data.tar.gz: 197ce7995e427743efe033a8843e094ec4932e87a1ad802a62981bdd86eef7df38104d7e7f5a69aa9c0f0f96a55ffe0970c2ff34ff1f9e1b48a210f127a9987e
+  metadata.gz: 8e6d94f06400b706bfcaa31309691175344d57d486fc0d8770a8326e35d9380c941909a3988892603cfe63b4e8bfc16e30199f5b53931109ba80ffc0924785c5
+  data.tar.gz: 54987691c3b1a076055ab048693e6b5366afc641eb265308782d8029544082837e7e7912d1d2b2c0b6732a60b140bbb6c9aafe9f02a3aaf83b8f3a5750f5ad08

data/.travis.yml

@@ -1,3 +1,7 @@
 language: ruby
+before_install:
+  - gem update bundler
 rvm:
-  - 2.2.0
+  - 2.2
+  - 2.1
+  - 2.0

data/Guardfile

@@ -0,0 +1,5 @@
+guard 'rspec', cmd: 'bundle exec rspec' do
+  watch(%r{^spec/.+_spec\.rb$})
+  watch(%r{^lib/(.+)\.rb$})     { |m| "spec/lib/#{m[1]}_spec.rb" }
+  watch('spec/spec_helper.rb')  { "spec" }
+end

data/README.md

@@ -64,7 +64,7 @@ slide.body = "Hello, pen."
 
 ## Supported OS
 - OS X El Capitan
-- OS X Mavericks
+- OS X Yosemite
 
 
 ## License

data/Rakefile

@@ -1,7 +1,17 @@
+require 'bundler'
 require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+
+require 'rspec/core'
+require 'rspec/core/rake_task'
+
+begin
+  Bundler.setup(:default, :development)
+rescue Bundler::BundlerError => e
+  $stderr.puts e.message
+  $stderr.puts "Run `bundle install` to install missing gems"
+  exit e.status_code
+end
 
 RSpec::Core::RakeTask.new(:spec)
 
 task :default => :spec
-

data/keynote-client.gemspec

@@ -18,9 +18,13 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
+  spec.add_development_dependency "pry", "~> 0.10.1"
   spec.add_development_dependency "bundler", "~> 1.7"
   spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "rspec"
+  spec.add_development_dependency "rspec", "~> 3.3.0"
+  spec.add_development_dependency "simplecov", "~> 0.10.0"
+  spec.add_development_dependency "coveralls", "~> 0.8.2"
+  spec.add_development_dependency "guard", "~> 2.13.0"
+  spec.add_development_dependency "guard-rspec", "~> 4.6.2"
   spec.add_dependency "unindent", "~> 1.0"
-  spec.add_development_dependency "pry"
 end

data/lib/keynote-client.rb

@@ -1,8 +1,11 @@
-require "keynote/version"
-require "keynote/theme"
+require 'unindent'
+
 require "keynote/document"
+require "keynote/theme"
 require "keynote/master_slide"
 require "keynote/slide"
+require 'keynote/slide_array'
+require "keynote/version"
 
 module Keynote
 end

data/lib/keynote/document.rb

@@ -1,6 +1,3 @@
-require 'unindent'
-require 'keynote/theme'
-require 'keynote/slide_array'
 require 'keynote/util'
 
 module Keynote

data/lib/keynote/slide.rb

@@ -1,4 +1,3 @@
-require 'unindent'
 require 'keynote/util'
 
 module Keynote
@@ -19,7 +18,9 @@ module Keynote
       :transition_properties,
     )
 
-    def initialize(base_slide, arguments = {})
+    def initialize(base_slide = nil, arguments = {})
+      raise ArgumentError.new('base_slide is not given') unless base_slide
+
       @base_slide = base_slide
       arguments.each do |attr, val|
         send("#{attr}=", val)
@@ -27,9 +28,10 @@ module Keynote
     end
 
     def title=(title)
+      title = title.gsub(/(\r\n|\r|\n)/) { '\\n' }
       @title = title
-      return unless @document
-      return unless @slide_number
+      return unless @document && @slide_number
+
       result = eval_script <<-APPLE.unindent
         var Keynote = Application("Keynote")
         var doc = Keynote.documents.byId("#{@document.id}")
@@ -40,9 +42,10 @@ module Keynote
     end
 
     def body=(body)
+      body = body.gsub(/(\r\n|\r|\n)/) { '\\n' }
       @body = body
-      return unless @document
-      return unless @slide_number
+      return unless @document && @slide_number
+
       result = eval_script <<-APPLE.unindent
         var Keynote = Application("Keynote")
         var doc = Keynote.documents.byId("#{@document.id}")

data/lib/keynote/theme.rb

@@ -1,4 +1,3 @@
-require 'unindent'
 require 'keynote/util'
 
 module Keynote

data/lib/keynote/version.rb

@@ -1,5 +1,5 @@
 module Keynote
   module Client
-    VERSION = "0.1.1"
+    VERSION = "0.1.2"
   end
 end

data/spec/keynote/slide_spec.rb

@@ -0,0 +1,108 @@
+require 'spec_helper'
+
+describe Keynote::Slide do
+  describe '#initialize' do
+    context 'when base_slide is not given' do
+      it 'raises an ArgumentError' do
+        expect { described_class.new }.to raise_error(ArgumentError)
+      end
+    end
+
+    context 'when base_slide is given' do
+      it 'returns Slide instance' do
+        slide = described_class.new('base_title', title: 'foo')
+        expect(slide).to be_a(described_class)
+        expect(slide.title).to eq('foo')
+      end
+    end
+  end
+
+  describe '#title=' do
+    subject { slide.title=('new_title') }
+
+    context 'when document is not set' do
+      let(:slide) { described_class.new('base_slide') }
+
+      it 'does not eval script to update Keynote' do
+        expect(slide).not_to receive(:eval_script)
+        subject
+      end
+    end
+
+    context 'when slide_number is not set'do
+      let(:slide) { described_class.new('base_slide', slide_number: 1) }
+
+      it 'does not eval script to update Keynote' do
+        expect(slide).not_to receive(:eval_script)
+        subject
+      end
+    end
+
+    context 'when both argument is set' do
+      let(:slide) do
+        described_class.new('base_slide',
+          document: Keynote::Document.new(id: 'some-document-id'),
+          slide_number: 1
+        )
+      end
+
+      it 'evals script to update Keynote' do
+        allow(Open3).to receive(:capture2).with(/osascript -l JavaScript/).and_return(["", 1])
+        expect(slide).to receive(:eval_script).with(/new_title/)
+        subject
+        expect(slide.title).to eq('new_title')
+      end
+    end
+  end
+
+  describe '#body=' do
+    subject { slide.body=(new_body) }
+
+    let(:new_body) { 'new_body' }
+
+    context 'when document is not set' do
+      let(:slide) { described_class.new('base_slide') }
+
+      it 'does not eval script to update Keynote' do
+        expect(slide).not_to receive(:eval_script)
+        subject
+      end
+    end
+
+    context 'when slide_number is not set'do
+      let(:slide) { described_class.new('base_slide', slide_number: 1) }
+
+      it 'does not eval script to update Keynote' do
+        expect(slide).not_to receive(:eval_script)
+        subject
+      end
+    end
+
+    context 'when document is set' do
+      let(:slide) do
+        described_class.new('base_slide',
+          document: Keynote::Document.new(id: 'some-document-id'),
+          slide_number: 1
+        )
+      end
+
+      it 'evals script to update Keynote' do
+        allow(Open3).to receive(:capture2).with(/osascript -l JavaScript/).and_return(["", 1])
+        expect(slide).to receive(:eval_script).with(/new_body/)
+        subject
+        expect(slide.body).to eq('new_body')
+      end
+
+      context 'and when new_body includes new-line character' do
+        let(:new_body) { 'new\nbody' }
+
+        it 'evals script to update Keynote with escaped new body' do
+          allow(Open3).to receive(:capture2).with(/osascript -l JavaScript/).and_return(["", 1])
+          expect(slide).to receive(:eval_script).with(/new\\nbody/)
+          subject
+          expect(slide.body).to eq('new\\nbody')
+        end
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,2 +1,21 @@
 $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
-require 'keynote/client'
+
+require 'simplecov'
+require 'coveralls'
+require 'keynote-client'
+
+Bundler.setup(:default, :development)
+
+RSpec.configure do |config|
+  config.color = true
+  config.tty = true
+end
+
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+  SimpleCov::Formatter::HTMLFormatter,
+  Coveralls::SimpleCov::Formatter
+]
+
+SimpleCov.start do
+ add_filter '/spec/'
+end

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: keynote-client
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - ryo katsuma
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-06 00:00:00.000000000 Z
+date: 2015-12-08 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.10.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.10.1
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -42,44 +56,86 @@ dependencies:
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.3.0
 - !ruby/object:Gem::Dependency
-  name: unindent
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :runtime
+        version: 0.10.0
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 0.10.0
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.8.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.8.2
+- !ruby/object:Gem::Dependency
+  name: guard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.13.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.13.0
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 4.6.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 4.6.2
+- !ruby/object:Gem::Dependency
+  name: unindent
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
 description: keynote-client provides a high level API like ActiveRecord style to control
   your Keynote.
 email:
@@ -92,6 +148,7 @@ files:
 - ".rspec"
 - ".travis.yml"
 - Gemfile
+- Guardfile
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -104,7 +161,7 @@ files:
 - lib/keynote/theme.rb
 - lib/keynote/util.rb
 - lib/keynote/version.rb
-- spec/keynote/client_spec.rb
+- spec/keynote/slide_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/katsuma/keynote-client
 licenses:
@@ -131,5 +188,5 @@ signing_key:
 specification_version: 4
 summary: keynote client with high level API.
 test_files:
-- spec/keynote/client_spec.rb
+- spec/keynote/slide_spec.rb
 - spec/spec_helper.rb

data/spec/keynote/client_spec.rb

@@ -1,11 +0,0 @@
-require 'spec_helper'
-
-describe Keynote::Client do
-  it 'has a version number' do
-    expect(Keynote::Client::VERSION).not_to be nil
-  end
-
-  it 'does something useful' do
-    expect(false).to eq(true)
-  end
-end