key_value 0.1.3 → 0.1.4

data/Readme.md

@@ -40,7 +40,6 @@ Usage
 
 TODO
 ====
- - setting / caching of false <-> AR serialize does not handle false
  - HandlerSocket support
 
 Authors

data/VERSION

@@ -1 +1 @@
-0.1.3
+0.1.4

data/key_value.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{key_value}
-  s.version = "0.1.3"
+  s.version = "0.1.4"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Roman Heinrich", "Michael Grosser"]
-  s.date = %q{2011-05-12}
+  s.date = %q{2011-05-13}
   s.email = %q{michael@grosser.it}
   s.files = [
     "Gemfile",

data/lib/key_value.rb

@@ -2,22 +2,28 @@ require 'active_record'
 
 class KeyValue < ActiveRecord::Base
   VERSION = File.read( File.join(File.dirname(__FILE__),'..','VERSION') ).strip
-  validates_presence_of :key, :value
+  validates_presence_of :key
 
   serialize :value
 
+  # serialize would treat false the same as nil
+  def value=(x)
+    x = x.to_yaml unless x.nil?
+    write_attribute :value, x
+  end
+
   def self.get(key)
     KeyValue.find_by_key(key).try(:value)
   end
 
   def self.set(key, value)
-    if value
+    if value.nil?
+      KeyValue.delete_all(:key => key)
+    else
       record = KeyValue.find_by_key(key) || KeyValue.new(:key => key)
       record.value = value
       record.save!
       value
-    else
-      KeyValue.delete_all(:key => key)
     end
   end
 
@@ -36,10 +42,10 @@ class KeyValue < ActiveRecord::Base
 
   def self.cache(key)
     value = get(key)
-    if value
-      value
-    else
+    if value.nil?
       set(key, yield)
+    else
+      value
     end
   end
 end

data/spec/key_value_spec.rb

@@ -23,7 +23,6 @@ describe KeyValue do
   end
 
   it "can set & get false" do
-    pending
     KeyValue.set('xxx', false)
     KeyValue.get('xxx').should == false
   end
@@ -96,7 +95,6 @@ describe KeyValue do
     end
 
     it "can store false" do
-      pending
       KeyValue.cache('xxx'){false}
       KeyValue.cache('xxx'){true}.should == false
     end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: key_value
 version: !ruby/object:Gem::Version 
-  hash: 29
+  hash: 19
   prerelease: 
   segments: 
   - 0
   - 1
-  - 3
-  version: 0.1.3
+  - 4
+  version: 0.1.4
 platform: ruby
 authors: 
 - Roman Heinrich
@@ -16,7 +16,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-05-12 00:00:00 +02:00
+date: 2011-05-13 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency