kevinrutherford-reek 1.1.3.11 → 1.1.3.12

data/History.txt

@@ -25,6 +25,7 @@
 * Now reports an error for corrupt config files
 * Empty config files are ignored
 
+
 == 1.1.3 2009-05-19
 
 === Minor Changes

data/bin/reek

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 #
 # Reek examines Ruby source code for smells.
-# Visit http://reek.rubyforge.org/ for docs etc.
+# Visit http://wiki.github.com/kevinrutherford/reek for docs etc.
 #
 # Author: Kevin Rutherford
 #

data/lib/reek/adapters/object_source.rb

@@ -17,7 +17,7 @@ module Reek
       sniffer.configure(LargeClass, disabled_config)
     end
 
-    def can_parse_objects?
+    def self.can_parse_objects?
       return true if Object.const_defined?(:ParseTree)
       begin
         require 'parse_tree'
@@ -28,7 +28,7 @@ module Reek
     end
 
     def syntax_tree
-      if can_parse_objects?
+      if ObjectSource.can_parse_objects?
         ObjectSource.unify(ParseTree.new.parse_tree(@source))
       else
         throw ArgumentError.new('You must install the ParseTree gem to use this feature')

data/lib/reek/adapters/source.rb

@@ -27,9 +27,13 @@ module Reek
   #
   class SourceFile < Source
 
+    def self.lines(file)
+      IO.readlines(file.path)
+    end
+
     def initialize(file)
       @file = file
-      super(@file.lines.to_a.join, @file.path)
+      super(SourceFile.lines(@file).join, @file.path)
     end
 
     def configure(sniffer)

data/lib/reek.rb

@@ -1,5 +1,5 @@
 $:.unshift File.dirname(__FILE__)
 
 module Reek # :doc:
-  VERSION = '1.1.3.11'
+  VERSION = '1.1.3.12'
 end

data/reek.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{reek}
-  s.version = "1.1.3.11"
+  s.version = "1.1.3.12"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Kevin Rutherford"]
-  s.date = %q{2009-07-23}
+  s.date = %q{2009-07-25}
   s.default_executable = %q{reek}
   s.description = %q{Code smell detector for Ruby}
   s.email = ["kevin@rutherford-software.com"]

data/spec/reek/smells/large_class_spec.rb

@@ -11,6 +11,7 @@ include Reek::Smells
 describe LargeClass, 'checking Class objects' do
 
   it 'should not report class with 26 methods' do
+    pending('test requires ParseTree') unless ObjectSource.can_parse_objects?
     class BigOne
       26.times do |i|
         define_method "method#{i}".to_sym do
@@ -22,6 +23,7 @@ describe LargeClass, 'checking Class objects' do
   end
 
   it 'should not report short class' do
+    pending('test requires ParseTree') unless ObjectSource.can_parse_objects?
     class ShortClass
       def method1() @var1; end
       def method2() @var2; end
@@ -35,6 +37,7 @@ describe LargeClass, 'checking Class objects' do
 
   describe LargeClass, 'counting instance variables' do
     it 'should not report class with 10 ivars' do
+      pending('test requires ParseTree') unless ObjectSource.can_parse_objects?
       class ManyIvars
         def method
           @vara = @varb = @varc = @vard = @vare
@@ -45,10 +48,12 @@ describe LargeClass, 'checking Class objects' do
     end
 
     it 'ignores class with only a couple of ivars' do
+      pending('test requires ParseTree') unless ObjectSource.can_parse_objects?
       LargeClass.should_not reek_of(:LargeClass)
     end
 
     it 'ignores fq class with only a couple of ivars' do
+    pending('test requires ParseTree') unless ObjectSource.can_parse_objects?
       Reek::Smells::LargeClass.should_not reek_of(:LargeClass)
     end
   end

data/spec/reek/smells/long_parameter_list_spec.rb

@@ -61,6 +61,7 @@ describe LongParameterList do
       end
 
       it 'should only report long param list' do
+        pending('test requires ParseTree') unless ObjectSource.can_parse_objects?
         InnerTest.should reek_only_of(:LongParameterList, /abc/)
       end
     end

data/spec/reek/smells/utility_function_spec.rb

@@ -7,13 +7,6 @@ include Reek::Smells
 
 describe UtilityFunction do
 
-  it 'should not report attrset' do
-    class Fred
-      attr_writer :xyz
-    end
-    Fred.should_not reek
-  end
-
   it 'should count usages of self'do
     'def <=>(other) Options[:sort_order].compare(self, other) end'.should_not reek
   end
@@ -29,16 +22,6 @@ describe UtilityFunction do
   it 'should report message chain' do
     'def simple(arga) arga.b.c end'.should reek_of(:UtilityFunction, /simple/)
   end
-  
-  it 'should not report overriding methods' do
-    class Father
-      def thing(ff); @kids = 0; end
-    end
-    class Son < Father
-      def thing(ff); ff; end
-    end
-    Son.should_not reek
-  end
 
   it 'does not report a method that calls super' do
     'def child(arg) super; arg.to_s; end'.should_not reek
@@ -81,3 +64,24 @@ describe UtilityFunction, 'should only report a method containing a call' do
     'def clean(text) text.each { @fred = 3} end'.should_not reek
   end
 end
+
+describe UtilityFunction do
+  it 'should not report attrset' do
+    pending('test requires ParseTree') unless ObjectSource.can_parse_objects?
+    class Fred
+      attr_writer :xyz
+    end
+    Fred.should_not reek
+  end
+  
+  it 'should not report overriding methods' do
+    pending('test requires ParseTree') unless ObjectSource.can_parse_objects?
+    class Father
+      def thing(ff); @kids = 0; end
+    end
+    class Son < Father
+      def thing(ff); ff; end
+    end
+    Son.should_not reek
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: kevinrutherford-reek
 version: !ruby/object:Gem::Version 
-  version: 1.1.3.11
+  version: 1.1.3.12
 platform: ruby
 authors: 
 - Kevin Rutherford
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-07-23 00:00:00 -07:00
+date: 2009-07-25 00:00:00 -07:00
 default_executable: reek
 dependencies: 
 - !ruby/object:Gem::Dependency