kettle-dev 3.1.19 → 3.1.20

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bd1cd8bed8e26d699094373fa5a769a6cbb941479bc93027915bf9b6da388322
-  data.tar.gz: a6457f10daf0e149eac4d9c3138efad3a715f0ca3acfaf0c4bdd8611434996f2
+  metadata.gz: 9efc79f5aed2cce009a847b8054a5ce39d54bd5c11f567d5463085e1ce11fcd6
+  data.tar.gz: 28b1079640e41dbd9f7ff7c0d844f377b177c4d408b504af893cc888b5abf200
 SHA512:
-  metadata.gz: f6414ee199198649eb4a72822e9536be47f748e98e6265e861e67769549a9a3de7433685ac058fdb064bad442ef4dd4cc119a3669d29b3ce8217ae32eb020d88
-  data.tar.gz: a3410112a6c5fffaaf1c779ec3c1c4d09ab336be891f52b4ad673847b357a8e8bdab28ad6209ad20f478c19e2175e0347ce668b29d7a5832f6aa8ed295c4e898
+  metadata.gz: f4982d17aabae7fc0e4d970a55fac3e8403f4daceea4d6e5399380a928c270a2a80ff879c3698eb3558276c39e3fd9a540d801a6ec226ad5e8989c96dd737ded
+  data.tar.gz: 7ada13071f91419315448d6b9d03be92c8a25f68d827fb5acbf94b97aad444d7173f6eb411bf7ac6ebdd6251deb4f8f86fdba868ab1edb308ce69eaf199d5eb9

data/CHANGELOG.md

@@ -30,6 +30,17 @@ Please file a bug if you notice a violation of semantic versioning.
 
 ### Security
 
+## [3.1.20] - 2026-10-21
+
+- TAG: [v3.1.20][3.1.20t]
+- COVERAGE: 91.52% -- 5773/6308 lines in 48 files
+- BRANCH COVERAGE: 75.66% -- 2226/2942 branches in 48 files
+- 53.70% documented
+
+### Fixed
+
+- Release availability probe no longer fails a release after a successful push when the gem.coop proxy lags rubygems.org: the probe alternates the gem.coop consumer-mirror validation with a live rubygems.org confirmation of the push target, backs off exponentially between attempts (10s base, 1.6x growth, 120s cap; tunable via KETTLE_DEV_RELEASE_PROBE_ATTEMPTS / KETTLE_DEV_RELEASE_PROBE_INITIAL_DELAY / KETTLE_DEV_RELEASE_PROBE_INTERVAL / KETTLE_DEV_RELEASE_PROBE_MAX_INTERVAL, also applied to release lockfile-reset retries), and proceeds with a warning when rubygems.org confirms the publish but gem.coop has not yet synced, instead of aborting the wave
+
 ## [3.1.19] - 2026-10-19
 
 - TAG: [v3.1.19][3.1.19t]
@@ -4189,7 +4200,9 @@ Please file a bug if you notice a violation of semantic versioning.
   - Selecting will run the selected workflow via `act`
   - This may move to its own gem in the future.
 
-[Unreleased]: https://github.com/kettle-dev/kettle-dev/compare/v3.1.19...HEAD
+[Unreleased]: https://github.com/kettle-dev/kettle-dev/compare/v3.1.20...HEAD
+[3.1.20]: https://github.com/kettle-dev/kettle-dev/compare/v3.1.19...v3.1.20
+[3.1.20t]: https://github.com/kettle-dev/kettle-dev/releases/tag/v3.1.20
 [3.1.19]: https://github.com/kettle-dev/kettle-dev/compare/v3.1.18...v3.1.19
 [3.1.19t]: https://github.com/kettle-dev/kettle-dev/releases/tag/v3.1.19
 [3.1.18]: https://github.com/kettle-dev/kettle-dev/compare/v3.1.17...v3.1.18

data/README.md

@@ -1084,7 +1084,7 @@ Thanks for RTFM. ☺️
 [📌gitmoji]: https://gitmoji.dev
 [📌gitmoji-img]: https://img.shields.io/badge/gitmoji_commits-%20%F0%9F%98%9C%20%F0%9F%98%8D-34495e.svg?style=flat-square
 [🧮kloc]: https://www.youtube.com/watch?v=dQw4w9WgXcQ
-[🧮kloc-img]: https://img.shields.io/badge/KLOC-6.284-FFDD67.svg?style=for-the-badge&logo=YouTube&logoColor=blue
+[🧮kloc-img]: https://img.shields.io/badge/KLOC-6.308-FFDD67.svg?style=for-the-badge&logo=YouTube&logoColor=blue
 [🔐security]: https://github.com/kettle-dev/kettle-dev/blob/main/SECURITY.md
 [🔐security-img]: https://img.shields.io/badge/security-policy-259D6C.svg?style=flat
 [📄copyright-notice-explainer]: https://opensource.stackexchange.com/questions/5778/why-do-licenses-such-as-the-mit-license-specify-a-single-year

data/lib/kettle/dev/release_cli.rb

@@ -71,6 +71,9 @@ module Kettle
       ].freeze
       DEBUG_TRUE_VALUES = %w[1 true yes on].freeze
       RELEASE_VALIDATION_SOURCE = "https://gem.coop"
+      # The push target registry. gem.coop is a caching proxy that can lag it,
+      # so this is authoritative for whether a pushed gem landed at all.
+      RELEASE_UPSTREAM_SOURCE = "https://rubygems.org"
       FAMILY_MEMBER_PUBLISH_MODE_ENV = "KETTLE_RELEASE_FAMILY_MEMBER_PUBLISH"
       FAMILY_MEMBER_FINALIZE_MODE_ENV = "KETTLE_RELEASE_FAMILY_MEMBER_FINALIZE"
 
@@ -887,7 +890,7 @@ module Kettle
             )
             if retryable
               puts "Release lockfile reset could not resolve a newly published workspace gem from #{RELEASE_VALIDATION_SOURCE}; waiting before retry #{attempt + 1}/#{attempts}."
-              sleep(release_availability_probe_interval)
+              sleep(release_availability_probe_interval(attempt))
               next
             end
 
@@ -908,7 +911,7 @@ module Kettle
             raise unless retryable
 
             puts "Release lockfile reset could not resolve a gem from #{RELEASE_VALIDATION_SOURCE}; waiting before retry #{attempt + 1}/#{attempts}."
-            sleep(release_availability_probe_interval)
+            sleep(release_availability_probe_interval(attempt))
           end
         end
 
@@ -2222,6 +2225,7 @@ module Kettle
         attempts = release_availability_probe_attempts
         last_stderr = nil
         last_status = nil
+        upstream_confirmed = false
         sleep(release_availability_probe_initial_delay)
         attempts.times do |index|
           attempt = index + 1
@@ -2247,33 +2251,99 @@ module Kettle
 
           last_stderr = stderr_str
           last_status = status
+          # Alternate the consumer-mirror check with the push target:
+          # #{RELEASE_UPSTREAM_SOURCE} answers "did the push land at all",
+          # while #{RELEASE_VALIDATION_SOURCE} is a caching proxy that can lag
+          # it. A confirmed push gets the full backoff window to sync.
+          upstream_confirmed ||= release_probe_upstream_published?(candidate)
+          if upstream_confirmed
+            puts("#{candidate.gem_name} #{candidate.version} is published on #{RELEASE_UPSTREAM_SOURCE}; " \
+                 "waiting for #{RELEASE_VALIDATION_SOURCE} to sync (attempt #{attempt}/#{attempts}).")
+          end
           emit_release_probe_event(
             action: "availability",
-            status: (attempt < attempts) ? "retrying" : "failed",
+            status: (attempt < attempts || upstream_confirmed) ? "retrying" : "failed",
             candidate: candidate,
             attempt: attempt,
             attempts: attempts,
-            reason: "exit #{status.exitstatus}"
+            reason: "exit #{status.exitstatus}",
+            upstream: upstream_confirmed ? "confirmed" : "unconfirmed"
+          )
+          sleep(release_availability_probe_interval(attempt)) if attempt < attempts
+        end
+
+        if upstream_confirmed
+          warn(<<~MSG)
+            WARNING: #{candidate.gem_name} #{candidate.version} is published on #{RELEASE_UPSTREAM_SOURCE}, but #{RELEASE_VALIDATION_SOURCE} has not synced it after #{attempts} attempt(s).
+            Proceeding because the push target is authoritative for the publish; downstream release steps resolve from #{RELEASE_VALIDATION_SOURCE} and retry on their own.
+            If a later step fails to resolve this gem, wait for #{RELEASE_VALIDATION_SOURCE} to sync and resume that member.
+          MSG
+          emit_release_probe_event(
+            action: "availability",
+            status: "ok",
+            candidate: candidate,
+            attempt: attempts,
+            attempts: attempts,
+            reason: "confirmed on #{RELEASE_UPSTREAM_SOURCE}; #{RELEASE_VALIDATION_SOURCE} sync pending",
+            upstream: "confirmed"
           )
-          sleep(release_availability_probe_interval) if attempt < attempts
+          return true
         end
 
         diag = last_stderr.to_s.empty? ? "" : "\n--- STDERR ---\n#{last_stderr}".rstrip
-        abort("Published gem availability probe failed for #{candidate.gem_name} #{candidate.version} after #{attempts} attempt(s) (exit #{last_status.exitstatus})#{diag}")
+        abort("Published gem availability probe failed for #{candidate.gem_name} #{candidate.version} after #{attempts} attempt(s) (exit #{last_status.exitstatus}); " \
+              "the version is not visible on #{RELEASE_UPSTREAM_SOURCE} either, so the push itself may have failed#{diag}")
       ensure
         FileUtils.rm_f(script_path) if script_path
       end
 
       def release_availability_probe_attempts
-        15
+        env_positive_integer("KETTLE_DEV_RELEASE_PROBE_ATTEMPTS") || 15
       end
 
       def release_availability_probe_initial_delay
-        5
+        env_positive_integer("KETTLE_DEV_RELEASE_PROBE_INITIAL_DELAY") || 5
+      end
+
+      # Exponential backoff between probe attempts: the base interval grows per
+      # attempt, capped, because the consumer-mirror proxy (gem.coop) can lag
+      # the push target (rubygems.org) by minutes. With defaults the worst case
+      # is ~20 minutes across 15 attempts, and it only accrues when the
+      # registry genuinely lags — a fast sync still passes on attempt 1.
+      def release_availability_probe_interval(attempt = 1)
+        base = env_positive_integer("KETTLE_DEV_RELEASE_PROBE_INTERVAL") || 10
+        cap = env_positive_integer("KETTLE_DEV_RELEASE_PROBE_MAX_INTERVAL") || 120
+        [(base * (1.6**(attempt - 1))).round, cap].min
+      end
+
+      # Whether the push target registry already serves the candidate.
+      # confirm: true forces a live registry read, never a stale cache entry,
+      # because this answer decides whether a failed mirror probe is fatal.
+      def release_probe_upstream_published?(candidate)
+        versions = Kettle::Dev::RubyGemsVersions.published_version_numbers(
+          candidate.gem_name,
+          source: RELEASE_UPSTREAM_SOURCE,
+          version: candidate.version,
+          confirm: true
+        )
+        return false if versions.nil?
+
+        versions.include?(candidate.version.to_s)
+      rescue => error
+        warn("Upstream availability check against #{RELEASE_UPSTREAM_SOURCE} failed: #{error.class}: #{error.message}")
+        false
       end
 
-      def release_availability_probe_interval
-        10
+      def env_positive_integer(name)
+        raw = ENV.fetch(name, nil).to_s.strip
+        return nil if raw.empty?
+
+        value = begin
+          Integer(raw)
+        rescue ArgumentError, TypeError
+          nil
+        end
+        value&.positive? ? value : nil
       end
 
       def with_release_availability_probe_gem_home
@@ -2627,7 +2697,7 @@ module Kettle
         )
       end
 
-      def emit_release_probe_event(action:, status:, candidate:, attempt:, attempts:, reason: nil)
+      def emit_release_probe_event(action:, status:, candidate:, attempt:, attempts:, reason: nil, upstream: nil)
         Kettle::Ndjson.emit_event(
           @event_recorder,
           "release_probe",
@@ -2640,6 +2710,7 @@ module Kettle
           attempt: attempt,
           attempts: attempts,
           reason: reason,
+          upstream: upstream,
           mark: release_progress_mark(status)
         )
       end

data/lib/kettle/dev/version.rb

@@ -5,7 +5,7 @@ module Kettle
     # Version namespace for this gem.
     module Version
       # Current gem version.
-      VERSION = "3.1.19"
+      VERSION = "3.1.20"
     end
     # Current gem version exposed at the traditional constant location.
     VERSION = Version::VERSION # Traditional Constant Location

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: kettle-dev
 version: !ruby/object:Gem::Version
-  version: 3.1.19
+  version: 3.1.20
 platform: ruby
 authors:
 - Peter H. Boling
@@ -423,10 +423,10 @@ licenses:
 - AGPL-3.0-only
 metadata:
   homepage_uri: https://kettle-dev.galtzo.com
-  source_code_uri: https://github.com/kettle-dev/kettle-dev/tree/v3.1.19
-  changelog_uri: https://github.com/kettle-dev/kettle-dev/blob/v3.1.19/CHANGELOG.md
+  source_code_uri: https://github.com/kettle-dev/kettle-dev/tree/v3.1.20
+  changelog_uri: https://github.com/kettle-dev/kettle-dev/blob/v3.1.20/CHANGELOG.md
   bug_tracker_uri: https://github.com/kettle-dev/kettle-dev/issues
-  documentation_uri: https://www.rubydoc.info/gems/kettle-dev/3.1.19
+  documentation_uri: https://www.rubydoc.info/gems/kettle-dev/3.1.20
   funding_uri: https://github.com/sponsors/pboling
   wiki_uri: https://github.com/kettle-dev/kettle-dev/wiki
   news_uri: https://www.railsbling.com/tags/kettle-dev