kenshoo 0.1.6 → 0.1.7

data/Rakefile

@@ -5,7 +5,7 @@ Bundler.setup
 require 'rake'  
 require 'echoe'  
   
-Echoe.new('kenshoo', '0.1.6') do |p|  
+Echoe.new('kenshoo', '0.1.7') do |p|  
   p.description     = "Append Kenshoo tracking id after the given affiliate link"  
   p.url             = "http://github.com/58Phases/kenshoo"  
   p.author          = "David Hsu"  

data/kenshoo.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{kenshoo}
-  s.version = "0.1.6"
+  s.version = "0.1.7"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=
   s.authors = ["David Hsu"]

data/lib/kenshoo.rb

@@ -18,7 +18,7 @@ module Kenshoo
 
   def self.link_with_tracking_id(instance, session)
     link = instance.try(:link)
-    return nil unless [Coupon, Store].include?(instance.class) && link
+    return nil unless [Coupon, Store].include?(instance.class) && !link.blank?
     
     network_code = nil
     begin
@@ -36,7 +36,7 @@ module Kenshoo
   end
   
   def self.wrap_link_with_tracking_id(link, network_code, session)
-    outlink = link.strip!
+    outlink = link = link.strip
     begin
       tracking_param = KENSHOO_PARAMS[network_code]
       if !session['sid'].blank? && !tracking_param.blank?

data/test/kenshoo_test.rb

@@ -3,14 +3,14 @@ require 'kenshoo'
 
 class KenshooTest < Test::Unit::TestCase
   def test_wrap_link_with_tracking_id
-    link = "http://www.tkqlhce.com/click-3986307-10731808"
+    link = " http://www.tkqlhce.com/click-3986307-10731808" # with extra space at the beginning
     network_code = 'CJ'
     session = {'sid' => '452b3346-37bb-0bc8-7290-000057cc146f'}
     outlink = Kenshoo.wrap_link_with_tracking_id(link, network_code, session)
-    assert_equal outlink, "http://www.tkqlhce.com/click-3986307-10731808?SID=452b3346-37bb-0bc8-7290-000057cc146f"
+    assert_equal outlink, "http://www.tkqlhce.com/click-3986307-10731808?sid=452b3346-37bb-0bc8-7290-000057cc146f"
     
     network_code = 'LS'
     outlink = Kenshoo.wrap_link_with_tracking_id(link, network_code, session)
-    assert_equal outlink, "http://www.tkqlhce.com/click-3986307-10731808?U1=452b3346-37bb-0bc8-7290-000057cc146f"
+    assert_equal outlink, "http://www.tkqlhce.com/click-3986307-10731808?u1=452b3346-37bb-0bc8-7290-000057cc146f"
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: kenshoo
 version: !ruby/object:Gem::Version 
-  hash: 23
+  hash: 21
   prerelease: false
   segments: 
   - 0
   - 1
-  - 6
-  version: 0.1.6
+  - 7
+  version: 0.1.7
 platform: ruby
 authors: 
 - David Hsu