kennel 2.7.0 → 2.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fb759ae2d81d962a137b9ff0485135f0995cf4e31542f0ab4f284eef9ea1c109
-  data.tar.gz: d1fafb3a5d44c746280967f752e4eb124510a823c7ac2bd51ca2e935517afbb6
+  metadata.gz: bebf47eb6fde98d7122a199324dca2c205b94a65e844193d7917f2e384fbc029
+  data.tar.gz: c3631e51b4d7ef363b7fd177e42d688e00f7ea9816b9161b27dd2f48753fff93
 SHA512:
-  metadata.gz: bf576a0739a2cb98e7098c71bbf222d202766dbb479f9fd3c7b13bc0561b3f699cd1396faf4ef070c34be3bbed102aa8f8ca153d6c8c2c43e4767d945fe8df13
-  data.tar.gz: 2f2de90e0ad97900b86d92b168c1065f0128c15a0039eec3f4e611364e650a9faff20c4f6890b375fa15b3321c3e399d4a7a76fd648bcf56083675599ecb9c14
+  metadata.gz: 7029a570da24413841e71dc380a7f07d476c9cff3b83aee05a032478ed1707771b96f071949e2284003ef51777f955174c9d241a0e11c2d6fbd6aadc1d4ccece
+  data.tar.gz: b5df9cfcd85ff76b762c9c8a96e630f1b3cf509eb8509e71a42fb2d5c8b24efd6588a88033abe38c2d1ff5b37f8087d2e0074be171f3e78066c1796df53f72b4

data/lib/kennel/api.rb

@@ -73,6 +73,7 @@ module Kennel
       end
     end
 
+    # fill the resource with the full response from the `show` if `list` does not return it
     def fill_details!(api_resource, list)
       details_cache do |cache|
         Utils.parallel(list) { |a| fill_detail!(api_resource, a, cache) }

data/lib/kennel/models/project.rb

@@ -18,7 +18,7 @@ module Kennel
       end
 
       def validated_parts
-        all = parts
+        all = filter_parts(parts)
         unless all.is_a?(Array) && all.all? { |part| part.is_a?(Record) }
           raise "Project #{kennel_id} #parts must return an array of Records"
         end
@@ -29,6 +29,11 @@ module Kennel
 
       private
 
+      # hook for users to add custom filtering via `prepend`
+      def filter_parts(parts)
+        parts
+      end
+
       # hook for users to add custom validations via `prepend`
       def validate_parts(parts)
       end

data/lib/kennel/syncer.rb

@@ -13,7 +13,7 @@ module Kennel
 
     attr_reader :plan
 
-    def initialize(api, expected, actual, filter:, strict_imports: true)
+    def initialize(api, expected:, actual:, filter:, strict_imports: true)
       @api = api
       @strict_imports = strict_imports
       @filter = filter
@@ -155,10 +155,10 @@ module Kennel
       raise # uncovered: should never happen ...
     end
 
-    # fill details of things we need to compare
-    def fill_details!(details_needed)
-      details_needed = details_needed.map { |e, a| a if e && e.class.api_resource == "dashboard" }.compact
-      @api.fill_details! "dashboard", details_needed
+    # fill details of things we need to compare, so diff works even though we cannot mass-fetch definitions
+    def fill_details!(matching)
+      dashboards = matching.filter_map { |e, a| a if e && e.class.api_resource == "dashboard" }
+      @api.fill_details! "dashboard", dashboards
     end
 
     def validate_expected_id_not_missing(expected)

data/lib/kennel/tasks.rb

@@ -109,7 +109,7 @@ namespace :kennel do
     end
   end
 
-  desc "generate local definitions"
+  desc "store definitions in generated/"
   task generate: :environment do
     Kennel::Tasks.kennel.generate
   end

data/lib/kennel/utils.rb

@@ -24,13 +24,14 @@ module Kennel
         workers = Array.new(threads).map do
           Thread.new do
             loop do
-              item, i = work.pop
+              item, i = work.shift
               break unless i
               done[i] =
                 begin
                   yield item
                 rescue Exception => e # rubocop:disable Lint/RescueException
-                  work.clear
+                  work.clear # prevent new work
+                  (workers - [Thread.current]).each(&:kill) # stop ongoing work
                   e
                 end
             end

data/lib/kennel/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Kennel
-  VERSION = "2.7.0"
+  VERSION = "2.8.0"
 end

data/lib/kennel.rb

@@ -56,7 +56,7 @@ module Kennel
   self.err = $stderr
 
   class Engine
-    attr_accessor :strict_imports
+    attr_accessor :strict_imports # TODO: rename to :enforce_expected_ids_exist
 
     def initialize
       @strict_imports = true
@@ -93,7 +93,9 @@ module Kennel
       @syncer ||= begin
         preload
         Syncer.new(
-          api, generated, definitions,
+          api,
+          expected: generated,
+          actual: definitions,
           filter: filter,
           strict_imports: strict_imports
         )
@@ -129,7 +131,7 @@ module Kennel
       end
     end
 
-    # performance: this takes ~100ms on large codebases, tried rewriting with Set or Hash but it was slower
+    # performance: this takes ~100ms on large codebases, tried rewriting with Set or Hash, but it was slower
     def validate_unique_tracking_ids(parts)
       bad = parts.group_by(&:tracking_id).select { |_, same| same.size > 1 }
       return if bad.empty?

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kennel
 version: !ruby/object:Gem::Version
-  version: 2.7.0
+  version: 2.8.0
 platform: ruby
 authors:
 - Michael Grosser
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-11-10 00:00:00.000000000 Z
+date: 2025-11-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: diff-lcs