kennel 1.135.1 → 1.135.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 24069caa804f546ea584129a0c300e0ceb974798a3015a7c70a9a0f0b2423da6
-  data.tar.gz: 9fb59fc2d21a839ebd965f5f72b604c75d1bac64e1591cd51614c1ec0f24d947
+  metadata.gz: 8928631a86f3c83bfabba16aea02f9ed8bc853ddbb7c316495dc15081fe90239
+  data.tar.gz: 63b5107f2a19fd90a4a3b79d6da278956c50dc873162725395f74701e02b9d3b
 SHA512:
-  metadata.gz: b566afcb3f60379a20cce4bcdea77238ec4dcbfc243ce6c1c0c5017710e4037591a55fca1c4dd7963539fa919710cff422d19beb1cc05414572266c7b9a7be1f
-  data.tar.gz: 717abf8426124a8be7d9f36ece88226adf56a3543673f0260a7295d5884748e91269fb0a75babd91ba05d4f8928cf1fe8e8255b95f54919039775f65cd1f601c
+  metadata.gz: 42d9bdc4fba36067d3fc65cf86ef19159c66a0a57fe1d1ab709a598d77eacc843cb591904b8c652a1dbc49626d2ae8ad4ca8bbf170e72485a7de2183513f71bd
+  data.tar.gz: 36f1d3207327b416667438ecb304882dbf3ac1b6da9fc066033efc6d47098995a863eb3096cc19d2ff064d09ae7d452a0e9a53b7f6f378d2bb30de66650ea578

data/lib/kennel/models/dashboard.rb

@@ -5,7 +5,8 @@ module Kennel
       include TemplateVariables
 
       READONLY_ATTRIBUTES = superclass::READONLY_ATTRIBUTES + [
-        :author_handle, :author_name, :modified_at, :deleted_at, :url, :is_read_only, :notify_list, :restricted_roles
+        :author_handle, :author_name, :modified_at, :deleted_at, :url, :is_read_only, :notify_list, :restricted_roles,
+        :tags
       ]
       TRACKING_FIELD = :description
       REQUEST_DEFAULTS = {
@@ -72,8 +73,6 @@ module Kennel
         template_variable_presets: nil
       }.freeze
 
-      TAG_PREFIX = /^team:/
-
       settings(
         :title, :description, :definitions, :widgets, :layout_type, :template_variable_presets, :reflow_type,
         :tags
@@ -85,7 +84,10 @@ module Kennel
         widgets: -> { [] },
         template_variable_presets: -> { DEFAULTS.fetch(:template_variable_presets) },
         reflow_type: -> { layout_type == "ordered" ? "auto" : nil },
-        tags: -> { project.team.tags } # ideally project.tags but that causes diffs
+        tags: -> do # not inherited by default to make onboarding to using dashboard tags simple
+          team = project.team
+          team.tag_dashboards ? team.tags : []
+        end
       )
 
       class << self
@@ -153,9 +155,7 @@ module Kennel
         all_widgets = render_definitions(definitions) + widgets
         expand_q all_widgets
         tags = tags()
-
-        # TODO: remove this once dd UI shows all tags ... maybe remove team tag once that is usable vis UI
-        tags_as_string = (project.team.tag_dashboards && !tags.empty? ? " (#{tags.join(" ")})" : "")
+        tags_as_string = (tags.empty? ? "" : " (#{tags.join(" ")})")
 
         json = super.merge(
           layout_type: layout_type,
@@ -163,8 +163,7 @@ module Kennel
           description: description,
           template_variables: render_template_variables,
           template_variable_presets: template_variable_presets,
-          widgets: all_widgets,
-          tags: tags.grep(TAG_PREFIX)
+          widgets: all_widgets
         )
 
         json[:reflow_type] = reflow_type if reflow_type # setting nil breaks create with "ordered"

data/lib/kennel/models/record.rb

@@ -151,7 +151,7 @@ module Kennel
         rescue StandardError
           if unfiltered_validation_errors.empty?
             @unfiltered_validation_errors = nil
-            raise PrepareError, safe_tracking_id # FIXME: this makes errors hard to debug when running tests
+            raise PrepareError, safe_tracking_id
           end
         end
 

data/lib/kennel/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Kennel
-  VERSION = "1.135.1"
+  VERSION = "1.135.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kennel
 version: !ruby/object:Gem::Version
-  version: 1.135.1
+  version: 1.135.2
 platform: ruby
 authors:
 - Michael Grosser
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-03-01 00:00:00.000000000 Z
+date: 2023-03-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: diff-lcs