kennel 1.12.0 → 1.12.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7114ffae96587ada9ea64441476daf3caf82f1149c877e9529a598651f25eece
-  data.tar.gz: 57986d14b955e2b392f68742e40b2284d8a3d36e67a8bce8d71c57ee35842145
+  metadata.gz: de90e72ad4a031e9da3725ee093fadb0ab3e683cdcd2167e0d22560b992660d0
+  data.tar.gz: '06971c4f0bb06f8e662b1bd7742f054d3e6fc4a09cf52b040718f4a904ad8e73'
 SHA512:
-  metadata.gz: 0f205bdb359a2ce62a6d4564e89b9e13ebc7faed6ce3e7ec41fdff29a03ea86b9017c8cfcfe1c347ce4f77d7ed895fd5606f6373638cad92a30b5e49d5e5425e
-  data.tar.gz: 6619e5a232fe196deabcf5ef48d80ab01733f93922b842762cdd6baf705b5e72e70193d0f36eedb1bd53e21dd63804701797b6f491547a797b1dc3f24b3d04b2
+  metadata.gz: ed56533779e791ec3fd21773c7788a1e961d2e05b34b9f9285baefb8ed3eba554d7020a102a856f64d2643d9f48a251a13e936f3aaf7176d9e0c379a3d17e730
+  data.tar.gz: 9d1b27677924dfe3d36f48f0017eceaaf619dbdd5881dd1cde49272df51324baf35793f30e1e98eb50819dc3a57a5629eecec5c7bb612f7b6d22fe219d375f66

data/lib/kennel/syncer.rb

@@ -29,19 +29,19 @@ module Kennel
     end
 
     def update
-      block_irreversible_partial_changes
-
       @create.each do |_, e|
         reply = @api.create e.class.api_resource, e.as_json
         reply = unnest(e.class.api_resource, reply)
         puts "Created #{e.class.api_resource} #{tracking_id(e.as_json)} #{e.url(reply.fetch(:id))}"
       end
 
+      block_irreversible_partial_updates
       @update.each do |id, e|
         @api.update e.class.api_resource, id, e.as_json
         puts "Updated #{e.class.api_resource} #{tracking_id(e.as_json)} #{e.url(id)}"
       end
 
+      block_irreversible_partial_deletes
       @delete.each do |id, _, a|
         @api.delete a.fetch(:api_resource), id
         puts "Deleted #{a.fetch(:api_resource)} #{tracking_id(a)} #{id}"
@@ -169,13 +169,22 @@ module Kennel
       end
     end
 
-    def block_irreversible_partial_changes
+    def block_irreversible_partial_updates
       return unless @project_filter
-      return if
-        @delete.none? &&
-        @update.none? { |_, e, _, diff| e.id && diff.any? { |_, field| TRACKING_FIELDS.include?(field.to_sym) } }
+      return if @update.none? { |_, e, _, diff| e.id && diff.any? { |_, field| TRACKING_FIELDS.include?(field.to_sym) } }
+      raise <<~TEXT
+        Updates with PROJECT= filter should not update #{TRACKING_FIELDS.join("/")} of resources with a set `id:`, since this makes them get deleted by a full update.
+        Remove the `id:` to test them out, which will result in a copy being created and later deleted.
+      TEXT
+    end
 
-      raise "Partial updates should not modify resources with an id, since these changes are irreversible"
+    def block_irreversible_partial_deletes
+      return unless @project_filter
+      return if @delete.empty?
+      raise <<~TEXT
+        Deletes with PROJECT= filter should not delete resources, since they could end up deleting things with a fixed `id:`.
+        Run a full update from an updated master branch to delete unwanted resources.
+      TEXT
     end
 
     def filter_by_project!(definitions)

data/lib/kennel/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Kennel
-  VERSION = "1.12.0"
+  VERSION = "1.12.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: kennel
 version: !ruby/object:Gem::Version
-  version: 1.12.0
+  version: 1.12.1
 platform: ruby
 authors:
 - Michael Grosser