kbsecret 0.4.2 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eb7d10f444c4875844599ef7cea9ba58beafceea
-  data.tar.gz: 8aaa914e08e66640d5b7f7f0a19234cb7e710345
+  metadata.gz: aafa31104e34d5e24baa546e26a05fd9cd695054
+  data.tar.gz: 860ddcb29cdc1d2e0a053d8910af5dd0b7e7cc1a
 SHA512:
-  metadata.gz: 48a40c37b778e6405d1528b93eb135b8f597b0d935d89de132a7144d1ff005343803dc00a77a6f7ac0f503f75662d5d0f1dee34a6f0a54ceb545ed0621296c19
-  data.tar.gz: 0cafc5bb7b6be04a730578ed23a17e0a308102e79250a7550b0faf218b57623b63adfe823dd2420742fa74abbd9b91ec167cd141dfd10484559b37543fabf4f1
+  metadata.gz: 0d58a6e350bd3972be81081ac70b3832e92b51ebb59d0fbe9a50c3bd36720c2e5e4051dd49c3666122fd6598e96b0ad38a4e911e80cd71a5f899217a8f1a78f2
+  data.tar.gz: b5222b237f8ad4caff0869f431a090e7522ffd882cf600e0731d074c981fed2761709ec47bb9bd6a0969bc26d4f3f4e7f18c4a64c3b3207380c31f879e731c3d

data/README.md

@@ -30,7 +30,8 @@ For hacking:
 
 ```bash
 $ git clone git@github.com:woodruffw/kbsecret.git && cd kbsecret
-$ RUBYLIB=./lib PATH=./bin:${PATH} ./bin/kbsecret help
+$ bundle install
+$ RUBYLIB=./lib PATH=./bin:${PATH} bundle exec ./bin/kbsecret help
 ```
 
 Documentation is available on [RubyDoc](http://www.rubydoc.info/gems/kbsecret/).
@@ -104,3 +105,4 @@ Please feel free to contribute completion scripts for other shells!
 * zsh/fish completions
 * facility for moving sessions (add users, change session label, etc)
 * glob for available sessions instead of requiring explicit configuration
+* complete general record unit tests, individual unit tests for record types and utilities

data/lib/kbsecret/exceptions.rb

@@ -5,8 +5,15 @@ module KBSecret
   class KBSecretError < RuntimeError
   end
 
+  # Raised during record creation if an unknown record type is requested.
+  class RecordTypeUnknownError < KBSecretError
+    def initialize(type)
+      super "Unknown record type: #{type}"
+    end
+  end
+
   # Raised during record creation if too many/few arguments are given.
-  class RecordCreationArityError < RuntimeError
+  class RecordCreationArityError < KBSecretError
     def initialize(exp, act)
       super "Needed #{exp} arguments for this record, got #{act}"
     end

data/lib/kbsecret/session.rb

@@ -50,12 +50,15 @@ module KBSecret
     # @param label [Symbol] the new record's label
     # @param args [Array<String>] the record-type specific arguments
     # @return [void]
+    # @raise UnknownRecordTypeError if the requested type does not exist
+    #  in {Record.record_types}
     # @raise RecordCreationArityError if the number of specified record
     #  arguments does not match the record type's constructor
     def add_record(type, label, *args)
       klass = Record.class_for(type.to_sym)
-      arity = klass.instance_method(:initialize).arity - 2
+      raise RecordTypeUnknownError, type unless klass
 
+      arity = klass.instance_method(:initialize).arity - 2
       raise RecordCreationArityError.new(arity, args.size) unless arity == args.size
 
       record = klass.new(self, label, *args)
@@ -91,7 +94,6 @@ module KBSecret
     end
 
     # @return [Array<String>] the fully qualified paths of all records in the session
-    # @api private
     def record_paths
       Dir[File.join(directory, "*.json")]
     end

data/lib/kbsecret.rb

@@ -11,7 +11,7 @@ require_relative "kbsecret/cli"
 # The primary namespace for kbsecret.
 module KBSecret
   # kbsecret's current version
-  VERSION = "0.4.2"
+  VERSION = "0.4.3"
 
   # fail very early if the user doesn't have keybase and KBFS running
   raise Keybase::KeybaseNotRunningError unless Keybase.running?

metadata

@@ -1,85 +1,85 @@
 --- !ruby/object:Gem::Specification
 name: kbsecret
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.3
 platform: ruby
 authors:
 - William Woodruff
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-10 00:00:00.000000000 Z
+date: 2017-06-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: keybase-unofficial
+  name: clipboard
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.0.7
+        version: '1.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.0.7
+        version: '1.1'
 - !ruby/object:Gem::Dependency
-  name: slop
+  name: keybase-unofficial
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.4'
+        version: 0.0.8
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.4'
+        version: 0.0.8
 - !ruby/object:Gem::Dependency
-  name: tty-prompt
+  name: pastel
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.0
+        version: '0.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.0
+        version: '0.7'
 - !ruby/object:Gem::Dependency
-  name: pastel
+  name: slop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.7'
+        version: '4.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.7'
+        version: '4.4'
 - !ruby/object:Gem::Dependency
-  name: clipboard
+  name: tty-prompt
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: 0.10.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: 0.10.0
 description: Manages your passwords, environment, and more via KBFS.
 email: william@tuffbizz.com
 executables: