katalyst-content 2.6.2 → 2.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eed6928b3cc84824468e19907357ff6ec9a94c95f221837e072c8461104cacea
-  data.tar.gz: 83f46dcf143e6e83a7ace219e50f730db747b5a93b274ef7e38160ad221c4861
+  metadata.gz: bdabab79e4bf2448d8557d5e4f6b1f62655b6be942237bf6d0b0846dccb9862d
+  data.tar.gz: 5504a62e8a0cca3f748e3eb4568cef6453588d74c5413f81b8cc586c1052f584
 SHA512:
-  metadata.gz: 2ab883ce41bedcb98748fd82d411be8b623b4c2e63cfba6df133fc6a37b26dad8935b0017d0140c96b6243e2a98ace118e520adf1eb8c345016e2cd984e9460b
-  data.tar.gz: a1b8a21741ff7cea1f8214adc6d73ebcee6bb39fb3c2d132e53c4266082d214c4a770055a4e2146ee9e248ca3b6bef1ca48fa515b8b38a98ab2d3a2c56946d1b
+  metadata.gz: f96d013e1b4bfe1c1bcd76d3433e789c2b23c74276f65924fa83977a9147930d80352378c15a58a6961bf477caaa088a3a9926c0c6137db85e05863436a983bd
+  data.tar.gz: 869e112cbd54113bf565869e753cddbc6e23a9088a666d39748fe49b67ecbd6f83ddd1edfbed8832d2ab66db458146a17838be7a91b65258d18642fb6a07f0cb

data/app/controllers/katalyst/content/items_controller.rb

@@ -87,15 +87,32 @@ module Katalyst
       #
       # This mimics the behaviour of direct uploads without requiring the JS
       # integration.
+      #
+      # Note: this idea comes from various blogs who have documented this approach, such as
+      # https://medium.com/@TETRA2000/active-storage-how-to-retain-uploaded-files-on-form-resubmission-91b57be78d53
+      #
+      # In Rails 7.2 the simple version of this approach was broken to work around a bug that Rails plans to address
+      # in a future release.
+      # https://github.com/rails/rails/commit/82d4ad5da336a18a55a05a50b851e220032369a0
+      #
+      # The work around is to decouple the blobs from their attachments before saving by duping
+      # them. This approach feels a bit hairy and might need to be replaced by a 'standard' direct upload approach
+      # in the future.
+      #
+      # The reason we use this approach currently is to avoid needing a separate direct upload controller for
+      # content which would potentially introduce a back door where un-trusted users are allowed to upload
+      # attachments.
       def store_attachments(item)
         item.attachment_changes.each_value do |change|
           case change
           when ActiveStorage::Attached::Changes::CreateOne
             change.upload
-            change.blob.save!
+            change.attachment.blob = change.blob.dup.tap(&:save!)
           when ActiveStorage::Attached::Changes::CreateMany
             change.upload
-            change.blobs.each(&:save!)
+            change.attachments.zip(change.blobs).each do |attachment, blob|
+              attachment.blob = blob.dup.tap(&:save!)
+            end
           end
         end
       end

data/app/models/concerns/katalyst/content/container.rb

@@ -49,8 +49,24 @@ module Katalyst
                  dependent:  :destroy,
                  validate:   true
 
+        # Rails 7.2 dropped support for ActiveModel enums. This is a temporary workaround.
+        # Intended behaviour:
+        # attribute :state, :string
+        # enum :state, %i[published draft unpublished].index_with(&:to_s)
         attribute :state, :string
-        enum :state, %i[published draft unpublished].index_with(&:to_s)
+
+        # Returns true if there is a published version. Note that this includes drafts.
+        def published?
+          %w[published draft].include?(state)
+        end
+
+        def draft?
+          state == "draft"
+        end
+
+        def unpublished?
+          state == "unpublished"
+        end
 
         # Find records by their state
         scope :state, ->(values) do
@@ -98,11 +114,6 @@ module Katalyst
           order(stmt.public_send(dir)).order(updated_at: dir)
         end
 
-        # Returns true if there is a published version. Note that this includes drafts.
-        def published?
-          super || draft?
-        end
-
         def state=(_)
           raise NotImplementedError, "state cannot be set directly, use publish!, revert! etc"
         end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: katalyst-content
 version: !ruby/object:Gem::Version
-  version: 2.6.2
+  version: 2.7.0
 platform: ruby
 authors:
 - Katalyst Interactive
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-09-03 00:00:00.000000000 Z
+date: 2024-09-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,20 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '7.0'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '7.2'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '7.0'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '7.2'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: active_storage_validations
   requirement: !ruby/object:Gem::Requirement
@@ -219,7 +213,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.11
+rubygems_version: 3.5.16
 signing_key: 
 specification_version: 4
 summary: Rich content page builder and editor