karousel 0.9.14 → 0.9.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 93a93eaf57fc60cc0adf49c6e327559f812d369a
-  data.tar.gz: f8ed2768ed3f5e4311112a7ff5217e49c85a3292
+  metadata.gz: 606a6df4c01aeba6bf5bc220e1506d168e096b2f
+  data.tar.gz: edc41e330cd23cde31aefca7ab1f14f250c9a79a
 SHA512:
-  metadata.gz: ae4345f80ae81991d61ef001665dff9691f94edc6fa2cb56230095d711dbf454ec3cedfa2b37973fd81b8864f8d38e45fea8659a2f2cb90ce81b8d36aca4f51f
-  data.tar.gz: baa91691ddd09c8a9f7b5313557a1f1a5fc295d8810cc1eb292947f15d605ded99e72f6f47d8099a29ebb04a6243ace38fc559b95eff1ea826c08ff2934e2b26
+  metadata.gz: d63da985e2de623a59bf0a7af7c839ba62f1e92b1857d5410344b509ba48886deaebaaa2f823d96cb0be96503bfc1aecdb47306242e8459f10ad51d84d8a9aff
+  data.tar.gz: 587c731ac53170afbe76bfacfa3072450a79120ac60ccd80d2c3fe9e3bf9d3c8e9452a0885822300db5c131dfa560fd9360b77ff3ea3729463b9263c9fc95c21

data/.gitignore

@@ -11,6 +11,8 @@ doc
 
 # bundler
 .bundle
+Gemfile.lock
+
 
 # jeweler generated
 pkg

data/.rspec

@@ -1 +1,3 @@
+--format documentation
 --color
+--require spec_helper

data/.rubocop.yml

@@ -0,0 +1,10 @@
+AllCops:
+  Exclude:
+    - bundle_bin/**/*
+    - bin/**/*
+  Include:
+    - '**/Gemfile'
+    - '**/Rakefile'
+Metrics/BlockLength:
+  Exclude:
+    - spec/**/*.rb

data/.ruby-version

@@ -1 +1 @@
-2.0.0-p247
+2.4.1

data/.travis.yml

@@ -1,6 +1,9 @@
 rvm:
-  - 1.9.3
-  - 2.0.0
+  - 2.0
+  - 2.1
+  - 2.2
+  - 2.3
+  - 2.4
 branches:
   only:
       - master

data/CHANGELOG

@@ -1,2 +1,3 @@
+0.9.15 -- cleaning up styles
 0.9.14 -- removed jeweler, refactoring
 0.9.13 -- major bug fixes

data/Gemfile

@@ -1,10 +1,5 @@
-source 'http://rubygems.org'
-
-group :test, :development do
-  gem 'rake', '~> 10.1'
-  gem 'rspec', '~> 2.14'
-  gem 'debugger', '~> 1.6'
-  gem 'coveralls', '~> 0.7', require: false
-end
+# frozen_string_literal: true
 
+source 'http://rubygems.org'
 
+gemspec

data/README.md

@@ -123,7 +123,7 @@ further details.
 [9]: https://gemnasium.com/GlobalNamesArchitecture/karousel.png
 [10]: https://gemnasium.com/GlobalNamesArchitecture/karousel
 [11]: https://github.com/GlobalNamesArchitecture/karousel/blob/master/spec/support/client_job_dummy.rb
-[12]: https://github.com/GlobalNamesArchitecture/karousel
+[12]: https://github.com/GlobalNamesArchitecture/karousel_example
 [13]: http://semver.org/
 [14]: https://github.com/dimus
 [15]: https://github.com/dshorthouse

data/Rakefile

@@ -1,21 +1,19 @@
+# frozen_string_literal: true
 # encoding: utf-8
-require 'bundler'
-require 'rake'
-require 'rspec/core'
-require 'rspec/core/rake_task'
 
-Bundler::GemHelper.install_tasks
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+require 'rubocop/rake_task'
 
-begin
-  Bundler.setup(:default, :development)
-rescue Bundler::BundlerError => e
-  $stderr.puts e.message
-  $stderr.puts 'Run `bundle install` to install missing gems'
-  exit e.status_code
+RSpec::Core::RakeTask.new(:rspec) do |rspec|
+  rspec.pattern = 'spec/**/*_spec.rb'
 end
 
-task :default => :spec
+RuboCop::RakeTask.new
+
+task default: %i[rubocop rspec]
 
-RSpec::Core::RakeTask.new do |t|
-  t.pattern = 'spec/**/*spec.rb'
+desc 'open an irb session preloaded with this gem'
+task :console do
+  sh 'irb -r pp -r ./lib/gn_crossmap.rb'
 end

data/karousel.gemspec

@@ -1,22 +1,28 @@
+# frozen_string_literal: true
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
-require 'karousel'
+require 'karousel/version'
 
-Gem::Specification.new do |s|
-  s.name = 'karousel'
-  s.version = Karousel::VERSION
-  s.authors = ['Dmitry Mozzherin', 'David Shorthouse']
-  s.email = 'dmozzherin@gmail.com'
-  s.description = %q{Use it if you have waaay too many items in 
-                    your workers' queue}
-  s.summary = 'Job dispenser for parallel workers'
+Gem::Specification.new do |gem|
+  gem.name = 'karousel'
+  gem.version = Karousel::VERSION
+  gem.authors = ['Dmitry Mozzherin', 'David Shorthouse']
+  gem.email = 'dmozzherin@gmail.com'
+  gem.description = 'Use it if you have way too many items in ' \
+                    'your worker gem queue'
+  gem.summary = 'Job dispenser for parallel workers'
 
-  s.homepage = 'http://github.com/GlobalNamesArchitecture/karousel'
-  s.license = 'MIT'
+  gem.homepage = 'http://github.com/GlobalNamesArchitecture/karousel'
+  gem.license = 'MIT'
 
-  s.files = `git ls-files`.split($/)
-  s.test_files    = s.files.grep(%r{^(spec|features)/})
-  s.require_paths = ['lib']
-end
+  gem.files = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
+  gem.require_paths = ['lib']
 
+  gem.add_development_dependency 'byebug', '~> 9.1'
+  gem.add_development_dependency 'coveralls', '~> 0.8'
+  gem.add_development_dependency 'rake', '~> 12.0'
+  gem.add_development_dependency 'rspec', '~> 3.2'
+  gem.add_development_dependency 'rubocop', '~> 0.49'
+end

data/lib/karousel.rb

@@ -1,15 +1,20 @@
-Dir[File.join(File.dirname(__FILE__), 'karousel', '*.rb')].each {|f| require f}
+# frozen_string_literal: true
 
+require_relative 'karousel/client_job'
+require_relative 'karousel/errors'
+require_relative 'karousel/job'
+require_relative 'karousel/version'
 
+# Implements karousel
 class Karousel
   attr_reader :size, :seats, :time_interval
-  STATUS = { init: 1, sent: 2, success: 3, failure: 4 }
+  STATUS = { init: 1, sent: 2, success: 3, failure: 4 }.freeze
 
   def self.version
     VERSION
   end
 
-  def initialize(klass, size=10, time_interval = 0)
+  def initialize(klass, size = 10, time_interval = 0)
     @klass = klass
     @size = size
     @time_interval = time_interval
@@ -26,7 +31,7 @@ class Karousel
 
   def run(&block)
     populate
-    until @seats.empty? do
+    until @seats.empty?
       send_request
       sleep(@time_interval)
       check_response
@@ -52,10 +57,12 @@ class Karousel
     @seats = @seats[@cursor..-1] + @seats[0...@cursor] if @cursor != 0
     @seats.size.times do
       job = @seats.shift
-      (job.status != :failure && job.finished?) ? job.process : 
+      if job.status != :failure && job.finished?
+        job.process
+      else
         @seats.push(job)
+      end
     end
     @cursor = 0
   end
-
 end

data/lib/karousel/client_job.rb

@@ -1,4 +1,7 @@
+# frozen_string_literal: true
+
 class Karousel
+  # Abstract class for ClientJob
   class ClientJob
     attr_accessor :status
 
@@ -27,6 +30,5 @@ class Karousel
     def not_implemented_error
       raise Karousel::NotImplementedError
     end
-
   end
 end

data/lib/karousel/errors.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+
 class Karousel
+  # Exception for not implemented abstract parts of Karousel
   class NotImplementedError < RuntimeError; end
 end

data/lib/karousel/job.rb

@@ -1,26 +1,29 @@
+# frozen_string_literal: true
+
 class Karousel
+  # Implements a job to be placed on karousel
   class Job
     attr_reader :client_job
     # STATUS = { init: 1, sent: 2, success: 3, failure: 4 }
 
     def initialize(client_job)
       unless client_job.is_a?(Karousel::ClientJob)
-        raise TypeError.new('Unknown client job type') 
+        raise(TypeError, 'Unknown client job type')
       end
       @client_job = client_job
     end
 
     def status
       @status = @client_job.status
-      unless [1,2,3,4].include?(@status)
-        raise TypeError.new('Status must be an integer between 1 and 4') 
+      unless [1, 2, 3, 4].include?(@status)
+        raise(TypeError, 'Status must be an integer between 1 and 4')
       end
       @status
     end
 
-    def status= (new_status)
-      unless [1,2,3,4].include?(new_status)
-        raise TypeError.new('Status must be an integer between 1 and 4') 
+    def status=(new_status)
+      unless [1, 2, 3, 4].include?(new_status)
+        raise(TypeError, 'Status must be an integer between 1 and 4')
       end
       @client_job.status = new_status
     end
@@ -40,6 +43,5 @@ class Karousel
       self.status = (is_ok ? STATUS[:success] : STATUS[:failure])
       is_ok
     end
-
   end
 end

data/lib/karousel/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Karousel
-  VERSION = '0.9.14'
+  VERSION = '0.9.15'
 end

data/spec/job_spec.rb

@@ -1,12 +1,12 @@
-require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
+# frozen_string_literal: true
 
 describe Karousel::Job do
+  subject { Karousel::Job.new(ClientJobDummy.new) }
 
-  it "should instantiate" do 
-    j = Karousel::Job.new(ClientJobDummy.new)
-    j.class.should == Karousel::Job
-    j.client_job.class.should == ClientJobDummy
+  describe '.new' do
+    it 'instantiates' do
+      expect(subject).to be_kind_of Karousel::Job
+      expect(subject.client_job).to be_kind_of ClientJobDummy
+    end
   end
-
 end
-

data/spec/karousel_spec.rb

@@ -1,49 +1,64 @@
-require_relative 'spec_helper'
+# frozen_string_literal: true
 
-describe "Karousel" do
-  before(:all) do
-    @karousel = Karousel.new(ClientJobDummy, 20, 0)
-  end
+describe Karousel do
+  subject { Karousel.new(ClientJobDummy, 20, 0) }
 
   before(:each) do
     ClientJobDummy.reset
   end
 
-  it 'should have version' do
-    Karousel.version.should =~ /^[\d]+\.[\d]+\.[\d]+$/
-  end
-  
-  it "should initiate" do
-    k = Karousel.new(ClientJobDummy, 20, 0)
-    k.class.should == Karousel
+  describe '.version' do
+    it 'has version' do
+      expect(Karousel.version).to match(/^[\d]+\.[\d]+\.[\d]+$/)
+    end
   end
 
-  it "should have size" do
-    @karousel.size.should == 20
-    @karousel.seats.size.should == 0
-    @karousel.time_interval.should == 0
+  describe '.new' do
+    it 'initiates' do
+      expect(subject).to be_kind_of Karousel
+    end
   end
-  
-  it "should run with block" do
-    karousel = Karousel.new(ClientJobDummy, 20, 0)
-    count = 0
-    karousel.run do 
-      count += 1
-      if count < 10
-        karousel.seats[1].class.should == Karousel::Job 
-        karousel.seats[1].client_job.class.should == ClientJobDummy
-      end
+
+  describe '#size' do
+    it 'has  size' do
+      expect(subject.size).to eq 20
     end
   end
 
-  it "should be able to get loaded with jobs" do 
-    @karousel.seats.size.should == 0 
-    @karousel.populate
-    @karousel.seats.size.should == 20
-    @karousel.seats[0].class == Karousel::Job
-    @karousel.seats[0].status.should == Karousel::STATUS[:init]
+  describe '#time_interval' do
+    it 'has time_interval accessor' do
+      expect(subject.time_interval).to eq 0
+    end
   end
 
+  describe '#seats' do
+    it 'has seats' do
+      expect(subject.seats).to be_kind_of Array
+      expect(subject.seats.size).to eq 0
+    end
+  end
 
+  describe '#run' do
+    it 'should run with block' do
+      count = 0
+      subject.run do
+        count += 1
+        if count < 10
+          expect(subject.seats[1]).to be_kind_of Karousel::Job
+          expect(subject.seats[1].client_job)
+            .to be_kind_of ClientJobDummy
+        end
+      end
+    end
+  end
 
+  describe '#populate' do
+    it 'loads jobs on karousel' do
+      expect(subject.seats.size).to eq 0
+      subject.populate
+      expect(subject.seats.size).to eq 20
+      expect(subject.seats[0]).to be_kind_of Karousel::Job
+      expect(subject.seats[0].status).to eq Karousel::STATUS[:init]
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1,16 +1,10 @@
+# frozen_string_literal: true
+
 require 'coveralls'
 Coveralls.wear!
 
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
-$LOAD_PATH.unshift(File.dirname(__FILE__))
-require 'rspec'
+$LOAD_PATH.unshift(File.join(__dir__, '..', 'lib'))
+$LOAD_PATH.unshift(__dir__)
 require 'karousel'
-require_relative 'support/client_job_dummy'
-
-# Requires supporting files with custom matchers and macros, etc,
-# in ./support/ and its subdirectories.
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
-
-RSpec.configure do |config|
-  
-end
+require 'support/client_job_dummy'
+require 'support/dummy_server'

data/spec/support/client_job_dummy.rb

@@ -1,16 +1,16 @@
-require_relative 'dummy_server'
+# frozen_string_literal: true
 
 class ClientJobDummy < Karousel::ClientJob
-  @@dummy_data = 0 
-  
+  @dummy_data = 0
+
   def self.reset
-    @@dummy_data = 0
+    @dummy_data = 0
   end
 
   def self.populate(karousel_size)
-    @@dummy_data += karousel_size
-    return [] if @@dummy_data > 100
-    karousel_size.times.map { self.new }
+    @dummy_data += karousel_size
+    return [] if @dummy_data > 100
+    Array.new(karousel_size, new)
   end
 
   def send
@@ -23,8 +23,5 @@ class ClientJobDummy < Karousel::ClientJob
     @server.are_we_there_yet_request
   end
 
-  def process
-  end
-
+  def process; end
 end
-

data/spec/support/dummy_server.rb

@@ -1,5 +1,7 @@
-class DummyServer
+# frozen_string_literal: true
 
+# Dummy Server for specs
+class DummyServer
   def first_request
     @wait_num = rand(10) + 1
     @tries_num = 0
@@ -9,5 +11,4 @@ class DummyServer
     @tries_num += 1
     @tries_num == @wait_num ? true : false
   end
-
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: karousel
 version: !ruby/object:Gem::Version
-  version: 0.9.14
+  version: 0.9.15
 platform: ruby
 authors:
 - Dmitry Mozzherin
@@ -9,23 +9,92 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-19 00:00:00.000000000 Z
-dependencies: []
-description: "Use it if you have waaay too many items in \n                    your
-  workers' queue"
+date: 2017-08-25 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '9.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '9.1'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.8'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.8'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '12.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '12.0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.2'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.2'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.49'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.49'
+description: Use it if you have way too many items in your worker gem queue
 email: dmozzherin@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .document
-- .gitignore
-- .rspec
-- .ruby-version
-- .travis.yml
+- ".document"
+- ".gitignore"
+- ".rspec"
+- ".rubocop.yml"
+- ".ruby-version"
+- ".travis.yml"
 - CHANGELOG
 - Gemfile
-- Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -49,9 +118,6 @@ files:
 - bin/term_display
 - bin/term_mandel
 - bin/thor
-- features/karousel.feature
-- features/step_definitions/karousel_steps.rb
-- features/support/env.rb
 - karousel.gemspec
 - lib/karousel.rb
 - lib/karousel/client_job.rb
@@ -73,26 +139,18 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Job dispenser for parallel workers
-test_files:
-- features/karousel.feature
-- features/step_definitions/karousel_steps.rb
-- features/support/env.rb
-- spec/job_spec.rb
-- spec/karousel_spec.rb
-- spec/spec_helper.rb
-- spec/support/client_job_dummy.rb
-- spec/support/dummy_server.rb
+test_files: []

data/Gemfile.lock

@@ -1,47 +0,0 @@
-GEM
-  remote: http://rubygems.org/
-  specs:
-    columnize (0.3.6)
-    coveralls (0.7.0)
-      multi_json (~> 1.3)
-      rest-client
-      simplecov (>= 0.7)
-      term-ansicolor
-      thor
-    debugger (1.6.1)
-      columnize (>= 0.3.1)
-      debugger-linecache (~> 1.2.0)
-      debugger-ruby_core_source (~> 1.2.3)
-    debugger-linecache (1.2.0)
-    debugger-ruby_core_source (1.2.3)
-    diff-lcs (1.2.4)
-    mime-types (1.25)
-    multi_json (1.8.0)
-    rake (10.1.0)
-    rest-client (1.6.7)
-      mime-types (>= 1.16)
-    rspec (2.14.1)
-      rspec-core (~> 2.14.0)
-      rspec-expectations (~> 2.14.0)
-      rspec-mocks (~> 2.14.0)
-    rspec-core (2.14.5)
-    rspec-expectations (2.14.2)
-      diff-lcs (>= 1.1.3, < 2.0)
-    rspec-mocks (2.14.3)
-    simplecov (0.7.1)
-      multi_json (~> 1.0)
-      simplecov-html (~> 0.7.1)
-    simplecov-html (0.7.1)
-    term-ansicolor (1.2.2)
-      tins (~> 0.8)
-    thor (0.18.1)
-    tins (0.9.0)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  coveralls (~> 0.7)
-  debugger (~> 1.6)
-  rake (~> 10.1)
-  rspec (~> 2.14)

data/features/karousel.feature

@@ -1,9 +0,0 @@
-Feature: something something
-  In order to something something
-  A user something something
-  something something something
-
-  Scenario: something something
-    Given inspiration
-    When I create a sweet new gem
-    Then everyone should see how awesome I am

data/features/support/env.rb

@@ -1,13 +0,0 @@
-require 'bundler'
-begin
-  Bundler.setup(:default, :development)
-rescue Bundler::BundlerError => e
-  $stderr.puts e.message
-  $stderr.puts "Run `bundle install` to install missing gems"
-  exit e.status_code
-end
-
-$LOAD_PATH.unshift(File.dirname(__FILE__) + '/../../lib')
-require 'karousel'
-
-require 'rspec/expectations'